Commit Graph

17 Commits (da4c3ebeac4477850b42b780c8dbf8a469ca9499)

Author SHA1 Message Date
Dusty Mabe b817f1f3ea actions/unarchive: fix unarchive from remote url (#17126)
* actions/unarchive: fix unarchive from remote url

Currently unarchive from remote url does not work because the core
unarchive module was updated to support 'remote_src' [1], but the
unarchive action plugin was not updated for this. This causes failures
because the action plugin assumes it needs to copy a file to the
remote server, but in the case of downloading a file from a remote
url a local file does not exist, so an error occurs when the file is
not found.

[1] https://github.com/ansible/ansible-modules-core/commit/467516e

* test_unarchive: fix test with wrong remote_src use

The non-ascii filenames test had improperly set remote_src=yes even
though it was actually copying the file from the local machine (i.e.
the file did not already exist remotely). This test was passing
until the remote_src behavior of unarchive was fixed in 276550f.
8 years ago
James Cammarata 153133132d Updating tests for new module feature for remote_src in unarchive
Fixes #10218
8 years ago
Toshio Kuratomi 2a5ef4496a Workaround test failures on OSX controllers for now -- will have to look
more heavily into normailizing the unicode later.
9 years ago
Toshio Kuratomi c03555b650 Fix unarchive failures when the destination is a symlink to a directory (#15999)
Also add integration tests for this problem and unicode filenames inside
a tarball.

Fixes #3725
9 years ago
Toshio Kuratomi b90506341a Fixes for tests that assumed yum as package manager for systems that
have dnf
9 years ago
Toshio Kuratomi a0def30c34 Add integration test for unarchive filelist feature 10 years ago
Toshio Kuratomi aab681bc2b Update core and extras module refs and add tests for an unarchive
problem that the update fixes:

https://github.com/ansible/ansible-modules-core/issues/1064
10 years ago
Dan Rue 787388ac30 Do not mark "skipped" when changed is false
When using the "creates" option with the unarchive module, set changed
to False if the file already exists. This behavior is consistent with
other modules which use "creates", such as command and shell.
10 years ago
Toshio Kuratomi 364f772cc5 Fix quoting of shell parameters used in remote_checksum and add integration test to detect the error
Fixes #682
10 years ago
Toshio Kuratomi 7e538d54dd Install zip for the unarchive test 10 years ago
Toshio Kuratomi cce87acfed Fix integration test for unarchive to test zipfiles 10 years ago
Toshio Kuratomi 6326daa34e Update modules for unarchive handling user,group,mode and add integration test for the same 10 years ago
Toshio Kuratomi ee469c2ab1 Add a check that unarchive works with complex_args 10 years ago
Brian Coca dd60036fb9 added changed status to return when new early create check is triggered,
added skipped check to test on create existing
10 years ago
Will Thames d9b895b319 Unarchive should work when parent directory is not writable
Correct unarchive so that the checks for writeability are
sensible.

Added a test for when parent directory is not writable
10 years ago
Richard C Isaacson a483e42583 unarchive module: Add creates functionality.
Closes GH-5354.

Forklift copy logic into unarchive. Provides integration unit tests.
11 years ago
Michael DeHaan 2177b773c8 Rename tests to test, use old directory name. 11 years ago