Commit Graph

16448 Commits (d91b3c6b9d767005e88c0e991de2a15692bca612)
 

Author SHA1 Message Date
James Cammarata d91b3c6b9d Make sure magic variables are available when templating vars_files
Also does some reorganization/cleanup on the magic vars/delegated
variable generation portions of VariableManager to make the above
possible.

Fixes #12633
9 years ago
James Cammarata 284bd118a0 Properly switch to the default transport when delegating from localhost 9 years ago
James Cammarata 97c2b2ecc5 Merge pull request #12636 from bcoca/galaxy
Galaxy
9 years ago
Brian Coca 6f88f79de9 removed dupe install code, now trap errors forom role.install 9 years ago
Brian Coca f73329401b galaxy updates
better error reporting on fetching errors
use scm if it exists over src
unified functions in requirements
simplified logic
added verbose to tests
cleanup code refs, unused options and dead code
moved get_opt to base class
fixes #11920
fixes #12612
fixes #10454
9 years ago
Brian Coca a3ed9fc131 updated to 'fixed' get_url so docs build again 9 years ago
Brian Coca 130ba70598 added missing blank line for markup separation 9 years ago
Brian Coca f3d0468726 updated submodule refs 9 years ago
Brian Coca da458bbfd6 added way to display inventory vars for host to faq + some minor fixes/edits 9 years ago
James Cammarata 323012be2e Pop tags out of playbook include params
Fixes #12605
9 years ago
Toshio Kuratomi 10a4a4e986 Quote any file paths that we have to use with dd to copy.
This is because we pass the whole dd command string into the shell
that's running on the contained environment rather than running it
directly from python via subprocess without a shell.
9 years ago
Toshio Kuratomi b83988d9fb Port libvirt_lxc connection plugin to v2 9 years ago
Toshio Kuratomi 567deb5ac2 Add explicit substitution of relative paths on the remote host just in case the connection programs do something unexpected. 9 years ago
Brian Coca 8528b20702 fixed usage text 9 years ago
Brian Coca 04a2b221b9 removed conflicting short options 9 years ago
James Cammarata 38528c8ef3 Show more info in the minimal callback for unreachable hosts
Fixes #12621
9 years ago
Toshio Kuratomi 613e87db6c FIx typo arg_path (not plural) 9 years ago
Brian Coca 5680a9fa32 removed redundant tests, adjusted makefile expected count 9 years ago
Brian Coca 4ba5ebd1c8 Merge pull request #12538 from yesbox/url_lookup_plugin_httperror_fix
Fix url lookup plugin HTTPError message not being reachable
9 years ago
Toshio Kuratomi a1f6de8745 Merge pull request #12593 from ansible/py3-unicode-exec
Since Connection.execute_command() returns bytes, deal with the repurcussions
9 years ago
Toshio Kuratomi 10750214ea Since Connection.execute_command() returns bytes, deal with the repurcussions here. 9 years ago
Brian Coca e2ae3215f6 corrected no_log for items and skipped tasks
corrected output from default callback
added new tests for no_log loops
updated makefile test to check for both positive and negative occurrences of no_log
9 years ago
James Cammarata 86ef20c73b Merge branch 'amenonsen-ssh-args' into devel 9 years ago
James Cammarata c28758d2a8 Merge branch 'ssh-args' of https://github.com/amenonsen/ansible into amenonsen-ssh-args 9 years ago
James Cammarata 82faba619e Also add args_path param to powershell shell plugin 9 years ago
James Cammarata 30d481ac57 Fix old-style (non-python) module support 9 years ago
Toshio Kuratomi e40e08d799 Update core sumodule ref to fix docs 9 years ago
Abhijit Menon-Sen ba98c70bea Mention new ssh argument variable in the changelog 9 years ago
Abhijit Menon-Sen b127221f50 Pass default None to getattr, remove repeated call 9 years ago
Abhijit Menon-Sen 478e234bc3 Reword the jump host section in the FAQ
It's just s/extra_args/common_args/, but I reworded some parts to make
things a bit clearer too.

Closes #12335
9 years ago
Abhijit Menon-Sen 96c4dc273a Set explicit default for ANSIBLE_SSH_ARGS
The earlier code behaved exactly as though this default had been set,
but it was actually handled as a(n unnecessary) special case inside the
connection plugin, rather than set as an explicit default.

If the default is overriden either in ansible.cfg or the environment,
the new code will continue to work (in fact, it won't know or care,
since it just uses the value set in the PlayContext).

This is submitted as a separate commit for easier review to address
backwards-compatibility concerns.
9 years ago
Abhijit Menon-Sen 1981bf2b95 Aggregate ssh arguments in PlayContext instead of the connection plugin
Using set_host_overrides() in the connection plugin to access the ssh
argument variables from the inventory didn't see group_vars/host_vars
settings, as noted earlier. Instead, we can set the correct values in
the PlayContext, which has access to all command-line options, task
settings, and variables.

The only downside of doing so is that the source of the settings is no
longer available in ssh.py, and therefore can't be logged. But the code
is simpler, and it actually works.

This change was suggested by @jimi-c in response to the FIXME in the
earlier commit.
9 years ago
Abhijit Menon-Sen 3ad9b4cba6 Rework additional ssh argument handling
Now we have the following ways to set additional arguments:

1. [ssh_connection]ssh_args in ansible.cfg: global setting, prepended to
   every command line for ssh/scp/sftp. Overrides default ControlPersist
   settings.
2. ansible_ssh_common_args inventory variable. Appended to every command
   line for ssh/scp/sftp. Used in addition to ssh_args, if set above, or
   the default settings.
3. ansible_{sftp,scp,ssh}_extra_args inventory variables. Appended to
   every command line for the relevant binary only. Used in addition to
   #1 and #2, if set above, or the default settings.
3. Using the --ssh-common-args or --{sftp,scp,ssh}-extra-args command
   line options (which are overriden by #2 and #3 above).

This preserves backwards compatibility (for ssh_args in ansible.cfg),
but also permits global settings (e.g. ProxyCommand via _common_args) or
ssh-specific options (e.g. -R via ssh_extra_args).

Fixes #12576
9 years ago
Toshio Kuratomi f13d5201b8 Update module refs 9 years ago
Brian Coca 42198a7a59 updated adding os_router and deprecating quantum modules 9 years ago
Brian Coca 4c9f58a152 added no_log censoring to item output
should be last commit that fixes #12214
9 years ago
Brian Coca 5c39538a73 added no_log tests as per #12214 9 years ago
Brian Coca ba4afcbbb6 added no_log to results
normalized outputs to use display class
cleaned up unused imports
9 years ago
Brian Coca c27bd4fab0 {sudo,su}_user does not imply become 9 years ago
James Cammarata 57372906aa Pull host/group vars when adding hosts/groups
Fixes #12582
9 years ago
James Cammarata aa3687d736 Fix syntax error for octal in encrypt methods 9 years ago
James Cammarata 538568305a Submodule pointer update for accelerate module fixes 9 years ago
James Cammarata 8ef78b1cf8 Fixing accelerated connection plugin 9 years ago
Brian Coca 00b8a24299 Merge pull request #12579 from acogdev/devel
Alphabitize retry_files_enabled and retry_files_save_path
9 years ago
Brian Coca 3705d54485 fixed error reporting on splitter 9 years ago
Brian Coca de2f62bd9e fixed error reporting for unkown become user 9 years ago
Brian Coca 6d6bfbc3d2 added missing import for pwd, was being obscured by exception catching and fallback 9 years ago
Brian Coca a680ef66dd fixed vault password file script execution 9 years ago
Brian Coca 6b842d9c49 fixed incorrect data passing on certain events 9 years ago
Brian Coca 2463922306 fixed error reporting when missing redis import 9 years ago