Commit Graph

5878 Commits (d7b516f75dc879ad350b285e7ddc398418bf85fd)

Author SHA1 Message Date
Brian Coca a6f6a80caa avoid inheritance issues with default=dict declaration at class level
this should avoid the issue of subsequent plays not prompting for a var
prompted for in a previous play.
9 years ago
Toshio Kuratomi 30094912eb boto is expecting that we pass it unicode strings.
The secret_key parameter especially can contain non-ascii characters and
will throw an error if such a string is passed as a byte str.

Potential fix for #13303
9 years ago
Arata Notsu 6d6d4f0c8e BOOLEAN should contain boolean literals
It is natural that an argument_spec with choises=BOOLEAN accepts
boolean literal (True, False) though the current implementation
allows only string or int.
9 years ago
Toshio Kuratomi ba4e571029 Update submodule refs to go along with the StandardError change in ec2 moudles 9 years ago
Toshio Kuratomi 19d5759771 raise AnsibleAWSError instead of StandardError.
* StandardError doesn't exist in python3
* because it is the root of builtin expections, we can't catch it
  separate from the builtin exceptions
* It doesn't tell us anything about the error being thrown as it's too
  generic
9 years ago
James Cammarata dc0fae1af7 Also make sure remote_user is defaulted correctly for delegated hosts
Fixes #13323
9 years ago
Toshio Kuratomi e2ddc2f6ab Call the function :-)
Fixes #13330
9 years ago
James Cammarata cc36eedf76 Ensure port is (re)set for delegated-to hosts
Fixes #13265
9 years ago
Brian Coca b5f2c3def2 fixed typo 9 years ago
Brian Coca eefb4931dd allow for bad stdout return from make temp dir command
fixes #13359
9 years ago
Brian Coca 005b17afec corrected become_methods class variable in winrm
This should now correctly react when using become with winrm
fixes #13331
9 years ago
James Cammarata 80db6bacc4 Make sure run_once tasks properly set variables for all active hosts
Fixes #13267
9 years ago
James Cammarata fbc9553bd4 Use text_type instead of unicode 9 years ago
James Cammarata c6a30f7000 Make sure the uuid in vars is string 9 years ago
James Cammarata f926e81782 Re-implement lookup wantlist
Fixes #13285
9 years ago
James Cammarata dfa576b037 Merge pull request #13307 from Yannig/devel_fix_big_include_vars
Fix for https://github.com/ansible/ansible/issues/13221
9 years ago
Peter Sprygada c087160652 initial add of ssh shared module.
This ssh shared module is used for building modules that require an
interactive shell environment such as those required for connecting
to network devices
9 years ago
James Cammarata 6671d78f95 Tweak location of stats callback execution and properly relocate stats output code 9 years ago
James Cammarata ea23159be4 Merge pull request #13348 from emonty/bug/iterate-on-none
Put in trap for args being None
9 years ago
Monty Taylor d20e67d708 Put in trap for args being None
_normalize_old_style_args can return None. If it does, the loop
"for args in args" blows up.
9 years ago
James Cammarata 800811a15f Trigger on_stats just once, not once for each play
Fixes #13271
9 years ago
James Cammarata a7f7f8bd29 Merge pull request #13297 from amenonsen/ssh-escalation
Explicitly accept become_success in awaiting_prompt state
9 years ago
James Cammarata 5b6162a166 Re-adding role_name/role_uuid variables 9 years ago
James Cammarata 8d9835c40b Merge pull request #13342 from Yannig/devel_fix_bomb_shell
Devel fix bomb shell
9 years ago
Yannig Perré 5227c6bb52 Do not copy variable_manager each time. Instead, keep host and local variable_manager sync.
Fix https://github.com/ansible/ansible/issues/13221
9 years ago
Yannig Perré 2fc7c8b460 More restrictive test against variable name to allow setting variable starting with _. 9 years ago
Brian Coca fa358d9d61 avoids prompting for vars during syntax check
fixes #13319
9 years ago
Yannig Perré 2c54fb1339 Switch parameters validation after parsing in order to be more consistent between old and new style. 9 years ago
Abhijit Menon-Sen f20e2630b0 Explicitly accept become_success in awaiting_prompt state
If we request escalation with a password, we start in expecting_prompt
state. If the escalation then succeeds without the password, i.e., the
become_success response arrives, we must explicitly move into the next
state (awaiting_escalation, which immediately goes into ready_to_send),
so that we no longer try to apply the timeout.

Otherwise, we would leak the success notification and eventually
timeout. But if the module response did arrive before the timeout
expired, the "process has already exited" test would do the right
thing by accident (which is why it didn't fail more often).

Fixes #13289
9 years ago
Toshio Kuratomi 1b743436b9 Do not double transform to unicode 9 years ago
Chrrrles Paul 157230c3e8 Merge pull request #13257 from chrrrles/utf8
fixing error with using non-ascii values for ask-sudo-password
9 years ago
Charles Paul 1e5a205389 fixing errors with utf-8 values
removing utf-8 stanza

changing cast to binary_type instead

using to_unicode
9 years ago
Brian Coca 71fe49ee3a Merge pull request #13247 from bcoca/fetch_fixes
fixes to fetch action module
9 years ago
Brian Coca 7244b5ae49 added missing : 9 years ago
Brian Coca 0ec60ac09b added missing events to base class 9 years ago
James Cammarata 70de8bc96f Fix ssh state issues by simply assuming it's never connected 9 years ago
James Cammarata 65747285a4 Properly check for prompting state when re-using ssh connection
Fixes #13278
9 years ago
James Cammarata 96fcfe45d0 Merge pull request #13264 from Yannig/devel_debug_var_list_or_dict
Allow debug var parameter to accept a list or dict.
9 years ago
Yannig Perré 5fa49a9ad8 Use to_unicode instead of str() 9 years ago
James Cammarata 679488fdb5 Merge pull request #13239 from sysreq0/devel
We should give pipes.quote() a string every time
9 years ago
James Cammarata 53e86f3130 Merge pull request #13261 from cchurch/with_items_reuse_connection
Modify task executor to reuse connections inside a loop.
9 years ago
James Cammarata e06b107d2d Template (and include vars) PlaybookInclude paths
Fixes #13249
9 years ago
Chris Church 272778f732 Modify task executor to reuse connection inside a loop. Fix WinRM connection to set _connected properly and display when remote shell is opened/closed. Add integration test using raw + with_items. 9 years ago
Toshio Kuratomi adf2d53fa2 Update submodule refs 9 years ago
Yannig Perré 0480b44f50 Allow debug var parameter to accept a list or dict. Fix https://github.com/ansible/ansible/issues/13252 9 years ago
Brian Coca 478c6c756a marked spot that should send per item reulsts 9 years ago
Brian Coca fb96748d7c fixes to fetch action module
* now only runs remote checksum when needed (fixes #12290)
 * unified return points to simplify program flow
9 years ago
Toshio Kuratomi 2631a8e6e4 Update extras to fix docs build 9 years ago
Toshio Kuratomi 8fd15ae2a3 Merge pull request #13217 from ansible/more-strict-plugin-lookup
Fix non-module plugins picking up files that did not end in .py.
9 years ago
Toshio Kuratomi 77c83fd520 Commit submodule refs to the devel HEAD 9 years ago
Toshio Kuratomi 664c7980a2 Update submodule refs 9 years ago
Sebastien Couture 087dbc1ed5 We should give pipes.quote() a string every time 9 years ago
Toshio Kuratomi 591c81e95f Docker cp sets file ownership to root:root so we can't use it.
Fixes #13219
9 years ago
Toshio Kuratomi d75e707af5 Simplify code a little 9 years ago
Toshio Kuratomi 72558f7ecd Merge pull request #13074 from joernheissler/patch-13073
Use ansible_host in synchronize module
9 years ago
Toshio Kuratomi c86120cea6 Fix non-module plugins picking up files that did not end in .py.
This was caused by accessing the cache using the passed in mod_type
rather than the suffix that we calculate with knowledge of whether this
is a module or non-module plugin.
9 years ago
James Cammarata c97c101bd3 Merge pull request #13209 from nitzmahone/winrm_put_file
fast winrm put_file without size restrictions
9 years ago
James Cammarata 8a0d2e0ef2 Submodule pointer update 9 years ago
James Cammarata 91500f8f5f Fix include param precedence in variable manager 9 years ago
James Cammarata 78e4f176e6 Return skipped/failed async results directly
Fixes #13205
9 years ago
James Cammarata 3b16ad973c Merge pull request #13201 from ma82/patch-1
Fix DataLoader's docstring
9 years ago
Marius Gedminas 66347c9449 Fix NameError when using loops
vars_copy disappeared in 3d1255d190.

Fixes #13213.
9 years ago
nitzmahone db83c0e7cd winrm error handling tweaks 9 years ago
James Cammarata 3d1255d190 Don't update job vars too early when getting loop items in TaskExecutor
Fixes #13113
9 years ago
Brian Coca f8ed99e5e4 Revert "success should not include skipped"
This reverts commit 300ee227a2.
9 years ago
nitzmahone 549163170f fast winrm put_file without size restrictions 9 years ago
Matteo Acerbi 0127d32652 Fix DataLoader's docstring
DataLoader.__init__ doesn't take an argument named vault_password
9 years ago
James Cammarata 9b9fb51d9d Template the final_environment value in _compute_environment_string()
Fixes #13123
9 years ago
Toshio Kuratomi 782aa9a7fd Update submodule refs 9 years ago
James Cammarata 180159b01d Adding vars back in and trying to add a little more speed by avoiding copies 9 years ago
James Cammarata 25807f5404 Don't modify things we've put on the queue
Fixes #12937
9 years ago
Brian Coca d35f615af8 added more debug info for command results 9 years ago
Brian Coca aa55db69fe Merge pull request #12687 from nitzmahone/pywinrm_arg_passthru
Force SSL transport for pywinrm updates, get host+group vars
9 years ago
James Cammarata f10d2c57c8 Restoring templating of hostvars returned by __getitem__ 9 years ago
James Cammarata 9f31c073fe Fixing a few bugs in the HostVars performance areas
* Also refresh inventory in the HostVars manager process when things
  are changed via add_host/group_by
* Raise j2undefined rather than return it
9 years ago
James Cammarata 984729016e Fix tag filtering on included files and add more debugging
Previously, we were filtering the task list on tags for each host
that was including the file, based on the idea that the variables
had to include the host information. However, the top level task
filtering is play-context only, which should also apply to the
included tasks. Tags cannot and should not be based on hostvars.
9 years ago
James Cammarata 5cbeab5a3c Performance improvements for HostVars and some bugfixes 9 years ago
Dann Bohn 7f2cae5405 add REPLACER_SELINUX back into module_common 9 years ago
Brian Coca 355fa4797a Merge pull request #13186 from nitzmahone/add_host_cache_fix
fix for dynamic (add_host) hosts not available in hostvars
9 years ago
Brian Coca 6a2559be02 Merge pull request #13184 from nitzmahone/hostvars_undefined_fix
hostvars should return j2 undefined as instance, not type
9 years ago
Toshio Kuratomi fc7e2912f2 zone connection plugin bugfixes and pipelining and sudo become methods enabled!
Thanks to peinheber for helping test and debug this!
9 years ago
nitzmahone 349e072a74 fix for dynamic (add_host) hosts not available in hostvars
Looks like there are two pattern caches that need to be cleared for this to work- added the second one.
Added integration tests for add_host to prevent future regressions.
9 years ago
nitzmahone 3bb1f7a561 hostvars should return j2 undefined as instance, not type
Looks like someone forgot to create an instance of undefined here- we were returning the undefined type object, which broke all the undefined checks.

Added an integration test around add_host that will catch this (separate PR to follow)
9 years ago
Brian Coca db27541a0e Merge pull request #13053 from Etherdaemon/fix_13010_boto3_aws_profile
Fixes #13010 by updating boto3 methods
9 years ago
Brian Coca 89646d4253 no need to be executable 9 years ago
Brian Coca 2083a2dffa Merge pull request #13174 from sebi-hgdata/sebi/consul_kv_issue
Consul kv lookup super invocation fix
9 years ago
Brian Coca 83f7942dcf removed print entries, corrected display calls to match latest devel 9 years ago
Brian Coca 78be81b96d Merge pull request #12510 from jcftang/devel
Initial add of logentries callback plugin
9 years ago
Brian Coca f1db99caa7 updated with latest changes to default 9 years ago
Brian Coca eeedaf2cbc fixed var name typo 9 years ago
Brian Coca e174247734 evaluate includes for skipped tags
cannot evaluate for include tags as underlying tasks might have them, but skips override so this should be a performance boost
9 years ago
Sebi Calbaza 1f052d5ce6 fixed super invocation 9 years ago
Jimmy Tang 19ba54c9fd Don't be fatal on import errors so plays don't fail if plugin doesn't have required dependencies 9 years ago
Jimmy Tang 125370ab48 Run when whitelisted 9 years ago
Jimmy Tang 5f2f5e2b59 Add boilerplate and fix initialisation to match what 2.0 expects 9 years ago
Jimmy Tang c02ceb8f12 Remove threading and queues. Added license information and cleaned up callback. 9 years ago
Jimmy Tang 85277c8aae Initial add of logentries callback plugin
This callback plugin will generate json objects to be sent to the
logentries service for auditing/debugging purposes.

To use:

Add this to your ansible.cfg file in the defaults block

    [defaults]
    callback_plugins = ./callback_plugins
    callback_stdout = logentries
    callback_whitelist = logentries

Copy the callback plugin into the callback_plugings directory

Either set the environment variables

    export LOGENTRIES_API=data.logentries.com
    export LOGENTRIES_PORT=10000
    export LOGENTRIES_ANSIBLE_TOKEN=dd21fc88-f00a-43ff-b977-e3a4233c53af

Or create a logentries.ini config file that sites next to the plugin with the following contents

    [logentries]
    api = data.logentries.com
    port = 10000
    tls_port = 20000
    use_tls = no
    token = dd21fc88-f00a-43ff-b977-e3a4233c53af
9 years ago
Brian Coca 300ee227a2 success should not include skipped
fixes #13161
9 years ago
James Cammarata 07b588f6c0 Version bump for new beta 2.0.0-0.5.beta3 9 years ago
James Cammarata 2b25b7974c Remove unnecessary sleep from result process 9 years ago
Brian Coca 634e10e5b8 Merge pull request #13156 from amenonsen/broken-timeout
If ssh died, it's an error, not a timeout
9 years ago
Abhijit Menon-Sen 26ea9c4351 If ssh died, it's an error, not a timeout 9 years ago
David M. Lee 5bd096208c Increase the escalation prompt timeout
It was set to match the SSH connect timeout. Unfortunately, they would
race when ssh fails to connect, and the connect timeout usually failed.
This led to some misleading error messages.

Fixes #12916
9 years ago
James Cammarata 31b1abf580 Merge pull request #13146 from nitzmahone/gce_error_messaging
fix gce module error reporting
9 years ago
nitzmahone 4163655099 fix gce module error reporting
Error reporting was broken for GCE modules- pprint didn't work with exceptions, so you'd always get "Unexpected response: {}" instead of the real error.
9 years ago
Toshio Kuratomi 958fb29b78 Merge pull request #12881 from Scypho/devel
fix for issue #11885 - allowing json in lookup template calls
9 years ago
James Cammarata 13750f68ee Reduce spinning while waiting on queues 9 years ago
Daniel Menet 0918416b83 substitute tilde and env vars before storing C.CACHE_PLUGIN_CONNECTION as instance attribute 9 years ago
Toshio Kuratomi 7fd8b86a10 Fix documentation build problems 9 years ago
Toshio Kuratomi d38ac6a394 Update submodule ref for another new module 9 years ago
Toshio Kuratomi 7807e99bca A bunch of shipit's merged 9 years ago
Toshio Kuratomi 8aa2cbd647 Fix traceback because we're using display from another object that no
longer has it.
9 years ago
James Cammarata b2b0fa8d13 Changed do/until failed color
Fixes #13130
9 years ago
James Cammarata 94c20c9ac6 Cleanup failed/changed logic in TaskExecutor
Fixes #12980
9 years ago
Toshio Kuratomi 62979efa14 Finish up plugin porting to global display
Also remove display = display which does nothing
9 years ago
Toshio Kuratomi 2bd695ed42 Port cache plugins to global display 9 years ago
Toshio Kuratomi b05d0b8c9c Port lookup plugins to global display. 9 years ago
Toshio Kuratomi 4c7128da17 Port action plugins to global display 9 years ago
Toshio Kuratomi 186e034515 Move the rest of executor code to global display 9 years ago
Toshio Kuratomi 7ecfa072da Move the rest of the playbook code to use global display 9 years ago
Toshio Kuratomi aa4f213cb5 Move connection plugins to using global display 9 years ago
Toshio Kuratomi 318bfbb207 Migrate cli and dependencies to use global display 9 years ago
Brian Coca 1b7d3f2898 updated submodule refs 9 years ago
Brian Coca 99f45f2e19 pass task args without filtering, copy module needs to explcitly support
remote_src or it will remove the src file
9 years ago
Toshio Kuratomi c7b69127ec Remove dead code 9 years ago
Toshio Kuratomi e45ce871a7 Fix for traceback when neither name nor pkg are in the module params 9 years ago
Toshio Kuratomi 4737305837 Remove dead code as this was moved to another class 9 years ago
Brian Coca be22a670e5 addes deprecated information to ansible-doc display
fixes #13118
9 years ago
Brian Coca 1b349fdf34 Merge pull request #13112 from privateip/eapi
add initial support for Arista eAPI
9 years ago
James Cammarata 566144461f Remove internal use of display and use the top-level import 9 years ago
James Cammarata 0fc187893d Catch import warnings in a common location for both get() and all()
Potential solution for #12979
9 years ago
James Cammarata 9f0c2cfda5 Merge pull request #13114 from mgedmin/fix-plugin-loader
Check sys.modules before loading modules
9 years ago
Marius Gedminas 54eae4a793 Check sys.modules before loading modules
Code for a plugin is usually loaded by a PluginLoader(), and henceforth
available from self._module_cache, which prevents duplicate loading.
However there are situations (e.g. where one action plugin imports code
from another one) where the plugin module might be already imported (and
resident in sys.modules), but not present in the PluginLoader's
_module_cache, which causes imp.load_source() to effectively reload the
module, overwriting global class declarations and causing subtle latent
bugs.

Fixes #13110.
Fixes #12979.
9 years ago
James Cammarata a99f2fd52f Save delegated vars in result for use in callback methods
Fixes #13014
9 years ago
Peter Sprygada 2e98f7f429 add initial support for Arista eAPI
This commit adds the shared module support for Arisat EOS devices
running eAPI.  The shared module builds on top of module_utils/urls.py.
9 years ago
James Cammarata e56fd9e95d Make sure pattern cache components are converted to unicode 9 years ago
James Cammarata 0b999c602a Properly figure subset and restrictions into host cache pattern
Fixes #13111
9 years ago
James Cammarata d8fb5efa90 Merge pull request #13102 from Yannig/devel_cache_enhancement
New method template_no_cache for template object.
9 years ago
Yannig Perré 0c360d17cb New parameter for template method.
We do not compute hash when we know that the result does not need to be cached (like with_items loop).
It also result in a small speed improvement.
9 years ago
Etherdaemon 27398131cf Fixes #13010 by updating boto3 methods to update boto3_conn to check for profile_name and if detected, remove from params and set a new variable of profile which is passed into Session separately 9 years ago
James Cammarata 09994c18f3 Correct logic around determining environment variable existence
Fixes #13105
9 years ago
James Cammarata c753ae6e22 Fixing up host pattern caching to avoid bugs
* Always cache and return unique list objects, so that if the list
  is changed later it does not impact the cached results
* Take additional parameters and the type of the pattern into account
  when building the hash string
9 years ago
James Cammarata e8f83dcba3 Revert "Temporarily disable template caching"
This reverts commit 4d1757ce64.
9 years ago
James Cammarata 4d1757ce64 Temporarily disable template caching 9 years ago
Toshio Kuratomi 995db275f8 Update submodule refs 9 years ago
Toshio Kuratomi db5d3f03a9 Fix first_found not finding files in roles (only templates) 9 years ago
James Cammarata ccbcfcddfc Move where we add environment and make it conditional on not existing
Also displays a warning now, because users should not be using that variable
name as it causes a collision with the internal variable of the same name.
9 years ago
Brian Coca 37ae243587 made get_file_lines rely on get_file_content which deals with many error
conditions that the former did not.
9 years ago
ghislainbourgeois eb850d7e5b Fix get_dns_facts on inexistent resolv.conf 9 years ago
James Cammarata e36b4e2a13 Merge pull request #13072 from Yannig/devel_cache_optimization
Cache optimization
9 years ago