Commit Graph

13275 Commits (d76a84a6c8958251d8713c2f77d38a1e5db03371)

Author SHA1 Message Date
Jonathan 4376417743 fix drain mode 'bool' (#30833) (#46478) 7 years ago
Martin Nečas 4c7bb32c1f Ovirt add kernel persist (#45555)
* ovirt add kernel persist

* Add description to kernel_params_persist

* update kernel_params_persist control logic

* correct pep8 syntax

* add condition for kernel_params

* put kernel persist check to function

* kernel persist check update tabs
7 years ago
Martin Nečas d79be6a00c add external provider to ovirt network (#43636)
* add external provider to ovirt network

* add version added

* add example

* test of importing external network

* ovirt correct datacenter search in external provider

* repair importing external provider

* update external provider docs

* update pep8 syntax
7 years ago
Sam Doran bcfdc37be0 Add documentation on underlying tools in user module (#46455) 7 years ago
Christian Kotte a4961ff32a VMware: Add check mode support to module vmware_host_firewall_facts (#46265) 7 years ago
Christian Kotte ab26119637 VMware: Add check mode support to module vmware_host_acceptance (#46260)
* Improve module description
* Add check mode support
7 years ago
Ganesh Nalawade 5e6eb921ae
Make default_operation optional in netconf_config module (#46333)
Fixes #46257

*  As per netconf rfc default-operation value is optional,
   hence removing the default value for default_operation
   option.
7 years ago
Dag Wieers 12d688c006 Docs: Clean up of 'fetch' module docs (#46330)
* Docs: Clean up of 'fetch' module docs

This is part of a series of module doc cleanups.

* Fixes as suggested by review
7 years ago
Dag Wieers 21d23829be Docs: Clean up 'win_reboot' module docs (#46377)
* Docs: Clean up 'win_reboot' module docs

This is part of a series of module doc cleanups.

* Remove hypothetical example
7 years ago
Sandra McCann 56f23594a5 add simple j2 example to vyos_config (#46442) 7 years ago
Dag Wieers be0dc34b6f Docs: Clean up of 'template' module docs (#46297)
* Docs: Clean up of 'template' module docs

* Changed influenced by review comments
7 years ago
Dag Wieers 3f2f53681d Docs: Clean up 'win_service' module docs (#46407)
* Docs: Clean up 'win_service' module docs

This is part of a series of module doc cleanups.

* Fix typo pause vs paused

* Use both YAML list syntaxes
7 years ago
Sam Doran b74279d14c Use proper index value with insertbefore on a one line file (#46071)
Add tests and changelog
7 years ago
Major Hayden b6568c1c75 Docs: Cleanup make module docs (#46422)
Signed-off-by: Major Hayden <major@redhat.com>
7 years ago
Dag Wieers d6a581502f Docs: Clean up of 'assemble' module docs (#46328)
This is part of a series of module doc cleanups.
7 years ago
Jordan Borean ba638f40cf
ps-lint: ignore rules that are not relevant to Ansible (#46376) 7 years ago
Major Hayden 208b3c53dd Docs: iptables module cleanup (#46368)
Signed-off-by: Major Hayden <major@redhat.com>
7 years ago
Dag Wieers 79511d02a7 Docs: Clean up of 'file' module docs (#46327)
This is part of a series of module doc cleanups.
7 years ago
Bianca Henderson 0ab448531b Update asa_config.py (#46448)
<!--- Your description here -->

+label: docsite_pr
7 years ago
newtonne bd849e8fb4 Macports: Add upgrade parameter and replace update_ports with selfupdate (#45049)
* macports: Replace update_ports with selfupdate

- Macports discourages use of `port sync` and recommends using `port
selfupdate` instead.
- Keep `update_cache` and `update_ports` as aliases.
- No longer require the `name` parameter so that `selfupdate` can be
used in a task by itself.

* macports: Add upgrade parameter

- New upgrade parameter which can be used to upgrade all outdated ports.

* Add changelog fragment
7 years ago
Major Hayden 84eb92d13d Docs: Cleanup selinux_permissive module docs (#46351)
Update the selinux_permissive instructions and add a comment to the
provided example.

Signed-off-by: Major Hayden <major@redhat.com>
7 years ago
Jordan Borean e283e7d5dd fixed tests after EAP set to Stop globally, ci_complete 7 years ago
Christian Kotte 1589424c3e VMware: Add check mode support in vmware_host_config_facts (#46272) 7 years ago
Felix Fontein 77fee07a88 Change with_*: loops to loop: loops. Fix some examples. (#46373) 7 years ago
Jordan Borean e972287c35 win_exec: refactor PS exec runner (#45334)
* win_exec: refactor PS exec runner

* more changes for PSCore compatibility

* made some changes based on the recent review

* split up module exec scripts for smaller payload

* removed C# module support to focus on just error msg improvement

* cleaned up c# test classifier code
7 years ago
Dag Wieers aa2f3edb49 Docs: Clean up of 'blockinfile' module docs (#46331)
* Docs: Clean up of 'blockinfile' module docs

This is part of a series of module doc cleanups.

* A few more fixes after review
7 years ago
Rohan Sadale 9874a49d1a Add examples for bind and unmount to mount module docs
PR #46375
7 years ago
Peter Jenkins 0a55431d83 Correct invalid example in jenkins_script docs (#46193) 7 years ago
Erwan Quelin 87416a4b91 Fix typo in the author's github username.
Ansibot is looking at the author's github username to query reviews for
modules in the same namespace.
7 years ago
cadl42 a7221dd289 Ignore empty result of rabbitmqctl list_user_permissions (#35598)
Fix #34863
7 years ago
mrmagooey b2dc7075df vcenter_folder - fix error events being generated, incorrect parent folders (#45951)
* fix error events being generated when vmware folders exist
* fix incorrect parent folders being identified (wrong type)
7 years ago
Egor Zaitsev 6df1f6b203 New module: routeros_facts – collect facts from RouterOS devices (#46114)
* feat(routeros): implement routeros_facts module

* fix(routeros): review by felixfontein

* fix(routeros): review by ganeshrn

* fix(routeros): review by felixfontein
7 years ago
Will Thames 411397a975 Use recursive_diff for kubernetes (#45645)
Move recursive_diff from cloudfront_distribution to
common.dict_transformations and reuse it in k8s modules
7 years ago
Zim Kalinowski 2a4bf670bb
clean up doc - removed required: false (#46357) 7 years ago
Juan Martinez 25a192034f Use specified loopvar in include_role example loop 7 years ago
Chris Scheib 6b00d4df5d Add logstash_plugin example for lower heap size
In a scenario where you've set your logstash heap size high, you may need to set your heap lower in order to execute logstash-plugin while logstash is still running.

Here's an example of someone running into insufficient memory while executing logstash-plugin: https://discuss.elastic.co/t/logstash-plugin-and-jvm-options/99646

This scenario is probably fairly common, so it may be worth documenting as an example.

+label: docsite_pr
7 years ago
Jason Meridth 667c40e80b Fix typo in ec2_vpnc_nat_gateway module (#46304)
- Added space between `format` and `in` on return item `create_time`
7 years ago
Daniel Jaouen 404b7140b6 homebrew_cask: Fixes #38772 7 years ago
abarbare c5d5d08b6b feat: add scaleway security_group_rule management (#45694)
* feat: add scaleway security_group_rule management
7 years ago
Remo Wenger 83e584577a docker_container: ambiguous parameter "stop_timeout" (#43874)
* docker_container: Honour stop_timeout when creating docker containers (#43814)

* Adjusting description to what actually happens.

See docker-py changelog for 2.7.0: 'APIClient.stop will
no longer override the stop_timeout value present in the
container’s configuration.'

* Add a test whether stop_timeout can be configured for the container.

* Added changelog.

* Integrate with comparisons (by default, ignore stop_timeout value for restarts; will be configurable with PR ansible/ansible#44789).

* Fix config change code and tests (#2)

* Improving wildcard test.
* Using correct config.
7 years ago
Matthew Krupcale 277bb3066c seboolean: Fix issue with changing persistent SELinux boolean values (#22779)
Previously, when the active SELinux value was the same as the desired value, regardless of the value of `persistent`, the module would simply exit successfully, assuming no need for update. This made the assumption that the active and persistent values should be the same, but that is not always the case. This modification treats both the active and persistent values separately when checking for the need to update. Note that the persistent update mode, however, will still update the active as well as the persistent value. If this is not desired, it is possible to separately toggle the active value alone.

Other changes:
* Make the check mode actually perform checks for changes
* Organizes semanage commands into set of logical steps
7 years ago
Daniel Jakots 2769a4e2cc Add support for OpenBSD (#46147) 7 years ago
Sam Doran 8b1ae30e2e
Use bytes rather than native string for result (#46281)
This prevents a stack trace in Python 3 when the result is an empty file since
the file is open in binary mode and a native string in Python 3 is str,
not bytes.
7 years ago
Dag Wieers ff06320b03 Add less judgmental hint to use script + template 7 years ago
Metzger, Simon 00d78d7ef3 added period in description. Changed integration test to work correctly. 7 years ago
Metzger, Simon 285af0b6fb added parameter leaf_port_blk_description in module and integration tests 7 years ago
Metzger, Simon be2c73ac18 be compliant to pep8 and pylint. Added integration tests. 7 years ago
Metzger, Simon cdd66295f2 changed documentation strings 7 years ago
Metzger, Simon 4d7cd4bea7 added new module aci_access_port_block_to_access_port 7 years ago
Vlad Mencl ef131c7556 module/systemd: fix logic determining if a service needs to be enabled (#46245)
* modules/systemd: fix logic: allow scope to default to 'system'

Fix logic introduced in 7ea909418e5: if 'scope' param is not specified,
it defaults to system, but the value of module.params['scope'] is None,
not 'system' - so allow for that.

* modules/systemd: fix logic: disabled means disabled

Fix logic determining whether a service with both systemd and initd files is enabled or disabled.

In situations where systemd thinks service is disabled, but rc.d symlinks mark it as enabled,
this module wrongly assumes the service is enabled.

Fix this logic: disabled means disabled

Only when the output from does NOT include disabled, consider the status of rc.d symlinks.

This essentially replicates the fixes done to the systemd handling in the "service" module in 3c89a21e0c

Fixes #22303

Fixes #44409
7 years ago
Dave Buckley dae2172045 fix wording for silencing a sensu client (#46250) 7 years ago
Brendan Jurd ab96bbdef9 Clean up Vault docs in User Guide. (#46188)
* Fix spelling of 'separate' throughout.

* Various cleanups in the User Guide for Vault.

- Fix spelling of 'algorithm'
- Fix indentation of nested list in payload format
- Fix mysterious refernce to 'b_pkey1'.
- Fix reference to newline as '\n': the backslash is lost when rendered
to the docs website. Specify the hex value for newline instead of the
backslash escape.

* Fix formatting

* Update vault.rst
7 years ago
Ondra Machacek 142d1f1f1c ovirt_host: Fix fail condititon of upgrade (#46104)
Signed-off-by: Ondra Machacek <omachace@redhat.com>
7 years ago
Felix Fontein 84682464c7 docker_container: allow to configure comparison for existing containers (#44789)
* Added comparison configuration.

* Improving user feedback on specifying a wrong option.

* Avoid bare except.

* Added basic integration tests.

* Adding wildcard support.

* Warn if ignore_image=yes is overridden.

* Added changelog fragment.
7 years ago
Sloane Hertel 9efc3dc761
Fix ec2_group for EC2-Classic accounts (#46242)
* Fix ec2_group for EC2-Classic accounts

* changelog
7 years ago
Felix Fontein a727a1ee67 [aws] route53 module: fix idempotency for CAA records (#46049)
* Fixing record order for CAA records to properly handle idempotency.

* Add integration tests that reproduce CAA failure
7 years ago
Susant Sahani aedcf9fed7 nmcli: set hairpin to str to bool (#45908)
Fix: nmcli module always sets hairpin mode to 1 for bridge slaves.

Closes #42569

Signed-off-by: Susant Sahani<susant@redhat.com>
7 years ago
Dag Wieers 04de52da2c Clean up common module docs (#45888)
Some of the older modules have evolved documentation that does not
follow a consistent style. This is a clean-up in form and style.
7 years ago
Adam Miller 71280ee773 Handle dnf immutable mutable datatypes (#46176)
In DNF < 3.0 are lists, and modifying them works
In DNF >= 3.0 < 3.6 are lists, but modifying them doesn't work
In DNF >= 3.6 have been turned into tuples, to communicate that
modifying them doesn't work

Further explanation of this is available via Adam Williamson from
the Fedora QA Team.

    https://www.happyassassin.net/2018/06/27/adams-debugging-adventures-the-immutable-mutable-object/

Signed-off-by: Adam Miller <admiller@redhat.com>
7 years ago
David Passante 382641ff24 cs_account: Implement role parameter support (#46166) 7 years ago
Kevin Subileau ac9d506a61 win_nssm: tests and several bug fixes (#44755)
* win_nssm: add failing tests for issue #44079

* win_nssm: use Run-Command instead of Invoke-Expression to prevent interpretation issue

Fix #44079

* win_nssm: add more failing tests

These tests highlight several issues with this module:
 * Service not started when state=started
 * Errors with app_parameters (see #25265)
 * Exception when passing several dependencies separated by comma as specified in doc

* win_nssm: fix service not started when state=started

Nssm status returns a multiline output that doesn't match any of the strict patterns in the switch statement.

* win_nssm: fix incorrect separator in doc for service dependencies

The dependencies parameter works with space as separator, but not with comma as shown in the documentation

* win_nssm: fix error with app_parameters parameter

Fix #25265

* win_nssm: add idempotence tests

* win_nssm: fix several idempotence issues and misbehaviors

Add missing space between arguments when app_parameters contains several keys.
Use Argv-ToString and Escape-Argument to improve arguments handling (parameters with quotes, backslashes or spaces).

* win_nssm: test parameters with spaces, quotes or backslashes

* win_nssm: restore comma as separator for service dependencies

Revert commit ddd4b4b

* win_nssm: restore support of string as dict form for app_parameters and remove support of literal YAML dict

* win_nssm: wrong variable in tests
7 years ago
Yunge Zhu 69594c5370 add azure_rm_cdnprofile and azure_rm_cdnprofile_facts (#45097)
* add cdn profile with facts

* fix merge issue

* fix version

* fix lint

* move cdn client out of azure_rm_common

* fix lint

* fix helper

* fix code bug

* fix bug

* fix import

* fix typo

* fix test
7 years ago
aaronk1 8498b58ad5 Update win_robocopy.py (#38633)
* Update win_robocopy.py

<!--- Show example of UNC path copy of a single file, noting trailing backslash required -->

+label: docsite_pr

* addresses jborean comment, removes double quotes

* Remove trailing slash part
7 years ago
Sandra McCann 08c392477e made sros_config docs match code for match options (#46135)
* made docs match code for match options

* fixed shippable error
7 years ago
tstoner b427499e3e Added feature facts to nxos_facts (#45934)
* Added feature facts to nxos_facts

* Fixed ansibot indentation

* Resolved ansibot whitespace missing after ','

* Per PR suggestion, created method in base class to gather switch config
and store in global variable to prevent multiple calls to switch.

* Addressed ansibot blank line & whitespace after ,
7 years ago
saichint 2b216384eb fix for banner idempotent issue (#46001)
* fix for banner issue

* review comments
7 years ago
René Moser f73996e6eb
cs_resourcelimit: use query_api for error handling (#46036) 7 years ago
René Moser 48b9992446
cs_ip_address: use query_api, fixes error handling (#46034) 7 years ago
René Moser 7f92a8c94c
cs_staticnat: fix sanity (#46037) 7 years ago
René Moser c09b785a66
cs_instance: doc: fix typo in examples (#46035) 7 years ago
Felix Fontein 95cfcac694 docker-py: bump minimal version to 1.8.0 (#46134)
* Bumping docker-py minimal version to 1.8.0.
* Improve docs formatting.
7 years ago
Abhijeet Kasurde c98cec17e0 VMware: trigger customization for customization_spec (#45415)
This fix allows to trigger VM customization if user specifies
customization spec.

Fixes: #44159

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
7 years ago
Abhijeet Kasurde a6b095756c
VMware: Add support for service type (#40651)
* Add support for - Replication, Provisioning
* Update documentation
* Update example

Fixes: #40529

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
7 years ago
Jordan Borean d0d4f2e406
win_setup: don't fail when running as non-admin and EAP is set to Stop (#46149) 7 years ago
Nathan Webster 3b786acb86 EC2_ASG: Enable support for launch_templates (#45647)
* Enable support for launch_templates in ec2_asg

* Fix asg create with LT and no version number

* Update mutually exclusive list

* Better function names
7 years ago
José Maia 923a7bd30f [azure] Fix name for the symbol * in docs (#46119)
Correct name is "asterisk", not "asterix", which is a popular franco-belgian comic character!

+label: docsite_pr
7 years ago
Zim Kalinowski 6056b89675
fix for managed disk facts (#46021) 7 years ago
abarbare 98b0594352 feat: add scaleway security group module (#45686)
fix: pep8 coding style

fix: error order requests
7 years ago
René Moser e7926cf9f4
cs_instance: fix host migration without volume (#46115) 7 years ago
Abhijeet Kasurde 4b4b21d745 [docs] Fix typos in aws_s3 and s3_bucket module docs (#46106)
Eucalypus to Eucalyptus

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
7 years ago
newtonne aac1ce7333 homebrew_cask: Pass install_options during uninstall (#44938)
Until https://github.com/Homebrew/homebrew-cask/issues/40866 is fixed,
install_options should be passed when uninstalling casks to ensure that
all artefacts are removed.
7 years ago
Dan f20938788a fixed nxos_aaa_server_host issue with type 7 encrypt key (#46015)
* fixed nxos_aaa_server_host issue with type 7 encrypt and added test cases

* added idempotence tests
7 years ago
Hirshr c11c3506cd spotinst_aws_elastigroup elastic_ips example (#41190)
* Update spotinst_aws_elastigroup.py
7 years ago
tomww c44de1069c Update synchronize.py, mention variable ansible_rsync_path needed for different local rsync binary (#41870)
* Update synchronize.py

If you want a different rsync binary on the local side, you need to set task variable ansible_rsync_path.
See examples.

Variable ansible_rsync_path looks to not be documented anywhere. If documented, needs to be said that is does not belong to synchronise options, instead belongs to tasks. (Sorry, I have no better wording)
7 years ago
Anoop Sood d1688adefc Update sl_vm.py (#43966)
* Update sl_vm.py

Updated the list of datacenters to include new datacenters.
7 years ago
akira6592 8213096b7f The sshkey option is available in version 2.7 and above (#46103) 7 years ago
Gustavo Muniz do Carmo 7a747341fb Fix iterator to list conversion in ldap_entry module
PR #45778 fixes #45417
7 years ago
Joachim Mathes 30314c15c7 Generalize config retrieval in ios_l3_interface module (#45270)
This makes it work with Cisco 3750E.
7 years ago
Dan a6c20488d3 Add ospf net type (#45904)
* Added ospf network type option to nxos_interface_ospf module

* Added documentation and example for the 'network' parameter

* adding version
7 years ago
Tobias Wolf d5f8738bf2 [rabbitmq_binding] Fix the quoting of vhost and other names (#45109)
* [rabbitmq_binding] Fix the quoting of vhost and other names, which was broken in PR #35651
* Merge missing urllib_parse.quote from PR #42422
* Missed one line, where  also needs to be escaped, i.e., the destination
7 years ago
tstoner e74e8b8e75 Additional feature enhancements to nxos_logging (#45844)
* Various changes to nxos_logging.  Plus added purge capibility.

* Made a few new nxapi_logging test cases conditional based on version
and/or platform.

* Addressed PR comments and ansibot shippable.  Fixed up nxos_logging documentation format.

* Addressed ansibot shippable issues with whitespaces and documentation.

* Resolved ansibot codestyle trailing whitespace
7 years ago
Horie Issei d8d4be40b0 Update typetalk.py to use com domain (#46045)
Typetalk now uses "com" domain.
FYI: https://www.typetalk.com/blog/typetalk-gets-new-top-level-domain-typetalk-com/

+label: docsite_pr
7 years ago
Sandra McCann c5a8a911b3 fix doc links (#46094) 7 years ago
Dominik Holler 67e87d3d1c ovirt_host_network: Add save parameter to example (#45965)
The parameter 'save' is added to an example and the default
behavior is mentioned in the description of the other
examples.
7 years ago
Susant Sahani 8ef18839a6 Add `systemctl daemon-reexec` to `systemd` module
```
- name: systemctl daemon-reexec
  - systemd:
       daemon_reexec=yes
```

Closes: #38880

Signed-off-by: Susant Sahani <susant@redhat.com>
7 years ago
Rémy Léone 53886ecc9b Add an Online servers fact 7 years ago
Vinay Dandekar fe6b7f6b5d [aws] Change IAM role name parsing to come from the ARN (#45534) 7 years ago
Sloane Hertel 485320aab8 [sns_topic] Don't mask non-authorization errors (#46030) 7 years ago
Dag Wieers db5b65f5d6 win_get_url: Clarify the encoded slash issue (#45376)
* win_get_url; Clarify the encoded slash issue
7 years ago
Dag Wieers f90fc8a9a2 Fix author in modules (#46068)
Fix a few cases where the author was incomplete or incorrect.
7 years ago