5 Commits (d63a71e3f83fc23defb97393367859634881b8da)

Author	SHA1	Message	Date
Rick Elrod	3c3ffc09c2	Fix and add tests for some module_utils.common.validation (#67771) ... * Fix test_check_mutually_exclusive exception-checking Asserting inside of the `with` context of `pytest.raises` doesn't actually have any effect. So we move the assert out, using the exception that gets placed into the scope after we leave the context, and ensure that it actually gets checked. This is also what the pytest documentation says to do: https://docs.pytest.org/en/latest/assert.html#assertions-about-expected-exceptions Signed-off-by: Rick Elrod <rick@elrod.me> * Add some tests for check_required_together Signed-off-by: Rick Elrod <rick@elrod.me> * use to_native instead of str, for consistency Signed-off-by: Rick Elrod <rick@elrod.me> * Add newlines for pep8 Signed-off-by: Rick Elrod <rick@elrod.me> * Add tests for check_required_arguments Signed-off-by: Rick Elrod <rick@elrod.me> * Sort missing keys in error message, since hashes are unsorted and this can be random Signed-off-by: Rick Elrod <rick@elrod.me> * Add changelog entry Signed-off-by: Rick Elrod <rick@elrod.me>	5 years ago
Sam Doran	2d266fbc87	Fix unit tests to work with pytest >= 5.0 (#60246) ... pytest made a change in the way the message from ExceptionInfo objects was returned. https://docs.pytest.org/en/latest/changelog.html#pytest-5-0-0-2019-06-28	5 years ago
Sam Doran	aa717661af	Move assertion in unit test inside loop (#60232)	5 years ago
Sam Doran	ff88bd82b5	Move type checking methods out of basic.py and add unit tests (#53687) ... * Move check_type_str() out of basic.py * Move check_type_list() out of basic.py * Move safe_eval() out of basic.py * Move check_type_dict() out of basic.py * Move json importing code to common location * Move check_type_bool() out of basic.py * Move _check_type_int() out of basic.py * Move _check_type_float() out of basic.py * Move _check_type_path() out of basic.py * Move _check_type_raw() out of basic.py * Move _check_type_bytes() out of basic.py * Move _check_type_bits() out of basic.py * Create text.formatters.py Move human_to_bytes, bytes_to_human, and _lenient_lowercase out of basic.py into text.formatters.py Change references in modules to point to function at new location * Move _check_type_jsonarg() out of basic.py * Rename json related functions and put them in common.text.converters Move formatters.py to common.text.formatters.py and update references in modules. * Rework check_type_str() Add allow_conversion option to make the function more self-contained. Move the messaging back to basic.py since those error messages are more relevant to using this function in the context of AnsibleModule and not when using the function in isolation. * Add unit tests for type checking functions * Change _lenient_lowercase to lenient_lowercase per feedback	6 years ago
Sam Doran	43a44e6f35	Move utility functions out of basic.py (#51715) ... Move the following methods to lib/anisble/module_utils/common/validation.py: - _count_terms() - _check_mutually_exclusive() - _check_required_one_of() - _check_required_together() - _check_required_by() - _check_required_arguments() - _check_required_if - fail_on_missing_params() --> create check_missing_parameters()	6 years ago