tedder
bffd137edd
code review fixes per #957
10 years ago
tedder
472331a53b
skip password changes so pg_authid isn't needed
...
Some places ([AWS RDS](https://forums.aws.amazon.com/thread.jspa?threadID=151248 )) don't have, or don't allow, access to the `pg_authid` table. The only reason that is necessary is to check for a password change.
This flag is a workaround so passwords can only be set at creation time. It isn't as elegant as changing the password down the line, but it fixes the longstanding issue #297 that prevented this from being useful on AWS RDS.
10 years ago
Toshio Kuratomi
b0bc6f1379
Merge pull request #888 from ansible/mysql-port
...
Fix for int port assignment in a playbook failing
10 years ago
Toshio Kuratomi
ec6304d5a0
Merge pull request #824 from Jmainguy/mysql_db_616
...
Now correctly gzip/bzips file back up in case of import failure
10 years ago
Jonathan Mainguy
ee8039ef09
Now correctly gzip/bzips file back up in case of import failure
...
Removed gunzip and bunzip2 dependency
10 years ago
Toshio Kuratomi
a1135f803d
Fix for int port assignment in a playbook failing
...
Ports are integer values but the old code was assuming they were
strings. When login_port is put into playbook complex_args as an
integer the code would fail. This update should make the argument
validating make sure we have an integer and then we can send that value
directly to the relevant APIs.
Fixes #818
10 years ago
Toshio Kuratomi
addca40604
Fix documentation to have correct param name
10 years ago
Solomon Gifford
35434f9672
mysql_user #829 : add update_password to mysql_user
10 years ago
David Hummel
1d92dd31a6
Fix issue #793 : mysql_db: for state={absent,present} connections to database mysql fail for users other than root
10 years ago
Brian Coca
02af66d232
Merge pull request #559 from mjschultz/postgres-db-fix
...
Build the db connection on `"postgres"` instead of `"template1"`
10 years ago
Brian Coca
1394920cd3
Merge pull request #44 from Jmainguy/mysql_db_6860
...
adds error message if socket does not exist
10 years ago
Johannes Steger
34aa98a99c
Fix function identifier quoting
10 years ago
Toshio Kuratomi
fbb9dcc69a
Also catch mysql errors so we can give the error message back through json rather than tracebacking
10 years ago
Bruce Pennypacker
272bb1fa63
requested changes
10 years ago
Bruce Pennypacker
a07873d6a3
Added support for 'REQUIRE SSL' grant option
10 years ago
Michael J. Schultz
b894bc2b77
Build the db connection on `"postgres"` instead of `"template1"`
...
According to the postgresql docs[1], you should not have a connection with
`"template1"` when copying multiple databases.
[1]: http://www.postgresql.org/docs/9.1/static/manage-ag-templatedbs.html
10 years ago
Toshio Kuratomi
b0c94cd6f6
Merge pull request #281 from kustodian/postgresql_db_fix_for_python_24_checkmode
...
Fixed postgresql_db failing on Python 2.4 with --check
10 years ago
kustodian
07b98c45df
Fixed postgresql_db failing on Python 2.4 with --check
...
This reverts commit 81cbdb6c8c
and adds ignoring of the SystemExit exception because of Python 2.4.
10 years ago
Petros Moisiadis
bd7c6dbd3a
mysql_user: Added missing privileges
...
Added missing privileges 'CREATE TABLESPACE' and 'PROXY' (see: http://dev.mysql.com/doc/refman/5.5/en/privileges-provided.html ).
10 years ago
Andrew Shults
8396c063a3
Strip white space to support multiline permissions in YAML
10 years ago
Toshio Kuratomi
e8edee4166
Fix typo
10 years ago
Toshio Kuratomi
b766390ae2
Add USAGE as a valid privilege
10 years ago
Toshio Kuratomi
5af4463823
Gixes to doc formatting
10 years ago
Toshio Kuratomi
dda6d89060
Fix typo so docs will build
10 years ago
Toshio Kuratomi
3a80b734e6
Escape % in db+table names before adding to a format string being passed into db.execute()
...
Fixes #416
10 years ago
Dan
084ccf5a64
Adds a login_unix_socket option to the postgresql_privs module.
10 years ago
Dan
3a3ff1f0e4
Adds a unix_socket/login_unix_socket option to the postgresql_user module.
10 years ago
Dan
bf36697a55
Adds a login_unix_socket option to the postgresql_db module.
10 years ago
Toshio Kuratomi
1cab307649
Fix module traceback instead of returning an error
10 years ago
Toshio Kuratomi
2a794fa776
Fix for single role_attr
10 years ago
Toshio Kuratomi
7dd2859f9b
Add a bare grant to the list of allowed privileges
10 years ago
Devin Christensen
06f1c1a97e
Fix user_alter in postgresql_user
10 years ago
Devin Christensen
c77ab67274
Fix user_add in postgresql_user
10 years ago
Devin Christensen
4a3d7473fd
Fix syntax error
10 years ago
Toshio Kuratomi
10ebcccedb
Escape mysql identifiers
10 years ago
Toshio Kuratomi
06ac459fc5
Correct new function name
10 years ago
Toshio Kuratomi
c84ae54294
Normalize privs and flags to uppercase so comparisons against allowed names will work
10 years ago
Toshio Kuratomi
fbc4ed7a88
Make sure we quote or confirm good all user provided identifiers
10 years ago
Toshio Kuratomi
51910a1a33
Audit escaping of identifiers in the postgresql_user module
10 years ago
Toshio Kuratomi
1b0afb137c
More robust quoting of database identifiers
...
Note: These aren't database values, those are already using the
appropriate Pyhton DB API method for quoting.
10 years ago
Jonathan Mainguy
16b251d743
adds error message if socket does not exist
10 years ago
kustodian
81cbdb6c8c
Fixed postgresql_db failing on Python 2.4 with --check
10 years ago
Michael DeHaan
3ed1378067
Some more module categorization.
10 years ago
Michael DeHaan
385a037cd6
package files
10 years ago
Michael DeHaan
c8e1a2077e
file extensions!
10 years ago
Michael DeHaan
417309a626
Restructuring.
10 years ago
Michael DeHaan
73123b69fa
Move modules into subdirectory.
10 years ago
James Martin
49a5619cc0
Prevents module from failing with "_mysql_exceptions.Warning: Sending passwords in plain text without SSL/TLS is extremely insecure." When not using SSL/TLS.
10 years ago
Michael DeHaan
677709803c
Merge pull request #8419 from georgeOsdDev/escape_underscore_in_database_name
...
mysql_db module: Escape "_" in database name for "SHOW DATABASES" statement
10 years ago
Michael DeHaan
185d5a6221
Merge branch 'spelling' of git://github.com/cgar/ansible into devel
...
Conflicts:
docsite/rst/guide_rax.rst
plugins/callbacks/mail.py
10 years ago
Takeharu Oshida
b42ff30505
Escape "_" in database name for "SHOW DATABASES" statement
10 years ago
Wayne Rosario
7cfef577a1
Adding the following Test Coverage:
...
Use mysql_user module to create, delete users.
Update user password and ensure new password was updated for the correct user.
Assert user has access to multiple databases
Assert user creation, deleting using different user privilege and ensure privilege work correctly.
10 years ago
Wayne Rosario
45d7e53da9
updating doc to include revoke example for mysql_user docs
10 years ago
Jonathan Mainguy
3da1e5ce62
This fixes 8173, if target was not defined it would break, now it wont
10 years ago
James Cammarata
93d862f3f5
Expand target for mysql_db
...
Fixes #8128
10 years ago
Jonathan Mainguy
2b84ec6b4a
Errors out with stderr 1049, unknown database: when importing a database that does not exist
10 years ago
James Cammarata
a8368e4dc4
Merge pull request #8092 from ghjm/mysql-exceptions
...
Added exception handling to database creation and deletion. Fixes #8075 .
10 years ago
Graham Mainwaring
8e6e9a12e7
Switched primary and alias names of the name/db parameter, to match documentation. Fixes #8065 .
10 years ago
Graham Mainwaring
6e237bed7a
Added exception handling to database creation and deletion. Fixes #8075 .
10 years ago
Jonathan Mainguy
f4690464b4
Makes ansible fail if login_port is defined and login_host is either not defined, or defined as localhost. This is because if login_host is localhost then MySQLdb will use the socket instead of TCP. This leads to confusion for ansible users as, when a port is defined it gets ignored if login_host is localhost. This is to fix the bug reported by wrosario #8070 . Info on MysqlDb can be read here http://mysql-python.sourceforge.net/MySQLdb.html
11 years ago
James Cammarata
ae37758257
Merge pull request #6766 from Jmainguy/mysql_db_bug
...
mysql_db module now correctly fails on import if bz2 or gz fails.
11 years ago
Scott Brown
34d960ef20
BUGFIX 1178: Adding better existence check in one place. db_import now fails fast if target does not exist b/c no point going further without the target.
11 years ago
Scott Brown
1853a3f565
BUGFIX 7811: Adding file existence check when performing mysql import on a .gz or .bz2 file, otherwise Ansible will not notice that the underlying *nix command silently died.
11 years ago
James Cammarata
8d0d2831e6
Fixing mysql master replication boolean
...
Fixes #7528
11 years ago
Josef Špak
1dbc069bcb
Fix typo in CHANGE MASTER TO syntax
11 years ago
Mathieu Martin
9589ee2a41
Add example 'Specify grants composed of more than one word' to the mysql_user module.
11 years ago
Scott Sturdivant
40a6a6f911
Clarify that the encrypted param must also be set.
...
While the encrypted parameter's documentation clearly states that it needs to
be set, if you are focused on the password parameter's documentation, there's
nothing to draw your attention to the fact that encrypted may also need to be
set.
11 years ago
Adam Chainz
29b10ac698
Fix sync_binlog name in mysql_variables example
...
The previous sync_binary_log is not a real MySQL variable.
11 years ago
Carlos E. Garcia
4dcaa9d9fb
multiple spelling error changes
11 years ago
Cove Schneider
ae0721d3da
re-add idempotency check
11 years ago
Cove Schneider
428dead8cd
add replicaset support to mongodb_user module
11 years ago
Michael DeHaan
acd89f7a1f
Merge pull request #6796 from mistaka0s/mysqldump_fix
...
Remove extra quote from the mysqldump password argument
11 years ago
Matt Martz
a4078a4bf8
Use /usr/bin/python instead of /usr/bin/env python
11 years ago
Chao Luan
749e749c11
Remove extra quote from the mysqldump password argument
...
The mysqldb Ansible module will fail if the state specified is import or dump with a '1045: Access Denied' mysql error for complex passwords.
This is caused by the extra quote around the '--password' argument to mysqldump, as pipes.quotes already quotes the password string.
>>> "--password='%s'" % pipes.quote('simple')
"--password='simple'"
>>> "--password='%s'" % pipes.quote('c0mplexp@ssword!')
"--password=''c0mplexp@ssword!''"
>>> "--password='%s'" % pipes.quote('password with space')
"--password=''password with space''"
11 years ago
Jonathan Mainguy
17fa8e3c84
Added mpdehaan suggestion to use os.path.splitext. Wise suggestion, does look clearner
11 years ago
Jonathan Mainguy
f0b2616bd8
mysql_db module now correctly fails on import if bz2 or gz fails.
11 years ago
Michael DeHaan
ff5560f00c
Update comments about redis config.
11 years ago
Michael DeHaan
fbb15ad52f
Merge branch 'devel' of git://github.com/mleventi/ansible into devel
11 years ago
Michael DeHaan
d10b3f9257
Merge pull request #5597 from laggyluke/mongodb_user_idempotence
...
Fix idempotence in mongodb_user module
11 years ago
Cristian Ciupitu
7f681c33a2
Micro-optimization: replace s.find(x)!=-1 with x in s
...
timeit shows a speedup of ~3x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
11 years ago
Richard Isaacson
35b4cf001c
Merge pull request #6461 from risaacson/modules_make_run_command_safer
...
Modules make run command safer
11 years ago
Richard C Isaacson
122917019c
mysql_db module: typo fix
...
Tests clean.
11 years ago
Richard C Isaacson
d9da5cf084
Shell updates.
11 years ago
James Martin
0a74cb484c
Fixes various typos introduced in a9017af2bb
.
...
Fixes odd encoding problem with wait_for_service.
11 years ago
Michael DeHaan
980653f20b
More shell fixes
11 years ago
James Cammarata
72217c297d
Adding validate_certs to all modules that use fetch_url
11 years ago
Richard C Isaacson
525e811d9b
Bulk update of choices=BOOLEANS to type='bool'
11 years ago
James Cammarata
b77ea4ed91
Merge pull request #4630 from mmoya/mysql_variables-fix2
...
Add support for string values
11 years ago
James Cammarata
a1b1182662
Validate SSL certs accessed through urllib*
...
* Adds another module utility file which generalizes the
access of urls via the urllib* libraries.
* Adds a new spec generator for common arguments.
* Makes the user-agent string configurable.
Fixes #6211
11 years ago
Michael DeHaan
8e9f058214
Merge pull request #6305 from amree/fix-mysql-replication-port
...
Fixed SQL syntax error when running mysql_replication module
11 years ago
Jimena Cabrera-Notari
86e7555554
Don't use keyword `error` in encode
...
This is not supported in Python 2.6. Just use positional arguments.
11 years ago
amree
59f954b349
MASTER_PORT variable for CHANGE MASTER TO command can only accept integer value
11 years ago
Guido Kollerie
314e621671
Emphasize target is on remote host. List supported file types.
...
From the documentation it is not immediately clear that the 'target'
option refers to a location on the remote host. This change emphasizes that.
In addition to .sql files, .bz2 and .gz files are supported for dumps and
restores. This is now documented.
11 years ago
Kyle Kelley
70d8be5cc2
Fix expires
11 years ago
James Martin
e312b0e5bf
Properly fetching the riak version, and properly setting the python interpreter.
11 years ago
James Cammarata
c85b7d868b
Merge branch 'fix-postgres_user_to_understand_pg_namespaces' of https://github.com/alanfairless/ansible into alanfairless-fix-postgres_user_to_understand_pg_namespaces
11 years ago
James Cammarata
a570280b81
Merge branch 'postgres_alter_role' of https://github.com/jinnko/ansible into jinnko-postgres_alter_role
...
Conflicts:
library/database/postgresql_user
11 years ago
Maykel Moya
5da6fcae4d
Add support for string values
...
The SET GLOBAL statement requires properly quoting of values. For example, the
following correct queries will fail if quotes are toggled:
mysql> SET GLOBAL innodb_lru_scan_depth = 2000;
mysql> SET GLOBAL master_info_repository = "TABLE";
`mysql_variable` module doesn't quote the value argument, therefore
string values will fail.
# this task will pass, 2000 is passed without quotes
- name: set a numeric value
mysql_variable: variable=innodb_lru_scan_depth value=2000
# this task will fail, TABLE is passed without quotes
- name: set a string value
mysql_variable: variable=master_info_repository value=TABLE
With this patch prepared statements are used. Proper quoting will be
done automatically based on the type of the variables thus an attempt
to convert to int, then to float is done in first place.
Booleans values, ie: ON, OFF, are not specially handled because they
can be quoted. For example, the following queries are correct and
equivalent, they all set _innodb_file_per_table_ to logical _True_:
mysql> SET GLOBAL innodb_file_per_table = "ON";
mysql> SET GLOBAL innodb_file_per_table = ON;
mysql> SET GLOBAL innodb_file_per_table = 1;
Tested in mysql 5.5 and 5.6.
11 years ago
Arturs Vonda
df853fa92e
Added port documentation to postgresql_db and postgresql_user
11 years ago
George Miroshnykov
58e34edce3
Add idempotency to mongodb_user module
11 years ago