Commit Graph

249 Commits (d55a4d59dc02b65fbeffb7f7c977521514395f65)

Author SHA1 Message Date
Sam Yaple 54804d25e3 Actually remove the section we are replacing 9 years ago
Sam Yaple dddb5270c8 Refix bug 1226 after revert
This patch properly fixes bug 1226 without introducing a breaking
change to idempotency which was introduced in PR #1358

We can properly assign permissions to databases with a '.' in the name
of the database as well as assign priviliges to all databases as
specified with '*'
9 years ago
Sam Yaple 2c35cfce9a Revert "escapeds changes"
While this change doesn't break the creation, it does break
idempotency. This change will convert '*.*' to '`*`.*' which is
functionally the same, however when the user_mod() function looks up
the current privileges with privileges_get() it will read '*.*'

Since '*.*' != '`*`.*' it will go through the process of updating the
privleges always resulting in a 'changed' result.

This reverts commit db9ab9b262.
9 years ago
Sudheer Satyanarayana f3a0f0f580 Update mysql_db.py
Mention package installation instructions for CentOS in notes.
9 years ago
Brian Coca fa5a72f40e Merge pull request #570 from sysadmin75/mysql_user_parse_grant
Fix to revoke privileges for mysql user = ''
9 years ago
Brian Coca 769b81cae1 Merge pull request #1001 from ospii/devel
Validate variable, return only the found variable value instead of tuple
9 years ago
Guilherme Carlos e13e369aae Fix login_user on mysql_user
`login_username` was provided but `login_user` is the correct option
9 years ago
Will Thames 47cb92f74f Ensure TEMP privilege gets removed when expanding ALL.
ALL gets expanded to the list of VALID_PRIVS which includes
TEMPORARY and TEMP
The code that replaced TEMP with TEMPORARY didn't work with the
expansion
9 years ago
Will Thames 2a0f6c1cb3 Correct handling of empty role_attr_flags
role_attr_flags is the empty string by default, not None.
9 years ago
Brian Coca ab5b5e8819 corrected version added 9 years ago
Brian Coca 2b53b92dc2 Merge pull request #1539 from acaveroc/mysql_vars_port_definition
Mysql vars port definition
9 years ago
Matt Martz 5a254e6303 Replace tabbed indentation with spaces for mysql_db module 10 years ago
ToBeReplaced 5e82f7e11e Make ALL_IN_SCHEMA for tables affect views
ALL TABLES is considered to include views, so we must check for reltypes
'r' and 'v', not just 'r'. This bug was introduced due to using a
custom, backwards-compatible version of "ALL TABLES IN SCHEMA".
10 years ago
Bryan Fleming 3b4b065315 fixes #1120 - privileges using columns 10 years ago
acaveroc e7876df99f Add version_added and type of parameter 10 years ago
acaveroc 7d2a5965bd Assorted minor bug fixes
- Modified data type for port definition from string to integer
- Modified login_host default value for compatibilize with port definition according with MySQL Documentation (https://dev.mysql.com/doc/refman/5.0/en/connecting.html)
10 years ago
acaveroc 5b84b0d136 Add port definition support for mysql_vars module 10 years ago
Sergei Antipov 5465fb8d4f mysql_user | Hide password 10 years ago
Greg DeKoenigsberg 2a5f0bde87 Proper author info for all remaining modules 10 years ago
Louis-Michel Couture d60d493916 Update example to remove outdated information 10 years ago
Toshio Kuratomi c700993dd5 Fix a problem introduced with #1101 and optimize privilege handling
* If a db user belonged to a role which had a privilege, the user would
  not have the privilege added as the role gave the appearance that the
  user already had it.  Fixed to always check the privileges specific to
  the user.
* Make fewer db queries to determine if privileges need to be changed
  and change them (was four for each privilege.  Now two for each object
  that has a set of privileges changed).
10 years ago
Toshio Kuratomi 8c10cc20ec Expand tildes and vars in the config file path 10 years ago
Will Thames 167e7c2b81 Perform privilege grants/revokes only when required
Use `has_table_privileges` and `has_database_privileges`
to test whether a user already has a privilege before
granting it, or whether a user doesn't have  a privilege
before revoking it.
10 years ago
Toshio Kuratomi 30fc6f03d6 Allow playbook specified login_user and login_password to override config file settings 10 years ago
Toshio Kuratomi f8d8af17cd Use a list comprehension instead of map and lambda 10 years ago
Toshio Kuratomi 474b731bcc Merge pull request #1036 from shr3kst3r/strip_spaces
Strip spaces around MySQL privileges before comparing to valid privileges
10 years ago
Toshio Kuratomi 2b5e932cfb Fix for the new import code when password is empty 10 years ago
Brian Coca 7a6f532020 Merge pull request #1423 from ercpe/mysql_db-debugging
Improved output of mysql_db plugin
10 years ago
Jonathan Mainguy db9ab9b262 escapeds changes
fixed merge conflict

remove uneeded regexs

arrays
10 years ago
Robin Miller cda7a9be15 Replaced lambda functions with list comprehensions. 10 years ago
Robin Miller 74b7ce9dcf Only revoke actually granted permissions, not 'ALL'.
This prevents errors when the login_user does not have 'ALL'
permissions, and the 'priv' value contains fewer permissions than are
held by an existing user. This is particularly an issue when using an
Amazon Web Services RDS instance, as there is no (accessible) user with
'ALL' permissions on *.*.
10 years ago
Johann Schmitz 8892aa2bf4 Improved output of mysql_db plugin
Show error number and error description on connect error to ease debugging.
10 years ago
Toshio Kuratomi d74187438f Merge pull request #1417 from fdupoux/mysql-db-use-python-pipelines
Decompress mysql dumps on the fly using python subprocess …
10 years ago
fdupoux 380b122d5a Refactoring to avoid duplication of code which manages the decompression of database dumps in various formats 10 years ago
fdupoux f634c10636 Simplify code which prepares the decompression command 10 years ago
Toshio Kuratomi 32e609720a Refactor dump compression and use get_bin_path for finding the compressors 10 years ago
fdupoux 1e2ce363f7 Decompress mysql dumps on the fly using python subprocess during an import to simplify operation 10 years ago
Jonathan Mainguy 5a22f052b4 changes hostname to lowercase 10 years ago
Toshio Kuratomi 0c04a54f67 Merge pull request #1368 from ansible/postgresql-user-account-vs-role-fix
Fix a problem introduced with #1101 and optimize privilege handling
10 years ago
Toshio Kuratomi c9b17136e4 Fix a problem introduced with #1101 and optimize privilege handling
* If a db user belonged to a role which had a privilege, the user would
  not have the privilege added as the role gave the appearance that the
  user already had it.  Fixed to always check the privileges specific to
  the user.
* Make fewer db queries to determine if privileges need to be changed
  and change them (was four for each privilege.  Now two for each object
  that has a set of privileges changed).
10 years ago
Brian Coca b9dba50372 minor doc fix and made sure check_implicit_admin is true boolean 10 years ago
Toshio Kuratomi 7dd9f57e16 Fix splitting of role_attrs 10 years ago
fdupoux 51ffbda9a1 Add support for xz compression (for dump and import) in mysql_db module 10 years ago
Toshio Kuratomi ed6b95a0bb Merge pull request #45 from Jmainguy/mysql_db_alldatabases
Adds name=all which allows a user to dump or import all data...
10 years ago
Jonathan Mainguy f0af9b9ed5 Adds all_databases option which allows a user to dump or import all databases at once, identical to mysqldump --all-databases
fix line 132

Update to name=all

cleaned up all_database per abadger's suggestions
10 years ago
Toshio Kuratomi 8b4e201772 Expand tildes and vars in the config file path 10 years ago
Brian Coca 35703caf6f Merge pull request #1101 from willthames/postgresql_reduce_alter_role
Update postgresql users only when necessary
10 years ago
Pascal Borreli f29a6ec54d Fixed typos 10 years ago
Toshio Kuratomi 58c8696fc5 Allow playbook specified login_user and login_password to override config file settings 10 years ago
Julia Kreger 35bcd6a965 Set default for mysql_user config_file
The default value set by the module was a value of None for the
config_file parameter, which propogates into the connect method
call overriding the stated default in the method.

Instead, the default should be set with-in the parameter
specification so the file check is not requested to check None.
10 years ago