Commit Graph

4632 Commits (d4a78dc951fc4a524d530e30e6b64b23b8e077a3)

Author SHA1 Message Date
Sébastien Gross 48128ec0ab [mount] make sure fstab exists
This is mainly to prevent from failing with no such file or directory
during module execution.
10 years ago
Sébastien Gross f2e2337d07 [mount] Add documentation for fstab option 10 years ago
James Cammarata 84759faa09 Security fixes:
* Strip lookup calls out of inventory variables and clean unsafe data
  returned from lookup plugins (CVE-2014-4966)
* Make sure vars don't insert extra parameters into module args and prevent
  duplicate params from superseding previous params (CVE-2014-4967)
10 years ago
Michael DeHaan 2769b3d0b2 Update version_added attribute on recent GCE module additions. 10 years ago
Michael DeHaan 98c6688343 Merge pull request #6976 from clconway/gce-snapshots
Adds support for snapshots and extra persistent disks to the gce modules
10 years ago
Hector Acosta ec70bb01ef Add check_mode support to authorized_key. Fixes #7300
Signed-off-by: Hector Acosta <hector.acosta@gmail.com>
10 years ago
Lee Gillentine 69337362e7 Adding another example to demonstrate unarchive working entirely on a remote machine 10 years ago
Michael DeHaan 9caa93c1cf Add note about useful quote filter. 10 years ago
Jonathan Mainguy 6789098bc5 This fixes 8173, if target was not defined it would break, now it wont 10 years ago
Will Angenent 0e33db837a Fix for issue #8152: Missing auth headers and a faulty JSON decode
Looks like this regressed in commit 9730157 due to fetch_url refactors.
10 years ago
Yasser Nabi 8a6bbfd3b5 Enable puppet facts
Currently facter facts omit facts that a distributed via Puppet. This
commit adds the `--puppet` option.

In cases where puppet is not installed, the command sends a warning to
STDERR *but* completes successfully. So should not cause any issues.

The benefit is, filtering can be done based on facts set by Puppet.
10 years ago
Jacob Hickey ea9af2cbb1 Add missing params to get_target_from_rule
get_target_from_rule was extracted from main() without enough parameters for
all the local variables it took with it from the extraction site.
10 years ago
Michael DeHaan 515d10fd88 Merge pull request #8172 from phenomenes/channel-key-parameter
Adds channel key parameter
10 years ago
Michael DeHaan 3aa10d9db5 Merge pull request #8145 from amandolo/ec2_tag
Fix EC2_TAG module output structure when listing tags
10 years ago
Jimena Cabrera-Notari 7efd8b61a6 Adds channel key parameter 10 years ago
Michael DeHaan 64b874129f Merge pull request #8139 from peterkh/devel
Fix "TypeError: group id must be integer" if groupid passed in for group key
10 years ago
Michael DeHaan ec874193fe Merge pull request #8143 from PinGwynn/feature
portage: default exit (not fail) if sync=yes in check mode
10 years ago
James Cammarata 68e59332c7 Merge branch 'patch-2' of https://github.com/napkindrawing/ansible into napkindrawing-patch-2 10 years ago
James Cammarata ac73822405 Expand target for mysql_db
Fixes #8128
10 years ago
James Cammarata d7469218a5 Merge pull request #8126 from dingus9/patch-1
Update lineinfile validate help
10 years ago
James Cammarata 02a6d5224f Merge pull request #8124 from dataxu/dev-asg-set-health-checks
Added setting of the health_check options on an existing ASG
10 years ago
Michael DeHaan 616d749ab3 Merge pull request #8156 from jirutka/fix-layman
layman: remove my email address
10 years ago
James Cammarata 3492e8748e Merge pull request #8146 from rmarchei/8102
fix get_distribution_version() on amazon linux
10 years ago
James Cammarata 19571d3f23 Merge pull request #7914 from hacosta/devel
Correctly handle .repo files in zypper_repository module
10 years ago
Ruggero Marchei 8904c61932 fix LooseVersion exception with empty distribution_version 10 years ago
Jakub Jirutka 437dc0a9ef layman: remove my email address 10 years ago
Michael DeHaan ca918cd3dd Merge pull request #8118 from oxyrox/devel
Typo
10 years ago
Michael DeHaan ee179e1149 Merge pull request #8111 from hfinucane/gh-8108
Fix pip failure when version is parsed as a float
10 years ago
Michael DeHaan 8da853ec7a Slight typo fix. 10 years ago
Michael DeHaan 3d1865e6c9 Pagerduty has advocated not using ansible for certain sizes of infrastructure. This module is removed until this is corrected.
http://blog.pagerduty.com/2014/06/10-common-ops-mistakes/?utm_source=twitter&utm_medium=social&utm_campaign=blog
10 years ago
Michael DeHaan 8f97f8a5f1 Merge pull request #8107 from hfinucane/optional-rsync-compress
Make 'compress' optional
10 years ago
Michael DeHaan 50f51367f9 Merge pull request #8106 from muff1nman/pacman-update-checkmode-fix
Fix #8047
10 years ago
Maxim Odinintsev a587d13c65 portage: default exit (not fail) if sync=yes in check mode 10 years ago
Andrea Mandolo d346b76fb7 Fix EC2_TAG module output structure when listing tags 10 years ago
Peter Hall 09a5d8f6d1 Fix "TypeError: group id must be integer" if groupid passed in for group
key
10 years ago
Ruggero Marchei d6bca15aa5 fix issue #8102 10 years ago
James Cammarata eb80bd1a56 Break out of loop for sockets in wait_for when there's no data to read 10 years ago
napkindrawing fe74cb0ad0 New option for route53: retry_interval
The current (hard-coded) retry interval of 500 seconds can cause ansible to have excessive run-times in the case of many domains. `retry_interval` provides a way to customize the wait between retries of calls to route53.
10 years ago
James Cammarata d80f4cee9d Merge branch 'wait-for-port-search-regex' of https://github.com/sivel/ansible into sivel-wait-for-port-search-regex 10 years ago
Nick Shobe d1ebf7fcf1 Update lineinfile 10 years ago
James Cammarata 49d07ca4cc Adding a note about 'type' field becoming required in rax_dns_record 10 years ago
James Cammarata b2f09d3989 Merge branch 'rax-ptr' of https://github.com/sivel/ansible into sivel-rax-ptr 10 years ago
Matt Ferrante 66d3d75b35 Added setting of the health_check options on an existing ASG 10 years ago
James Cammarata d52b50cb03 Merge pull request #7478 from sivel/rax-keypair-filepath
rax_keypair module: Allow public_key to be a path to a file
10 years ago
James Cammarata 8753849959 Merge pull request #7477 from sivel/rax-user-data
rax module: Support config_drive and user_data
10 years ago
Aladin Jaermann 015a22ffba Correct typo 10 years ago
Henry Finucane dfd1470c22 Ensure version is a string 10 years ago
Henry Finucane 49889bd808 Make 'compress' optional 10 years ago
Andrew DeMaria 5fdd2a7b01 Fix #8047
Ensure that json is returned when only updating the cache and in check mode
10 years ago
James Cammarata 8a6cfa1a23 Merge pull request #8103 from Jmainguy/mysql_db_6214
mysql_db: Fix error message for #6214
10 years ago
James Cammarata fe3f6b3253 Merge pull request #8104 from AdmiralNemo/patch-1
Correct regex in is_keyid
10 years ago
James Cammarata aa08368b8f Merge pull request #8094 from ghjm/vsphere-fixes
Fixed tracebacks during VM creation. Fixes #8067.
10 years ago
Dustin C. Hatch dc304e6488 Correct regex in is_keyid
The `rpm_key` module claims to take a key ID as an argument, however it fails if one is actually given:

    msg: Not a valid key DEADBEEF

The reason for this is the regular expression in the `RpmKey.is_keyid` method is incorrect; it will only match the literal string "0-9a-f" exactly 8 times, rather than exactly 8 characters in the set 0-9 or a-f.
10 years ago
Jonathan Mainguy 40ef07a286 Errors out with stderr 1049, unknown database: when importing a database that does not exist 10 years ago
James Cammarata 5e0d07c93e Merge pull request #8092 from ghjm/mysql-exceptions
Added exception handling to database creation and deletion. Fixes #8075.
10 years ago
James Cammarata 9dc1931576 Merge pull request #8093 from ghjm/mysql-dbname
Switched primary and alias names of the name/db parameter. Fixes #8065.
10 years ago
Michael DeHaan fbdb10d8a5 Documentation simplification for git module parameter 10 years ago
Graham Mainwaring fb83bdffa8 Fixed tracebacks when datacenter not found, when notes not given, and when collecting facts after VM creation. Fixes #8067. 10 years ago
Graham Mainwaring 22390e50e5 Switched primary and alias names of the name/db parameter, to match documentation. Fixes #8065. 10 years ago
Graham Mainwaring 980d9da7e9 Added exception handling to database creation and deletion. Fixes #8075. 10 years ago
James Cammarata c96b2ae391 Merge pull request #8080 from ciupicri/service
Remove unused code
10 years ago
James Cammarata 4d86bbe6dc Merge pull request #8086 from dataxu/dev-fix-typo
Bug Fix - fixed the choices typo got the ec2_asg module
10 years ago
James Cammarata 3a6d00f81d Add note about changing resource_tags to required in ec2_vpc 10 years ago
James Cammarata 2184b15542 Merge branch 'psa-resource-tag-required' into devel 10 years ago
Matt Ferrante 03fc2714f1 fixed the choices typo got the ec2_asg module 10 years ago
James Cammarata 3e7d91723f Adding version_added for new vm_hw_version field in vpshere_guest 10 years ago
James Cammarata 87d1cdd035 Merge branch 'fix-7206' of https://github.com/hiciu/ansible into hiciu-fix-7206 10 years ago
Trond Hindenes d5a0c18170 Better result handling 10 years ago
James Cammarata dc89cc5f44 Merge pull request #8079 from Jmainguy/mysql_db_8070
Makes ansible fail if login_port is defined and login_host is either not...
10 years ago
Cristian Ciupitu 6a8bc42014 Remove useless code 10 years ago
Jonathan Mainguy 90f7f82224 Makes ansible fail if login_port is defined and login_host is either not defined, or defined as localhost. This is because if login_host is localhost then MySQLdb will use the socket instead of TCP. This leads to confusion for ansible users as, when a port is defined it gets ignored if login_host is localhost. This is to fix the bug reported by wrosario #8070. Info on MysqlDb can be read here http://mysql-python.sourceforge.net/MySQLdb.html 10 years ago
James Cammarata 0798f3cda4 Merge branch 'issue_7848' of https://github.com/mpeters/ansible into mpeters-issue_7848 10 years ago
James Cammarata 26707568c7 Merge branch 'issue_7906' of https://github.com/mpeters/ansible into mpeters-issue_7906 10 years ago
James Cammarata aecd292f13 Merge branch 'resource-tag-required' of https://github.com/psa/ansible into psa-resource-tag-required 10 years ago
James Cammarata 06f72ca3b1 Merge branch 'bug/8057' of https://github.com/ericwb/ansible into ericwb-bug/8057 10 years ago
Trond Hindenes 3bf16805e1 improvements to win_feature 10 years ago
Andreas Fleig 30ad859fe0 ini_file: replace lambda with named function
Fixes #6876
10 years ago
James Cammarata 0da5996bb5 Merge pull request #8049 from ranjan/dev
Provision VM using virtual network.
10 years ago
Eric Brown cdedb0f817 Adds an option to specify the glance endpoint type
Some environments that utilize an SSL terminator with a self-signed
certificate can use the publicURL without getting certificate
verify errors.  This allows using the internalURL with in my case
is HTTP and not HTTPS.

Closes issue: #8057
10 years ago
James Cammarata 1f2a436bbf Merge pull request #8038 from caphrim007/correct-missing-msg-argument
Fix missing msg argument
10 years ago
James Cammarata ec16b18bab Merge pull request #8036 from sqs/remove-fragile-RDS-instance-type-validation
Remove validation of RDS DB instance type names because Amazon frequently adds new ones
10 years ago
James Cammarata 1f813ba128 Merge pull request #8022 from psa/vpc-gateway-peering
Fix for #7368 breaks peering connections. Unreak them.
10 years ago
Tim Rupp 4a871f496a Fix missing msg argument
The following patch adds a missing 'msg=' syntax. An exception is raised
in ansible if this block is reached during the execution of the module

    TypeError: fail_json() takes exactly 1 argument (2 given)

With the 'msg=' added, you get a more informative error. For example

    msg: No settings provided to update_domain().
10 years ago
Michael DeHaan 1a3a3af04c Merge pull request #8015 from cchurch/test_win_service
win_service module updates and tests
10 years ago
Quinn Slack 9190df2aa9 Remove validation of RDS DB instance type names because Amazon frequently adds new ones 10 years ago
Ranjan Kumar ac252ea731 Provision VM using virtual network. 10 years ago
Paul Armstrong 97b3e8c6e4 Fix for #7368 breaks peering connections. Unreak them. 10 years ago
James Cammarata 746f52c5aa Merge pull request #7896 from botify-labs/feature/add-instance-monitoring-to-ec2-lc
Adds support for Cloudwatch detailled monitoring in ec2_lc module.
10 years ago
James Cammarata 0ee28c1a0e Make sure subnets and route_tables are initialized before using
Fixes #7712
10 years ago
Chris Church efc07cf627 Return service name, display name, start mode and state from win_service module. 10 years ago
Paul Armstrong d5b6781482 Make resource_tags required and do whitespace cleanup 10 years ago
Michael Leer 891aa41001 add interfact documentation #7704 10 years ago
Jacopo 0a5cac5657 Fixed bug with environment path for homebrew_cask 10 years ago
Brian Coca e1d57d8876 now compares permissions correctly 10 years ago
Markus Amalthea Magnuson a44e322db4 Use correct parameter name in error message.
The parameter is called `cron_file` but the error message uses `file` which is confusing.
10 years ago
Hector Acosta f870120b3c Check at most 16 characters of the key. Fixes #7936
Signed-off-by: Hector Acosta <hector.acosta@gmail.com>
10 years ago
Hector Acosta d3268d05ec Correctly handle .repo files in zypper_repository module
Before the changes, removing a repository required a repo url. This shouldn't be required since zypper allows removing a repo based on its alias (mapped to name in this module).

The name variable was always required, which is misleading since repofiles provide their own alias. So a runtime check was added to avoid this confusion.

Additionaly, running this module on .repo files weren't idempotent. e.g

Before:
$ ./hacking/test-module -m library/packaging/zypper_repository -a "repo=http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo name=foo"
{"repo": "http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo", "state": "present", "changed": true}
$ ./hacking/test-module -m library/packaging/zypper_repository -a "repo=http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo name=foo"
{"msg": "Repository named 'devel_languages_python' already exists. Please use another alias.\n", "failed": true}

After:
$ ./hacking/test-module -m library/packaging/zypper_repository -a "repo=http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo"
{"repo": "http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo", "state": "present", "changed": true}
$ ./hacking/test-module -m library/packaging/zypper_repository -a "repo=http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo"
{"repo": "http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo", "state": "present", "changed": false}

Signed-off-by: Hector Acosta <hector.acosta@gmail.com>
10 years ago
James Cammarata 29434b06b8 Merge pull request #7942 from sidred10/devel
Fixed FreeBSD ports install issue
10 years ago
sid 08370b3caf Fixed FreeBSD ports install issue 10 years ago
Maxim Odinintsev 82c026387f Successfull exit if sync=yes and no package provided 10 years ago