Commit Graph

22409 Commits (d47de74adecc0e71f4b6ea0eb0cfef41fa4fc218)
 

Author SHA1 Message Date
Gugli a00c078912 Add support for repos with svn:externals files
When a SVN repository has some svn:externals properties, files will be
reported with the X attribute, and lines will be added at the end to
list externals statuses with a text looking like
"Performing status on external item at ....".
Such lines were counted as a local modification by the regex, and the
module returned a change, even though they were none.

To have a clean (and parsable) "svn status" output, it is recommended
to use the --quiet option. The externals will only appear if they have
been modified. With this option on, it seems even safer to consider
there are local modifications when "svn status" outputs anything.
8 years ago
Raghu Udiyar e6e8f65e92 Creating ami should be idempotent
If the ami already exists, return details of the duplicate
ami instead of failing with an error.
8 years ago
tedder dd6d5f0cb5 feature pull request: catch and retry recoverable errors
boto can throw SSLError when timeouts occur (among other SSL errors). Catch these so proper JSON can be returned, and also add the ability to retry the operation.

There's an open issue in boto for this: https://github.com/boto/boto/issues/2409

Here's a sample stacktrace that inspired me to work on this. I'm on 1.7, but there's no meaningful differences in the 1.8 release that would affect this. I've added line breaks to the trace for readability.

    failed to parse: Traceback (most recent call last):
      File "/home/ubuntu/.ansible/tmp/ansible-tmp-1419895753.17-160808281985012/s3", line 2031, in <module> main()
      File "/home/ubuntu/.ansible/tmp/ansible-tmp-1419895753.17-160808281985012/s3", line 353, in main download_s3file(module, s3, bucket, obj, dest)
      File "/home/ubuntu/.ansible/tmp/ansible-tmp-1419895753.17-160808281985012/s3", line 234, in download_s3file key.get_contents_to_filename(dest)
      File "/usr/local/lib/python2.7/dist-packages/boto/s3/key.py", line 1665, in get_contents_to_filename response_headers=response_headers)
      File "/usr/local/lib/python2.7/dist-packages/boto/s3/key.py", line 1603, in get_contents_to_file response_headers=response_headers)
      File "/usr/local/lib/python2.7/dist-packages/boto/s3/key.py", line 1435, in get_file query_args=None)
      File "/usr/local/lib/python2.7/dist-packages/boto/s3/key.py", line 1488, in _get_file_internal for bytes in self:
      File "/usr/local/lib/python2.7/dist-packages/boto/s3/key.py", line 368, in next data = self.resp.read(self.BufferSize)
      File "/usr/local/lib/python2.7/dist-packages/boto/connection.py", line 416, in read return httplib.HTTPResponse.read(self, amt)
      File "/usr/lib/python2.7/httplib.py", line 567, in read s = self.fp.read(amt)
      File "/usr/lib/python2.7/socket.py", line 380, in read data = self._sock.recv(left)
      File "/usr/lib/python2.7/ssl.py", line 341, in recv return self.read(buflen)
      File "/usr/lib/python2.7/ssl.py", line 260, in read return self._sslobj.read(len) ssl.SSLError: The read operation timed out
8 years ago
Toshio Kuratomi fa60891f68 Fix a problem introduced with #1101 and optimize privilege handling
* If a db user belonged to a role which had a privilege, the user would
  not have the privilege added as the role gave the appearance that the
  user already had it.  Fixed to always check the privileges specific to
  the user.
* Make fewer db queries to determine if privileges need to be changed
  and change them (was four for each privilege.  Now two for each object
  that has a set of privileges changed).
8 years ago
Tristan Fisher 75ef963922 removes bool type from validate. 8 years ago
Tristan Fisher 0180be25c4 standardizes bools in argument_spec 8 years ago
jaypei fbc8d4ca4a use the right way to unescape line string Reference https://github.com/ansible/ansible/issues/10864 8 years ago
Feanil Patel 36dfb78831 Output the Internet Gatewoy id directly instead of in a dict. 8 years ago
Benno Joy 70188fe02a Fixes issue 1197 for s3 module, where the file gets downloaded even if checksums match 8 years ago
Feanil Patel bfb36f0f1f Tell me what the igw id is if we created an igw. 8 years ago
Toshio Kuratomi 5027fc0642 Expand tildes and vars in the config file path 8 years ago
Brian Coca d7bd36a215 Revert "Add deprecated documentation for _quantum_subnet" cause it was already added
This reverts commit 3fa32c4984.
8 years ago
Toshio Kuratomi 8576d1f9d1 Add deprecated documentation for _quantum_subnet 8 years ago
Will Thames 34e0e17090 Perform privilege grants/revokes only when required
Use `has_table_privileges` and `has_database_privileges`
to test whether a user already has a privilege before
granting it, or whether a user doesn't have  a privilege
before revoking it.
8 years ago
David Shrewsbury 67d8ff197e Rename os_subnet to os_subnet.py 8 years ago
Monty Taylor acdc90f31d Add OpenStack Subnet module
Also deprecated old quantum_subnet module
8 years ago
xiaclo 8715ce07ae Fix issue #1156
Fix as suggested in the issue.

https://github.com/ansible/ansible-modules-core/issues/1156
8 years ago
Toshio Kuratomi 4f42e752e6 Allow playbook specified login_user and login_password to override config file settings 8 years ago
James Cammarata 46b60a5b70 Fix missing expanduser on chdir value 8 years ago
James Cammarata d07378ceac Command module changes for v2 compatibility 8 years ago
Toshio Kuratomi 0af631499a Use a list comprehension instead of map and lambda 8 years ago
Toshio Kuratomi 8976b46888 Import ansible module_utils at bottom of file to not mess with line numbers in tracebacks 8 years ago
Toshio Kuratomi b6257f73b4 Properly flip default for verifying server cert. Add nice error messages when the cert is invalid 8 years ago
Toshio Kuratomi a4497a7ddf Change uri module to validate ssl certs by default 8 years ago
whiter 8ee2102993 Doc update to highlight use of body_type parameter 8 years ago
Toshio Kuratomi c291c2dfea Fix for the new import code when password is empty 8 years ago
Jonathan Mainguy a3f30540ca add :// url support for EL 5 8 years ago
Dennis Rowe 5109628693 Strip spaces around perms 8 years ago
billwanjohi a6fd78af37 s3 put: add support for server-side encryption
- added 'encrypt' boolean option
- reordered module options alphanumerically
8 years ago
Toshio Kuratomi b6a312e489 Minor fixups found during review of #582 8 years ago
Patrik Lundin 899788f1a7 service: Fix comments in OpenBsdService class.
No functional change.
8 years ago
Johann Schmitz 8f8109f1e0 Improved output of mysql_db plugin
Show error number and error description on connect error to ease debugging.
8 years ago
Andrew Pashkin a960caae96 Add 'docker_api_version' to docker_image
By default docker-py uses latest version of Docker API. This is not
always desireable, and this patch adds option to specify version, that
should be used.
8 years ago
Jonathan Mainguy 7ab2ddbe2a escapeds changes
fixed merge conflict

remove uneeded regexs

arrays
8 years ago
Brian Coca 322518d06c stat doc fix fixes #1371 8 years ago
Robin Miller a2f685a134 Replaced lambda functions with list comprehensions. 8 years ago
whiter d252e7c08f Fix for issue #1332 - when instance is has finished deleting and get_db_instance returns None, exit gracefully 8 years ago
Robin Miller 8859a7cf8e Only revoke actually granted permissions, not 'ALL'.
This prevents errors when the login_user does not have 'ALL'
permissions, and the 'priv' value contains fewer permissions than are
held by an existing user. This is particularly an issue when using an
Amazon Web Services RDS instance, as there is no (accessible) user with
'ALL' permissions on *.*.
8 years ago
Brian Coca 7ccc2143fd sleep when only doing a time delay to avoid cpu churn 8 years ago
fdupoux e34c7f31dc Refactoring to avoid duplication of code which manages the decompression of database dumps in various formats 8 years ago
fdupoux 9b83311471 Simplify code which prepares the decompression command 8 years ago
Toshio Kuratomi dd4838e4aa Refactor dump compression and use get_bin_path for finding the compressors 8 years ago
fdupoux aa79810cc8 Decompress mysql dumps on the fly using python subprocess during an import to simplify operation 8 years ago
Wang Qiang 86b6f39cf0 Do instance update after add tags to instance. 8 years ago
Jonathan Mainguy 20301427f8 fixes check mode for Ubuntu 14.04 8 years ago
James Cammarata 3e72a0657d Re-reverting windows modules PR #384 8 years ago
Vladislav Lewin 36ce019beb add SLE12 support to hostname.py 8 years ago
marko de813195c5 Added support for foreign security groups (Fixes: #373) 8 years ago
Jesse Keating 96b03ce138 Add an openstack servers actions module
This module supports a few of the server actions that are easy to
initially impiment. Other actions require input and provide return
values in the API calls that will be more difficult to impliment, and
thus are not part of this initial commit.
8 years ago
Vasyl Kaigorodov 70235a930b Fix "_is_package_installed() takes exactly 4 arguments, 3 provided" error 8 years ago