Brian Coca
e957150f77
Merge pull request #189 from jarmani/openbsd_rcctl
...
Openbsd rcctl
10 years ago
Toshio Kuratomi
4c50fbedf4
Merge pull request #632 from mscherer/fix_uneeded_echo
...
Do not use echo shell builtin for password
10 years ago
Michael Scherer
826d313aad
Do not use echo shell builtin for password
...
Using \t in a password may result in a different password
being set :
$ echo 'a\ta'
a a
Problem report originally found by Pilou-
( https://github.com/ansible/ansible-modules-extras/pull/198 )
10 years ago
Brian Coca
8c8be0e48c
Merge pull request #572 from jrobeson/rename-fedora-hostname-strategy
...
[hostname] rename FedoraStratgy to SystemdStrategy
10 years ago
Toshio Kuratomi
2973bac72f
Clarify documented behaviour of user module's ssh_key_file parameter
...
Fixes #9873
10 years ago
Johnny Robeson
50011f13d6
[hostname] rename FedoraStratgy to SystemdStrategy
10 years ago
Peter Oliver
18c429d016
Fix appending to a user's group on Solaris
...
Without this change, you get:
AttributeError: 'set' object has no attribute 'extend'
Tested on a Solaris 11.2 client with the included Python 2.6.8.
10 years ago
Toshio Kuratomi
443951ce82
Merge pull request #524 from zitterbacke/patch-1
...
re-enable AIX password setting
10 years ago
Toshio Kuratomi
67aeab9576
Merge pull request #512 from mscherer/fix_438
...
Revert commit cbc417c
, as the code is broken, see #438
10 years ago
Jonathan Mainguy
541070be4c
Fixed hostname for rhel5 python 2.4.3
10 years ago
zitterbacke
2e88582165
re-enable AIX password setting
...
the AIX class uses a unsafe shell for setting the user password (containing a pipe in the command). This patch adopts to the new behavior of module_utils/basic.py (since somewhere around 1.7).
besides it changes the qoutes for the echo command from double to single, because password-hashes contain $-signs and one would not have this variables expanded.
10 years ago
Michael Scherer
39cd64ec17
Revert commit cbc417c
, as the code is broken, see #438
...
LooseVersion expect a string, so filtering to return a int
is incorrect. Thanks to Jeremy Brown for the analysis.
10 years ago
Toshio Kuratomi
e1f90635af
Don't traceback if a gid is specified instead of a group name
...
Fixes https://github.com/ansible/ansible/issues/9796
10 years ago
Patrik Lundin
2acfbf016d
Handle string returned by 'default' correctly.
...
We need to handle the string returned by 'default' in the same way we handle
the string returned by 'status' since the resulting flags are compared later.
10 years ago
Brian Coca
ba139b145b
fixed hostname for gentoo
10 years ago
Brian Coca
aba9e5e4f9
vastly simplified systemd detection, made enable/disable errors clearer
...
both of which allows us to remove 'service name detection' as if systemd
is init we still use it to handle initscripts.
10 years ago
Brian Coca
df6d58614e
now actually adds usable name for systemd when service only has init
...
script
10 years ago
Toshio Kuratomi
5af4463823
Gixes to doc formatting
10 years ago
Toshio Kuratomi
799a75580a
Update cron example for setting to run twice a day
...
Fixes #415
10 years ago
Brian Coca
943f8fe7c9
Merge pull request #346 from bcoca/service_cleanup
...
service cleanup
10 years ago
Achilleas Pipinellis
a375ce33d3
Clarify supported init systems.
10 years ago
Pascal Borreli
32a00ec3a3
Fixed typo
10 years ago
Fabrice Bernhard
1ef8c26c0e
Typo in comments
...
Credit goes to @kbsali
@pborreli : you did not see that one? :-)
10 years ago
Brian Coca
29d211e7ab
service cleanup
10 years ago
Brian Coca
f49120598f
service now detects systemd is actually running, not just installed
10 years ago
Jonathan Mainguy
8b8008569f
fixes user module for rhel5 by using -n instead of -N, all other distros will still use -N
10 years ago
Robert Estelle
4dd099fe7a
Remove incorrect executable permissions.
10 years ago
Brian Coca
04680ce228
Merge pull request #286 from bcoca/hostname_24_compatible
...
made hostname work with python 2.4
10 years ago
Patrik Lundin
eea4d06848
Fix typo: Replace "N0" with "NO".
10 years ago
Brian Coca
83669d7eda
switched to iterator as per comments
10 years ago
Martijn P. Rijkeboer
5257222f33
Fix whitespace around '=' in sysctl.conf.
10 years ago
Brian Coca
e4b6968901
made hostname work with python 2.4
10 years ago
Toshio Kuratomi
7f611468a8
Fix for systemd service scripts with newlines
...
Fixes #127
10 years ago
Patrik Lundin
f9d9c1b6d7
Multiple fixes for OpenBSD rcctl handling.
...
* Use the newly added 'default' argument to know if the default flags are set
or not.
* Handle that 'status' may either return flags or YES/NO.
* Centralize flag handling logic.
* Set action variable after check if we need to keep going.
Big thanks to @ajacoutot for implementing the rcctl 'default' argument.
10 years ago
Patrik Lundin
e463400412
Simplify self.arguments logic.
...
Strange logic pointed out by @jarmani, thanks!
10 years ago
Patrik Lundin
924cf20cf8
Depend more on rcctl if it is present.
...
* Make the module support enable/disable of special services like pf via rcctl.
Idea and method from @jarmani.
* Make the module handle when the user supplied 'arguments' variable does not
match the current flags in rc.conf.local.
* Update description now that the code tries to use rcctl for everything if it
is available.
10 years ago
Patrik Lundin
5f37624eb4
Tweak error checking for "enabled" code.
...
Based on input from @jarmani:
* A return value of 2 now means a service does not exist. Instead of
trying to handle the different meanings of rc after running "status",
just look at stderr to know if something failed.
* Skip looking at stdout to make the code cleaner. Any errors should
turn up on stderr.
10 years ago
Patrik Lundin
c6dd88c1d1
Fail if "rcctl status" writes to stderr.
10 years ago
Patrik Lundin
1a8cdb5e3e
Check rc and print error message if any.
...
It is probably good to use stdout before printing a generic error
message as well.
10 years ago
Patrik Lundin
c46e030100
Make "enabled" code aware of --check mode.
10 years ago
Jonathan Armani
1b97390765
Add enable / disable of services for OpenBSD if rcctl is present
10 years ago
Michael DeHaan
385a037cd6
package files
10 years ago
Michael DeHaan
c8e1a2077e
file extensions!
10 years ago
Michael DeHaan
417309a626
Restructuring.
10 years ago
Michael DeHaan
73123b69fa
Move modules into subdirectory.
10 years ago
Toshio Kuratomi
8b81062be0
The fix for gh-7284 causes problems for initscripts which have the
...
standards compliant return codes but return a verbose error message via
stdout. Limit the times when we invoke the heuristic to attempt to work
around this.
10 years ago
Michael Scherer
c9a0a7ae4b
Fix #9704 , correctly set changed as false when nothing is done
10 years ago
Toshio Kuratomi
7b100dd389
Be more specific in checking if a job restarted successfully.
...
Fixes : #9056
10 years ago
Toshio Kuratomi
36083c3b90
Failure to enable a service now fails the task
...
Fixes: 8855
10 years ago
Toshio Kuratomi
a50258d26a
remove debugging that was causing failure
10 years ago