Commit Graph

25517 Commits (d30e466103d84af7ce8782b5a7737d7ee4a247bd)
 

Author SHA1 Message Date
Dustin C. Hatch 90df50b045 packaging/os/portage: Handle noreplace in check mode
The `--noreplace` argument to `emerge` is generally coupled with
`--newuse` or `--changed-use`, and can be used instruct Portage to
rebuild a package only if necessary. Simply checking to see if the
package is already installed using `equery` is not sufficient to
determine if any changes would be made, so that step is skipped when
the `noreplace` module argument is specified. The module then falls back
to parsing the output from `emerge` to determine if anything changed. In
check mode, `emerge` is called with `--pretend`, so it produces
different output, and the parsing fails to correctly infer that a change
would be made.

This commit adds another regular expression to check when running in
check mode that matches the pretend output from `emerge`.

Signed-off-by: Dustin C. Hatch <dustin@hatch.name>
8 years ago
Dustin C. Hatch c514a9a940 packaging/os/portage: Improve check mode handling
When running in check mode, the *portage* module always reports that no
changes were made, even if the requested packages do not exist on the
system. This is because it was erroneously expecting `emerge --pretend`
to produce the same output as `emerge` by itself would, and attempts to
parse it. This is not correct, for several reasons. Most specifically,
the string for which it is searching does not exist in the pretend
output. Additionally, `emerge --pretend` always prints the requested
packages, whether they are already installed or not; in the former case,
it shows them as reinstalls.

This commit adjusts the behavior to rely on `equery` alone when running
in check mode. If `equery` reports at least one package is not
installed, then nothing else is done: the system will definitely be
changed.

Signed-off-by: Dustin C. Hatch <dustin@hatch.name>
8 years ago
Eike Frost 754df8ff20 add zabbix proxy support to zabbix_host 8 years ago
Brian Coca a4a17630cd forgot finally 2.4 syntax 8 years ago
Brian Coca bfa63e01e5 also fixed exceptions 8 years ago
Brian Coca 027aaed757 made sensu_check 2.4 friendly 8 years ago
Toshio Kuratomi 5afc244147 Modify a few more modules to not conditionalize urllib(2) import. 8 years ago
Toshio Kuratomi 16bd2c7357 be explicit about urllib import and remove conditional urllib(2) import
urllib and urllib2 have been in the python stdlib since at least
python-2.3.  There's no reason to conditionalize it.

Fixes https://github.com/ansible/ansible/issues/11322
8 years ago
Anders Ingemann 655fa27dc7 Add sensu_check module 8 years ago
Brian Coca c73d248ba6 monior docfixes added extensino to vsphere_copy so it actually installs 8 years ago
Amir Moulavi 4588a4f9ed Implementation of EC2 AMI copy between regions 8 years ago
Rene Moser ee2809d4f4 cloudstack: new module cs_facts 8 years ago
Dag Wieers 209ba9aed0 Spurious newline could corrupt payload
Due to a spurious newline we corrupted the payload. It depends on the order of the headers and if there were headers added by vSphere.

The Accept header was also not needed.
8 years ago
whiter cc47adbc03 New module - ec2_eni 8 years ago
Rob White 4ad6cc183a Updated documentation and added boto profile support. 8 years ago
Robert Estelle b180b97273 ec2_vpc_igw - Rename IGWException to AnsibleIGWException. 8 years ago
Robert Estelle 83d3ff2692 ec2_vpc_igw - Exit with fail_json when boto is unavailable. 8 years ago
Robert Estelle 9433c88aef Add ec2_vpc_igw module. 8 years ago
Will Thames bbc82baa58 Add GUIDELINES for AWS module development
Starting point for a reference when doing pull request reviews.
If something doesn't meet the guidelines we can point people
at them. If something is bad but is not mentioned in the
guidelines, we should add it here.
8 years ago
Siva Popuri ba389018bc Corrected the license text to match GPLv3 8 years ago
Siva Popuri 62d42f0163 Added clc ansible module for managing groups in centurylink cloud 8 years ago
Siva Popuri f50657aec0 Revert "ansible modules for centurylink cloud are added"
This reverts commit 11c953477c.
8 years ago
Siva Popuri a2248dd2d0 ansible modules for centurylink cloud are added 8 years ago
Gerrit Germis 47633753db added version_added: "2.0" to new parameters 8 years ago
Gerrit Germis c659f19e25 allow wait, wait_retries and wait_interval parameters for haproxy module. This allows the haproxy to wait for status "UP" when state=enabled and status "MAINT" when state=disabled 8 years ago
Billy Kimble c2ff48bfe1 added hall.com notification module 8 years ago
Brian Brazil 6b51454234 Add dpkg_selections module, that works with dpkg --get-selections and --set-selections.
This is mainly useful for setting packages to 'hold' to prevent them
from being automatically upgraded.
8 years ago
Brian Coca 6ababec09f minor doc update 8 years ago
Dag Wieers 9197b84236 New module to copy (push) files to a vCenter datastore 8 years ago
Dag Wieers 6dc8696e02 Another incompatibility with python 2.4 8 years ago
Dag Wieers 35d4b3530b Fix TravisCI failure on python 2.4 8 years ago
Kevin Carter 16cc3423a5 Fix the lxc container restart state
The lxc container restart state does not ensure that the container
is in fact started unless another config or command is passed into
the task. to fix this the module simply needs to have the function
call added ``self._container_startup()`` after the container is
put into a stopped state.

Signed-off By: Kevin Carter <kevin.carter@rackspace.com>
8 years ago
Franck Nijhof 5f84fc985d Small fix for boolean when boolean type was set via a variable (somehow changes the behaviour of Ansible because of YAML as it seems. Booleans then become represented as a string). 8 years ago
Franck Nijhof 631927c579 Renamed module from mac_defaults to osx_defaults so the naming is more up to par with existing modules (e.g. osx_say) 8 years ago
Franck Nijhof 13916e0e02 Added module for managing Apple Mac OSX user defaults 8 years ago
Greg DeKoenigsberg c65a612d1f Changes to author formatting, remove emails 8 years ago
Greg DeKoenigsberg f98648bf6f Adding the list of valid module reviewers 8 years ago
Greg DeKoenigsberg 313352c845 Add author data 8 years ago
Greg DeKoenigsberg 9e56cb6c0f Adding author info 8 years ago
whiter c9fb43a8e3 New module - ec2_eni_facts 8 years ago
Rene Moser a9449f951e cloudstack: fix clean_up arg to be boolean in cs_network 8 years ago
Rene Moser 614caead31 cloudstack: add new module cs_template 8 years ago
Brian Coca 50bf780709 fixed doc issues 8 years ago
Chris Long dab27eb089 Fixed descriptions to all be lists replaced enabled with autoconnect - refactored code to reflect update. removed ansible syslog entry. 8 years ago
Chris Long 2f9ad910af Updated as per bcoca's comments: removed 'default' in state: removed defunct action: removed reference to load_platform_subclass changed cname to conn_name 8 years ago
Chris Long 367b0e7dc8 Initial commit of nmcli: NetworkManager module. Currently supports: Create, modify, remove of - team, team-slave, bond, bond-slave, ethernet TODO: vlan, bridge, wireless related connections. 8 years ago
Alex Lo 6e27752cea Error message typo 8 years ago
Alex Lo 62390208e3 Fix boto library checking 8 years ago
Alex Lo 04f5a73bd1 There is no absent, only disabled 8 years ago
Alex Lo 66800925cd remove extraneous imports 8 years ago