4 Commits (d241794daa6d413e6447890e2a4f11e0d818cf0e)

Author	SHA1	Message	Date
Brian Coca	4ac0c23db6	added unsafe toggle to vars_prompt (#49219) ... * added unsafe toggle to vars_prompt fixes #47534	6 years ago
Sam Doran	96c2375692	Add setup roles for passlib and pexpect for use with pause and vars_prompt tests (#43613) ... * Add passlib to RHEL test instance This looks like the only tests instance that is missing this libary. It is needed for vars_prompt tests. * Create setup roles for pexect and passlib Switch to using aliases rather than installing directly in the test scripts	6 years ago
Matthias Fuchs	7871027c9d	Share the implementation of hashing for both vars_prompt and password_hash (#21215) ... * Share the implementation of hashing for both vars_prompt and password_hash. * vars_prompt with encrypt does not require passlib for the algorithms supported by crypt. * Additional checks ensure that there is always a result. This works around issues in the crypt.crypt python function that returns None for algorithms it does not know. Some modules (like user module) interprets None as no password at all, which is misleading. * The password_hash filter supports all parameters of passlib. This allows users to provide a rounds parameter, fixing #15326. * password_hash is not restricted to the subset provided by crypt.crypt, fixing one half of #17266. * Updated documentation fixes other half of #17266. * password_hash does not hard-code the salt-length, which fixes bcrypt in connection with passlib. bcrypt requires a salt with length 22, which fixes #25347 * Salts are only generated by ansible when using crypt.crypt. Otherwise passlib generates them. * Avoids deprecated functionality of passlib with newer library versions. * When no rounds are specified for sha256/sha256_crypt and sha512/sha512_crypt always uses the default values used by crypt, i.e. 5000 rounds. Before when installed passlibs' defaults were used. passlib changes its defaults with newer library versions, leading to non idempotent behavior. NOTE: This will lead to the recalculation of existing hashes generated with passlib and without a rounds parameter. Yet henceforth the hashes will remain the same. No matter the installed passlib version. Making these hashes idempotent. Fixes #15326 Fixes #17266 Fixes #25347 except bcrypt still uses 2a, instead of the suggested 2b. * random_salt is solely handled by encrypt.py. There is no _random_salt function there anymore. Also the test moved to test_encrypt.py. * Uses pytest.skip when passlib is not available, instead of a silent return. * More checks are executed when passlib is not available. * Moves tests that require passlib into their own test-function. * Uses the six library to reraise the exception. * Fixes integration test. When no rounds are provided the defaults of crypt are used. In that case the rounds are not part of the resulting MCF output.	6 years ago
Sam Doran	6d38167d49	Only template values in vars_prompt rather than all vars (#39304) ... * Only template values in vars_prompt rather than all vars This allows the use of variables in vars_prompt fields but allows variables entered in the prompt to affect play vars rather than throwing an undefined error. Only post validate if there was a vars_prompt * Add tests for vars_prompt	6 years ago