Commit Graph

49631 Commits (d1f86d715142cd46f2d103fd4986ed6686e5806e)
 

Author SHA1 Message Date
Christian Köberl 569f0cf808
azure_rm_rg_info: fix KeyError: 'ansible_facts' (#66729)
* azure_rm_rg_info: fix KeyError: 'ansible_facts'

Fix facts for using old azure_rm_resourcegroup_facts, closes #66727

* fix intendation
5 years ago
Sylvia van Os ff0576802f
Support changing fetch_url settings for Rendeck modules (#66357) 5 years ago
CWollinger 274a07e7c7
Add module ipwcli_dns.py to manage DNS records on Ericsson IPWorks (#67135)
* Create ipwcli_dns.py

* add newline at the end

* Update after review and support AAAA

* Update lib/ansible/modules/net_tools/ipwcli_dns.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* add integration tests and change param user to username

Co-authored-by: Felix Fontein <felix@fontein.de>
5 years ago
Lukas Bestle 31a6a37329
Add integration tests for the mas module (#67442)
* Add integration tests for the mas module

See https://github.com/ansible/ansible/pull/19768.

* Implement review feedback
5 years ago
Michael Heap a43f76cbf9
Add `mas` module for installing applications via the Mac App Store (#19768)
* Add `mas` module for installing applications via the Mac App Store

Currently, only the `install` command is available, and you must provide IDs
when installing applications.

* mas module: Update metadata

Brings the metadata in line with the current style.

* mas module: General refactor, support more states

- `check_mode` is now fully supported
- Support for states `absent` and `latest` (using `mas uninstall` and `mas upgrade`)
- Support for a list of apps to manage
- Remove return value as other packaging modules don’t support it either
- Return msg with details on the changes on success
- Code was refactored to be easier to read and maintain

* mas module: Add upgrade_all option

* mas module: Fix linting errors

* mas module: Implement review feedback

Co-authored-by: Lukas Bestle <account-github@lukasbestle.com>
5 years ago
Ronnie P. Thomas 807f4ea658
Don't send JOIN and PART commands if channel is not set (#62334)
Currently, the irc module is sending JOIN and PART commands even if the channel
key is not set in the irc module. This causes the module to send JOIN and PART
commands to the #None channel. This module can send PRIVMSGs to either a
channel or a list of nicks, so sending JOIN and PART doesn't make sense in
cases where channel is undefined. The same goes for the TOPIC command, which is
used to set a topic for channels.

This patch ensures that the JOIN, PART and TOPIC commands are only sent if the
channel is defined.
5 years ago
tottoto cc86748109
Fix url handling in lxd_container and lxd_profile module (#66097)
* Fix url handling in lxd_container module

* Fix url handling in lxd_profile module
5 years ago
koenw eaf879a7a7
Fix uptimerobot stacktrace on decode (#66244)
* Fix uptimerobot stacktrace on decode

`req.read()` always returns bytes whereas the json module expects
strings.

I don't know how this worked before.

* Use `module_utils._text.to_native` instead of decode
5 years ago
Daniel Sternig 11483921f2
Added additional error handling inside the hcloud.py inventory plugin… (#66381)
* Added additional error handling inside the hcloud.py inventory plugin. Otherwise, errors may happen, if the HCloud API is not able to correctly identify the server image.

* Corrected the previous commit to not check for None on variables that are always set. Additionally, used image.description if image.name was not set, instead of the previously added default string.
5 years ago
Cody Hill a753ff7cbf
Fix packet dynamic inventory "Slug" issue. (#63916)
* Fixed 'slug' bug in packet_net.py that was caused by a breaking change in the Packet API.

* Removed some debugging and comments I had left.

* Missed a spot!
5 years ago
Pilou 5aa60a5fa7
ovirt: don't ignore instance_cpus parameter (#64366) 5 years ago
Ilija Matoski e1a815381a
Thresholds need to be passed for the log alert type (#64851)
* Thresholds need to be passed for the log alert type

* removed whitespace from linting error
5 years ago
Vitaly Shestovskiy 95d4908987
Fix packet.net dynamic inventory projects limit. (#64889)
* Added parameters to list more than 10 projects per run

* Fix slug issue due to packet api change. Same as https://github.com/ansible/ansible/pull/63916
5 years ago
Mads Jensen f978b6c789
Use https for Ansible Slack icon. (#65625) 5 years ago
Emmanuel MICKIEWICZ 8647d0a873
Removing a cron file when the 'name' parameter is specified is now allowed (#57471). Added integration tests to validate new behavior. (#65640)
Also added user input validation to return a clear error when deleting an environment variables without specifying a name.
5 years ago
Phil fe6848badd
sefcontext: fix fatal failure for socket file type (#65690)
fix #65689
5 years ago
Timm Drevensek 9541377a20
Port keycloak to python3 (#66452) 5 years ago
bitchkat 6b017db05b
support rabbitmq 3.8.x in version check (#66855)
* support rabbitmq 3.8.x in version check

* Removed extraneous white space
5 years ago
Felix Fontein b1de5d43fc
openssh_keypair and openssl_privatekey: add regenerate option (#67038)
* Add regenerate option to openssh_keypair and openssl_privatekey.

* Add changelog.
5 years ago
Felix Fontein 55cb8c5388
docker_login: fix permissions for ~/.docker/config.json (#67353)
* Fix permissions for ~/.docker/config.json.

* Add changelog, remove debug output.
5 years ago
Lujeni 25181e1b70
mongodb_user: Ensure to close database connection (closes #59353) (#65665) 5 years ago
Jill R c9b38bd74e
ec2_snapshot and ec2_snapshot_info test suite (#65896)
* ec2_snapshot and ec2_snapshot_info test suite

* Add a fact to make tests easier to follow.
Test all return values, and add missing RETURN docs to module.
5 years ago
Na-Ne c2ad25020b
removed the multiline if condition as it seems unnecessary and also prevents the warning message (#66543)
* removed "this_dns_name" variable comparision with empty string.  #66537

* removed the imultiline if condition as it seems unnecessary.  #66537
5 years ago
Milan Ilic 717b7fee9f
Update redis module to support memory size units (#66975) 5 years ago
Pascal Stauffer 24ce97a49b
open_iscsi: Set default port as string (#67270) 5 years ago
Andrew Klychkov 59bcc9f739
Bugfix of 67377: postgresql_set converts value to uppercase if "mb" or "gb" or "tb" is in the value string (#67418)
* Bugfix of 67377: postgresql_set converts value to uppercase if "mb" or "gb" or "tb" is in the value string

* fix CI

* add changelog
5 years ago
Tomer Brisker a4f5c2e993
Post reports to newer Foreman API endpoint (#64955)
The `/api/v2/reports` endpoint has been deprecated a long time ago and should
no longer be used. This changes to callback to use the correct API
endpoint and paramerter.
5 years ago
XuLei Ren 435bd91d2e
Add new command ClearSessions (#65600)
* Add ClearSessions command to clear all active sessions.

* Delete trailing whitespaces
5 years ago
Prasad Katti f21ee7f685
cloudformation - use mutually_exclusive for on_create_failure and disable_rollback (#65629)
* cloudformation - use mutually_exclusive for on_create_failure and disable_rollback

* cloudformation - remove unit test test_disable_rollback_and_on_failure_defined
5 years ago
Nick Lopez be1459af0f
use proxy settings for Redfish requests (#65998) 5 years ago
Mark Chappell 9edcda7ef7
Refactor iam_role to bring down the complexity score (#66027)
* Simplify BotoCore- / Client- Error try/except loops where we don't need different behaviour

* Refactor IAM Role manipulation to reduce complexity scores

* Missing permissions

* Add retry decorator by default

* compare_attached_role_policies is dead code, remove it
5 years ago
sky-joker d0443909ff
Zabbix: add integration test for zabbix_user module (#66418)
* add integration test for zabbix_user module

* Fix syntax mistake

* remove unsupported languages ​​from integration test
5 years ago
Markus Fischbacher 98bc53d3cb
zabbix_action - allowing string for esc_period (#66841)
* allowing string for esc_period

* add changelog fragment

* Update zabbix_action.py

* remove now unneeded test
5 years ago
Andrej Svenke f98874e4f9
ec2_asg: max_instance_lifetime and respect wait on replace (#66863)
* ec2_asg: max_instance_lifetime and respect wait on replace

* ec2_asg: max_instance_lifetime integration tests

* ec2_asg: address review comments
5 years ago
Dusan Matejka d2f4d305ee
Zabbix host tags & macros integration tests + zbx server version increase (#66997)
* bumped zabbix integration tests to be run against current LTS 4.4

* macros and tags tests for zabbix host + naming changes due to switch to zabbix 4.4
5 years ago
Bill Dodd fe2a8cb145
do not loop through chassis in manage_indicator_led() (#66044) 5 years ago
akatch 936bd83614
Fix duplicate log entries (and add item support for failures) (#66098) 5 years ago
ihard ad2428c176
fix hashi_vault lookup generates warning at LDAP authenticate #52131 (#67251) 5 years ago
Mark Chappell c36f03b3e1
Add AWSRetry decorator to ec2_vpc_nacl (#67204)
* Add AWSRetry decorator to ec2_vpc_nacl

* Also add a decorator to ec2_vpc_nacl_info to catch things like API rate limit errors.

* add double-removal integration tests to make sure things don't get too slow

* Fixup retry usage for _info

* Simplify changed logic when modifying a NACL

* tweak error message
5 years ago
René Moser bcd145c111
vultr: Fix retry max delay param ignored (#67437)
* vultr: Fix retry max delay param not taken

* add changelog
5 years ago
Jim Ladd a5af649a73
foreman: ansible_ssh_host should consider ip, ipv4, ipv6 (#67401) 5 years ago
anshulbehl ffead3b1c0
migration data for checkpoint collection (#67194)
* migration data for checkpoint collection

* Adding files instead of dirs
5 years ago
Jake Jackson 23e81f9907
google migration data (#67327) 5 years ago
Kevin Breit 8f6bce9134
Migrate Meraki modules to collections (#66396)
* Add documentation for ansible-test with collections

* Declare Meraki modules moved to collection

I have moved the Meraki modules to a collection at Galaxy called `cisco.meraki`. If additional changes are needed for this declaration please let me know.

* Remove changes to collection and specify each module for BOTMETA

* Remove duplicate anchors maybe

* Remove anchor references
5 years ago
anshulbehl 2ab80a4388
migration data for fortios collection (#67193)
* migration data for fortios collection

* Adding all files to BOTMETA instead of dirs
5 years ago
Oliver Kastler 0760a7ec08
Fix for shared snapshot parameter (#60250)
* Fix for shared snapshot parameter

Fixing this bug:
`Unknown parameter in input: "IsShared", must be one of: DBInstanceIdentifier, DBSnapshotIdentifier, SnapshotType, Filters, MaxRecords, Marker, IncludeShared, IncludePublic, DbiResourceId`

* Updated documentation for shared snapshots

Tags can't get accessed for shared snapshots

* fixed indentation

* added test for shared snapshot

* fixed isPublic parameter to correct IncludePublic parameter

Co-authored-by: Oliver Kastler <oliver@realestate.co.nz>
5 years ago
Sam Doran 7ae34cef15
Fix role list regression (#67436)
Add the roles_path parent to the role_parser
object, so paths are passed to the list function

Add basic role list tests to prevent future regressions
5 years ago
Nirav Katarmal 5ea26b6e5a
Added nameAlias field (#67150)
* Added nameAlias field to all the supported ACI modules

* Changed nameAlias to name_alias

* Review changes
5 years ago
Adam Miller 98c1fc9d3a
add a testing section to collections dev guide (#67370)
Signed-off-by: Adam Miller <admiller@redhat.com>
5 years ago
Vasili 9b28f1f5d9
Fix incorrect "Could not match supplied host pattern" warning (#66764) (#67432) 5 years ago