Commit Graph

358 Commits (d07032fa5a9ceb49137af8b7ea90c41f4d53decd)

Author SHA1 Message Date
Jim Richardson bbfe11fc1e return True/False from remove_job_file()
revised fix for https://github.com/ansible/ansible/issues/4795
11 years ago
Jim Richardson bcc08564e7 fix for https://github.com/ansible/ansible/issues/4795
Incorrect changed result in cron module.
Report changed=False if no cron is removed:wq
11 years ago
Hiroaki Nakamura abed2c47fa Fix for RHEL6. 11 years ago
Michael DeHaan 3705f41992 Merge pull request #4754 from mscherer/fix_4648
Fix 4648, cron module is not working on solaris
11 years ago
Michael DeHaan d34a26e307 Undo an inadvertant revert from template changes so we still allow pythonic imports in module land. 11 years ago
Michael Scherer 9e7b02aaee make cron module work on solaris
Cron on solaris do not take the same
set of option than vixie cron on linux, and
among the biggest difference, root cannot set
the crontab of a user directly from a file. Thus the
use of su to run the crontab command. Fix issue #4648
11 years ago
Michael Scherer 506ce6a809 remove unused function 11 years ago
Scott Dunlop dbc1e20462 add "zle" as a supported ZFS compression type
ZFS supports "zle" compression, which compresses runs of null bytes efficiently.
11 years ago
James Tanner d154bf8781 Revert templating enhancements from 73dbab70 e6c28658 d409352c 9858b1f2 4587528b 9b1fe455 214b0b05 8d3db803 7f9504d1 5031104c 35cb9dc2 2bd8cb57 1e85c754 11 years ago
jctanner a1fcaf5c61 Merge pull request #4715 from mscherer/fix_4702
Fix #4702, make setup work on windows
11 years ago
Michael Scherer 3f0b3a71ca Fix #4702, make setup work on windows 11 years ago
James Cammarata 0e9184eefd Fixing authorized_keys module to make the key part detection better
Fixes #4677
Fixes #4657
Fixes #4599
11 years ago
Christian Berendt 2848cf34fc changing permissions of modules to 0644 11 years ago
Michael DeHaan 3badedc983 Merge pull request #4424 from localvoid/firewalld-rich_rules
Add support for Rich Rules in firewalld module
11 years ago
Michael DeHaan d0904ded84 Merge pull request #4600 from earchibald/devel
Added ['date_time']['tz_offset'] using %z to get the time offset rather ...
11 years ago
Michael DeHaan b725361bce Merge pull request #4560 from tronner/issue4461
Fix illegal set operation in FreeBSD section of user module.
11 years ago
Michael DeHaan 9858b1f2f3 Enable imports to work on a snippet based system, allowing for instance a library of common EC2 functions
to be reused between modules.  See library/system/service and library/system/ping for initial examples.  Can
work the old way to just import 'basic', or can import the new way to import multiple pieces of code from
module_utils/.
11 years ago
James Tanner 40574c1938 Fixes #4448 reloaded services should be started if not running 11 years ago
James Cammarata aa0577c211 Merge branch 'fix_autorized_keys' of https://github.com/mscherer/ansible into mscherer-fix_autorized_keys 11 years ago
James Cammarata b58b287fce Fixing up authorized_keys to accept comments with spaces 11 years ago
Michael Scherer 951a91723d make sure that options are quoted, as people can add a shell
script there with a comma that would produce invalid configuration
upon being wrote again
11 years ago
Michael Scherer 7672e9fef8 sort the option_key to have a constant predictable line 11 years ago
Michael Scherer 264945a1f7 adding a single comma at the end of the options list confuse the module
it start to duplicate line, because this create
a empty option in the list, and so the module add a new line along the previous
one. See

>>> ' a,b, '.strip().split(',')
['a', 'b', '']
11 years ago
Scott Sturdivant 4d24e2e29f If the output of rcvar isn't a key=value pair, ignore it. 11 years ago
Eugene Archibald 30eb5c7342 Fixed (broken) tab to (correct) spaces for indentation 11 years ago
Michael DeHaan 21d4400c96 Misc pep8 fixes 11 years ago
Michael DeHaan 75e0a1c6de Merge pull request #4592 from mscherer/fix_4586
setup module, replace ':' by '_' in interface name, fix #4586
11 years ago
Eugene Archibald 145c0b8be1 Added ['date_time']['tz_offset'] using %z to get the time offset rather than time zone. 11 years ago
Michael Scherer d5c290b513 fix logic in module host to add aliases even if none exist already, fix #4563
self._has_aliases is used to know if a alias already exist, but
the test we want is to know if we need to add a new alias, which
is stored in self.aliases
11 years ago
Michael Scherer fc211ac1a0 setup module, replace ':' by '_' in interface name, fix #4586 11 years ago
James Tanner 4f674ec522 Fixes #4554 Enumerate user homedir if not passed as an argument 11 years ago
Thomas Ronner aee68511e6 Fix illegal set operation in FreeBSD section of user module. 11 years ago
jctanner 7e8e186b3b Merge pull request #4517 from adfinis-sygroup/devel
Remove keys regardless of the options
11 years ago
James Tanner 23cbdba65e Fixes #4350 Create homedirectory if create=yes and directory is missing 11 years ago
Hiroaki Nakamura 54243dc8f5 Add support for Fedora, OpenSUSE and ArchLinux.
Tested under Fedora 19 and OpenSUSE 12.3. Not tested on ArchLinux.
11 years ago
Hiroaki Nakamura 8c5eb96de4 Do not use shortcut conditional operator which is not supported in Python 2.4. 11 years ago
James Cammarata 35284818a9 Handle ssh key files that may only have a type/key specified
If a specified key did not have a comment, it would be ignored as
an invalid key.

Fixes #4513
11 years ago
Stefan Heinemann af704562a9 Set the options of an authorized key comma separated
According to the sshd man page, no spaces are permitted between the
options of an authorized ssh key
11 years ago
Stefan Heinemann 346d46a94c Don't mind the options of a key when removing it
This allows to remove a key without knowing the options in the
authorized_key file
11 years ago
Michael DeHaan 6ff4806b90 Merge branch 'devel' of git://github.com/shirou/ansible into devel 11 years ago
Keith Buck 36a8312de6 Improve the formatting and content for the sysctl module's description. 11 years ago
James Cammarata 49130c688d Adding 'unique' option to authorized_key module and cleanup
A small refactoring of the authorized_key module to accomodate these
changes, plus fixing some things like not rewriting the file on every
new key. These changes bring the original feature for ssh options in-
line with the comments in #3798

Fixes #3785
11 years ago
David Minor ed7d3f92a0 Add ssh key options parameter to authorized_key module 11 years ago
James Tanner e3849f1be7 Fixes #4312 for older versions of usermod which do not have --append 11 years ago
Michael DeHaan 119b6d73dd Remove examples of module antipattern of setting the choices array for boolean types. 11 years ago
Boris Kaul 5a34e572f5 Add support for Rich Rules in firewalld module 11 years ago
Boris Kaul 194a7dab9f Fix timeout bug in firewalld module 11 years ago
James Tanner b7f229d390 Second attempt at preventing ipv6 route enumeration on EL4 machines 11 years ago
James Tanner 4b1600aae5 Revert "Do not enumerate ipv6 routes in CentOS 4"
This reverts commit 5186c408f7.
11 years ago
James Tanner 5186c408f7 Do not enumerate ipv6 routes in CentOS 4 11 years ago
Michael DeHaan 135f79f337 Add documentation about how passwords are generated. 11 years ago
James Cammarata a2ac5d6df2 Better detection/categorization of ipv4 secondaries/virtual IPs
Fixes #3916
Fixes #3478
11 years ago
Michael DeHaan c5672cf16e Merge pull request #4389 from MattTheRat/devel
addresses #4371 - adds -m to usermod commands
11 years ago
Matt Warren 74c412e249 addresses https://github.com/ansible/ansible/issues/4371 - adding -m to home directory modification 11 years ago
Michael DeHaan f6c3dce497 Merge pull request #4336 from orkaa/devel
Fixes service update-rc.d functionality on debian
11 years ago
Martijn Lina 4cd3b9d637 replace dashes in rc.conf keys (which are based on freebsd rc.d filenames) to underscores 11 years ago
Skylar Saveland b47add0f32 fixes 4365 - Mac with cisco vpn client, GenericBsdIfconfigNetwork get_default_interfaces fails with index out of range 11 years ago
Adam Miller 323e8d4a8c fixed firewalld get_service_enabled 11 years ago
Nace Oroz 672a0c04e4 Fixes service update-rc.d functionality on debian 11 years ago
cdigiovanni 7ff2b3befd Added support to disable and enable upstart jobs 11 years ago
Brian Harring f88fed2060 Enforce umask for cron module, so cron_file generated files are 0644.
Certain cron implementations get cranky if files in cron.* are group
writable.
11 years ago
Nils Pascal Illenseer 4ee6c6d5df Add option 'lz4' for compression 11 years ago
Cristobal Rosa 617f7bb0a0 Added an space between code and comments in order to follow the coding standars 11 years ago
Cristobal Rosa be279295b6 Added a new check to check whether an network interface is in promiscuous mode 11 years ago
James Cammarata 9dd2d1eb13 Merge pull request #4222 from lessmian/devel
Module lvol fails when decimal point is a colon
11 years ago
James Cammarata 301a00ccf5 Merge branch 'obsd-fix-release' of https://github.com/johanwiren/ansible into johanwiren-obsd-fix-release 11 years ago
James Cammarata 23417368df Fixing up some open_iscsi docs and CHANGELOG update 11 years ago
James Cammarata c98ed252fe Merge branch 'open_iscsi_bis' of https://github.com/sergevanginderachter/ansible into sergevanginderachter-open_iscsi_bis 11 years ago
Tomasz Lesniewski 385ffcdfb1 Module lvol fails when decimal point is a colon 11 years ago
Rene Moser ff84812047 host: minor doc style improvements 11 years ago
Tomasz Lesniewski e2815a56dc Module lvol fails when decimal point is a colon 11 years ago
Michael DeHaan 314e1aafc1 Merge pull request #4220 from dagwieers/setup-dmidecode-fix
Fix for commented dmidecode output
11 years ago
Dag Wieers 5bd7664fac Fix for commented dmidecode output
This patch fixes the problem that on some system dmidecode prints out warning information as commented text. For example:

    [user@system ~]# dmidecode -s system-manufacturer
    # SMBIOS implementations newer than version 2.6 are not
    # fully supported by this version of dmidecode.
    HP

So we remove all commented lines from the output.
11 years ago
Rene Moser 803b2b91a6 host: added another example 11 years ago
James Cammarata a6d62ef59b Minor pep8 cleanup 11 years ago
James Cammarata 4420379f59 Fixing some bugs found during testing in the host module 11 years ago
James Cammarata da0d50c383 Merge branch 'feature/host' of https://github.com/resmo/ansible into resmo-feature/host 11 years ago
James Cammarata a8fac7906d Merge branch 'devel' of https://github.com/drybjed/ansible into drybjed-devel 11 years ago
James Cammarata c31ece58fa Added version_added string to new modprobe module and CHANGELOG update 11 years ago
James Cammarata 4d7b5da25d Merge branch 'modprobe-module' of https://github.com/stygstra/ansible into stygstra-modprobe-module 11 years ago
James Cammarata d1f713938e Modified env fact gathering to use the native python method
Also updated CHANGELOG for this feature
11 years ago
James Cammarata 19343288df Merge branch 'env_facts' of https://github.com/bcoca/ansible into bcoca-env_facts 11 years ago
Maciej Delmanowski 551b93c547 Made re.search string shorter 11 years ago
Maciej Delmanowski 40b0471e95 Add Linux Container identification 11 years ago
Johan Wirén e9554e5da2 Fixed setup module to no longer break on OpenBSD release versions. 11 years ago
James Cammarata 4efdf0d49f More housekeeping
* Modified version_added strings in recent modules
* Added firewalld inclusion to the CHANGELOG
11 years ago
James Cammarata 8721ad2909 Moving firewalld module from net_infra to system 11 years ago
René Moser 0ba7acd205 host: code cleanup 11 years ago
James Cammarata c2e02fbd6b Minor tweak to service changed logic from the previous commit 11 years ago
James Cammarata f62093da56 Merge branch 'service-enable-fix' of https://github.com/gottwald/ansible into gottwald-service-enable-fix 11 years ago
Petr Svoboda 8d290e3394 Fix traceback in service module when svc_cmd is None (2nd fix)
When service module is used on unsupported Linux system where init
script is used directly, LinuxService.svc_cmd is None so .endswith()
fails.

This extends fix from e2f20db534 also
for state=restarted.

Fixes issue #3533
11 years ago
René Moser bcaab4236b host: updated version_added 11 years ago
Rene Moser 7f96dd832f added module host
Add or remove entries in /etc/hosts using tasks:
- host: ip=127.0.0.1 hostname=localhost aliases=foobar.com,localhost.foobar.com
- host: ip=127.0.0.1 hostname=localhost state=present
- host: ip=192.168.1.1 state=absent
- host: hostname=localhost state=absent
- host: ip=::1 hostname=localhost aliases=ip6-localhost,ip6-loopback
11 years ago
David Stygstra 58620ca477 Add Python 2.4 support to modprobe module 11 years ago
David Stygstra 27a08dc647 Module to manage kernel modules 11 years ago
James Cammarata f4c5f37ca6 Merge branch 'issue_3417_systemd_stuff' into devel 11 years ago
James Cammarata 02033f9ec8 Merge branch 'archlinux-fact' of https://github.com/Schnouki/ansible into Schnouki-archlinux-fact 11 years ago
r-p-e 2f887c6dca Add some more OpenBSD facts
added:
 * ansible_distribution
 * ansible_distribution_release
 * ansible_distribution_version
11 years ago
Ingo Gottwald f7adbf2f29 Bugfix service module: Only change service state when needed 11 years ago
Thomas Jost dfb10e646e Add Archlinux "distribution" fact 11 years ago
James Cammarata 72eaa0570e Allow service module to manage services not ending in .service
Fixes #3417
11 years ago
James Cammarata 5110b2d440 Slight refactorization of the sysctl module
* Added in support for freebsd-style sysctl commands
* Replaced some functionality that was provided by module_common
* Simplified some logic in a couple of places (ie, not checking
  a split with len() but instead limiting the split to 1)

Fixes #3380
11 years ago
James Cammarata 3e9b63febd Compare exploded values in the sysctl module to avoid whitespace errors
Fixes #3931
11 years ago
James Cammarata b2741f451e Fixes to the service module for Ubuntu 12.04 (LTS)
Fixes #3615
Fixes #3572
11 years ago
James Cammarata 9a3a3e648b Check for systemd ownership of a service even if an init.d script exists
Also slight modification to the error message in the earlier commit that
modified the update-rc.d detection portion of the code

Fixes #3474
11 years ago
James Cammarata 7c8aa669cf Minor fix to account for template service names in systemctl 11 years ago
James Cammarata 6c3af4df81 Fix for update-rc.d based systems that also have systemd installed
By default, the service module had assumed that if the system had the
update-rc.d binary, the service was either managed via upstart or standard
sysV init-style scripts. This patch adds a check for systemctl ahead
of the other methods when update-rc.d is detected, and also simplifies
the logic around the detection of systemctl-managed services
11 years ago
James Laska 546788a1b6 The required package for selinux is libselinux-python 11 years ago
Brian Coca c2d1607490 Added collection of user's env
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
James Cammarata 82e1722fff Merge branch 'aix_wpar_facts' of https://github.com/mplonka/ansible into mplonka-aix_wpar_facts 11 years ago
James Cammarata 26a8d4ce9f Added 'reloaded' state to list of states checked for bounced services
Fixes #3556
11 years ago
Serge van Ginderachter a351c25c59 Introduce open-iscsi module to manage targets on the initiator. 11 years ago
Raul Melo 461858e476 Fix issue 3908. There was some ilegal operations over the sets 11 years ago
James Cammarata ceddc37f07 Fix for the cron module on FreeBSD
Apparently crontab on freebsd does not like the file path coming before
the "-u username" portion of the command to install the crontab
11 years ago
Hiroaki Nakamura a0da0afe00 Fix a bug in DebianStrategy.get_permanent_hostname(). Use strip, not split! 11 years ago
Hiroaki Nakamura 4f91238e34 Rewrite with "try ... finally" instead of "with" statement to support Python 2.4. 11 years ago
Hiroaki Nakamura 3b1d7d88b5 Remove extra sysloggings. 11 years ago
Hiroaki Nakamura f4ba0e78a4 Raise an error on unsupported platform/distributions. 11 years ago
Hiroaki Nakamura ce2b37e2ff Add a hostname module, which sets system's hostname. 11 years ago
Marcin Płonka 61298e4703 Skipping facts not available on AIX WPARs 11 years ago
shirou e18ede85a0 supports nested values of ohai. 11 years ago
Michael DeHaan 5e049a5df7 Merge branch 'fix_service_with_initscript' of git://github.com/psvo/ansible into devel 11 years ago
Andy Wilson bc30203abe docfix: grammar in docstring for sysctl module 11 years ago
Petr Svoboda e2f20db534 Fix traceback in service module when svc_cmd is None
When service module is used on unsupported Linux system where init
script is used directly, LinuxService.svc_cmd is None so .endswith()
fails.

Fixes issue #3533
11 years ago
Michael Scherer cfa5a0f94d Add urpmi as a package manager for mandriva-based distribution 11 years ago
James Cammarata e32a6110af Removing skipped=True so the task is just marked as not-changed 11 years ago
James Cammarata d98ad7b374 Set result to skipped when vol group is missing and lv state=absent
Fixes issue #3714 - lvol module state=absent fails (with error) if
the volume group doesn't exist
11 years ago
rishid 07ef8c4d84 Verify groups string is not empty before trying add user to groups 11 years ago
Brian Coca 0ae7bcf3e2 fixed bug from prev update
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Brian Coca 1e1f117886 whitespace updates on new lines
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Brian Coca d8e8aa714e now uses get_bin_path for lvg executables
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Michael DeHaan 8cc13590b4 Make exceptions handling python 2.4 compatible. 11 years ago
Michael DeHaan fc9aa5f014 Continue on mount errors, don't fail the setup module. 11 years ago
Brian Coca 3f85a82ae9 use global to fail as its not in self
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Michael DeHaan 1acd9b6325 Update CHANGELOG 11 years ago
Michael DeHaan e589365279 Merge branch 'iss_cron' of git://github.com/dirtyharrycallahan/ansible into dh_cron 11 years ago
Michael DeHaan 588b20c012 Merge pull request #3602 from bcoca/fine_tune_stat_exception
narrowed down exception
12 years ago
Michael DeHaan 3b3b600a98 Merge pull request #3470 from langemeijer/devel
Only append non_unique parameter if a uid is provided as well to user module
12 years ago
Brian Coca b7b1c714f9 narrowed down exception we ignore and fail if any other unexpected one
crops up.
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Florian Tham ceff31241b fix fatal error when removing logical volumes 12 years ago
Antti Rasinen 7b8f24adda Make zfs set_property accept values with embedded spaces
Converting the argument list to a string with ' '.join causes
the shell interpreter to misparse spaces in property values.
Since the zfs command does not need shell anywhere, using
a list instead of a string works just as well with run_command. 

Fixes #3545.
12 years ago
Antti Rasinen 7670572578 Fix zfs property parsing
Current property parser breaks when values contain spaces. Since
zfs get -H returns tab separated lines,  it is better to explicitly
split on tabs than on whitespace.
12 years ago
trbs 38b6087495 fix missing json module for issue #3363 print JSON error as string instead 12 years ago
Brian Coca 80b9b01e97 now won't throw exception if we don't have permission to stat a mtab
entry on linux (weird chromebook issue)
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Michael DeHaan 8fe15f0a30 Merge pull request #3426 from trbs/services_sleep_option
sleep option for service module which adds a pauze between stopping and ...
12 years ago
Michael DeHaan 3a84254f6d Merge pull request #3496 from johanwiren/bsd-ipv6-facts
Fix for populating default_ipv6 on BSD systems
12 years ago
Michael DeHaan d1398594ce Merge pull request #3497 from johanwiren/bsd-gateway
Updated setup module to collect gateway fact for BSD systems
12 years ago
Michael DeHaan 952760c605 Merge pull request #3388 from bcoca/fixed_user_create_doc
updated module docs to reflect 'correct' on_create vs on_creation
12 years ago
Johan Wirén 1c247c9eb4 Updated GenericBsdIfconfigNetwork to collect gateway 12 years ago
Johan Wirén 10e9194744 Fix for populating default_ipv6 on BSD systems 12 years ago