Commit Graph

100 Commits (cfabc2e28a485f651d4e334bfdf7961d8e3464c6)

Author SHA1 Message Date
Richard C Isaacson c2bf201bce Bulk update of choices=BOOLEANS to type='bool' 11 years ago
James Cammarata 11f500fa2f Merge pull request #4630 from mmoya/mysql_variables-fix2
Add support for string values
11 years ago
James Cammarata 9730157525 Validate SSL certs accessed through urllib*
* Adds another module utility file which generalizes the
  access of urls via the urllib* libraries.
* Adds a new spec generator for common arguments.
* Makes the user-agent string configurable.

Fixes #6211
11 years ago
Michael DeHaan 616d7e53b1 Merge pull request #6305 from amree/fix-mysql-replication-port
Fixed SQL syntax error when running mysql_replication module
11 years ago
Jimena Cabrera-Notari cc6e1ec261 Don't use keyword `error` in encode
This is not supported in Python 2.6. Just use positional arguments.
11 years ago
amree 1d731e5c30 MASTER_PORT variable for CHANGE MASTER TO command can only accept integer value 11 years ago
Guido Kollerie a000f37132 Emphasize target is on remote host. List supported file types.
From the documentation it is not immediately clear that the 'target'
option refers to a location on the remote host. This change emphasizes that.
In addition to .sql files, .bz2 and .gz files are supported for dumps and
restores. This is now documented.
11 years ago
Kyle Kelley b5eb4d2a71 Fix expires 11 years ago
James Martin 0e3356c40e Properly fetching the riak version, and properly setting the python interpreter. 11 years ago
James Cammarata 1544c93bf2 Merge branch 'fix-postgres_user_to_understand_pg_namespaces' of https://github.com/alanfairless/ansible into alanfairless-fix-postgres_user_to_understand_pg_namespaces 11 years ago
James Cammarata 87bf16930e Merge branch 'postgres_alter_role' of https://github.com/jinnko/ansible into jinnko-postgres_alter_role
Conflicts:
	library/database/postgresql_user
11 years ago
Maykel Moya 811aa2611e Add support for string values
The SET GLOBAL statement requires properly quoting of values. For example, the
following correct queries will fail if quotes are toggled:

mysql> SET GLOBAL innodb_lru_scan_depth = 2000;
mysql> SET GLOBAL master_info_repository = "TABLE";

`mysql_variable` module doesn't quote the value argument, therefore
string values will fail.

  # this task will pass, 2000 is passed without quotes
  - name: set a numeric value
    mysql_variable: variable=innodb_lru_scan_depth value=2000

  # this task will fail, TABLE is passed without quotes
  - name: set a string value
    mysql_variable: variable=master_info_repository value=TABLE

With this patch prepared statements are used. Proper quoting will be
done automatically based on the type of the variables thus an attempt
to convert to int, then to float is done in first place.

Booleans values, ie: ON, OFF, are not specially handled because they
can be quoted. For example, the following queries are correct and
equivalent, they all set _innodb_file_per_table_ to logical _True_:

mysql> SET GLOBAL innodb_file_per_table = "ON";
mysql> SET GLOBAL innodb_file_per_table = ON;
mysql> SET GLOBAL innodb_file_per_table = 1;

Tested in mysql 5.5 and 5.6.
11 years ago
Arturs Vonda 6d85082586 Added port documentation to postgresql_db and postgresql_user 11 years ago
Matthew Jones 31ac3e71df Allow strings containing single and double quotes to be used as passwords for postgres_user 11 years ago
Timur Batyrshin 658c15930e reword "except Error as e:" into "except Error, e:" to be compatible with Python 2.5 (#5852) 11 years ago
jctanner 09f7b11d1d Merge pull request #5435 from jkleckner/fix-mysql-dump-import
mysql_db module: make dump and import to use port argument
11 years ago
David Busby b4f86abafd Documentation update to yield example of "WITH GRANT OPTION" which is undocumented previous 11 years ago
Alan Fairless 7a86083850 Fix postgresql_user to understand PG namespaces
Previously postgresql_user quoted user supplied identifers to create
grant statements that look like this:

    GRANT SELECT on "tablename" to "user";

Which only works if the tablename is not in a namespace.  If you supply
a namespaced tabelname like "report.revenue" then it creates this
incorrect statement:

    GRANT SELECT on "report.revenue" to "user";

Which will not find the "revenue" table in the "report" namespace, but
will rather look for a table named "report.revenue" in the current
(default public) namespace.  The correct form is:

    GRANT SELECT on "report"."revenue" to "user";

This approach could have the unfortunate effect that code that
previously relied on the other behavior to grant privileges on tables
with periods in their names may now break.  PostgreSQL users
typically shouldn't name tables as such, and users can still access the
old behavior and use tablenames with periods in the if they must by
supplying their own quoting.
11 years ago
Jim Kleckner dacef1915a Add quotes to password argument for dump/import
The password is passed on a command line for dump and import and needs
quoting.

Ideally, this would not be passed on a command line at all - any ideas?
Or at least have a stronger form of quoting so that embedded single
quotes will be escaped.
11 years ago
Jinn Koriech aebae13c9b postgresql_user module: Gracefully handle ALTER ROLE on read-only postgres servers. 11 years ago
Jim Kleckner f532b449d7 Fix mysql_db dump and import to use port argument
The code for mysql_db did not pass the port argument when state=dump or
state=import.
11 years ago
jctanner 7182486fd2 Merge pull request #5099 from tartansandal/postgresql_db_check_mode
postgres_db CHECKMODE changed status
11 years ago
Jinn Koriech 6f2843724d Fix postgresql_user documentation render 11 years ago
Jinn Koriech 6b54417bd5 Add documentation for usage of encrypted postgresql passwords. 11 years ago
James Tanner ad837709bd Addresses #5023 Fix import comments 11 years ago
James Tanner 6000d636b3 Fixes #5023 Convert all modules to use new snippet import pattern 11 years ago
Kahlil (Kal) Hodgson ab14ec840b postgres_db CHECKMODE changed status
Make the changed status for postgres_db under CHECKMODE match the
status that would be returned normally.
11 years ago
Michael DeHaan 36effd237c There's a cleaner way to do this, commit to module formatter pending.
Revert "No longer need to reference 'version_added' in docs for these, as this was quite a while ago."

This reverts commit ff0a41d446.
11 years ago
Michael DeHaan ff0a41d446 No longer need to reference 'version_added' in docs for these, as this was quite a while ago. 11 years ago
Michael DeHaan f7c3975f21 Add version_added to all modules missing version_added information, the docs formatter will now
raise errors when omitted, updated changelog with new modules.
11 years ago
James Tanner 15243cd801 Fix typo in postgresql_user module docstrings 11 years ago
jctanner 8041735c56 Merge pull request #4686 from bcoca/postgresql_user_pwds
postgresql_user now supports users w/o a password, encrypted passwords and expiration
11 years ago
James Tanner 6cdc99286c Merge pull request #4307 from damianmoore/mysql_gzip_bzip2_support
Add support for compressing mysql dumps and extracting during import.
11 years ago
Steve Tjoa 626d41c1d1 Changed parameter from 'user' to 'name' in the examples to coincide with the specs. 11 years ago
James Tanner d3c8832414 Fixes #4720 Use mysql command to restore database instead of mysqldump 11 years ago
Brian Coca 87e886a550 updated to make note that password is required before v1.4
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Brian Coca 594ecc00c1 updated docs
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Brian Coca 61d9472312 now supports users w/o a password, encrypted passwords and expiration
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Maykel Moya 3db7ec8356 Fail if requested variable is not available 11 years ago
James Tanner 3c4dd618e4 Fixes #4454 Make a temporary clean cnf file if unable to parse existing 11 years ago
Maykel Moya b90a250165 Improve change detection in mysql_variables
mysql_variables bindly executes a SET var = value query even when
the variable already has the requested value.

With this patch the query is executed only if the current value is
different to the requested one.
11 years ago
James Tanner 807e602228 mysql_db: if connection is a socket, do not specify hostname 11 years ago
James Tanner 84a692bcf7 Fixes #4301 Use module_common functions for mysqldump and return better errors 11 years ago
Michael DeHaan e4036b1bfc Merge pull request #4342 from pileofrogs/devel
mysql_replication switch to DictCursor for compatibility with more mysql server versions
11 years ago
Michael DeHaan ce79efc34a Add missing version_added doc to mysql login port parameter. 11 years ago
Dylan Martin 345329b69f toned down the error message for unconfigured master/slave 11 years ago
Jeroen Hoekx 08b0773da5 Add append_privs parameter to MySQL user module.
This adds the privileges given to the existing list of privileges
instead of overwriting any existing ones.
11 years ago
Dylan Martin 6b26a73681 switch to DictCursor 11 years ago
Damian Moore 3c57168aaa mysql_db now supports import and dump of gzip and bzip2 compressed files 11 years ago
James Cammarata 30a1560d67 Merge branch 'devel' of https://github.com/tomdymond/ansible into tomdymond-devel 11 years ago