8 Commits (cf0cd4b50bbabc5b2f8c36c63fc7b064c94f2040)

Author	SHA1	Message	Date
Sam Doran	888be697cb	Revert "Change default file permissions so they are not world readable (#70221)" (#71231) ... * Revert "Change default file permissions so they are not world readable (#70221)" This reverts commit 5260527c4a. * Revert "Fix warning for new default permissions when mode is not specified (#70976)" This reverts commit dc79528cc6.	4 years ago
Sam Doran	5260527c4a	Change default file permissions so they are not world readable (#70221) ... * Change default file permissions so they are not world readable CVE-2020-1736 Set the default permissions for files we create with atomic_move() to 0o0660. Track which files we create that did not exist and warn if the module supports 'mode' and it was not specified and the module did not call set_mode_if_different(). This allows the user to take action and specify a mode rather than using the defaults. A code audit is needed to find all instances of modules that call atomic_move() but do not call set_mode_if_different(). The findings need to be documented in a changelog since we are not warning. Warning in those instances would be frustrating to the user since they have no way to change the module code. - use a set for storing list of created files - just check the argument spac and params rather than using another property - improve the warning message to include the default permissions	4 years ago
Brian Coca	ac509d489b	Revert "stricter permissions on atomic_move when creating new file (#68970)" (#68983) ... This reverts commit 566f2467f6.	5 years ago
Brian Coca	566f2467f6	stricter permissions on atomic_move when creating new file (#68970) ... fixes #67794 updated some tests that expected previous defaults CVE-2020-1736	5 years ago
Matt Martz	697b566971	Update units to pass on macOS (#60435) ... * Update units to pass on macOS. Fixes #27810 * raising=False	5 years ago
Sam Doran	2a98faee2b	Move _handle_aliases() out of basic.py (#48578) ... Refinements: - return legal_inputs and update class properties - remove redundant arguments from method and handle in caller - add better exception types to method * Add unit tests for handle_aliases	6 years ago
Sviatoslav Sydorenko	f1e67c3328	Bugfix/ fix mocker patch in tests (#52372) ... * 🐛 Fix invalid os.stat mock in tests * 🐛 Fix leaking mock patch in tests Closes #52347	6 years ago
Toshio Kuratomi	370a7ace4b	Split basic units (#33510) ... Split the one monolithic test for basic.py into several files * Split test_basic.py along categories. This is preliminary to get a handle on things. Eventually we may want to further split it so each file is only testing a single function. * Cleanup unused imports from splitting test_basic.py * Port atomic_move test to pytest. Working on getting rid of need to maintain procenv * Split a test of symbolic_mode_to_octal to follow unittest best practices Each test should only invoke the function under test once * Port test_argument_spec to pytest. * Fix suboptions failure	7 years ago