Commit Graph

47 Commits (ce391c726576c75a67d3340deff9a63a9f59cfac)

Author SHA1 Message Date
Patrik Lundin fb41bdfc1e service: Fix comments in OpenBsdService class.
No functional change.
9 years ago
Brian Coca d02ef57815 minor doc fix 9 years ago
Brian Coca 0c9dd0e6a4 Merge pull request #751 from j2sol/service_must_exist
Add service option to avoid failure on missing service
9 years ago
Jonathan Mainguy 442b6a2067 fixes check mode for Ubuntu 14.04 9 years ago
Semyon Deviatkin 4e22a8039c Fix unused variable systemd_enabled
Removed declared but unused variable systemd_enabled
10 years ago
James Cammarata c4f6e63117 Fix bug in service where upstart services incorrectly use init scripts
Fixes #1170
10 years ago
Brian Coca 727c9131c8 Merge pull request #1138 from bcoca/service_fix
simplified bad if chain
10 years ago
Brian Coca f1d72ea004 simplified bad if chain
hopefully fixes #1136
10 years ago
Brian Coca 61f664bc47 Merge pull request #251 from davidfritzsche/patch-1
Add working status detection for pf on FreeBSD
i'm going to merge this to give you a usable workaround, still I consider this a bug in the init script.
10 years ago
David Wittman 8d53ef2f60 [service] Fix bug with upstart detection
Upstart scripts are being incorrectly identified as SysV init scripts
due to a logic error in the `service` module.

Because upstart uses multiple commands (`/sbin/start`, `/sbin/stop`,
etc.) for managing service state, the codepath for upstart sets
`self.svc_cmd` to an empty string on line 451.

Empty strings are considered a non-truthy value in Python, so
conditionals which are checking the state of `self.svc_cmd` should
explicitly compare it to `None` to avoid overlooking the fact that
the service may be controlled by an upstart script.
10 years ago
Toshio Kuratomi 939ecd33d4 In service_enable, the default of changed is True so we have to set it
to False explicitly if it is False.

Fixes #875
10 years ago
Brian Coca 1bca815d37 Merge pull request #95 from Gamevy/use-insserv
Use insserv where available
10 years ago
Brian Coca ed8154bdc7 Merge pull request #759 from jonhadfield/systemd_enabled_check
use is-enabled to check systemd service status.
10 years ago
Dagobert Michelsen 1f2ffb3900 Solaris SMF is already supported and should be mentioned in the docs, 10 years ago
Brian Coca b82055f021 Merge pull request #648 from bcoca/service_fix_update-rc.d
simplified update-rc.d enable/disable handling,
10 years ago
Jon Hadfield b20b29bd17 use is-enabled to check systemd service status. 10 years ago
Jesse Keating cf0e8d62d2 Add service option to avoid failure on missing service
This adds a must_exist option to the service module, which gives callers the
ability to be tolerant to services that do not exist. This allows for
opportunistic manipulation of a list of services if they happen to exist on the
host. While failed_when could be used, it's difficult to track all the
different error strings that might come from various service tools regarding a
missing service.
10 years ago
Graham Hay 17c7d9c5d5 Use insserv where available 10 years ago
Jonathan Armani 645e0653a3 Merge branch 'devel' into openbsd_rcctl 10 years ago
Toshio Kuratomi 4f1f8e89c9 More information about distutils on Solaris in case we run into this again 10 years ago
Toshio Kuratomi effdba95de Merge pull request #639 from tgolly/devel
distutils is not available on some non-Linux OS's
10 years ago
Brian Coca e957150f77 Merge pull request #189 from jarmani/openbsd_rcctl
Openbsd rcctl
10 years ago
Patrik Lundin e8c328773a Update OpenBSD rcctl handling to use new syntax.
See http://marc.info/?l=openbsd-cvs&m=142054488027109&w=2
10 years ago
Tim G 8f43a0a4fe Load distutils on all platforms EXCEPT Solaris.
Solaris doesn't ship distutils with with the default Python package.  This patch fixes "service" on Solaris since 30d6713.
10 years ago
Brian Coca 9ac5ed2621 now allows for case in which someone removed the K* links and is trying
to reenable a service
10 years ago
Brian Coca f4a709ad7c simplified update-rc.d enable/disable handling, removed forced defaults
creation as that breaks local customizations
10 years ago
Tim G 68b5b7be72 distutils is not available on some non-Linux OS's 10 years ago
Patrik Lundin 2acfbf016d Handle string returned by 'default' correctly.
We need to handle the string returned by 'default' in the same way we handle
the string returned by 'status' since the resulting flags are compared later.
10 years ago
Brian Coca aba9e5e4f9 vastly simplified systemd detection, made enable/disable errors clearer
both of which allows us to remove 'service name detection' as if systemd
is init we still use it to handle initscripts.
10 years ago
Brian Coca df6d58614e now actually adds usable name for systemd when service only has init
script
10 years ago
Toshio Kuratomi 5af4463823 Gixes to doc formatting 10 years ago
Brian Coca 943f8fe7c9 Merge pull request #346 from bcoca/service_cleanup
service cleanup
10 years ago
Achilleas Pipinellis a375ce33d3 Clarify supported init systems. 10 years ago
Brian Coca 29d211e7ab service cleanup 10 years ago
Brian Coca f49120598f service now detects systemd is actually running, not just installed 10 years ago
Patrik Lundin eea4d06848 Fix typo: Replace "N0" with "NO". 10 years ago
David Fritzsche c96a85fb70 Add working status detection for pf on FreeBSD
The return code of "service pf onestatus" is usually zero on FreeBSD (tested with FreeBSD 10.0), even if pf is not running. So the service module always thinks that pf is running, even when it needs to be started.
10 years ago
Toshio Kuratomi 7f611468a8 Fix for systemd service scripts with newlines
Fixes #127
10 years ago
Patrik Lundin f9d9c1b6d7 Multiple fixes for OpenBSD rcctl handling.
* Use the newly added 'default' argument to know if the default flags are set
  or not.
* Handle that 'status' may either return flags or YES/NO.
* Centralize flag handling logic.
* Set action variable after check if we need to keep going.

Big thanks to @ajacoutot for implementing the rcctl 'default' argument.
10 years ago
Patrik Lundin e463400412 Simplify self.arguments logic.
Strange logic pointed out by @jarmani, thanks!
10 years ago
Patrik Lundin 924cf20cf8 Depend more on rcctl if it is present.
* Make the module support enable/disable of special services like pf via rcctl.
  Idea and method from @jarmani.
* Make the module handle when the user supplied 'arguments' variable does not
  match the current flags in rc.conf.local.
* Update description now that the code tries to use rcctl for everything if it
  is available.
10 years ago
Patrik Lundin 5f37624eb4 Tweak error checking for "enabled" code.
Based on input from @jarmani:
* A return value of 2 now means a service does not exist. Instead of
  trying to handle the different meanings of rc after running "status",
  just look at stderr to know if something failed.
* Skip looking at stdout to make the code cleaner. Any errors should
  turn up on stderr.
10 years ago
Patrik Lundin c6dd88c1d1 Fail if "rcctl status" writes to stderr. 10 years ago
Patrik Lundin 1a8cdb5e3e Check rc and print error message if any.
It is probably good to use stdout before printing a generic error
message as well.
10 years ago
Patrik Lundin c46e030100 Make "enabled" code aware of --check mode. 10 years ago
Jonathan Armani 1b97390765 Add enable / disable of services for OpenBSD if rcctl is present 10 years ago
Michael DeHaan c8e1a2077e file extensions! 10 years ago