4 Commits (cd8161a94827bd8dbae53610318f5957b56b8b98)

Author	SHA1	Message	Date
Chris Van Heuveln	6bb13bbb84	nxos_vlan: fix broken purge behavior (issue #57101) (#57229) ... * nxos_vlan: fix broken purge behavior (issue #57101) Symptoms/Analysis: - `nxos_vlan` `purge: true` would fail when `purge` was trying to delete all unspecified vlans, including vlan 1. - `nxos` devices do not allow removing vlan 1 and raise a cli exception error - Previous fix #55144 caused a side effect when `purge` was used: vlan changes specified by `aggregate` were ignored; e.g. - vlan 4 is not present; playbook specifies `aggregate: { vlan: 4 }, purge: true` - results in proper purging but vlan 4 is not created Solutions: - ignore vlan 1 when purging - remove the `not purge` check from state present logic Added additional unit tests and integration tests. Tested against all regression platforms. * PEP fixes * Add agg_show_vlan_brief.txt fixture * Add warning for removing vlan 1 * change method name check	6 years ago
Trishna Guha	96346938ee	nxos_vlan refactor to support non structured output (#43805) ... * nxos_vlan refactor to support non structured output Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> * unittest fix Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> * minor fixes Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> * use check_rc Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> * address review comment Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> * remove additional return statement * address Nate's review Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>	6 years ago
Trishna Guha	60f3649ebd	Convert nxos_vlan to DI module (#31866) ... * Convert nxos_vlan to DI * fix conflict * push fix for qalthos's comment Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>	7 years ago
Nathaniel Case	0b4cebfb8b	nxos_vlan tweaks (#23194) ... * Remove commented code Remove a lot of unnecessary output * Tests * Sort vlan ids _after_ running set operations, so order is not lost	8 years ago