ansible

Commit Graph

Author	SHA1	Message	Date
Dag Wieers	b82f965616	mail: Fix regression when sending mail without SSL (#46403 ) When refactoring the code the non-SSL use-case was broken. The main cause is that we have no way to do integration tests for testing SMTP.	7 years ago
guoqiao	6ef9c2d7b7	Fix mail module for python 3.7.0 (#44550 ) (#44552 ) In python 3.7.0, changes in `ssl.py` breaks `smtplib.SMTP_SSL`, which then breaks `mail` module in ansible. Run this line in python shell: import smtplib;smtplib.SMTP_SSL().connect(host='smtp.gmail.com', port=465) Before python 3.7.0, we will get: (220, b'smtp.gmail.com ESMTP j13-v6sm3086685pgq.56 - gsmtp') In python 3.7.0, we get such error at `lib/python3.7/ssl.py` line 843, method `_create`: ValueError: server_hostname cannot be an empty string or start with a leading dot. The ssl module is using host info on SMTP_SSL instance, which is not set. The fix/workaround is simple, just pass host info to it: import smtplib;smtplib.SMTP_SSL(host='smtp.gmail.com').connect(host='smtp.gmail.com', port=465) Fixes: #44550 Signed-off-by: Guo Qiao <guoqiao@gmail.com>	7 years ago
Agris	5df01abd58	Fix for starttls connections for notification mail module (#42381 ) * Fixes #42338 Fixes #42338 Fixed starttls connection usage by adding smtp.ehlo before smtp.has_extn function. * remove Trailing whitespace remove Trailing whitespace Fixes #42338 * marged bcoca requested changes Fixes #42338 move ehlo for starttls section only. * Remove spaces	8 years ago
Brian Coca	72b0ed8cb4	fix handling of some exceptions for mail plugin redid the flow to simplify and dedupe code, also now we capture extra exceptions previouslly causing traceback see https://groups.google.com/forum/?#!msg/ansible-project/qhalnkYZMfI/93n8hlEpBAAJ	8 years ago
John R Barker	195beebcb4	Module DOCUMENTATION should match argspec (#34895 ) * Module DOCUMENTATION should match argspec Large update of many modules so that DOCUMENTATION option name and aliases match those defined in the argspec. Issues identified by https://github.com/ansible/ansible/pull/34809 In addition to many typos and missing aliases, the following notable changes were made: * Create `module_docs_fragments/url.py` for `url_argument_spec` * `dellos_command` shouldn't have ever had `waitfor` (was incorrectly copied) `ce_aaa_server_host.py` `s/raduis_server_type/radius_server_type/g` * `Junos_lldp` enable should be part of `state`.	8 years ago
Kenny Gillen	1234a79349	Fix gender pronouns and the odd typo (#31709 )	8 years ago
Dag Wieers	f5dded59c2	mail: Fix charset encoding issue This PR includes: - An important fix to charset encoding of from address - Documentation and examples cleanup - PEP8 fixes - Warning on insecure access - Strict parameter typing - More modern interface (using lists rather than comma, space or pipe-delimited strings) - Warn on failure to send mail to some recipients ``` [WARNING]: Failed to send mail to 'foobar': 550 5.1.1 <foobar>: Recipient address rejected: User unknown in local recipient table ``` - Warn on failure to parse some headers ``` [WARNING]: Skipping header 'Foobar', unable to parse ``` - Return failed recipients as return value - Changed default encoding to utf-8	8 years ago
Andrea Tartaglia	b9de989ad4	Fix mail module headers encoding (#29109 ) * Fixes encoding issue in Subject line * Use Header to correctly set header charset	8 years ago
Konstantin Shalygin	343da35381	mail: Fix auth over starttls. (#24089 )	8 years ago
Toshio Kuratomi	f203ca7907	Update metadata to 1.1	8 years ago
Toshio Kuratomi	4109a82d0a	remove wildcards and add boilerplate * cloud/centurylink * source_control * cloud/google * notification * cloud/rackspace * cloud/vmware	9 years ago
R. Soto	5c0c985547	update auth_flag variable after STARTTLS connection is established, fixes #26376	9 years ago
Dylan Silva	bba4549b43	Downgraded more modules from Curated to Community (#24751 )	9 years ago
Toshio Kuratomi	eb1214baad	New metadata 1.0 (#22587 ) Changes to the metadata format were approved here: https://github.com/ansible/proposals/issues/54 * Update documentation to the new metadata format * Changes to metadata-tool to account for new metadata * Add GPL license header * Add upgrade subcommand to upgrade metadata version * Change default metadata to the new format * Fix exclusion of non-modules from the metadata report * Fix ansible-doc for new module metadata * Exclude metadata version from ansible-doc output * Fix website docs generation for the new metadata * Update metadata schema in valiate-modules test * Update the metadata in all modules to the new version	9 years ago
Matt Clay	cb76200c7d	PEP 8 E111 & E114 cleanup. (#20838 )	9 years ago
Toshio Kuratomi	a8af6c6baf	Fix some SSL errors in mail.py causing SMTP Syntax Errors (Rebase of https://github.com/ansible/ansible-modules-extras/pull/708 ) (#19253 ) * Rebase of https://github.com/ansible/ansible-modules-extras/pull/708 708 was full of extraneous merge commits interwoven with commits to implement the feature. In the end the only way I could clean this up in reasonable time was to just take a regular diff between the PR and the base. This lost the history of intermediate commits but I've preserved attribution to @dayton967 via git's --author field. Although I preserved the logic of the PR, there were a few additional things that I cleaned up: * Fixed import of email.mime.multipart * Used the argspec to set port and timeout to integers instead of having ad hoc code inside of the module. * Used argspec's choices for secure instead of ad hoc code inside of the module. * Removed some unused variables * Made secure_state a python boolean instead of using 0 and 1 * Used secure with string comparisons instead of turning it into an integer code. This is much more readable. * Fixed catching of SMTPExceptions (SMTPException wasn't imported directly so it needed to use the smtplib namespace.)	9 years ago
James Cammarata	011ea55a8f	Relocating extras into lib/ansible/modules/ after merge	9 years ago

17 Commits (cbb49f66ecbba1547fe864cb2ff08ddbe0ad074c)