Commit Graph

36064 Commits (ca3457458f87ebb65eeefc8361fb25e4baf70ef8)
 

Author SHA1 Message Date
Matt Clay a48254275f Temporarily disable subversion test on osx.
(cherry picked from commit f283edcb19)
7 years ago
Ed Costello b717765d59 Fix documentation of validate_certificates option in aws doc_fragment.
Unignore sanity test failures for AWS modules caused by this common
fragment.

(cherry picked from commit 2a0c7c4331)
7 years ago
John R Barker e1174f8864
fix yamllint issue (#36636) 7 years ago
Matt Davis e77c1b9e42 New release v2.5.0rc1 7 years ago
Matt Davis 98882b725f 2.5.0rc1 CHANGELOG prep 7 years ago
Matt Davis 97a7c3f39c rename versioned CHANGELOGs with dash 7 years ago
Matt Davis 2ddcdb8720 Revert "Add force option to systemd module (#35925)"
(mistaken cherry pick)

This reverts commit 9935cda4a3.
7 years ago
Dag Wieers 917e5ae5d8 Improve convert_bool error message
The error message as it was confused me when the value was 'enabled' and
there was also a module parameter named 'enabled'.

    enabled is not a valid boolean.  Valid booleans include: yes, on, 1, true, ...

So by clearly describing it as a value, the confusion would have been
avoided.

    The value 'enabled' is not a valid boolean.  Valid booleans include: yes, on, 1, true, ...

(cherry picked from commit 487cf0ee8d)
7 years ago
Matt Davis ed9781bbfb
Do not cache the loop item label so that it will update with each item (#36609)
Add integration test for #36430 (#36432)

(cherry picked from commit d1f76939e5)
(cherry picked from commit 9fced4f0a9)
7 years ago
Dag Wieers b1e125b718 Backport missing integration tests (#36610)
Somehow this file was missing from the previous backport.
7 years ago
John R Barker 3d1c8bc2e1 Network Getting started docs (#36337) (#36597)
* first draft of getting started guide
(cherry picked from commit 51a010a696)
7 years ago
Jordan Borean f8d8d84f05 Win feature error cp (#36559)
* win_feature: better error handling to make it easier to debug issues (#36491)

* win_feature: better error handling to make it easier to debug issues

* removed ignroed pslint rules that are no longer needed

(cherry picked from commit ef4f8851dc)

* Added changelog for win_feature error handling fix
7 years ago
Matt Martz 9bd7147bb8 Start of tests for modify_module, specifically to ensure proper shebang replacement on old style modules (#36602) (#36606)
(cherry picked from commit a7062b7587)
7 years ago
Chris Houseknecht 7e378e791c
Bump OpenShift client req to 0.4.3. Fixes openshift_scale. (#36580) 7 years ago
Abhijeet Kasurde 980b6a00e2 Fixup VMware module docs issues (#36409) (#36523)
Fix various argspec vs documentation issue

(cherry picked from commit 5d0ed38e3a)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
7 years ago
Ryan Brown c4e94af4e9 [cloud] catch NoCredentialsError in boto3_conn (#36545) 7 years ago
Toshio Kuratomi e93cc41211
Bp 2.5 ansible interpreter py3 (#36561)
* Fix types when evaluating interpreter (#36541)

* Fix types when evaluating interpreter. Fixes #36536
* Rename variables that contain bytes to b_*
* Get rid of to_text() and to_bytes() calls that do nothing (because the
  data is already the proper type)

(cherry picked from commit a4df4d33ac)

* Changelog entry for the ansible_*_interpreter fix
7 years ago
Sam Doran 84debca5fb Check for regexp match when using insertbefore or insertafter (#36474) (#36552)
Add tests to cover this scenario
Add changelog fragment
Fixes #36156

(cherry picked from commit 723daf3e3a)
7 years ago
mikedlr 26cdfd84a0 Bring aws_ssm None fixes into stable (from #36456) (#36492)
* aws ssm parameter lookup - change to reutrn Nones for missing variables

* aws ssm parameter lookup - fix error case message to dump response

* aws ssm parameter lookup - fix integration test cases
7 years ago
Julien Vey 7965ecb962 efs: improve documentation about the update of an efs (#36473)
(cherry picked from commit 3abaa43b1c)
7 years ago
scottb 138ed416eb Changelog fragment copy edits. (#36555)
* Changelog fragment copy edits.

* Typo fixes.

* Typo fix 2.
7 years ago
Dag Wieers df78df5d90 Apply all devel ACI changes missing from stable-2.5 (#36553) 7 years ago
Matt Davis 61c1241a77 reformat multiline bugfix entries 7 years ago
Matt Davis 0057cfa066 remove plugin sections from reno config
* we'll generate those at runtime using plugin metadata instead of trying to cobble together from sections
7 years ago
Julien Vey 54f9f06edc [cloud] ec2_group: fix check mode when using tags (#36503)
Fixes #36412
7 years ago
Sam Doran cb73fba369 Add note to use script module rather than inline here documents (#32863)
* Add example on how to use a here document with shell module

* Remove here doc example and add note to use script module instead

(cherry picked from commit 5e7ee9df0a)
7 years ago
Toshio Kuratomi 7f9fdbbb30 Revert "remove query/q (#36315)"
This reverts commit b47d2e07e1.

query is a feature for 2.5.  We're not reverting it now.

(cherry picked from commit 03a6d72633)
7 years ago
Sloane Hertel 741b941f33 [cloud] If inventory file isn't able to be parsed by aws_ec2, raise an AnsibleParserError (#36387) (#36459)
* If inventory file isn't able to be parsed by aws_ec2, return an empty dict instead of None

* Raise an AnsibleParserError instead

* remove extra lines

* aws_ec2 inventory plugin - fix path matching logic
7 years ago
Sloane Hertel 32515884ef [cloud] Change to longer interval jittered backoffs for AWS facts (#36266) (#36464)
* Change to longer interval jittered backoffs for security group fact gathering

* Add the ECS throttling error code to the list of things to retry on
7 years ago
Sloane Hertel 77af8f36cb [cloud] Retry WAF actions on WAFStaleDataException (#36405) (#36507)
Add a util to run functions with AWSRetry to retry on WAFStaleDataExceptions and update ChangeToken for each attempt
7 years ago
Sloane Hertel 234ba3f8b3 [ec2_vpc_net_facts] Fix UnsupportedOperation for regions other than u… (#35302) (#36512)
* [ec2_vpc_net_facts] Fix UnsupportedOperation for regions other than us-east-1

* Make fix more Pythonic

* Fix the exception handling for the module
7 years ago
Matt Martz 2c8d9beca3 cherry-pick #36470 for 2.5 (#36525)
* Re-use logic from StrategyBase._load_included_file in StrategyModule.run for free and linear (#36470)

This improves include_role performance and recursion limits

(cherry picked from commit 10fefc7156)

* Add changelog for 36470
7 years ago
Sloane Hertel bcc3ce8d74 [cloud] Better handling of absent AWS SES identity notification information. (#36354) (#36515)
* Better handling of absent AWS SES identity notification information.

Fixes #36065

aws_ses_identity module now handles the cases where information about
the notification setup for the identity isn't returned by the AWS api.

This seems to happen in an edge case, believed to be eventual
consistency on registering new identities. So this case is treated
as if has been no notification setup for the identity yet.

Also fix 2 flake8 warnings in the module, a missing newline and unused
import.

* Increase the Boto Retries on SES APIs to deal with throttling.

This should address the unstable integration test failing due to
parallel runs in shippable hitting AWS throttling.

* Add retries loading SES details for inclusion in successful response.

There seems to be an eventual consistency behaviour with identity
registration. It's possible to still get no identity back after
registration.

This can cause failures in the shippable builds. This should fix that by
creating a retry of retrieving the identity information after
registration.

A similar retry loop has been added to notification attributes to ensure
this doesn't suffer from the same failure.

* Add missing sleep in get_notification_attributes to avoid busy loop.
7 years ago
Brian Coca 7188165dd1 remove query/q (#36315)
* remove query/q

remove and fixed tests for removed func

* paren fix

(cherry picked from commit b47d2e07e1)
7 years ago
Brian Coca c6af155049 catch all cases of no inventory when asked to fail
fixes #36034

(cherry picked from commit fdbd1297cf)
7 years ago
Trishna Guha 16845be9b1
nxos fixes (#36514)
* fix nxos_pim module doc (#36505)

* fix nxos_pim module doc

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* address review

(cherry picked from commit 9598978e12)

* nxos_vrf fix (#36494)

* nxos_vrf fix

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Address review

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 713828804d)
7 years ago
Sam Doran 9935cda4a3 Add force option to systemd module (#35925)
* Add force option to systemd module

* Use multi-line YAML syntax in examples

* Add version_added for new option

(cherry picked from commit 2bffcfa63b)
7 years ago
René Moser 7e1ff91a5a
cs_user: fix return user_api_secret for ACS v4.10 and later (#36447) (#36489)
(cherry picked from commit 6402a3e504)
7 years ago
Jordan Borean 9b00fd4ca1
fetch: set fail_on_missing: True as default as per docs (#36469)
* fetch: set fail_on_missing: True as default as per docs

* Updated docs for fetch to say behaviour was changed in 2.5 and updated tests

(cherry picked from commit df8a5d7a4f)
7 years ago
Trishna Guha 28fb690cc3
fail module when config is invalid and jsonrpc doesn't return error (#36482) (#36488)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit d5858bbcbe)
7 years ago
David Newswanger 6eb248a327 removed to_subnet from list of imports on ios_l3_interface.py as it was not being used (#35969) (#36450)
(cherry picked from commit 15fa18a619)
7 years ago
Ganesh Nalawade b458dfc222
fixed conditional error message (#36476) (#36485)
(cherry picked from commit f207897f32)
7 years ago
Deepak Agrawal 6ff000254f
vyos_config IndexError in sanitize_config (#36375) (#36484)
* Bug in del(list) logic. Say you have a list of 4 elements a[0-3]
and you have to remove index 1 and 3, if you remove index 1 first
then list is cut short a[0-2] and does not have index 3

Fix: Remove indexes in reverse sorted order e.g. 3 and 1 in above
example so that order of indexes remain preserved even after deleting

fix is to remove indexes in reverse sorted order

* Add test cases for failed case

(cherry picked from commit 0bbea9a579)
7 years ago
Trishna Guha d86d4907cc
fix nxos_bgp_neighbor_af issues (#36472) (#36481)
(cherry picked from commit 47a92386c9)
7 years ago
Trishna Guha 4f5ac56c53
Fix nxos_banner module for unstructured output (#36411) (#36479)
* Fix nxos_banner module for unstructured output

* Refactor and bug fixes

* Fix pep8 error

(cherry picked from commit ef7d574920)
7 years ago
Matt Clay 8db5d139a1 Fix path handling in validate-modules sanity test.
(cherry picked from commit a9b58b84d8)
7 years ago
Trishna Guha 108cbbc40e
fix vyos_l3_interface adding multiple addresses to interface (#36377) (#36443)
* fix vyos_l3_interface adding multiple addresses to interface

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* add test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 3d06ce245a)
7 years ago
Brian Coca 0ee6771659 remove extra fields from debug output
fixes #35493

updated tests

(cherry picked from commit a79378fccb)
7 years ago
Brian Coca 6d1a9a8211 hide uneeded fields for callbacks (#36259)
* hide uneeded fields for callbacks

fix selective instead of pushing uneeded fields to the methods

* piipii

(cherry picked from commit 6af5693dc2)
7 years ago
Brian Coca 46b565cd96 now get_url defaults to module temp dir (#36218)
* now get_url and other modules default to module temp dir

also fixed 'bare' exception

* allow modules to work with older versions

* updated docs per feedback

(cherry picked from commit c119d54e4a)
7 years ago