Commit Graph

29 Commits (c8bd14925d9258c4fd676fda5a3830ef01e932c9)

Author SHA1 Message Date
jctanner 872a1ee39b Merge pull request #5107 from maetthu/devel
authorized_key module: rewrite options to dict parser, fixes #5032
11 years ago
James Tanner ad837709bd Addresses #5023 Fix import comments 11 years ago
James Tanner 6000d636b3 Fixes #5023 Convert all modules to use new snippet import pattern 11 years ago
Matthias Blaser 9d442243ab rewrite options to dict parser, fixes #5032 11 years ago
Michael DeHaan 36effd237c There's a cleaner way to do this, commit to module formatter pending.
Revert "No longer need to reference 'version_added' in docs for these, as this was quite a while ago."

This reverts commit ff0a41d446.
11 years ago
Michael DeHaan ff0a41d446 No longer need to reference 'version_added' in docs for these, as this was quite a while ago. 11 years ago
James Tanner 7be13faae8 Fix comment yaml escaping in authorized_key module 11 years ago
James Tanner 4ba51eef6f Save comment hashes in sshkeys 11 years ago
James Tanner 16b22d0d64 Cleanup debug statements 11 years ago
James Tanner b938554311 Fixes #5032 escape and safely split key options in authorized_keys module 11 years ago
James Tanner 32986c4d64 Fixes #5021 safely split hostkeys with quotes 11 years ago
James Cammarata 0e9184eefd Fixing authorized_keys module to make the key part detection better
Fixes #4677
Fixes #4657
Fixes #4599
11 years ago
James Cammarata aa0577c211 Merge branch 'fix_autorized_keys' of https://github.com/mscherer/ansible into mscherer-fix_autorized_keys 11 years ago
James Cammarata b58b287fce Fixing up authorized_keys to accept comments with spaces 11 years ago
Michael Scherer 951a91723d make sure that options are quoted, as people can add a shell
script there with a comma that would produce invalid configuration
upon being wrote again
11 years ago
Michael Scherer 7672e9fef8 sort the option_key to have a constant predictable line 11 years ago
Michael Scherer 264945a1f7 adding a single comma at the end of the options list confuse the module
it start to duplicate line, because this create
a empty option in the list, and so the module add a new line along the previous
one. See

>>> ' a,b, '.strip().split(',')
['a', 'b', '']
11 years ago
jctanner 7e8e186b3b Merge pull request #4517 from adfinis-sygroup/devel
Remove keys regardless of the options
11 years ago
James Cammarata 35284818a9 Handle ssh key files that may only have a type/key specified
If a specified key did not have a comment, it would be ignored as
an invalid key.

Fixes #4513
11 years ago
Stefan Heinemann af704562a9 Set the options of an authorized key comma separated
According to the sshd man page, no spaces are permitted between the
options of an authorized ssh key
11 years ago
Stefan Heinemann 346d46a94c Don't mind the options of a key when removing it
This allows to remove a key without knowing the options in the
authorized_key file
11 years ago
James Cammarata 49130c688d Adding 'unique' option to authorized_key module and cleanup
A small refactoring of the authorized_key module to accomodate these
changes, plus fixing some things like not rewriting the file on every
new key. These changes bring the original feature for ssh options in-
line with the comments in #3798

Fixes #3785
11 years ago
David Minor ed7d3f92a0 Add ssh key options parameter to authorized_key module 11 years ago
Joshua Lund cc275ca2be Added a new with_file example to the authorized_key documentation 12 years ago
Jan-Piet Mens 5c69918d53 DOCS: standardize on EXAMPLES (a.k.a. Docs-JumboPatch JetLag Edition)
Migrated all examples: in DOCUMENTATION=''' string to standalone EXAMPLES=''' string
  Added deprecation warning to moduledev.rst and remove deprecated example from it
  Fixed up a few typos and uppercased some acronyms.
  add consistency to how EXAMPLES are formatted
12 years ago
Joshua Lund 51c7441244 Updates to the authorized_key documentation
* Clarified the meaning of 'user'
* Changed 'sshdir' to 'path' in the example
  * 'sshdir' is used internally in the module, but the argument is 'path'
* Made the capitalization consistent in the descriptions
12 years ago
Lorin Hochstein 8c9cceacbf authorized_key: Set manage_dir default value
This commit fixes a bug where the authorized_key module causes
the ~user/.ssh directory to be owned by root instead of the user,
when the manage_dir argument is not specified.

If the manage_dir argument was not specified, the module behaved as if
manage_dir was set to false, even though it's supposed to default to
true.

This module assumed that an optional argument, with no default
specified, will not be present in the module.params dictionary.

What actually seems to happen is that the argument does appear in
the module.params dictionary with a value of None.

The upside is that this line was evaluating to None instead of
true:

    manage_dir = params.get("manage_dir", True)

I fixed the problem in this particular module by explicitly specifying
the default value for the manage_dir arugment. But if this bug
occurred because of a change in behavior in AnsibleModule, then other
modules may be broken as well.
12 years ago
Oleg 3531fbdb29 fix for authorized_key: skip chown and chmod if authorized_key_file is link 12 years ago
Michael DeHaan 391fb98ee2 Allow modules to be categorized, and also sort them when generating the documentation. 12 years ago