16579 Commits (c8ad55103e44833d20c509176541b1897bc26f28)

 

All Branches   

Search

Author	SHA1	Message	Date
James Cammarata	60e1a1f8eb	Fix bug in nested lookup where pop is called indiscriminately	9 years ago
Brian Coca	191ae0831d	fixed syntax error	9 years ago
Brian Coca	48412c13b2	fixed copy n paste typo on future code	9 years ago
James Cammarata	bb1101498d	Clean up typo from cdc6c52	9 years ago
James Cammarata	cdc6c5208e	Clean string data run through the template engine ... Also strip UnsafeProxy off of low level srings and objects to ensure they don't cause issues later down the road Fixes #12513	9 years ago
James Cammarata	ae9b34b1d9	Fix for equality checking in Host to make sure things are like types	9 years ago
Toshio Kuratomi	fa9ea32a86	Fix test of whether a result has a failed host	9 years ago
Brian Coca	1c49e3b842	draft shared service code for modules, part of spliting service module	9 years ago
Toshio Kuratomi	41756be4d3	Update core module ref	9 years ago
Toshio Kuratomi	dcdcd9e9c5	Move is_executable to the toplevel of basic.py so we can utilize it from other code	9 years ago
James Cammarata	aedec951be	Merge pull request #12521 from mgedmin/patch-1 ... Typo in shell command in example	9 years ago
Marius Gedminas	b57d549e16	Typo in shell command in example	9 years ago
James Cammarata	ccddda1ebc	Merge pull request #12502 from mgedmin/py3k ... Python 3: make test_variable_manager_precedence pass	9 years ago
James Cammarata	eb8d7dcd14	Make sure formatted strings don't bomb on tuples ... Fixes #12501	9 years ago
James Cammarata	31d5f88a1d	Use the task loop to calculate multiple delegated hosts ... Due to the way we're now calculating delegate_to, if that value is based on a loop variable ('item') we need to calculate all of the possible delegated_to variables for that loop. Fixes #12499	9 years ago
Toshio Kuratomi	a1428d6bed	Remove tmp as a parameter to the connection plugins ... There doesn't appear to be anything that actually uses tmp_path in the connection plugins so we don't need to pass that in to exec_command. That change also means that we don't need to pass tmp_path around in many places in the action plugins any more. there may be more cleanup that can be done there as well (the action plugin's public run() method takes tmp as a keyword arg but that may not be necessary). As a sideeffect of this patch, some potential problems with chmod and the patch, assemble, copy, and template modules has been fixed (those modules called _remote_chmod() with the wrong order for their parameters. Removing the tmp parameter fixed them.)	9 years ago
James Cammarata	95b371dd60	Use AnsibleFileNotFound instead of AnsibleParsingError when YAML files are not found ... And update portions of code to expect the proper error. Fixes #12512	9 years ago
Toshio Kuratomi	0250beb68a	Remove compress option from paramiko connection for now ... It's not available on older versions of paramiko such as shipped in RHEL6	9 years ago
James Cammarata	12df9f2e31	Make hostvars more dynamic again to improve performance with large inventories ... Fixes #12477	9 years ago
Abhijit Menon-Sen	82b33c381f	We don't need even a token timeout here; just poll once ... The process is already gone, so there's not going to be any new data showing up on its stderr; we only want to make sure that we haven't missed something that was already written. So polling once is enough.	9 years ago
Abhijit Menon-Sen	6e82df451a	Clarify select() handling for ssh connections ... This change is motivated by an ssh oddity: when ControlPersist is enabled, the first (i.e. master) connection goes into the background; we see EOF on its stdout and the process exits, but we never see EOF on its stderr. So if we ran a command like this: ANSIBLE_SSH_PIPELINING=1 ansible -T 30 -vvv somehost -u someuser -m command -a whoami We would first do select([stdout,stderr], timeout) and read the command module output, then select([stdout,stderr], timeout) again and read EOF on stdout, then select([stderr], timeout) AGAIN (though the process has exited), and select() would wait for the full timeout before returning rfd=[], and then we would exit. The use of a very short timeout in the code masked the underlying problem (that we don't see EOF on stderr). It's always preferable to call select() with a long timeout so that the process doesn't use any CPU until one of the events it's interested in happens (and then select will return independent of elapsed time). (A long timeout value means "if nothing happens, sleep for up to <x>"; omitting the timeout value means "if nothing happens, sleep forever"; specifying a zero timeout means "don't sleep at all", i.e. poll for events and return immediately.) This commit uses a long timeout, but explicitly detects the condition where we've seen EOF on stdout and the process has exited, but we have not seen EOF on stderr. If and only if that happens, it reruns select() with a short timeout (in practice it could just exit at that point, but I chose to be extra cautious). As a result, we end up calling select() far less often, and use less CPU while waiting, but don't sleep for a long time waiting for something that will never happen. Note that we don't omit the timeout to select() altogether because if we're waiting for an escalation prompt, we DO want to give up with an error after some time. We also don't set exceptfds, because we're not actually acting on any notifications of exceptional conditions.	9 years ago
Toshio Kuratomi	03127dcfae	remove the stdin return value from connection plugin exec_command() methods ... The value was useless -- unused by the callers and always hardcoded to the empty string.	9 years ago
James Cammarata	9d47eabfa4	Merge pull request #12506 from hyperized/devel ... Add Weekday (0-6) as a number and add weeknumber (00-52)	9 years ago
Toshio Kuratomi	24b9e2e6d1	Update extras submodule ref	9 years ago
Gerben Geijteman	4c20964475	Add Weekday (0-6) as a number and add weeknumber (00-52)	9 years ago
Marius Gedminas	56f2a25bff	Python 3: there's no 'unicode'	9 years ago
Marius Gedminas	6d4618f46f	Python 3: there's no dict.iteritems()	9 years ago
Marius Gedminas	0624797375	Bugfix: if you define a custom __eq__, you must define a __hash__ too ... Also, on Python 3 the stock object.__hash__ raises an error ("unhashable type"), and we have code that uses Host instances as dict keys.	9 years ago
Marius Gedminas	a2bc6b4b26	Bugfix: if you define __eq__, you should define __ne__ too	9 years ago
Marius Gedminas	5d29a2eabd	Python 3: shlex.split() wants unicode ... On Python 2, shlex.split() raises if you pass it a unicode object with non-ASCII characters in it. The Ansible codebase copes by explicitly converting the string using to_bytes() before passing it to shlex.split(). On Python 3, shlex.split() raises ('bytes' object has no attribute 'read') if you pass a bytes object. Oops. This commit introduces a new wrapper function, shlex_split, that transparently performs the to_bytes/to_unicode conversions only on Python 2. Currently I've only converted one call site (the one that was causing a unit test to fail on Python 3). If this approach is deemed suitable, I'll convert them all.	9 years ago
Toshio Kuratomi	5d3d9cfe0d	Convert to byte strings to avoid UnicodeErrors ... Fixes #12488	9 years ago
Brian Coca	de18bcb95f	correct typo on error reporting ... fixes #12495	9 years ago
Brian Coca	6c3813ed37	added win_firewall_rule module	9 years ago
James Cammarata	65f5bed33e	Merge pull request #12493 from amenonsen/ssh-fds ... Fix typo in checking select results	9 years ago
Abhijit Menon-Sen	40f608a377	A bit more debugging output ... We used to display input chunks earlier anyway, so this isn't making things more verbose.	9 years ago
Abhijit Menon-Sen	9700d9c04f	Fix typo in checking select results ... It's possible for more than one fd to be set, so 'elif' is obviously not the right thing to use.	9 years ago
James Cammarata	1164e83477	Remove unnecessary calls to save inventory restrictions since 81bf88b	9 years ago
Toshio Kuratomi	89a78ba16e	Update submodule refs	9 years ago
James Cammarata	9e734df0ec	Conditionally poll longer if we're still waiting for an auth prompt	9 years ago
Toshio Kuratomi	5f0f5363b6	Merge pull request #12487 from mgedmin/py3k ... Fix one more failing test on Python 3	9 years ago
James Cammarata	2898e000a0	Don't use the connection timeout for the select poll timeout	9 years ago
James Cammarata	713809b62d	Merge branch 'amenonsen-ssh-indata' into devel	9 years ago
Abhijit Menon-Sen	587054db2a	Send initial data before calling select whenever possible ... Without this, we could execute «ssh -q ...» and call select(), which would timeout after the default 10s, and only then send initial data. (This is a relic of the earlier change where we always ran ssh with -vvv, so the situation where it would sit quietly never happened in practice; but this would have been the right thing to do even then.)	9 years ago
James Cammarata	c9a004227e	Improve error catching from malformed playbook data ... Fixes #12478	9 years ago
James Cammarata	e8e1d9f6fb	Apply --limit to inventory in adhoc commands ... Fixes #12473	9 years ago
Marius Gedminas	95e655eb67	Python 3: there's no basestring ... Fixes one failing test. The long series of module_utils/basic.py fixes were all because module_utils/basic is imported in ansible/inventory/script.py.	9 years ago
Marius Gedminas	2c4982b58d	Python 3: there's no itertools.imap ... Because the builtin map() acts like an iterator already.	9 years ago
Marius Gedminas	6708d56a21	Python 3: avoid long integer literals ... Even Python 2.4 automatically promotes int to long.	9 years ago
Marius Gedminas	f5d4935197	Python 3: treat python as a function in module_utils/basic.py ... NB: we can't use 'from __future__ import print_function', but luckily print(one_thing) works fine on both Python 2 and Python 3 without that.	9 years ago
Marius Gedminas	e71a986e16	Python 3: avoid octal constants in module_utils/basic.py	9 years ago