17961 Commits (c79d9a9c623cc650f92866052e6eeb6537f1cb58)

 

All Branches   

Search

Author	SHA1	Message	Date
Toshio Kuratomi	94a9ed0ee1	Set decoding of path to unicode to raise an exception if non-utf8 ... Letting it pass would just cause an error later on (no such file found) so it's better to catch it here and know that we have users dealing with non-utf8 pathnames than to have to track it down from later on.	9 years ago
Toshio Kuratomi	40373dea4d	Make all parts of messages and pathnames into unicode so that we don't get UnicodeError tracebacks. ... Note that the fix for display normalizing to unicode is correct but the fix for pathnames is probably not. Changing pathnames to unicode type means that we will handle utf8 pathnames fine but pathnames can be any sequence of bytes that do not contain null. We do not handle sequences of bytes that are not valid utf8 here. To do that we need to revamp the handling of basedir and paths to transform to bytes instead of unicode. Didn't want to do that in 2.0.x as it will potentially introduce other bugs as we find all the places that we combine basedir with other path elements. Since no one has raised that as an issue thus far so it's not something we need to handle yet. But it's something to keep in mind for the future. To test utf8 handling, create a utf8 directory and run a playbook from within there. To test non-utf8 handling (currently doesn't work as stated above), create a directory with non-utf8 chars an run a playbook from there. In bash, create that directory like this: mkdir $'\377' Fixes #13937	9 years ago
Brian Coca	742bd2c554	clarify role include paths	9 years ago
Brian Coca	a773486432	fixed exception handling to be 2.4 compatible ... previous 'fix' broke on 2.4	9 years ago
James Cammarata	1f7492171e	Don't clear start at task flag until all hosts are advanced ... Clearing the flag after the first host was advanced caused all other hosts to not advance at all. Fixes #13864	9 years ago
Brian Coca	d09c9f526b	added missed ec2_vpc_net_facts	9 years ago
Brian Coca	9f05ce3e2b	be consistent about conversion to_str	9 years ago
Brian Coca	54435261e8	updated submodule refs	9 years ago
Brian Coca	5dd2aad535	ignore exceptions in get_file_contents ... it should be common enough to not be able to read files in some jailed/container environments even though permissions tell us otherwise	9 years ago
Toshio Kuratomi	5e18bc5955	Turn results that come from traceback messages into unicode, not str. ... Fixes #13964 Fixes #13967	9 years ago
Brian Coca	11ca4e6282	Merge pull request #13934 from dlangille/dlangille-patch-2 ... Specify the correct default options for sudo_flags	9 years ago
James Cammarata	1733d434d1	Fix with loop + delegate issues ... * Don't re-use the existing connection if the remote_addr field of the play context has changed * When overriding variables in PlayContext (from task/variables), don't set the same attribute based on a different variable name if we had already previously set it from another variable name Fixes #13880	9 years ago
Brian Coca	1c9774785f	Merge pull request #13923 from slimandslam/patch-1 ... Added example of running commands on a remote Windows Server	9 years ago
Brian Coca	1c06294d24	Merge pull request #13922 from rgroten/patch-2 ... minor wording fixes	9 years ago
Toshio Kuratomi	2c512e5a63	Update submodule refs	9 years ago
Toshio Kuratomi	ded02b4968	Fix proposed by @Yannig to fix become success detection when the output is multiline ... See the Bug report for a specific error case with local connection, sudo, and the raw module Fixes #13728	9 years ago
Brian Coca	27f4730c29	correctly deals with non serializable type ... combine_vars shoudl really be data types, but some just get in in test, add dict to mock and avoid combine_vars using object	9 years ago
Brian Coca	83069a38d5	better init detection	9 years ago
James Cammarata	b5058736ce	Fix set_fact + run_once to assign variables to all hosts in the list ... Fixes #13921	9 years ago
James Cammarata	46e515131e	Allow module args as k=v pairs when using the module: option with local_action ... This task format is valid in 1.x, but was broken in 2.x: - local_action: module: shell echo "hello world"	9 years ago
James Cammarata	b769426c8f	Merge branch 'ktaragorn-patch-1' into devel	9 years ago
James Cammarata	c42484a029	Minor cleanup when reassigning play context to reused connections ... * Relocate the assignment of the host address to the remote_addr field in the play context, which was only done when the connection was created (it's now done after the post_validate() is called on the play context) * Make the assignment of the play context to the connection an else, since it's not required if the connection is not reused	9 years ago
James Cammarata	bc1bcc3419	Merge branch 'patch-1' of https://github.com/ktaragorn/ansible into ktaragorn-patch-1	9 years ago
Dan Langille	2765708450	Specify the correct default values for sudo_flags ... The correct default options for sudo_flags can be found at: https://github.com/ansible/ansible/blob/devel/lib/ansible/constants.py#L181 Slightly alter explanation of '-H' so as not to confuse it with -E, --preserve-env (which preserves existing environment variables). When adding the two other options, include short explanations of those options. Add note about '-n', which did not appear in 1.x I believe, and which bit me.	9 years ago
Dan Langille	2cde16a06c	Add correct default options for sudo_flags ... see https://github.com/ansible/ansible/blob/devel/lib/ansible/constants.py#L181	9 years ago
Toshio Kuratomi	36aa89ac7e	Fix erroneous fetch fail when fail_on_missing is set to False ... Fixes #13832	9 years ago
Chrrrles Paul	3f66f58fde	Merge pull request #13819 from chrrrles/vmware_doc_fragments ... doc fragments for vmware and vca modules	9 years ago
Ryan Groten	e6ab0daa4b	minor wording fixes	9 years ago
J Levitt	8e059d058b	Added example of running commands on a remote Windows Server ... Added example of running commands on a remote Windows Server	9 years ago
Peter Sprygada	4e5dc44289	fixes documentation string	9 years ago
Brian Coca	fd2d4e2271	Merge pull request #13919 from dkasak/patch-2 ... Fix typos.	9 years ago
Denis	4e95c9f1eb	Fix typos.	9 years ago
Brian Coca	a2a23c14ac	Merge pull request #13901 from bcoca/add_hosts_fix ... fix issue with add_hosts overwriting existing vars	9 years ago
James Cammarata	1825b4a9c7	Fix any_errors_fatal incorrect implementation in 2.0 ... Also adds that flag to blocks. Fixes #13744	9 years ago
Matt Davis	acf49cf837	Merge pull request #13569 from mattclay/apt-repository-filename ... Test for filename option in apt_repository module.	9 years ago
Toshio Kuratomi	1b82de2354	Non-newstyle modules can't use pipelining ... This is because we pass arguments to non-newstyle modules via an external file. If we pipeline, then the interpreter thinks it has to run the arguments as the script instead of what is piped in via stdin.	9 years ago
Brian Coca	cd0ad03053	Merge pull request #13902 from bcoca/update_not_blast_inventory ... overwrite/merge not remove prev inventory data	9 years ago
Brian Coca	a311872c5b	overwrite/merge not remove prev inventory data	9 years ago
Toshio Kuratomi	01e78bd39b	Merge pull request #13900 from Yannig/devel_fix_unicode_parsing_with_error ... Allow Ansible to return error with unicode within it.	9 years ago
Brian Coca	c2d314dec5	fix issue with add_hosts overwriting existing vars ... fixes github.com/ansible/ansible-modules-core/issues/2799 and is alternative to #13841	9 years ago
Yannig Perré	e5ea576461	Allow Ansible to return error with unicode within it. ... Fix for https://github.com/ansible/ansible/issues/13899	9 years ago
Brian Coca	ec95f50cb6	updated docs with new test grammer examples	9 years ago
Brian Coca	94fa9c2a7a	test aliases to enable gramatical consistancy ... keeps backwards compat by not removing the previouslly non grammer matching states and introduces new ones so user can decide which one he wants (or keep both and still be inconsistent to annoy those that care)	9 years ago
James Cammarata	abc82fee13	Fix typo in 0b86aa6	9 years ago
James Cammarata	0b86aa62e1	Hack to work around callback API change for v2_playbook_on_start	9 years ago
Brian Coca	c14eece0c6	md5 now uses smaller salt ... fixes #13891	9 years ago
Brian Coca	9d1b280689	now combine vars errors dump vars ... very hard to debug w/o knowing what vars were being merged at the time of the error	9 years ago
Toshio Kuratomi	b1a56051bd	Prevent traceback. ... https://github.com/ansible/ansible/issues/13743#issuecomment-171520585 In some circumstance, the file fails to open. When that occurs, we can't try to close it in the finally clause. Using a context manager is the cleanest way to change the code to account for that case.	9 years ago
Toshio Kuratomi	965602882a	Update submodule refs	9 years ago
Toshio Kuratomi	6c0b4bc56e	Add python-setuptools to the requirements for running ansible as ... python-setuptools contains the egginfo needed to make pkg_resources work.	9 years ago