Matt Clay
9dd3eafa14
ansible-test - Use pylint unidiomatic-typecheck
...
This replaces the regex based check previously used within the validate-modules sanity test.
NOTE: The pylint check overlaps with a similar check for pep8.
Both are used, since the pep8 based check is more nuanced than the one in pylint.
For example, allowing `is` checks, but not `==` comparisons.
If the pylint check is ignored, the pep8 check would still be relevant.
1 year ago
Matt Clay
f5c742cdfd
ansible-test - Clean up old Python 2 compat code ( #81962 )
...
* Update generated code __future__ import
* Remove Python 2.x compat from compile sanity test
* Remove __metaclass__ from pylint good names list
* Remove Python 2.x compat from ansible-test injector
* Remove Python 2.x compat from ansible-test importer
* Remove Python 2.x compat from ansible-test units
* Remove Python 2.x compat from validate-modules
* Remove Python 2.x compat from pylint plugins
* Remove more Python 2.x compat from ansible-test
* Remove Python 2.x openssl detection in ansible-test
* Remove obsolete Python 2.x comment
* Remove obsolete ansible-test Python 2.x support
* Remove unused bootstrap script functions
* Keep mypy happy
* Remove unused imports
* Keep pylint happy
1 year ago
Matt Davis
d8484f0af7
Update default test container Python to 3.12 and support for PyLint 3.0.1 ( #81953 )
...
* temporary PyLint plugin to mask 3.12 finalizer noise
* ansible-test - Default to Python 3.12 for base/default
* ansible-test - Update pylint requirements
* ansible-test - Remove obsoleted changelog entry
* Add changelog fragment for pylint work-around
1 year ago
Matt Clay
f31c287348
ansible-test - Improve compatibility with pylint 3 ( #81841 )
1 year ago
Matt Clay
f28e32c063
ansible-test - Limit deprecated check to core ( #81552 )
...
Using `# deprecated:` comment checks in collections would effectively limit those collections to a single version of ansible-core.
1 year ago
Matt Martz
6fead15334
Pylint deprecated comment checker ( #81071 )
...
Co-authored-by: Matt Clay <matt@mystile.com>
1 year ago
Matt Clay
3a1d58bc58
ansible-test - Use raise from to handle exceptions ( #80905 )
2 years ago
Matt Clay
676b731e6f
ansible-test - Replace pytest-forked ( #80525 )
...
- Unit tests now report warnings generated during test runs.
- Python 3.12 warnings about `os.fork` usage with threads (due to `pytest-xdist`) are suppressed.
- Added integration tests to verify forked test behavior.
2 years ago
Matt Martz
62211097cb
Expand pylint deprecated plugin to catch ansible.module_utils.common.warnings uses ( #80462 )
2 years ago
Matt Martz
7251938370
ansible.builtin inferred by collection_name == None ( #80446 )
2 years ago
Mark Chappell
f64e79be41
sanity tests - ignore pre-release versions for deprecation comparisons ( #79185 )
2 years ago
Matt Clay
d67b436eba
ansible-test - Improve pylint backwards compat ( #79997 )
2 years ago
Matt Clay
43487c6581
ansible-test - Enable unused-import pylint rule ( #79912 )
...
This was previously enabled for core. This change enables it for collections.
2 years ago
Matt Clay
10bc8af5a2
ansible-test - Remove auto format pylint rule ( #79985 )
2 years ago
Matt Clay
497d296ed6
Enable pylint rules to detect pointless statements ( #79944 )
...
Also instruct `git blame` to ignore the commit used to convert pointless strings to comments.
2 years ago
Matt Clay
379058e10f
Update collections.abc imports ( #79911 )
...
* Update `collections.abc` imports
- Use `six.moves` for modules and module_utils
- Use `collections.abc` for controller code
This avoids using `ansible.module_utils.common._collections_compat`,
which was added before the vendored `six` was updated to provide these
imports.
* Update _collections_compat to use six.moves
Also update the custom pylint rule to reflect this change.
2 years ago
Matt Clay
e658995760
ansible-test - Enable pylint unused-import for core ( #79910 )
2 years ago
Matt Clay
4706af58ab
ansible-test - Enable trailing-comma-tuple pylint rule ( #79909 )
2 years ago
Matt Clay
0a53309f47
ansible-test - Update pylint to 2.16.0 ( #79878 )
2 years ago
Matt Clay
cda16cc5e9
ansible-test - Improve container management. ( #78550 )
...
See changelogs/fragments/ansible-test-container-management.yml for details.
2 years ago
Matt Clay
c56b35598f
ansible-test - Upgrade pylint. ( #78727 )
...
This version of pylint now supports Python 3.11.
2 years ago
Matt Clay
ece85abbc4
ansible-test - Verify executables are executable. ( #78606 )
2 years ago
Matt Clay
69ceb31600
ansible-test - Update sanity test requirements. ( #78528 )
2 years ago
Matt Clay
89862fda3b
ansible-test - Sanity test code cleanup. ( #78497 )
2 years ago
Matt Clay
86779cc903
ansible-test - Code cleanup.
...
This helps prepare for a future pylint upgrade.
3 years ago
Matt Martz
bdf37336c8
Update pylint deprecated plugin to use ansible-invalid* symbols ( #77086 )
3 years ago
Matt Clay
5a6e05affb
More strict pylint checking of ansible-test code.
3 years ago
Matt Clay
d19b506ce8
ansible-test - Clean up future boilerplate. ( #76874 )
...
* ansible-test - Clarify need for empty __init__.py
* ansible-test - Update code-smell boilerplate.
* Update code-smell boilerplate for core.
* Update future boilerplate test for ansible-test.
All ansible-test code (except for targets) and core-specific sanity tests now use the same boilerplate.
The test also checks for unwanted `__future__` and `metaclass` boilerplate.
* Relocate target tools to the correct directory.
Several tools used on target Python versions were incorrectly placed in the controller directory.
3 years ago
Matt Clay
1932f0008b
ansible-core - Remove support for Python 2.6. ( #75853 )
3 years ago
Matt Clay
68ab92e22a
ansible-test - Remove support for Python 2.6.
...
Deferring removal of obsolete constraints until container updates are required.
3 years ago
Matt Clay
0d5a9f2138
ansible-test - More PEP 484 type hints.
3 years ago
Matt Clay
4ea8d9a782
ansible-test - split controller/target testing ( #75605 )
3 years ago
Matt Clay
99a79e1969
ansible-test - Move code from _data to _util. ( #75495 )
...
* Update paths to match relocated files.
* Update ansible-test symlink paths.
* Update path classification.
* Update MANIFEST.in
* Update sanity test context paths.
* Update sanity ignores.
* Update shebang sanity test.
* Update configure-remoting-ps1 sanity test.
* Update BOTMETA.yml to reflect new paths.
* Update paths in collection loader comments.
* Update Makefile for ansible-test.
* Update docs.
* Add changelog fragment.
3 years ago