Commit Graph

10545 Commits (c60954605b00f188e2b86c5a957ab177abd887e5)

Author SHA1 Message Date
chouseknecht df09b4f668 Set version_added 8 years ago
chouseknecht 1670d9b030 Add pull option to pull images prior to evaluating service state. 8 years ago
Kevin Kirsche db03ebdfb9 Fix typo in "ssantaize" typo
ssantaize to santaize
8 years ago
John Barker 2b82389705 General EOS documentation improvements
Typos, formatting, choices.
8 years ago
Shawn Siefkas e9bf046c26 Check mode fixes for ec2_vpc_net module (#2179)
* Check mode fixes for ec2_vpc_net module

Returns VPC object information

Detects state change for VPC, DHCP options, and tags in check mode

* Early exit on VPC creation in check mode
8 years ago
Shawn Siefkas 0b95051039 Fix #2526 (#2527)
Fail on unhandled exception in ec2_asg rather than raise
8 years ago
Shawn Siefkas 66f1f6d537 Check mode fix for ec2_group module (#2184)
The default VPC egress rules was being left in the egress rules for
purging in check mode.  This ensures that the module returns the correct
change state during check mode.
8 years ago
Michael Scherer 3c2110215c Do not hardcode default ssh key size for RSA (#4074)
By default, ssh-keygen will pick a suitable default for ssh keys
for all type of keys. By hardocing the number of bits to the
RSA default, we make life harder for people picking Elliptic
Curve keys, so this commit make ssh-keygen use its own default
unless specificed otherwise by the playbook
8 years ago
peter.jang b06f3bbb22 fix for rsync protocol (#4211) 8 years ago
John R Barker aa6a7d5789 State runnng v running
Fix typo
8 years ago
Matt Clay c2270a37ff Enable FreeBSD tests on Shippable. (#4296) 8 years ago
Rick Mendes be33879152 Fixes #4227: just changing messaging 8 years ago
Rick Mendes eae75cf727 Fix #3549, failure to reference `module` in `ec2_eip` module 8 years ago
David Chwalisz f979928ecc file module: add clarification on state=absent re files that do not exist. 8 years ago
Christian Schwarz e526b2ad3d system/service.py: fix false-positive service enablement on FreeBSD. (#4283)
sysrc(8) does not exit with non-zero status when encountering a
permission error.

By using service(8) `service <name> enabled`, we now check the actual
semantics expressed through calling sysrc(8), i.e. we check if the
service enablement worked from the rc(8) system's perspective.

Note that in case service(8) detects the wrong value is still set,
we still output the sysrc(8) output in the fail_json() call:
the user can derive the exact reason of failure from sysrc(8) output.
8 years ago
Lyle Mantooth f57ece661f Remove file extension from policy names (#3805)
Fixes #3804.

Prevents `__file__` from contributing ".", which is an illegal character in ELB policy names.
8 years ago
Julien Vey 7ba3ba2da9 Fix Typo in docker_image_facts module 8 years ago
Monty Taylor f441e2c1a9 Rename a confusing variable
I had to read the two lines in question twice. That might just make me
dumb, but if I'm dumb, someone else might be too.
8 years ago
Rick Mendes 4fad93561a please remove me as maintainer 8 years ago
Rick Mendes d6cc007380 Fixes #4227 8 years ago
Jasmine Hegman f5c3f4dd6b Update docs to indicate ec2_asg state defaults to present (#4046)
* Update docs to indicate ec2_asg state defaults to present

Hopefully fixes Issue #4016

* Forgot to flip required to false
8 years ago
Matt Clay df5869df4a Enable Windows tests on Shippable. (#4278) 8 years ago
Shaun Brady 7b8d625546 Make ec2_elb_lb respect VPCs when resolving groups
AWS security groups are unique by name only by VPC (Restated, the VPC
and group name form a unique key).

When attaching security groups to an ELB, the ec2_elb_lb module would
erroneously find security groups of the same name in other VPCs thus
causing an error stating as such.

To eliminate the error, we check that we are attaching subnets (implying
that we are in a VPC), grab the vpc_id of the 0th subnet, and filtering
the list of security groups on this VPC.  In other cases, no such filter
is applied (filters=None).
8 years ago
Shaun Brady 3b32b60338 Remove trailing white space 8 years ago
Shaun Brady 04199140c5 Make group_name resolution VPC aware
EC2 Security Group names are unique given a VPC.  When a group_name
value is specified in a rule, if the group_name does not exist in the
provided vpc_id it should create the group as per the documentation.

The groups dictionary uses group_names as keys, so it is possible to
find a group in another VPC with the name that is desired.  This causes
an error as the security group being acted on, and the security group
referenced in the rule are in two different VPCs.

To prevent this issue, we check to see if vpc_id is defined and if so
check that VPCs match, else we treat the group as new.
8 years ago
Rob Phoenix 6339398e7c various typo corrections to ios network modules 8 years ago
John Baublitz fe09641476 Doc update 8 years ago
John Baublitz c8dc0bf5c9 Fix exception handling to be compatible with Python 3 8 years ago
John Baublitz 4b11312737 Additional error handling for corner cases like deleting networks with active subnetworks 8 years ago
John Baublitz e4697c3780 Documentation 8 years ago
John Baublitz 96599a5963 Logic to allow subnet creation 8 years ago
John Baublitz 5591e6bb0b Add error handling for specifying 'mode' with insufficiently recent libcloud 8 years ago
John Baublitz 9c9b22dc8f Changes to allow 'auto' mode which does not allow IP address specification 8 years ago
John Baublitz 839871d87b Support for newer networking modes in GCE 8 years ago
Brian Coca 7f1e6ca005 updated docs to reflect new feature 8 years ago
Ryan 8b582cceaa fix typo in azure_rm_storageaccount (#4236) 8 years ago
Brian Coca d579dab0a0 deprecated accelerate 8 years ago
chrisweaver 531954e2f6 Enforce boolean type for dup_ok
Stop "choices" from being interpreted as strings.
8 years ago
Toshio Kuratomi 879afebf77 Remove git and synchronize modules from list of commands we want users to use the module for instead. (#4233) 8 years ago
Matthew Martin 4d952d6e6e Add CAPABILITY_NAMED_IAM to cloudformation capabilities
While from the documentation[1] one would assume that replacing
CAPABILITY_IAM with CAPABILITY_NAMED_IAM; this as empirically been shown
to not be the case.

1: "If you have IAM resources, you can specify either capability. If you
have IAM resources with custom names, you must specify
CAPABILITY_NAMED_IAM."
http://docs.aws.amazon.com/AWSCloudFormation/latest/APIReference/API_CreateStack.html
8 years ago
Michael Baydoun 3818cc2b95 fixes issues where iam_policy incorrected reported changed 8 years ago
John Baublitz 906b457bf1 Collapse boilerplate code into change_instance_state function 8 years ago
John Baublitz eb97165acc Add states for stopping and starting machines 8 years ago
Tom Melendez 067bb6ec01 Added helper function and logic to sort attributes before comparing. 8 years ago
Kai Kousa 4a8a052e2e Improve documentation on security_groups-option 8 years ago
Tom Melendez 8becd9a14d Allow GCE firewall rules to be updated when attributes changes. Fixes #2111.
Previously, when the attributes of a GCE firewall change, they were ignored.  This PR changes that behavior and now updates them.

Note that the "update" also removes attributes that are not specified.

An overview of the firewall rule behavior is as follows:

1. firewall name in GCP, state=absent in PLAYBOOK: Delete from GCP
2. firewall name in PLAYBOOK, not in GCP: Add to GCP.
3. firewall name in GCP, name not in PLAYBOOK: No change.
4. firewall names exist in both GCP and PLAYBOOK, attributes differ: Update GCP to match attributes from PLAYBOOK.
8 years ago
yfried-redhat b1ee47f358 Make os_floating_ip module idempotent
Current module fails when tries to assign floating-ips to server that
already have them and either fails or reports "changed=True" when no
ip was added

Removing floating-ip doesn't require address

Server name/id is enough to remove a floating ip.
8 years ago
Andrei Lukovenko 436ff356e7 Bug: repeatable invocation with state=present leads to (#3052)
[localhost]: FAILED! => {"changed": false, "failed": true, "msg":
"'Domain' object has no attribute 'id'"}

How to reproduce:

- name: create domain
  digital_ocean_domain: state=present name=DOMAIN_NAME ip=DROPLET_IP

- name: create domain
  digital_ocean_domain: state=present name=DOMAIN_NAME ip=DROPLET_IP

Problem: DigitalOcean API changed API
(https://developers.digitalocean.com/documentation/v2/#list-all-domain-records)
8 years ago
Brian Coca 544b044129 stop trying to set permissions in check mode
fixes #4195
8 years ago
Brian Coca 498dc61154 documenting behaviour as clear as possible 8 years ago
Toshio Kuratomi 0364831c22 Remove version-added on name field.
This parameter was actually added in 2.0.  It's just that the
documentation in previous versions of the module were wrong (it said the
name was  "network" rather than "name.)  I've renamed the parameter in
the documentation of prior versions so ansible-module-validate should no
longer think that this is a new parameter.
8 years ago
Peter Sprygada 42da47813b adds update_config argument to ios_config
New argument controls whether or not configuration is applied to the
remote device.
8 years ago
Peter Sprygada 4611e2b9ad initial add of new module vyos_config
New module for sending configuration commands to remote devices running
the VyOS operating system.
8 years ago
Peter Sprygada cff91c4c3b initial add of new module vyos_facts
* adds collection of default facts
* adds collection of configuration facts
* adds collection of lldp neighbors
8 years ago
Ryan S. Brown 9336e0d070 Indent `unarchive` module documentation to fix parsing error. 8 years ago
tobixx ed1d80b7d8 added read-/write-/executeable flags for invoking user (#4130) 8 years ago
James Cammarata aa1e9e3d5f Add remote_src param for unarchive to deprecate `copy` param
From ansible/ansible#10218
8 years ago
Peter Sprygada 92ac734e13 initial commit of vyos_command module
This adds a new module, vyos_command for sending CLI commands to remote
devices running VyOS operating system.
8 years ago
Peter Sprygada 25294f40c8 bug fix in ios_config module for handling config contents
Config contents when passed via argument were returning a string but
the module expects an instance of NetworkConfig.  This fixes that
problem.
8 years ago
Jan Hutař 5eb4e0dd0d Add way to specify environment (#3453) 8 years ago
h-hirokawa 57921c0b4d Fix azure_rm_virtualmachine (#4174). 8 years ago
Chris Houseknecht c91de38322 Entrypoint fails with 'command not found' error. 8 years ago
Chris Houseknecht 7ffa6a43c5 Add push parameter. Let API handle registry authentication check. 8 years ago
Chris Houseknecht 4002caf60e Fix module failing when no ports are exposed 8 years ago
jjshoe d8b752b3cf Fixed a typo (#4168) 8 years ago
Richard Levenberg 4943d329a4 handle multiple winrm listeners (#4142)
* handle multiple winrm listeners

* use the sorterd array
8 years ago
Marcos Diez f10413b919 better authorized_keys documentation (#3739) 8 years ago
Peter Sprygada 43ba7f3b3b removes unneeded check_args function from ios_command
The module would raise a KeyError trying to find the save_config key
which is not present in the argument_spec.  This was caused by the
check_args() function.  Since the ios shared argument spec isn't used
the check_args function is not needed and has been removed.
8 years ago
Chris Houseknecht 030dcccad4 Fix multi-interface port binding. 8 years ago
Chris Houseknecht bd3e1c77fe Add cleanup parameter. (#4144) 8 years ago
Peter Sprygada 438b9328ea fixup ios_template module to use NetworkModule
This removes the get_module() factory function and directly creates
an instance of NetworkModule.  This commit includes some minor clean
up to transition to the ios shared module for 2.2
8 years ago
Chris Houseknecht 7515b2d563 Fix 'all' option for published_ports parameter. 8 years ago
David Shrewsbury 37edf33955 Fix bug in os_router.py when router is not actually updated. (#4107)
The shade update_router() call will return None if the router is
not actually updated. This will cause the module to fail if we
do not protect against that.
8 years ago
Brian Coca 72eaf0281a updated checkmode for update-rc.d
fixes #4146
8 years ago
Chris Houseknecht dc496ffeb4 Fix purge_networks 8 years ago
Peter Sprygada 66268dd3ec fix up ios_command to use NetworkModule
* using check mode will now block all commands except show commands
* module will no longer allow config mode commands
* check args for unused values and issue warning
8 years ago
Qi Luo b86a229b61 Fix getting actual_stdin_open 8 years ago
Peter Sprygada 5fe848fca2 refactor ios_config for network module
This refactors the ios_config module to use the network module added
in 2.2 to simplify common network functions

new features

* add src, dest arguments for working with config
* results now return flag if the config was saved or not
* adds append argument for updating the dest file (when dest is used)
8 years ago
Rene Moser 5e3249b244 os_server, doc: add version added for delete_fip
Also see #3509
8 years ago
David Shrewsbury 530fd1365a Allow os_server to delete FIP (#3509)
The os_server module could automatically generate a floating IP for
the user with auto_ip=true, but we didn't allow for this FIP to be
automatically deleted when deleting the instance, which is a bug.
Add a new option called delete_fip that enables this.
8 years ago
Andrei Lukovenko 85bd975238 Bug: invocation with state=absent always leads to (#3051)
[localhost]: FAILED! => {"changed": false, "failed": true, "msg":
"'Domain' object has no attribute 'id'"}

How to reproduce:

- name: create domain
  digital_ocean_domain: state=present name=DOMAIN_NAME ip=DROPLET_IP

- name: destroy domain
  digital_ocean_domain: state=absent name=DOMAIN_NAME

Problem: DigitalOcean API accepts domain name, not record ID
(https://developers.digitalocean.com/documentation/v2/#delete-a-domain)
8 years ago
Adrian Moisey 28716f565c Add default port for aurora (#4102)
If a port isn't specified, it's looked up. The lookup breaks without
this.

Related: https://github.com/ansible/ansible-modules-core/pull/3414
8 years ago
Peter Sprygada 28a701128d update ios_facts module to use NetworkModule
minor update to ios_facts to remove get_module() in favor of NetworkModule
8 years ago
jctanner d5b35eb8db add gather_timeout parameter (#4093) 8 years ago
James Cammarata 2aad8bd882 Removing erroneous import from async_status 8 years ago
James Cammarata 204e83aeed Ensure async wrapper and status return consistent fields 8 years ago
Matt Clay 72cd76e023 Enable IRC and Slack notifications on Shippable. 8 years ago
Matt Clay a7bef31ab3 Run each integration test separately. 8 years ago
Matt Clay 1b69cff1a4 Initial support for module integration tests. 8 years ago
Dag Wieers 017eeaea29 Fix a problem where the newly provided mode is a string (#3769)
* Fix a problem where the newly provided mode is a string

This fixes #3597

* Implement python3-compatible get_exception() handling
8 years ago
Dag Wieers 855ca9b204 Revert PR #3575 since it causes problems related to exclude patterns (#3767)
* Revert PR #3575 since it causes problems related to exclude patterns

By using a different method for getting archive filelists, and extracting we introduced new problems related to excluding based on gtar patterns.

As a result files that would be excluded by gtar, would still be in the filelist. Implementing our own gtar compatible pattern exclusion mechanism is near to impossible (believe me, we looked at it...). The best way is to look at the original problem and deal with that, and ensure that extraction and filelists are done with the exact same tool and exact same options.

The solution is to decode the octal unicode representation in gtar's output back to unicode. Since gtar has no problem extracting these files in LANG=C, we simply has to compensate for it.

This reverts #3575 and fixes #11348.

* Implement codecs.escape_decode() instead of decode("string_escape") for python3
8 years ago
Chris Houseknecht a8059c68d0 Remove object name validation. 8 years ago
Brian Coca b55fd5f67a updated set_fact docs with note about typing 8 years ago
nitzmahone b51a1e175e minor win_template doc corrections 8 years ago
Brian Coca ad996f162b name was the issue, not pkg 8 years ago
Brian Coca d8e91f01b0 protect another portion against None name 8 years ago
Brian Coca 506e6ff2e2 another fix for None in name 8 years ago
Brian Coca c871f488eb avoid traceback when name is None 8 years ago
Robin Roth 5d928ca13c Fix git shallow update (#3912)
* remove unused variables

* fetch branch name instead of HEAD

fix #3782, which was introduced by f1bacc1d3f

* disable git depth option for old git versions

fixes #3782
git support for `--depth` did not fully work in old git versions (before 1.8.2)
fall back to full clones/fetches on those versions

* raise required git version to 1.9.1 for depth option

* use correct depth argument in switch_version
8 years ago
Christian Schwarz e25cb4df77 service module: use sysrc on FreeBSD (#4042)
* service module: use sysrc on FreeBSD

sysrc(8) is the designated userland program to edit rc files on FreeBSD.

It first appeared in FreeBSD 9.2, hence is available on all supported
versions of FreeBSD.

Side effect: fixes #2664

* Incorporate changes suggested by bcoca.

- Use `get_bin_path` to find sysrc binary.
- Only use sysrc when available (support for legacy versions of FreeBSD)
8 years ago