Commit Graph

20273 Commits (c2cc6e4ac8f17a2cd0edeb7ed8e6fc4871380e9e)

Author SHA1 Message Date
Chris Houseknecht c2cc6e4ac8
Add compatibility for docker-py version 3 (#36973) (#37071) 8 years ago
Trishna Guha 5ec5c05f0d
remove unused tx_rate and rx_rate from vyos_interface (#37062) (#37064)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 5f3feac7fa)
8 years ago
John R Barker e03b17e2e5
filesystem: fix documentation (#36556) (#36633)
(cherry picked from commit 07927f52ae)
8 years ago
Trishna Guha f48d636500
Fix n3k separate to combined image upgrade (#37017) (#37055)
* Fix n3k separate to combined image upgrade

* Address review comments

(cherry picked from commit 51e8eab9db)
8 years ago
Ganesh Nalawade bbf27efe06
Fix eos integration test failures (#37020) (#37054)
Fixes #36919

Fix other eos modules integration test failure in dci
(cherry picked from commit ba3201cd2f)
8 years ago
Toshio Kuratomi 38a498bcfd
Bkprt py3 maven artifact (#37041)
* Python3 issues in maven_artifact (#37035)

Fixes #33761

(cherry picked from commit 1bc860fafd)

* Add a changelog for the python3 maven_artifact fix
8 years ago
Ryan Petrello 422e4aa310 properly pass /api/v1/ credential fields for older Towers (#36917)
(cherry picked from commit 0e7106b106)
8 years ago
Ryan Petrello ee4578c4cd properly detect the absence of credential_type in older tower-cli (#36908)
(cherry picked from commit a82043939b)
8 years ago
Ryan Petrello f0e65cb05a tower cred: support credential kind/type for /api/v1/ and /api/v2/ (#36662)
older versions of Tower (3.1) don't have a concept of CredentialTypes
(this was introduced in Tower 3.2).  This change detects older versions
of pre-3.2 tower-cli that *only* support the deprecated `kind`
attribute.

(cherry picked from commit 641f8b4ef6)
8 years ago
Ryan Petrello 644b116848 tower cred: update kind options in documentation
(cherry picked from commit 8a41233202)
8 years ago
Ryan Petrello 86cc8ae591 tower cred: filter user name lookup by the proper key
(cherry picked from commit cd6855275e)
8 years ago
Ryan Petrello 1a412d49bf tower cred: implement credential /api/v1/ kind compatability
(cherry picked from commit 9cb4b70e27)
8 years ago
Thierry Bouvet 8cc9abcd75 Fix credentials for Tower API V2
(cherry picked from commit 640749d54f)
8 years ago
Toshio Kuratomi 9711c60b01
Bkprt py3 znode (#37038)
* fix python3 compatibility for znode module

kazoo client requires bytes and not string

(cherry picked from commit 2d98a2de68)
8 years ago
Nathaniel Case a3f96ec4af
ios_static_route idempotence fix (#35912) (#37012)
* Remove default admin_distance and fix the idempotence thereof

Fixes #33290

* Fix tests and use yaml anchors to shorten tests

* Add test for undefined admin_distance

* Read config from `show run` if `show ip static route` fails

* Restore flags to ios.get_config &  use get_config where appropriate

(cherry picked from commit 7016b3b9ca)
8 years ago
Nathaniel Case 639f7b569a
Move _start_connection() to module_utils/connection and fix Popen() call (#36249) (#37005)
* Fix Popen() call to use ansible python

* Remove PATH searching, reuse location of ansible instead

(cherry picked from commit 0feea66988)
8 years ago
John R Barker 36566e62a7
Fix_regex (#36569) (#37002)
(cherry picked from commit 4021194532)
8 years ago
Trishna Guha 2cd49b4ab0
eos_static_route fix (#36903) (#36933)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit ef7f3fcab6)
8 years ago
Ganesh Nalawade 3e123d8298
map network_os to ncclient device_params (#36819) (#36913)
* map network_os to ncclient device_params

Fixes #36786

* update device map

* Add default netconf fallback plugin

(cherry picked from commit b12e90311f)
8 years ago
Ganesh Nalawade dce80b1364
Fix junos_command py3 related issues (#36782) (#36895)
Fixes #36204

*  tostring() input string shoulb be in byte string format
*  to_ele() input is required in unicode format
(cherry picked from commit 41d75783b5)
8 years ago
Trishna Guha f3653747bb
Fix nxos_interface multiple issues (#36827) (#36891)
* fix interface_type

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix setting mtu, doc for state check param, doc for params applicable for ethernet intf

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* speed idempotence and add unittest

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fabric_forwarding_anycast_gateway applicable for svi type intf only

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix speed

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 2fbfce06e7)
8 years ago
Chris Houseknecht 5c65fa3e00 Convert key to snake. Fixes #36845. (#36887) 8 years ago
John R Barker f5684acee5
Updated the documentation of modules to match argspec including the type setting for bool parameters (#36821) (#36860)
(cherry picked from commit 60e39b9718)
8 years ago
John R Barker 8040168c4f
aws_ssm_parameter_store module - value parameter should be no_log since it's often a secret (#36843) (#36859)
(cherry picked from commit 3f19ef680a)
8 years ago
Ondra Machacek 3257fe28f3 Fixes for oVirt modules (#36846)
* ovirt_vms: Fix boot devices idempotence

* ovirt_host_networks: Fix removing the label

* ovirt_vms: Fix NoneType in placement policy check

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1549082

* int("255.255.255.0" does not work, fixes issue #33867 (#36271)
8 years ago
John R Barker d4252c89e9
nso_config break cycles in dependency sorting (#36828) (#36838)
False assumption that values can not have cyclic dependencies. Fix by
removing dependency on self and look for cycles, if found remove
dependency to get a partial sort done.
(cherry picked from commit 042c111563)
8 years ago
Trishna Guha fb630c926a
nxos_facts fix and integration tests (#36796) (#36820)
* fix nxos_facts ipv6 error

* time_range not supported for N35

(cherry picked from commit db43fe6a76)
8 years ago
John R Barker 19ea7bcdd8
nso_config work around ordering issues (#36774) (#36785)
Include dependencies when sorting entries to avoid issues with certain
versions of NSO.
(cherry picked from commit e75989ec88)
8 years ago
John R Barker 99f4e016bb
Added extra choice floppy for bootdev option in ipmi_boot module (#36174) (#36784)
(cherry picked from commit 52627f3fa0)
8 years ago
Julien Vey 9e9f910cb6 ec2_group:documentation explicit a behaviour for sg rules (#36627) 8 years ago
Peter Sprygada b86f07324e fix cliconf get_config method to match base signature (#36682)
This commit fixes up the get_config method to match the minimum method
signature as defined by the base class.  Without this patch, the
get_config method calls will fail in some cirumstances.

(cherry picked from commit fb6a8c0133)
8 years ago
René Moser eb12520854
cs_sshkeypair: fix ssh key rename (#36726) (#36730)
* tests: cs_sshkeypair: add reproducer for failed key rename

* cs_sshkeypair: fix rename ssh key

(cherry picked from commit cdb2969703)
8 years ago
John R Barker 5052db2698
NSO ValueBuilder improvements. 4.5 leaf-list compatability. (#36583) (#36735)
Fix issues in ValueBuilder used in nso_config and nso_verify so that it
can handle leaf-list in NSO 4.5 and detect identityref types from
unions.

Fail gracefully if a type is not found.
(cherry picked from commit 2789cc5c09)
8 years ago
John R Barker d67d19bc1f
Backport/2.5/36722 (#36733)
* Fix sanity checks in OpenStack docs fragment (#36722)

Signed-off-by: Mário Santos <mario.rf.santos@gmail.com>
(cherry picked from commit 8b52006d5c)
8 years ago
Peter Sprygada 0aa62a54cd allows ib_spec attrs to be filtered in update (#36673)
* allows ib_spec attrs to be filtered in update

This change will allow the ib_spec entries to be be filtered on a change
object by setting the update keyword to false.  The default value for
update is true.  When the update keyword is set to false, the keyed
entry will be removed from the update object before it is sent to the
api endpoint.

fixes #36563

* fix up pep8 issues

(cherry picked from commit 93b795baf0)
8 years ago
Trishna Guha b1bdc5dae2
nxos_vlan, nxos_linkagg fix (#36711)
* fix nxos_vlan aggregate (#36710)

* fix nxos_vlan aggregate

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 44332bda78)

* nxos_linkagg fix (#36706)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit d6912cf40e)
8 years ago
Ganesh Nalawade d60eac9bc4
Decouple config and state check in vlan and vrf network modules (#36386) (#36704)
* Decouple config and state check in {network_os }_vlan and { network_os }_vrf modules

Fixes #35567
Fixes #34754

`interfaces` option is used for configuration as well as operational state
check. If interface is configured to given vlan or vrf but if
operational state of interface is disabled it results in module failure.

Fix is to decouple same option usage for config and state.
With this fix `interfaces` is used as config option and a new
option named `associated_interfaces` will be used for intent check
for assigned interfaces.

* Fix CI failures

* Fix review comment

* Fixed integration test failure

(cherry picked from commit 5a6b893240)
8 years ago
Ed Costello b717765d59 Fix documentation of validate_certificates option in aws doc_fragment.
Unignore sanity test failures for AWS modules caused by this common
fragment.

(cherry picked from commit 2a0c7c4331)
8 years ago
Matt Davis e77c1b9e42 New release v2.5.0rc1 8 years ago
Matt Davis 2ddcdb8720 Revert "Add force option to systemd module (#35925)"
(mistaken cherry pick)

This reverts commit 9935cda4a3.
8 years ago
Dag Wieers 917e5ae5d8 Improve convert_bool error message
The error message as it was confused me when the value was 'enabled' and
there was also a module parameter named 'enabled'.

    enabled is not a valid boolean.  Valid booleans include: yes, on, 1, true, ...

So by clearly describing it as a value, the confusion would have been
avoided.

    The value 'enabled' is not a valid boolean.  Valid booleans include: yes, on, 1, true, ...

(cherry picked from commit 487cf0ee8d)
8 years ago
Matt Davis ed9781bbfb
Do not cache the loop item label so that it will update with each item (#36609)
Add integration test for #36430 (#36432)

(cherry picked from commit d1f76939e5)
(cherry picked from commit 9fced4f0a9)
8 years ago
Jordan Borean f8d8d84f05 Win feature error cp (#36559)
* win_feature: better error handling to make it easier to debug issues (#36491)

* win_feature: better error handling to make it easier to debug issues

* removed ignroed pslint rules that are no longer needed

(cherry picked from commit ef4f8851dc)

* Added changelog for win_feature error handling fix
8 years ago
Chris Houseknecht 7e378e791c
Bump OpenShift client req to 0.4.3. Fixes openshift_scale. (#36580) 8 years ago
Abhijeet Kasurde 980b6a00e2 Fixup VMware module docs issues (#36409) (#36523)
Fix various argspec vs documentation issue

(cherry picked from commit 5d0ed38e3a)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
8 years ago
Ryan Brown c4e94af4e9 [cloud] catch NoCredentialsError in boto3_conn (#36545) 8 years ago
Toshio Kuratomi e93cc41211
Bp 2.5 ansible interpreter py3 (#36561)
* Fix types when evaluating interpreter (#36541)

* Fix types when evaluating interpreter. Fixes #36536
* Rename variables that contain bytes to b_*
* Get rid of to_text() and to_bytes() calls that do nothing (because the
  data is already the proper type)

(cherry picked from commit a4df4d33ac)

* Changelog entry for the ansible_*_interpreter fix
8 years ago
Sam Doran 84debca5fb Check for regexp match when using insertbefore or insertafter (#36474) (#36552)
Add tests to cover this scenario
Add changelog fragment
Fixes #36156

(cherry picked from commit 723daf3e3a)
8 years ago
mikedlr 26cdfd84a0 Bring aws_ssm None fixes into stable (from #36456) (#36492)
* aws ssm parameter lookup - change to reutrn Nones for missing variables

* aws ssm parameter lookup - fix error case message to dump response

* aws ssm parameter lookup - fix integration test cases
8 years ago
Julien Vey 7965ecb962 efs: improve documentation about the update of an efs (#36473)
(cherry picked from commit 3abaa43b1c)
8 years ago