1089 Commits (c267e1906ea0728caa92666e7edaeb99e7df759c)

Author	SHA1	Message	Date
Abhijit Menon-Sen	88a20e7a20	Fix broken integration test with unicode hostnames ... 1. The test did "name: '{{hostnames}}.{{item}}'" inside a with_sequence loop, which didn't do what was intended: it expanded hostnames into an array, appended ".1", and set name to the resulting string. This can be converted to a simple with_items loop. 2. Some of the entries in hostnames contained punctuation characters, which I see no reason to support in inventory hostnames anyway. 3. Once the add_host failures are fixed, the playbook later fails when the unicode hostnames are interpolated into debug output in ssh.py due to an encoding error. This is only one of the many places that may fail when using unicode inventory hostnames; we work around it by providing an ansible_ssh_host setting.	9 years ago
Abhijit Menon-Sen	7479ab47e0	Be stricter about parsing hostname labels ... Labels must start with an alphanumeric character, may contain alphanumeric characters or hyphens, but must not end with a hyphen. We enforce those rules, but allow underscores wherever hyphens are accepted, and allow alphanumeric ranges anywhere. We relax the definition of "alphanumeric" to include Unicode characters even though such inventory hostnames cannot be used in practice unless an ansible_ssh_host is set for each of them. We still don't enforce length restrictions—the fact that we have to accept ranges makes it more complex, and it doesn't seem especially worthwhile.	9 years ago
Abhijit Menon-Sen	065bb52109	Be systematic about parsing and validating hostnames and addresses ... This adds a parse_address(pattern) utility function that returns (host,port), and uses it wherever where we accept IPv4 and IPv6 addresses and hostnames (or host patterns): the inventory parser the the add_host action plugin. It also introduces a more extensive set of unit tests that supersedes the old add_host unit tests (which didn't actually test add_host, but only the parsing function).	9 years ago
Marius Gedminas	f91b28ef23	Fix safe_eval() of set literals ... There was code to support set literals (on Python 2.7 and newer), but it was buggy: SAFE_NODES.union() doesn't modify SAFE_NODES in place, instead it returns a new set object that is then silently discarded. I added a unit test and fixed the code. I also changed the version check to use sys.version_tuple instead of a string comparison, for consistency with the subsequent Python 3.4 version check that I added in the previous commit.	9 years ago
Brian Coca	5809a2e81d	Merge pull request #12299 from resmo/feature/test_cs_user ... cloudstack: new integration test role test_cs_user	9 years ago
James Cammarata	444987cde6	Fix unit test for plugins after basedir/push_basedir removal	9 years ago
Rene Moser	f6382a160d	cloudstack: new integration test role test_cs_user	9 years ago
Toshio Kuratomi	e2c49b4ef4	Fix problem with "=" in the initial file path.	9 years ago
Toshio Kuratomi	3a50393cf7	Merge pull request #12269 from mgedmin/py3k ... Python 3: fix TypeError: unorderable types in test	9 years ago
Toshio Kuratomi	c1039de70c	Compatibility with six-1.3.0	9 years ago
James Cammarata	ac6f61ec7f	Properly handle group/host_var files with dots in them ... Fixes #12245	9 years ago
Marius Gedminas	c22f4ee697	Add a comment explaining why async = 1 in the test	9 years ago
Marius Gedminas	1a1c9203e2	Python 3: fix TypeError: unorderable types in test ... The full error was ====================================================================== ERROR: test_task_executor_execute (units.executor.test_task_executor.TestTaskExecutor) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/mg/src/ansible/test/units/executor/test_task_executor.py", line 252, in test_task_executor_execute mock_action.run.return_value = dict(ansible_facts=dict()) File "/home/mg/src/ansible/lib/ansible/executor/task_executor.py", line 317, in _execute if self._task.async > 0: TypeError: unorderable types: MagicMock() > int() ---------------------------------------------------------------------- Experiments show that Python 2 MagicMock() > 0 is true, so I'm setting the async property on mock_task to 1. (If I set it to 0, the test fails anyway.)	9 years ago
James Cammarata	ff9f5d7dc8	Starting to add additional unit tests for VariableManager ... Required some rewiring in inventory code to make sure we're using the DataLoader class for some data file operations, which makes mocking them much easier. Also identified two corner cases not currently handled by the code, related to inventory variable sources and which one "wins". Also noticed we weren't properly merging variables from multiple group/host_var file locations (inventory directory vs. playbook directory locations) so fixed as well.	9 years ago
Brian Coca	c17fbf2f12	simplify become testing and handling, we had drifted and were doulbe checking prompt, become and become_pass ... fixed tests to conform to new signature and now tests both with and w/o password now we are more explicit about self.prompt	9 years ago
Toshio Kuratomi	e218bf8da9	Do not escape backslashes when processing a template file. ... Fixes #12198 Fixes #12241	9 years ago
James Cammarata	b2cb3153f1	Fix unit tests for PlayIterator changes regarding fact gathering	9 years ago
Marius Gedminas	a32bf1ec18	Simplify FactCache.copy() ... Also fix the bug (missing from six import iteritems) I introduced in 823677b490.	9 years ago
Marius Gedminas	823677b490	Replace .iteritems() with six.iteritems() ... Replace .iteritems() with six.iteritems() everywhere except in module_utils (because there's no 'six' on the remote host). And except in lib/ansible/galaxy/data/metadata_template.j2, because I'm not sure six is available there.	9 years ago
Toshio Kuratomi	1b64702b9a	Fix templar unittests for change in preserve_trailing_newline parameter's default value	9 years ago
James Cammarata	45aac6a739	Adding unit tests for safe_eval	9 years ago
James Cammarata	843138e7d9	Merge pull request #12202 from mgedmin/py3k ... Use rich comparisons for Attribute and FieldAttribute	9 years ago
Toshio Kuratomi	9ecfc30f9a	* Mark all strings as unicode -- shouldn't matter for this dataset but ... ansible is passing unicode arond internally so we should test the same data. * Add a zero length test for _count_newlines and fix the zero newlines test to have no newlines.	9 years ago
Toshio Kuratomi	417bf1c805	Unittest the _count_trailing_newlines function	9 years ago
Brian Coca	a7231c2203	actually implemented flags correctly for all priv escalation methods	9 years ago
Brian Coca	14f061d5ea	fixed become tests	9 years ago
Marius Gedminas	33a374edde	Use rich comparisons for Attribute and FieldAttribute ... Because __cmp__ is not supported on Python 3.	9 years ago
Toshio Kuratomi	aeff960d02	Cleanup combine_vars ... * Dedupe combine_vars() code (removed from VariableManager) * Fix merge_hash algorithm to preserve the type * unittest combine_vars and merge_hash	9 years ago
Toshio Kuratomi	7f5080f64a	Fix backslash escaping inside of jinja2 expressions ... Fixes #11891	9 years ago
James Cammarata	ccaf47bd97	Fix unit tests broken by 057712c1	9 years ago
Brian Coca	514fa73fcd	galaxy fixes	9 years ago
Marius Gedminas	c846bab69b	Fix assert statement syntax ... `assert (condition, message)` gets parsed by Python as `assert a_two_tuple`, and a 2-element tuple is never False. Discovered by compileall on Python 3.4, which emits a SyntaxWarning for this common mistake.	9 years ago
Marius Gedminas	709dbbc7db	Use 0oNNN octal syntax in test/	9 years ago
Marius Gedminas	727cb8a917	Support print() function in test/	9 years ago
Marius Gedminas	9ae66a7f5c	Use 'except ... as' syntax in contrib/ and test/ too	9 years ago
Abhijit Menon-Sen	4f3a98eff6	Update Vault tests to make sure AES decryption works ... Note that this test was broken in devel because it was really just duplicating the AES256 test because setting v.cipher_name to 'AES' no longer selected AES after it was de-write-whitelisted. Now that we've removed the VaultAES encryption code, we embed static output from an earlier version and test that we can decrypt it.	9 years ago
Abhijit Menon-Sen	b84053019a	Make the filename the first argument to rekey_file	9 years ago
Abhijit Menon-Sen	c4b2540ecc	Update tests for VaultEditor API changes	9 years ago
James Cammarata	601a1cc6d9	Multiple fixes for include statements and blocks in general ... Fixes #11981 Fixes #11995 Fixes #12039 Fixes #12077	9 years ago
Toshio Kuratomi	9f9891df2c	Add unicode characters to the data that we're testing that ansible-vault can decrypt	9 years ago
Toshio Kuratomi	56ae3a032f	Merge pull request #12075 from ansible/fix-vault-unicode ... Unicode and other fixes for vault	9 years ago
Toshio Kuratomi	a3fd4817ef	Unicode and other fixes for vault	9 years ago
Brian Coca	846f0b0510	changed no_log expected type to new value	9 years ago
Brian Coca	3e13dfd7e8	used stdoutlines list to avoid string mismatches ... added block environment test	9 years ago
Brian Coca	efa005c228	added names to assert tasks for easier debugging	9 years ago
Brian Coca	d6a1cbeefb	corrected varname that started with number and broke templating	9 years ago
Brian Coca	104b8a9a7b	avoid hostvars which is not a dict	9 years ago
Brian Coca	857d74a274	made diff ignore whitespace	9 years ago
Brian Coca	6da2587c36	Merge pull request #12058 from resmo/for-ansible ... cloudstack: more integration tests and updates	9 years ago
James Cammarata	db65503778	Revert "Add PowerShell exception handling and turn on strict mode."	9 years ago
Rene Moser	69d5e62083	cloudstack: test_cs_account: account_state was renamed, fixes tests	9 years ago
Rene Moser	eb44f85dc8	cloudstack: test_cs_instance: make it more configurable	9 years ago
Rene Moser	15a7f818e1	cloudstack: add more integration tests	9 years ago
Brian Coca	3ccfebc9f7	Merge pull request #12047 from cchurch/powershell_common_cleanup ... Add PowerShell exception handling and turn on strict mode.	9 years ago
Ryan Petrello	1886307845	Fix a parsing bug that prevents IPv6 addresses from being used with `add_host` ... Closes #8682	9 years ago
Chris Church	af9200c2de	Add integration tests for win_group module.	9 years ago
Chris Church	4b2cdadc98	Add PowerShell exception handling and turn on strict mode. ... * Add exception handling when running PowerShell modules to provide exception message and stack trace. * Enable strict mode for all PowerShell modules and internal commands. * Update common PowerShell code to fix strict mode errors. * Fix an issue with Set-Attr where it would not replace an existing property if already set. * Add tests for exception handling using modified win_ping modules.	9 years ago
Brian Coca	01708cc824	added test for environment directive	9 years ago
Feanil Patel	892e230514	Don't convert nulls to strings. ... This change is similar to https://github.com/ansible/ansible/pull/10465 It extends the logic there to also support none types. Right now if you have a '!!null' in yaml, and that var gets passed around, it will get converted to a string. eg. defaults/main.yml ``` ENABLE_AWESOME_FEATURE: !!null # Yaml Null OTHER_CONFIG: secret1: "so_secret" secret2: "even_more_secret" CONFIG: hostname: "some_hostname" features: awesame_feature: "{{ ENABLE_AWESOME_FEATURE}}" secrets: "{{ OTHER_CONFIG }}" ``` If you output `CONFIG` to json or yaml, the feature flag would get represented in the output as a string instead of as a null, but secrets would get represented as a dictionary. This is a mis-match in behaviour where some "types" are retained and others are not. This change should fix the issue. I also updated the template test to test for this and made the changes to v2. Added a changelog entry specifically for the change from empty string to null as the default. Made the null representation configurable. It still defaults to the python NoneType but can be overriden to be an emptystring by updating the DEFAULT_NULL_REPRESENTATION config.	9 years ago
Rene Moser	9d3577a74a	cloudstack: fix tests unhashable type: 'dict'	9 years ago
Rene Moser	8f3c181d90	cloudstack: tests: use resource_prefix	9 years ago
Brian Coca	69f380da3a	changed mod_args test to match connection	9 years ago
Jeremy Wells	9f9f476b6e	Update consul integration test with http checks	9 years ago
Brian Coca	ab355218a0	fixed test to new parser options	9 years ago
Brian Coca	1acb29ff9b	sequence will now run once for start=end, added test to suite ... fixes #11979	9 years ago
Brian Coca	ee21ebaffc	Merge pull request #11975 from mutemule/become_doas ... Add become support for OpenBSD doas	9 years ago
Damian Gerow	1c5611100e	Add become support for OpenBSD doas	9 years ago
Brian Coca	43bf9c86d8	fixed typo	9 years ago
Brian Coca	d38bb4152d	fixed test to match new exception class used	9 years ago
Brian Coca	2eb5333b50	fixed test to match new become output	9 years ago
Brian Coca	43cc27084d	corrected on delete also	9 years ago
Brian Coca	089687140d	corrected role path	9 years ago
Brian Coca	033c77a13b	now creates/removes files/ dir	9 years ago
Brian Coca	464a436f8f	fixed testplay host, included lookup path tests in all, added stage for easier debugging	9 years ago
Brian Coca	60803a1d3c	added lookup paths testing	9 years ago
Brian Coca	8f106c9a58	Merge pull request #11078 from Yannig/devel ... New lookup plugin : ini	9 years ago
Toshio Kuratomi	e8452c864e	Restore the relative path handling portion of #11865	9 years ago
Brian Coca	b9433650d1	Revert "Path of group_vars and host_vars were getting the basedir added twice." ... in view of simpler solution incomming from james This reverts commit bae7a02be5.	9 years ago
Toshio Kuratomi	bae7a02be5	Path of group_vars and host_vars were getting the basedir added twice. ... Fix inventory so this won't happen and fix DataLoader so that it will test relative paths relative to self._basedir Fixes #11789	9 years ago
Yannig Perré	47db352725	Merge remote-tracking branch 'ansible/devel' into devel	9 years ago
Yannig Perré	c0bd140959	Add documentation for the ini lookup plugin.	9 years ago
Yannig Perré	733d40a77c	When value does not exist, return default value instead of stopping ansible with an exception.	9 years ago
James Cammarata	9891bcbcae	Fix unit tests broken by previous commit	9 years ago
Brian Coca	aefca24616	Merge pull request #10857 from jeffb-stell/devel ... Add test for https://github.com/ansible/ansible/issues/9851	9 years ago
James Cammarata	6b244ed61e	update unit tests for role templating changes	9 years ago
James Cammarata	a586c74967	Merge pull request #11838 from cchurch/stringify_powershell_unquote_value ... Fix for PowerShell unquote method when passed None.	9 years ago
Chris Church	cafc35fd5b	Fix for PowerShell unquote method when passed None.	9 years ago
Chris Church	6969b5ac8b	Make sure raw doesn't eat key=value arguments.	9 years ago
Chris Church	2154212491	Merge pull request #11094 from cchurch/test_win_feature_has_servermanager ... Only run win_feature tests when the host has the ServerManager module.	9 years ago
Chris Church	e87cf4a3cc	Fixes for WinRM/PowerShell support in v2. ... - Add support for inserting module args into PowerShell modules. Fixes #11661. - Support Windows paths containing spaces. Applies changes from #10727 to v2. Fixes #9999. Should also fix ansible/ansible-modules-core#944 and ansible/ansible-modules-core#1007. - Change how execution policy is set for running remote scripts. Applies changes from #11092 to v2. Also fixes ansible/ansible-modules-core#1776. - Use codepage 65001 (UTF-8) for WinRM connection instead of default (CP437), convert command to UTF-8 and results from UTF-8. Replaces changes from #10024. Fixes #11198. - Close WinRM connection when task completes. - Use win_stat, win_file and win_copy modules instead of stat, file and copy when called from within other action plugins (only when using WinRM+PowerShell). - Unquote Windows path arguments before passing to win_stat, win_file, win_copy and slurp modules (only when using WinRM/PowerShell). - Check for win_ping module to determine if core modules are missing (only when using WinRM/PowerShell). - Add stdout_lines to result from running low level commands (so stdout_lines is available when using raw/script). - Update copy action plugin to use shell functions for joining paths and checking for trailing slash. - Update fetch action plugin to unquote source path when using Windows paths. - Add win_copy and win_template action plugins that inherit from copy and template. - Support running .bat and .cmd scripts using default system encoding instead of UTF-8. - Always send PowerShell commands as base64-encoded blobs to allow for running simple PowerShell commands via raw. - Support running modules on Windows with interpreters other than PowerShell. - Update integration tests to support above changes and test unicode fixes. - Add test for win_user error from ansible/ansible-modules-core#1241 (fixed by ansible/ansible-modules-core#1774). - Add test for additional win_stat output values (implemented by ansible/ansible-modules-core#1473). - Add test for OS architecture and name from setup.ps1 (implemented by ansible/ansible-modules-core#1100). All WinRM integration tests pass for me with these changes.	9 years ago
Brian Coca	c2d8ca4bf7	fixed test to expected output	9 years ago
Brian Lloyd	07b14b9731	integration tests for windows implementation of lineinfile	9 years ago
James Cammarata	ba56beda90	Fix include task using a potentially undefined variable	9 years ago
James Cammarata	71867f9480	Remove vars attribute from base ... Fixes #11779	9 years ago
James Cammarata	42cfacf83b	Switch up the task/host overrides for PlayContext to use the compiled vars dict ... Fixes #11436	9 years ago
James Cammarata	e505a1b7c4	Fix variable precedence integrationt test	9 years ago
Brian Coca	c76a66694f	fixed typo	9 years ago
Michael Scherer	106e942faa	Document and test 'is undefined' rather than 'is not defined' ... According to https://github.com/ansible/ansible/issues/10273, this syntax should work better for nested dicts.	9 years ago
James Cammarata	8146a193eb	Fix strategy base unit tests after 88e1ef8	9 years ago
Toshio Kuratomi	b06353791c	Don't pass mode from synchronize action plugin to the ansible module ... Fixes https://github.com/ansible/ansible-modules-core/issues/1783	9 years ago
James Cammarata	993ce592b1	Update unit tests for flush_handlers fix	9 years ago
James Cammarata	66a8864ae9	Fix environment setting and inheritence ... Fixes #11401	9 years ago
James Cammarata	46f74a0d69	Re-adding --start-at-task test to unicode integration test	9 years ago
James Cammarata	e64989beb4	Moving ConnectionInformation -> PlayContext ... Also making PlayContext a child class of the Playbook Base class, which gives it access to all of the FieldAttribute code to ensure field values are correctly typed after post_validation Fixes #11381	9 years ago
James Cammarata	b09eed3353	Merge branch 'test_notify_with_loops' of https://github.com/pilou-/ansible into pilou--test_notify_with_loops	9 years ago
James Cammarata	fadd8f23f1	Fix broken strategy unit test from earlier change	10 years ago
James Cammarata	dca36c1d16	Reestablishing the use of tags/when for role duplication detection ... Not figuring these in can cause problems with "diamond" pattern relationships, even though this is still not quite optimal.	10 years ago
Pierre-Louis Bonicoli	aa23ea8462	tests: checks that handlers work with loops	10 years ago
Pierre-Louis Bonicoli	8c392a94b7	Play.get_name: remove prefix, return name only	10 years ago
James Cammarata	3d77723e3d	Cleaning up some stuff related to the connection info/become/executable change	10 years ago
Brian Coca	9dc5607730	Merge pull request #11519 from bcoca/human_readable ... new human_readable filter to transform bits and bytes into cake	10 years ago
James Cammarata	d6b058eaae	Removing invocation from async test, as it's pointless	10 years ago
Brian Coca	323362e23a	added stdout to test result	10 years ago
Toshio Kuratomi	327b1676a8	Add support for SNI and TLS-1.1 and TLS-1.2 to the fetch_url() helper ... Fixes #1716 Fixes #1695	10 years ago
Brian Coca	f6c64a8c00	fixed var file loading	10 years ago
Brian Coca	5eb25a48ee	added empty include test	10 years ago
Brian Coca	22165dd046	fixed bad parsing tests	10 years ago
James Cammarata	3b913943b2	Updating base strategy unit test regarding bad file loads based on earlier change	10 years ago
Brian Coca	44aef347cb	enabled good parsing tests in parsing target ... fixed test_good_parsing role added raw duplicate parameters to test_good_parsing	10 years ago
James Cammarata	6971e92f39	Fixing up some output stuff	10 years ago
Brian Coca	b4de103bb2	Merge pull request #11555 from cchurch/test_win_get_url_updates ... Update tests for win_get_url module to test force parameter	10 years ago
Chris Church	1aa2191fd5	Update tests for win_get_url module to test force parameter and invalid URLs/paths.	10 years ago
Brian Coca	c6dde19a5e	Merge pull request #11537 from chrismeyersfsu/azure-test ... assert password or ssh key provided on new image creation	10 years ago
Brian Coca	9c5a6d7b5a	fixed all references to old plugins/inventory to point at contrib/inventory	10 years ago
James Cammarata	5430169b77	Cleaning up includes test to match 2.0 behavior ... * Perhaps the only precedence change, in 2.0+ variables from set_fact will not override params to an include file, as params are expected to be more specific than host-based variables. * Uncommented long-form include example.	10 years ago
James Cammarata	1163e38d39	Fix unit tests for new magic variable addition 'ansible_version'	10 years ago
James Cammarata	bbe8f48a46	Update role unit tests for changes made to require a play during loading	10 years ago
James Cammarata	b520d5bc60	Lots of fixes for integration test bugs	10 years ago
Chris Meyers	32685f9648	assert password or ssh key provided on new image creation	10 years ago
James Cammarata	27fcf1a4b5	Fix bug in registered variables related to delegate_to changes	10 years ago
James Cammarata	f5baad4fb2	Removing unicode --start-at-task test for now as we haven't added that back into devel	10 years ago
James Cammarata	64a1b1e043	Fix first_available_file: support for copy and template actions	10 years ago
marconius	79394f5c8f	Added tests for `taggable` module	10 years ago
Brian Coca	48827a31bc	added minimal testing for special template vars	10 years ago
James Cammarata	bfbb88b4a9	Fix strategy plugin unit tests related to earlier changes	10 years ago
Brian Coca	688088547b	new human_readable filter to transform bits and bytes into cake (not really)	10 years ago
Toshio Kuratomi	f44f9569e1	Test unquote works as expected and fix two bugs: ... * escaped end quote * a single quote character	10 years ago
Brian Coca	aa6486778f	fixed become test to match new expected output	10 years ago
James Cammarata	53cd96befe	Updating unit tests to account for new magic variable 'vars'	10 years ago
Brian Coca	5122455db8	ported missing sequence updates from 1.9	10 years ago
Matt Martz	2cd3a1be00	assertRaises should be given an exception type. Fixes 11441	10 years ago
Matt Martz	43f81c7c01	Fix YAML formatting issue for rax integration tests	10 years ago
Brian Coca	200706d5ab	Merge pull request #9812 from fgsch/fix_1904 ... Allow globbing in creates= and removes= directives	10 years ago
Matt Martz	c440762b61	Make the wait_timeout for rax tests a configurable default	10 years ago
James Cammarata	4fbd4ae18b	Update VariableManager test for additional magic variable playbook_dir	10 years ago
Matt Martz	b370f6efce	Add tests for rax_scaling_group	10 years ago
Toshio Kuratomi	605ddad37e	Add test that url lookup checks tls certificates	10 years ago
James Cammarata	d913f169a8	Update failed_when integration test to be more thorough	10 years ago
Brian Coca	5ed2e44026	adjusted with_dict test to now work	10 years ago
Brian Coca	dc31086a17	added with_dict test	10 years ago