Commit Graph

275 Commits (bd5cf57e769300ff69836411c01c171be9641b8f)

Author SHA1 Message Date
James Cammarata 43f96a636b Fix issue with symlink path detection
Fixes #7627
Fixes #7664
11 years ago
James Cammarata 7483acde5d Fix linking issue to directories in file module
The os.path.isdir() returns True for symlinks that point to directories,
so we also need to check to make sure it's not a symlink too.

Fixes #7657
11 years ago
Brian Coca 202ac68995 Correctly examine path for relative links in file module
Fixes #7515
Fixes #7537
11 years ago
Kit Westneat fabe8521cb Fixed documentation for etype parameter on acl module.
The etype parameter just had a copy of the default parameter documentation.
Changed it to reflect what it really is for.
11 years ago
Brian Coca c24956032d unified calls to fs function vs duplicate functions for file and
directory
11 years ago
James Cammarata 062e82937f Fixing absolute path calculation for file module when linking
Fixes #7403
11 years ago
telsacolton 06963c7826 Make file hardlink error message reasonble
When we hard-link a file, and the link path already exists, give the link path in the error message instead of the source
11 years ago
telsacolton 0d8104b8b7 Give reasonable error when symlink fails
When a symlink fails because the path already exists and force=no, we should output path in the error message instead of source.
11 years ago
James Cammarata a9311a5dcb Merge branch 'file_new_dirs_perms' of https://github.com/bcoca/ansible into bcoca-file_new_dirs_perms 11 years ago
James Cammarata a18f4b6230 Merge branch 'devel' of https://github.com/jjshoe/ansible into jjshoe-devel 11 years ago
James Cammarata d9bb1a480a Merge pull request #7013 from orgoj/replace-patch-changed
module replace - report changed only if contents is changed
11 years ago
James Cammarata b753625dbf Refuse to convert a non-empty directory into a link with the file module
Also adds an integration test for the above.

Fixes #7254
11 years ago
someda 50080b3774 fix #7244 recursive copy fails when setting directory attributes
- reverse the order of new_directory_list returned from split_pre_existing_dir in copy module
11 years ago
Michael DeHaan 6b26efdee0 Merge pull request #7119 from jjshoe/patch-4
Finish reverting a broken commit in #5679
11 years ago
James Cammarata ac1948c04c Minor tweak to rsync_path construction in synchronize module
Fixes #7182
11 years ago
Skyler Leigh Amador a8d9470938 Remove --timeout option to rsync from synchronize defaults
The current 10-second default timeout for rsync seems to be behind issue #6809.

As a workaround for the underlying issue in rsync when different versions are
used on the source and destination sides, don't include the timeout option
unless the user specifies a timeout > 0.
11 years ago
Joel Schuweiler 5bad971873 Finish reverting #b73cddc 11 years ago
jjshoe a34478d6f3 Ensure the validation string has %s in it 11 years ago
Brian Coca f079d022a3 now when making multiple dirs in path to make dir, same permissions are assigned (but only for NEW dirs)
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
11 years ago
Erika Heidi 036c7a7759 Possible docs error: 'path' instead of 'src'
I came to this example today (line 50), and when I tried it, I got an error:

`msg: src and dest are required for creating links`

So, I changed **path** to **src** and it worked fine. Looks like the example is wrong, since the docs say "dest" is already an alias for "path", in which case we would have 2 "path" definitions.
11 years ago
Michael Heca a1706e6411 module replace - report changed only if contents is changed 11 years ago
James Cammarata e8b33636ae Get the bin path for commands in the unarchive module
Fixes #6927
11 years ago
James Tanner b0556ab1fb Addresses #6702 Remove version_added from description string 11 years ago
James Tanner 42fbbd0502 Addresses #6702 set version_added for rsync_opts 11 years ago
jctanner bb3ce0c744 Merge pull request #6702 from jjshoe/devel
Allow you to pass in arbitrary rsync options
11 years ago
James Tanner dfdc3b82a0 Fixes #6929 remote file module doc fragments from copy and template 11 years ago
James Tanner 68cd7258b6 Fixes #6894 create docs fragment for files 11 years ago
James Cammarata b73cddc485 Revert "Fix #5679 again after recent changes in core"
This reverts commit 2bfaacd170.

Fixes #6821
11 years ago
Richard C Isaacson dc93b31d22 assemble module: fix insertion of newlines when not needed.
This builds on GH-6359 and changes the logic so that a newline is only inserted between fragments if the previous fragment does not end with a newline.
11 years ago
Peter Gehres 3ac731087c Fix for #6353 adding a newline between assembled files 11 years ago
Michael DeHaan 1fa19e29e8 Use common file argument system previously implemented by @sivel for rax modules on the file modules as well (copy/file/template).
Application to other cloud providers would make very good sense.
11 years ago
James Tanner 9fe2bcd076 Merge #5903 from rhaido/ansible
Update files documentation for usage of force=True and hardlinks
11 years ago
cgtx f6abc17e8a backreferences should be double escaped 11 years ago
Michael DeHaan 8baaf458c7 Repairs for documentation build. 11 years ago
Michael DeHaan c1fbf80f70 Slight docs tweak, split lines according to code standards 11 years ago
Andrea.Mandolo 838b914a0d correct documentation comment and version_added in "synchronize" module 11 years ago
Andrea.Mandolo c039dbe300 Add STDOUT lines in response of "synchronize" module 11 years ago
Andrea.Mandolo f9ec53cdef Add "checksum" option support to 'synchronize' module 11 years ago
Michael DeHaan 37efa1640f Merge branch 'update_docs_validate_cmd_not_passed_via_shell' of git://github.com/rwehner/ansible into devel
Conflicts:
	library/files/template
11 years ago
Michael DeHaan 2ddb251538 Merge pull request #6597 from tarka/handle-uncreated-symlink-tmpfile
Handle missing symlink tempfile
11 years ago
jjshoe d57910b93a Allow you to pass in arbitrary rsync options. I also added help for it, and what version it was added in. 11 years ago
Jeff Geerling 8960cba4a3 Fixed template validation docs and example. 11 years ago
jjshoe 12c84dd6bd Show argument dependency
failed: [192.168.1.2] => {"cmd": "rsync --delay-updates -FF --compress --timeout=10 --delete-after --rsh 'ssh -i /home/jjshoe/.vagrant.d/insecure_private_key -o StrictHostKeyChecking=no' --rsync-path 'sudo rsync' --out-format='<<CHANGED>>%i %n%L' /tmp/app vagrant@192.168.1.2:/home/ubuntu/app", "failed": true, "item": "", "rc": 1}
msg: rsync: --delete does not work without --recursive (-r) or --dirs (-d).
rsync error: syntax or usage error (code 1) at main.c(1453) [client=3.0.9]
11 years ago
James Cammarata f2c06cadc3 Cleanup from merge of replace module and CHANGELOG update 11 years ago
James Cammarata 9775872f83 Merge branch 'devel' of https://github.com/EvanK/ansible into EvanK-devel 11 years ago
James Cammarata d545b73ccb Merge branch 'file_fixes_agg' of https://github.com/bcoca/ansible into bcoca-file_fixes_agg 11 years ago
Robert Wehner 8a19d31391 Update 'validate=' parameter documentation to make clear that the command
passed via this paramter is not passed via shell and so all shell features
will not work.
11 years ago
James Tanner ea5186ca63 Fixes #6590 add set_remote_user parameter to synchronize
This allows usage of custom ssh configs for remote hosts where
the inventory user does not match the configured user.
11 years ago
Steve Smith e157355fd6 Only unlink the symlink tempfile on error if it was created in the
previous operation.
11 years ago
Brian Coca 1b38bd8a40 fixed issue with tmp file (path can include filename) and added missing
else which made it try to link x2
11 years ago