Commit Graph

1586 Commits (bbe352b544917e4733dbfcfdcbdff65056f79d99)

Author SHA1 Message Date
Jeremiah Heller 7de718cd51 Fix copy when force=no and update _remote_md5 docs.
Previously setting force=no caused copy to subversively
fail when target did not exist on remote host.

Caused by Runner._remote_md5 returning 1
when files don't exist, rather than 0.
13 years ago
Kavin Kankeshwar 8217e0706f Avoid crash in module_common when the file cannot be moved/copy 13 years ago
Serge van Ginderachter 0c0d6c0b4e performance optimization in inventory.groups_list()
don't calculate all hosts for every parent group of every group
when that parent group was already in the cache
13 years ago
Serge van Ginderachter dd9919342b hide magic variables used bin/ansible output
'verbose_override' and 'verbose_always'
13 years ago
Michael DeHaan 3a635d2d26 Lots of formatting fixes 13 years ago
Michael DeHaan 11792a9daa Merge pull request #2987 from kentfrazier/sudo_user
Fix bug with include-level vars and sudo_user.
13 years ago
Michael DeHaan 84623441e1 Merge pull request #2945 from jsmartin/new_fetch
Fetch destination path can now be overriden.
13 years ago
Michael DeHaan 4fc6be8579 Merge pull request #2993 from SirScott/pkgng
Make pkgng and with_items result in a single module call.
13 years ago
Michael DeHaan 4b988dbd43 Merge pull request #2978 from bryanlarsen/basename
add basename and dirname to the core jinja2 filters
13 years ago
Michael DeHaan 27236cf598 Merge pull request #2998 from SirScott/runner-permissions
Ensure the tmp_path is sufficiently open.
13 years ago
Michael DeHaan 159ba7d68a Merge pull request #2956 from akerl/unicodefix
ignore unicode errors in stdout
13 years ago
Michael DeHaan 98a4331107 Merge pull request #2999 from ngrilly/python
Python
13 years ago
Michael DeHaan 5fdca267ac Merge pull request #3018 from dsedivec/devel
Plug-ins loaded from top-level plug-in directory
13 years ago
Serge van Ginderachter 94028852d9 Make debug module always verbose in playbooks
Created a new flag 'verbose_always' handled by
on_ok callback, similar to the 'verbose_override'
flag used by the setup module.
13 years ago
Dale Sedivec 611d56dc4c Plug-ins loaded from top-level plug-in directory
PluginLoader._get_paths, as of 391fb98e, was only finding plug-ins that
were in a subdirectory of one of the basedirs (i.e. in a category
directory).  For example, action_plugins/foo.py would never be loaded,
but action_plugins/bar/foo.py would work.

This makes it so that "uncategorized" plug-ins in the top level of a
directory such as action_plugins will be loaded, though plug-ins in a
"category" subdirectory will still be preferred.  For example,
action_plugins/bar/foo.py would be preferred over action_plugins/foo.py.
13 years ago
Scott Sturdivant 5516ece859 Ensure the tmp_path is sufficiently open. 13 years ago
Nicolas Grilly 7aee588918 Idiomatic Python: use in operator instead of method find 13 years ago
Nicolas Grilly 7babd30cf7 Idiomatic Python: use isinstance instead of type 13 years ago
James Martin 3c131dbd2b Initial Commit. 13 years ago
Scott Sturdivant d91bc1692e Make pkgng and with_items result in a single module call. 13 years ago
Kent Frazier 4c6583bd00 Fix bug with include-level vars and sudo_user.
If a variable was provided for an include, in either of these ways:

    ---
    - hosts: all
      tasks:
      - include: included.yml param=www-data
      - include: included.yml
        vars:
          param: www-data

and then that param was used as the value of sudo_user in the included
tasks:

    ---
    - name: do something as a parameterized sudo_user
      command: whoami
      sudo: yes
      sudo_user: $param

you would receive a "failed to parse: usage: sudo" error back and the
command would not execute.

This seemed to be due to a missing call to template.template somewhere,
because the final value being passed through ssh was still `$param`.
After some digging, the issue seems to instead have been a problem with
providing the wrong context to the template for expansion. Inside the
`Task` logic, it was passing `play.vars` as the context, where
`module_vars` seemed more appropriate. After replacing it, my test case
above ran without issue. There was a comment above suggesting that the
template call might be unnecessary, but removing it made the original
error return, since it is not getting escaped later down the line. I
removed the comment since it was inaccurate.

I tried to actually incorporate my test case above into the test suite
as a regression test, but was unable to figure out how to structure it.
The existing test infrastructure seemed to only be testing for correct
number of counts in things (ok vs. changed, etc.), without regard for
whether the content generated by the command is correct. If there is an
example of a test similar to this one (where I would want to check the
JSON generated to make sure sudo_user had been converted), please let me
know and I will be happy to submit an additional patch.
13 years ago
Bryan Larsen f629baef11 add basename and dirname to the core jinja2 filters 13 years ago
Michael DeHaan 753ebea186 Prefer categorized modules to uncategorized, such that if someone does an install on top of old content
the categorized modules will win over the 1.1 uncategorized modules, as the packages may not automatically
clean up the old content.
13 years ago
Michael DeHaan cd57d59913 If ansible is configured to use a log file but cannot write to it, exit, but don't traceback. 13 years ago
Michael DeHaan 496f06c3c9 Pass variables to lookup function for those that want to use them. 13 years ago
Michael DeHaan 16709ecd76 Replace tab with spaces. 13 years ago
Dimos Alevizos e96bc981ce Set paramiko's logging level
Excplicity set paramiko's logging level to WARNING.
By default it inherits ansible's DEBUG logging level (set in
callbacks.py) and fills the log file with useless debug messages.
Obviously it only applies if log_path is set in ansible.cfg
13 years ago
Les Aker 1179d1bbd8 corrected indentation 13 years ago
Les Aker 2adc335481 ignore unicode errors in stdout 13 years ago
Maykel Moya 60f24bb077 Remove unused modules 13 years ago
Maykel Moya f52e3dee70 Don't hardcode chroot executable path 13 years ago
Ben Ritcey 0938d4d89a Allow the remote MD5 checks to be run via sudo 13 years ago
Michael DeHaan 8475a92dec Merge pull request #2939 from mmoya/lookup-crypted-passwds
Add support for crypted passwords to password lookup
13 years ago
Stoned Elipot 94ba0f740a Fix for issue #2916 : for each host promote the host variables as globally scoped variables for the sake of the groups determination 13 years ago
Maykel Moya 45f5447f9f Fix name in copyright 13 years ago
Maykel Moya 96afc3f462 Add support for crypted passwords to password lookup
Added new parameter 'encrypt' with same semantics from that of
vars_prompt. When encryption is requested a random salt will be
generated and stored along the password in the form:
'<password> salt=<salt>'.

Also store passwords with an ending '\n' for easier looking at files
with console tools. File content was being already rstripped so this
is harmless.
13 years ago
Brian Coca 8dd72d2828 changed lockfile to be opened in write mode (solaris for one doesn't like
exclusive locks on read)
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
13 years ago
Michael DeHaan f2a8c0d612 Fix listification inside of with_items so it runs more intelligently. 13 years ago
Michael DeHaan 161f3e3670 Merge pull request #2899 from sergevanginderachter/host-group-vars-no-subdirs
don't parse subdirs in host/group_vars
13 years ago
Michael DeHaan ff3625b0c9 Merge pull request #2902 from timhabermaas/fix-grammatical-error
Fix grammatical error in error message
13 years ago
Serge van Ginderachter 7eeab168bc bug fix in first_found search path assembly 13 years ago
Tim Habermaas 4d24faeeb1 Fix grammatical error in error message 13 years ago
Serge van Ginderachter a6b827ca07 don't parse subdirs in host/group_vars
as those are not supported in
core vars_plugins/group_vars.py
but might be used by other vars_plugins
13 years ago
Michael DeHaan 2a091a3505 Remove duplicate import. 13 years ago
Michael DeHaan a78edbb45c More pep8 13 years ago
Michael DeHaan 50586928b2 No need for trailing semicolon. 13 years ago
Michael DeHaan ea8302e68d Indentation. 13 years ago
Michael DeHaan 9f47d13306 Misc identation. 13 years ago
Michael DeHaan 0a1657080b Indentation fix 13 years ago
Michael DeHaan 3fdf15fa8a template code fixes for 'make pep8' 13 years ago