Commit Graph

566 Commits (bb8bac490a1b4f1ac4b8e6c718057ad11726be62)

Author SHA1 Message Date
Toshio Kuratomi 7b100dd389 Be more specific in checking if a job restarted successfully.
Fixes: #9056
10 years ago
Toshio Kuratomi 36083c3b90 Failure to enable a service now fails the task
Fixes: 8855
10 years ago
Toshio Kuratomi a50258d26a remove debugging that was causing failure 10 years ago
Toshio Kuratomi 2e16bd3a44 Refactor the Linux service_enable() method
* Fix check_mode for initctl systems

Fixes #9009
10 years ago
Toshio Kuratomi 104401805b Revert "Refactor the Linux service_enable() method" needs some debugging
This reverts commit e294e31fd3.
10 years ago
Toshio Kuratomi c362902f50 Refactor the Linux service_enable() method
* Fix check_mode for initctl systems

Fixes #9009
10 years ago
Toshio Kuratomi a9928492f7 Make systemd vs rht detection more robust for centos
Centos 6.x and below use an old RHT style of configuring hostname.
CentOS 7.x and better use systemd.  Instead of depending on the
distribution string which seems to have changed over the course of 6.x
we need to explicitly check the version.

Fixes #8997
10 years ago
James Cammarata 7edcf21bdc Move initscript rc check to later in service status check
Fixes #7284
10 years ago
Michael DeHaan 5aa6ddef7f Tracebacks are now catchable with ignore_errors and have streamlined output. Also removes 'baby-JSON' for bash modules. 10 years ago
Patrik Lundin 0abf14ff19 service: use self.changed in service_enable_rcconf().
This sets the "changed" result of the module when a rc file is modified.
Previously only --check mode would show that it was going to change.
10 years ago
James Cammarata 30d6713bf0 Add additional checks to detect upstart services
Also adds checks for the upstart version, in order to test check
support for manual vs. start on manual
10 years ago
Eri Bastos 6f8a29dc3d Proposed fix for issue #7757 10 years ago
James Cammarata c8376e296f Tweaking change to documentation language for cron name param 10 years ago
James Cammarata 509761249c Merge branch 'devel' of https://github.com/mattparker/ansible into mattparker-devel 10 years ago
James Cammarata 07e77c5bed Merge pull request #8740 from mattparker/patch-1
Name appears to be a required parameter for cron module
10 years ago
James Cammarata 1f2727c607 Merge pull request #8729 from ercpe/openrc-hostname
Hostname strategy implementation for OpenRC based systems (e.g. Gentoo)
10 years ago
Matt Parker 6086c505fe Update cron documenation
The "name" parameter seems to be rather important as the identifying feature of a cron job.  This is an update to the documentation to further emphasize this.
10 years ago
Matt Parker 5accd15ba6 Name appears to be a required parameter
As far as I can tell, `name` is a required parameter.  The guard test at (now) line 458 says you need name if `state == present` and at 464 if `state != present`, although that's not quite as clear.  Each of the code paths at 485 - 495 pass the name param through to `add_job`, `update_job` and `remove_job`, and the actual _update_job method earlier seems to require it too.  However I don't really know python so I may be wrong, but I can't see the circumstances when `name` is not required.
10 years ago
Johann Schmitz 7ef67e3f8b Hostname strategy implementation for OpenRC based systems (e.g. Gentoo) 10 years ago
Ding Deng 85c6434262 debconf module: add the missing 'error' vtype and reorder vtypes as they appeared in debconf-devel(7). 10 years ago
Michael DeHaan 60ce2d3853 Fix documentation builds. 10 years ago
Michael DeHaan f21d6c7980 Merge pull request #8002 from prune998/patch-2
added missing force flag on mkfs commandline
10 years ago
Michael DeHaan 185d5a6221 Merge branch 'spelling' of git://github.com/cgar/ansible into devel
Conflicts:
	docsite/rst/guide_rax.rst
	plugins/callbacks/mail.py
10 years ago
Michael DeHaan 66ec9089bd Update docs. 10 years ago
Michael DeHaan f6f184b36d Updating docs. 10 years ago
Brian Coca aeeefd046f bumped to 1.7 10 years ago
Brian Coca 5aa2ca762a added control to fail or not on missing key
made split 'smarter' but still overridable
10 years ago
Brian Coca 391f8ec600 added getent module to get system data as facts 10 years ago
Serge van Ginderachter 961d4b0d6c execute the mount after path validation
This avoids a stale situation where name/path contains some impossible path,
but gets configured (faultly) in fstab, and the module only fails after that,
when creating that path.
10 years ago
Jonathan Mainguy 650003dd5c Fixes issue #8339 where Scientific Linux incorrectly tries to use FedoraStrategy of hostnamectl 10 years ago
Michael DeHaan e978dcf7eb Merge pull request #8283 from ps-jay/sys_mount_fstype_doc
Add fstype arg to the mount examples
10 years ago
Michael DeHaan bc01f2571e Merge pull request #8311 from neersighted/wrap_distroversion
Wrap get_distribution_version() in the hostname module
10 years ago
Michael DeHaan 2212b64fd9 Cleaning up explanation of mount module states. 10 years ago
Bjorn Neergaard cbc417ca1b Wrap get_distribution_version() in the hostname module
We wrap get_distribution_version() with a new function,
_get_distribution_version(), that returns `0` when the result is a string or
`None`.

This accounts for the case when get_distribution_version() returns a string,
and we try to compare it to a float. We do this in the hostname module instead
of the module snippets because other modules may want the real string
version.module snippets because other modules may want the real string version.
10 years ago
Michael DeHaan 99ad691950 Merge branch 'ufw' of git://github.com/Trozz/ansible into devel 10 years ago
Michael DeHaan caba7ac6a6 Merge pull request #7954 from alimony/patch-3
cron module: Use correct parameter name in error message.
10 years ago
James Cammarata 03f0d6bec8 Merge pull request #8308 from robinro/extend-hostname-distrolist
Extended distributions list for hostname module
10 years ago
Robin Roth 7920f4eaf5 Fix extra newline at end of hostname for Fedora
This fixes a bug introduced by 138b45e3.
The hostname has an additional newline at the end which leads to the
state always being 'changed: true' even if the hostname is unchanged.
10 years ago
Robin Roth a26bc9c926 Extended distributions list for hostname module
Implementations already present
10 years ago
Tom Lazar d89adce760 FreeBSD 10 compatibility fix
On FreeBSD the whitespace around the ``=`` triggers a (cryptic) ``no such file or directory`` error. removing the whitespace like above fixes this.
10 years ago
Philip Jay bb7b290ed8 Add fstype arg to the mount examples
Needed fstype in the examples, since fstype is a required argument for
mount.
10 years ago
Berend de Boer f46c4ee093 Default for fstab missing, causing KeyError: 'fstab' 10 years ago
James Cammarata 6879e4ff0a Merge pull request #8223 from renard/create-fstab-if-not-exists
Create fstab if not exists
10 years ago
Sébastien Gross e0f7b3f39c [mount] make sure fstab exists
This is mainly to prevent from failing with no such file or directory
during module execution.
10 years ago
Sébastien Gross 806052a9e5 [mount] Add documentation for fstab option 10 years ago
Hector Acosta 60edb6b04b Add check_mode support to authorized_key. Fixes #7300
Signed-off-by: Hector Acosta <hector.acosta@gmail.com>
10 years ago
Yasser Nabi 8cc894bef2 Enable puppet facts
Currently facter facts omit facts that a distributed via Puppet. This
commit adds the `--puppet` option.

In cases where puppet is not installed, the command sends a warning to
STDERR *but* completes successfully. So should not cause any issues.

The benefit is, filtering can be done based on facts set by Puppet.
10 years ago
Michael DeHaan 96fe275946 Merge pull request #8139 from peterkh/devel
Fix "TypeError: group id must be integer" if groupid passed in for group key
10 years ago
Ruggero Marchei ae95ebd075 fix LooseVersion exception with empty distribution_version 10 years ago
Peter Hall ae67002c15 Fix "TypeError: group id must be integer" if groupid passed in for group
key
10 years ago