Commit Graph

2264 Commits (bb3cbac73821ee070c6310f657ffa899a0278338)

Author SHA1 Message Date
Trishna Guha 2e145cd1f2
fix nxos_switchport/l2_interface trunk_vlans state absent (#37180) (#37181)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 02999b77a4)
7 years ago
Jordan Borean 09de6dc020
win_uri: backport return value fix for non 200 responses (#37156)
* win_uri: return response info on non 200 responses, convert DateTime values to ISO 8601 (#37104)

(cherry picked from commit c1f5e11cdf)

* Added changelog fragment for win_uri return value fix
7 years ago
Trishna Guha ee67c6c1e3
fix nxos_l2_interface tests for fretta (#37086) (#37101)
(cherry picked from commit b7bc61c7df)
7 years ago
Jordan Borean f0a808e02c Win lineinfix fix (#36888)
* Win lineinfile fix (#35100)

* win_lineinfile: fix #33858. Removed conversion from \r\n

* win_lineinfile: added test for #33858

* win_lineinfile: added documentation and more tests for change

* win_lineinfile: fixed wrong hash in testing

(cherry picked from commit e15a903bdf)

* Added changelog for win_lineinfile fix

* fix typo in changelog
7 years ago
Ganesh Nalawade bbf27efe06
Fix eos integration test failures (#37020) (#37054)
Fixes #36919

Fix other eos modules integration test failure in dci
(cherry picked from commit ba3201cd2f)
7 years ago
Nathaniel Case a3f96ec4af
ios_static_route idempotence fix (#35912) (#37012)
* Remove default admin_distance and fix the idempotence thereof

Fixes #33290

* Fix tests and use yaml anchors to shorten tests

* Add test for undefined admin_distance

* Read config from `show run` if `show ip static route` fails

* Restore flags to ios.get_config &  use get_config where appropriate

(cherry picked from commit 7016b3b9ca)
7 years ago
Ganesh Nalawade 3f8377c2d9
Enable eapi integration test for eos modules (#36934) (#36935)
(cherry picked from commit 83c3561ee5)
7 years ago
Ganesh Nalawade a275a39299
Fix eos_vrf integration test failures (#36893) (#36896)
(cherry picked from commit 5c2a1a6124)
7 years ago
Trishna Guha fb630c926a
nxos_facts fix and integration tests (#36796) (#36820)
* fix nxos_facts ipv6 error

* time_range not supported for N35

(cherry picked from commit db43fe6a76)
7 years ago
René Moser eb12520854
cs_sshkeypair: fix ssh key rename (#36726) (#36730)
* tests: cs_sshkeypair: add reproducer for failed key rename

* cs_sshkeypair: fix rename ssh key

(cherry picked from commit cdb2969703)
7 years ago
Trishna Guha b1bdc5dae2
nxos_vlan, nxos_linkagg fix (#36711)
* fix nxos_vlan aggregate (#36710)

* fix nxos_vlan aggregate

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 44332bda78)

* nxos_linkagg fix (#36706)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit d6912cf40e)
7 years ago
Ganesh Nalawade d60eac9bc4
Decouple config and state check in vlan and vrf network modules (#36386) (#36704)
* Decouple config and state check in {network_os }_vlan and { network_os }_vrf modules

Fixes #35567
Fixes #34754

`interfaces` option is used for configuration as well as operational state
check. If interface is configured to given vlan or vrf but if
operational state of interface is disabled it results in module failure.

Fix is to decouple same option usage for config and state.
With this fix `interfaces` is used as config option and a new
option named `associated_interfaces` will be used for intent check
for assigned interfaces.

* Fix CI failures

* Fix review comment

* Fixed integration test failure

(cherry picked from commit 5a6b893240)
7 years ago
Matt Clay a48254275f Temporarily disable subversion test on osx.
(cherry picked from commit f283edcb19)
7 years ago
Matt Davis ed9781bbfb
Do not cache the loop item label so that it will update with each item (#36609)
Add integration test for #36430 (#36432)

(cherry picked from commit d1f76939e5)
(cherry picked from commit 9fced4f0a9)
7 years ago
Dag Wieers b1e125b718 Backport missing integration tests (#36610)
Somehow this file was missing from the previous backport.
7 years ago
Jordan Borean f8d8d84f05 Win feature error cp (#36559)
* win_feature: better error handling to make it easier to debug issues (#36491)

* win_feature: better error handling to make it easier to debug issues

* removed ignroed pslint rules that are no longer needed

(cherry picked from commit ef4f8851dc)

* Added changelog for win_feature error handling fix
7 years ago
Sam Doran 84debca5fb Check for regexp match when using insertbefore or insertafter (#36474) (#36552)
Add tests to cover this scenario
Add changelog fragment
Fixes #36156

(cherry picked from commit 723daf3e3a)
7 years ago
mikedlr 26cdfd84a0 Bring aws_ssm None fixes into stable (from #36456) (#36492)
* aws ssm parameter lookup - change to reutrn Nones for missing variables

* aws ssm parameter lookup - fix error case message to dump response

* aws ssm parameter lookup - fix integration test cases
7 years ago
Dag Wieers df78df5d90 Apply all devel ACI changes missing from stable-2.5 (#36553) 7 years ago
Toshio Kuratomi 7f9fdbbb30 Revert "remove query/q (#36315)"
This reverts commit b47d2e07e1.

query is a feature for 2.5.  We're not reverting it now.

(cherry picked from commit 03a6d72633)
7 years ago
Sloane Hertel 77af8f36cb [cloud] Retry WAF actions on WAFStaleDataException (#36405) (#36507)
Add a util to run functions with AWSRetry to retry on WAFStaleDataExceptions and update ChangeToken for each attempt
7 years ago
Brian Coca 7188165dd1 remove query/q (#36315)
* remove query/q

remove and fixed tests for removed func

* paren fix

(cherry picked from commit b47d2e07e1)
7 years ago
Jordan Borean 9b00fd4ca1
fetch: set fail_on_missing: True as default as per docs (#36469)
* fetch: set fail_on_missing: True as default as per docs

* Updated docs for fetch to say behaviour was changed in 2.5 and updated tests

(cherry picked from commit df8a5d7a4f)
7 years ago
Deepak Agrawal 6ff000254f
vyos_config IndexError in sanitize_config (#36375) (#36484)
* Bug in del(list) logic. Say you have a list of 4 elements a[0-3]
and you have to remove index 1 and 3, if you remove index 1 first
then list is cut short a[0-2] and does not have index 3

Fix: Remove indexes in reverse sorted order e.g. 3 and 1 in above
example so that order of indexes remain preserved even after deleting

fix is to remove indexes in reverse sorted order

* Add test cases for failed case

(cherry picked from commit 0bbea9a579)
7 years ago
Trishna Guha d86d4907cc
fix nxos_bgp_neighbor_af issues (#36472) (#36481)
(cherry picked from commit 47a92386c9)
7 years ago
Trishna Guha 108cbbc40e
fix vyos_l3_interface adding multiple addresses to interface (#36377) (#36443)
* fix vyos_l3_interface adding multiple addresses to interface

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* add test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 3d06ce245a)
7 years ago
Trishna Guha 21b74f7cce
fix nxos_bgp_neighbor issues (#36318) (#36420)
(cherry picked from commit 80d19e6af3)
7 years ago
Trishna Guha 9692394c7d
Stable 2.5 (#36374)
* Set hostname to 'switch' on nxos_system (#36373)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit eb7f4460c8)

* fix nxos_config json pipeline error (#36236)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 736d6406c0)
7 years ago
Trishna Guha 22b4d69a7b
nxos_system test fix inventory_hostname_short (#36359) (#36360)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit a5654bd63c)
7 years ago
Trishna Guha b08bdc5f6d
nxos fix cherry-pick (#36340)
* Fix nxos_system tests (#36201)

* Fix nxos_system tests

* Add debug connection plugin info

* Move sanity test under common

(cherry picked from commit 5b5d24631a)

* Fixes for the N3500 platform that uses the A8 image (#36261)

* fix nxos_l3_interface tests as n35 doesn't support ipv6

* add terminal dont-ask to nxos_feature and nxos_lldp

* put interfaces in L2 mode for N35

* fix nxos_feature unit-tests

(cherry picked from commit e24c547a3a)
7 years ago
David Newswanger cf196613ff
re enabled tests that were fixed in ansible/ansible-modules-core#5008 (#36257) (#36303)
(cherry picked from commit a7c2f6d092)
7 years ago
Dag Wieers 179aa475a5 aci_firmware_source: Add integration tests (#36246)
This PR includes:
- Rename 'protocol' parameter to 'url_protocol'
- Add limited integration tests (as we have no public firmware access)
- Add missing examples
(cherry picked from commit e1b5bc049c)
7 years ago
Dag Wieers dd92db800a aci_taboo_contract: Add integration tests and examples (#36276)
This PR includes:
- Missing integration tests
- Missing examples
- Two typo's in other integration tests
(cherry picked from commit 334e405e6f)
7 years ago
Dag Wieers 51c4fceb64 aci_domain_to_encap_pool: Add integration tests (#36217)
(cherry picked from commit d86c5aee3c)
7 years ago
Dag Wieers eb0232fa86 aci_encap_pool: Standardize on 'pool_allocation_mode' (#36215)
(cherry picked from commit e431d578da)
7 years ago
Dag Wieers 66e7c8d938 ACI: Avoid using 'previous' with query operations (#36181)
When ACI modules are being used for querying MOs, we should not return
the previous state, as there is no previous state, there's only the
current state.

This impacts a lot of tests that were used to testing the current state
as 'previous'.
(cherry picked from commit dba561efa7)
7 years ago
Dag Wieers 38b000062f aci_vlan_pool: Improve integration tests (#36173)
This PR includes:
- More elaborate integration tests
- Split static and dynamic VLAN pools in separate files
(cherry picked from commit 3093285c94)
7 years ago
Abhijeet Kasurde fb46cf3718
VMware: Fix DVPG idempotency issue (#36285)
This fixes, cloning operation where template or existing VM
does not have network or DVPG. Also, adds some strict type checking in
network parameters.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit a377302d6b)
7 years ago
Dag Wieers 5ce2822855 aci_aep_to_domain: Fix query all objects (#36131)
This PR includes:
- A fix to the module where domain_type without domain caused havoc
- A fix to the integration tests when querying all binding objects
- Improvements to integration tests
(cherry picked from commit 7897558b95)
7 years ago
Dag Wieers b85989205f aci_domain_to_vlan_pool: Add missing integration tests (#36079)
(cherry picked from commit 9f028e9dea)
7 years ago
Dag Wieers e81c181881 aci_aep_to_domain: Add missing integration tests (#36071)
(cherry picked from commit 98a3059f7b)
7 years ago
Dag Wieers eec7945222 aci_interface_policy_leaf_policy_group: Fix tests (#35973)
(cherry picked from commit d76db835ff)
7 years ago
Dag Wieers 76648f358e ACI: Fixes to recent change to parameter choices (#35968)
This PR includes:
- Fixes related to the recent merge of #31637 and #34537
- A generic fix for a reference for assignment issue
- Fixes to aci.boolean() in order to catch exception
(cherry picked from commit 01ba3a4efc)
7 years ago
Dag Wieers c5f7b5baa5 aci_domain: Add missing integration tests (#36051)
(cherry picked from commit 30adc2f124)
7 years ago
Abhijeet Kasurde 92e64c9eb9
VMware: re-enable vmware_guest_powerstate tests (#36094)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

(cherry picked from commit 66743f33fa)
7 years ago
Trishna Guha fe9e887f86
fix nxos_bgp_af issues (#36147) (#36283)
* fix nxos_bgp_af issues

* shippable fix

* review comments

* shippable error fix

(cherry picked from commit 75a34f6668)
7 years ago
Toshio Kuratomi a7a03bbf4a Normalize usage of temp and tmp on tmp (#36221)
* Normalize usage of temp and tmp on tmp
* Rename system_tmps system_tmpdirs
* Add ANSIBLE_REMOTE_TMP spelling of environment variables

(cherry picked from commit 06f73ad578)
7 years ago
Trishna Guha a6be3df24c
Fix nxos_linkagg tests (#36175) (#36222)
(cherry picked from commit 787114462e)
7 years ago
Brian Coca 74b120329c never tags docs and test (#35964)
* fufilling the promise

* moved changes

* Copy edit

(cherry picked from commit 0cf70a8970)
7 years ago
Jordan Borean 7dd4625dde
win_uri: fix creates/removes option (#36016)
(cherry picked from commit f8d1c97279)
7 years ago