5404 Commits (bafcd7becd0c0c72f1182b25f1ff7fcb030c69e8)

Author	SHA1	Message	Date
James Cammarata	40bdf09998	Merge pull request #12561 from srvg/anotherdirpy ... Inject existing groups at InventoryDir initialization	10 years ago
James Cammarata	6fcd292c5e	Merge pull request #12569 from amenonsen/fixes ... Bring groups handling in ini.py up-to-date (trivial fix)	10 years ago
James Cammarata	dfa33d0f23	Tweak variable manager use in role includes to avoid test failures	10 years ago
Abhijit Menon-Sen	50d75f8d6d	Bring groups handling in ini.py up-to-date ... Since c8f2483d, ini.py expects to always be passed in a pre-created list of groups, and can no longer deal sensibly with an empty list; this just makes that expectation clear.	10 years ago
James Cammarata	a89412ecb1	Fail all hosts if a run_once task fails ... Fixes #12563	10 years ago
James Cammarata	7173f587ed	Allow delegate_to on a role again ... Fixes #12560	10 years ago
James Cammarata	a3e913da62	Don't assume handlers exist in the same role (if any) ... Fixes #12536	10 years ago
Serge van Ginderachter	7461ba9998	Inject existing groups at InventoryDir initialization ... This fixes a corner case where ini files live in a subdir of the main inventory directory. Reproducing the original error: mkdir -p inventory/ini cat > inventory/ini/hosts << EOF [www] www1 EOF $ ansible -i inventory/ all -m ping ERROR! 'all' (or without the [www] group, it would complain about 'ungrouped')	10 years ago
James Cammarata	79e364d98b	Properly template role dependency names ... Fixes #12505	10 years ago
Marius Gedminas	5edd6d9be4	Python 3: there's no basestring ... Fixes another failing test. (I don't want to do a global search/replace for 'basestring' because I want to have unit tests covering each occurrence. When I run out of existing failing tests, I'll try to write new ones.)	10 years ago
Toshio Kuratomi	95ede22a1e	Add a comment about the docker connection and usage by non-root users	10 years ago
Toshio Kuratomi	0e110d23f8	Misc cleanups and some fixes for docker connection plugin ... * Remove extraneous imports * Fix some error handling * Enable pipelining * Disable su since it doesn't work * Add error message when installed docker is not recent enough to support this plugin * Move nested functions to class level * Make transport a class attribute * Make exec_command, put_file and fetch_file more robust	10 years ago
Toshio Kuratomi	1d119a1f46	Cleanup some extraneous imports	10 years ago
James Cammarata	ffdba96668	Save the included directory for playbook includes for use as the basedir ... Fixes #12524	10 years ago
Konstantin Manna	4226e49bc6	bugfix: statement had no effect => statement now has assumed effect	10 years ago
Konstantin Manna	1ccfeafa76	bugfix: use correct close calls	10 years ago
Brian Coca	c1ad96e5cf	removed fixme as it is already implemented below.	10 years ago
RedRampage	922b5c8109	Removed deletion of salt by 'password' lookup ... Removed deletion of salt param from lookup file by 'password' lookup_filter. Old behaviour leads to constant changed status when two tasks uses same lookup, one with 'encrypt' parameter, and other without. For example: tasks: - name: Create user user: password: "{{ lookup('password', inventory_dir + '/creds/user/pass' ncrypt=sha512_crypt) }}" ... # Lookup file 'creds/user/pass' now contain password with salt - name: Create htpasswd htpasswd: password: "{{ lookup('password', inventory_dir + '/creds/user/pass') }}" ... # Salt gets deleted from lookup file 'creds/user/pass' # Next run of "Create user" task will create it again and will have 'changed' status	10 years ago
Toshio Kuratomi	12a2585e84	chroot plugin minor touchups: ... * Disable su as it's not currently working 100% (and was disabled in v1). * Move BUFSIZE out of the class to match other conenction plugins * _connect shouldn't return self.	10 years ago
Toshio Kuratomi	7a4266e9c5	One more try -- the error message should reference the become method ... requested via play context	10 years ago
Toshio Kuratomi	696cf32d63	Correct name of variable	10 years ago
Brian Coca	8d024c3747	Merge pull request #12472 from resmo/for_ansible ... cloudstack: improvements and tests	10 years ago
Toshio Kuratomi	0dfa1fb43a	Correct call to method typo	10 years ago
Toshio Kuratomi	d827325644	Re-order the methods in ssh.py so that methods needed for implementation are near and just above the relevant public methods. ... Standard with the rest of the code base.	10 years ago
Toshio Kuratomi	37844a5c1b	Update submodule refs	10 years ago
Toshio Kuratomi	c811668a4d	Merge pull request #12546 from amenonsen/ssh-cleanups ... A couple of ssh cleanups	10 years ago
Toshio Kuratomi	05af4c8e91	Merge pull request #12471 from amenonsen/pipelining ... Make pipelining a connection variable	10 years ago
Abhijit Menon-Sen	38c7422da5	Move ControlPersist/Path checking into a separate method ... This is also peripheral to what _build_command needs, can be improved and tested independently, and so makes more sense in a separate method. This commit doesn't change any functionality (and I've verified that it works with the various combinations: control_path set in ansible.cfg, ssh_args adding or not adding ControlMaster/ControlPersist, etc.).	10 years ago
Toshio Kuratomi	c3a05b1181	Update to fix one more doc error	10 years ago
Abhijit Menon-Sen	f33d541964	Move sshpass checking into a separate method ... Checking for sshpass is peripheral to the calling code, so it's easier to follow when the details are moved into a method.	10 years ago
Abhijit Menon-Sen	565c6f1ae7	Make ansible_pipelining a connection variable ... SSH pipelining can be a significant performance improvement, but it will not work if sudoers is configured to requiretty. With this change, one could have pipelining enabled in ansible.cfg, but use sudo to turn off requiretty in a separate play (or task) where pipelining is disabled: - hosts: foo vars: ansible_pipelining: no tasks: - lineinfile: dest=/etc/sudoers line='Defaults requiretty' state=absent sudo_user: root (Note that sudoers has a complicated syntax, so the above lineinfile invocation may be too simplistic for production use; but the point is that a separate play can do something to disable requiretty.)	10 years ago
Toshio Kuratomi	fd267989fb	Fix docs build	10 years ago
Toshio Kuratomi	69ebb899a7	Update submodule refs	10 years ago
James Cammarata	c860775b5d	Another fix for --limit in adhoc	10 years ago
James Cammarata	babf47decb	Clean up some bugs related to --limit on adhoc commands	10 years ago
James Cammarata	621575681a	Merge pull request #12542 from amenonsen/qfix ... Clarify why we add -q only for ssh	10 years ago
Abhijit Menon-Sen	2ce219b5af	Clarify why we add -q only for ssh	10 years ago
Marius Gedminas	9b39af8e9a	Python 3: the StringIO module is gone ... Fixes 17 failing tests on Python 3.4, restoring the 8 failures we had last Friday.	10 years ago
Jesper Geertsen Jonsson	353b549eb0	Fix HTTPError message not being reachable	10 years ago
James Cammarata	4cd810a674	Only append -q option for ssh if we're using ssh	10 years ago
James Cammarata	46984a067c	Don't wrap vars from include_vars with UnsafeProxy	10 years ago
James Cammarata	abfeb104df	Merge pull request #12529 from soarpenguin/bug-fix ... fix no self pointer out of class.	10 years ago
Toshio Kuratomi	342bc97322	Port chroot conection plugin to the latest v2 connection API. ... Also get pipelining working for people who look to chroot as an example for their own connection plugins Note: In the latest v2 API, action handles become but chroot doesn't reliably handle become. Maybe we need to add a has_become attribute that the action can display an appropriate error.	10 years ago
Toshio Kuratomi	056a020357	Do not fail if /proc/uptime is not present ... This can happen in chroot environments that don't have all of /proc available	10 years ago
Toshio Kuratomi	ae66d01a33	Document how a command is executed on the remote machine ... Helps connection plugin implementors understand how to structure exec_command()	10 years ago
James Cammarata	6dd38c2a10	Fix parent attribute lookup to be default ... Fixes #12526	10 years ago
James Cammarata	a1c38a3fda	Adding delegate_to to Blocks	10 years ago
Brian Coca	bb6141ec41	renamed managed_syslog to no_target_syslog	10 years ago
Abhijit Menon-Sen	8251ab2e37	Update outdated comment ... Since #12165 was merged, hostnames are properly validated.	10 years ago
Abhijit Menon-Sen	6ff4d40d74	Update outdated comment ... We now use "sudo -n" instead of "sudo -k && sudo …"	10 years ago
soarpenguin	1ea66e234f	fix logic judgment error.	10 years ago
soarpenguin	2caa52a981	fix no self pointer out of class.	10 years ago
Brian Coca	37a918438b	task logging revamp ... * allow global no_log setting, no need to set at play or task level, but can be overriden by them * allow turning off syslog only on task execution from target host (manage_syslog), overlaps with no_log functionality * created log function for task modules to use, now we can remove all syslog references, will use systemd journal if present * added debug flag to modules, so they can make it call new log function conditionally * added debug logging in module's run_command	10 years ago
James Cammarata	60e1a1f8eb	Fix bug in nested lookup where pop is called indiscriminately	10 years ago
Brian Coca	191ae0831d	fixed syntax error	10 years ago
Brian Coca	48412c13b2	fixed copy n paste typo on future code	10 years ago
James Cammarata	bb1101498d	Clean up typo from cdc6c52	10 years ago
James Cammarata	cdc6c5208e	Clean string data run through the template engine ... Also strip UnsafeProxy off of low level srings and objects to ensure they don't cause issues later down the road Fixes #12513	10 years ago
James Cammarata	ae9b34b1d9	Fix for equality checking in Host to make sure things are like types	10 years ago
Toshio Kuratomi	fa9ea32a86	Fix test of whether a result has a failed host	10 years ago
Brian Coca	1c49e3b842	draft shared service code for modules, part of spliting service module	10 years ago
Toshio Kuratomi	41756be4d3	Update core module ref	10 years ago
Toshio Kuratomi	dcdcd9e9c5	Move is_executable to the toplevel of basic.py so we can utilize it from other code	10 years ago
James Cammarata	ccddda1ebc	Merge pull request #12502 from mgedmin/py3k ... Python 3: make test_variable_manager_precedence pass	10 years ago
James Cammarata	eb8d7dcd14	Make sure formatted strings don't bomb on tuples ... Fixes #12501	10 years ago
James Cammarata	31d5f88a1d	Use the task loop to calculate multiple delegated hosts ... Due to the way we're now calculating delegate_to, if that value is based on a loop variable ('item') we need to calculate all of the possible delegated_to variables for that loop. Fixes #12499	10 years ago
Toshio Kuratomi	a1428d6bed	Remove tmp as a parameter to the connection plugins ... There doesn't appear to be anything that actually uses tmp_path in the connection plugins so we don't need to pass that in to exec_command. That change also means that we don't need to pass tmp_path around in many places in the action plugins any more. there may be more cleanup that can be done there as well (the action plugin's public run() method takes tmp as a keyword arg but that may not be necessary). As a sideeffect of this patch, some potential problems with chmod and the patch, assemble, copy, and template modules has been fixed (those modules called _remote_chmod() with the wrong order for their parameters. Removing the tmp parameter fixed them.)	10 years ago
James Cammarata	95b371dd60	Use AnsibleFileNotFound instead of AnsibleParsingError when YAML files are not found ... And update portions of code to expect the proper error. Fixes #12512	10 years ago
Toshio Kuratomi	0250beb68a	Remove compress option from paramiko connection for now ... It's not available on older versions of paramiko such as shipped in RHEL6	10 years ago
James Cammarata	12df9f2e31	Make hostvars more dynamic again to improve performance with large inventories ... Fixes #12477	10 years ago
Abhijit Menon-Sen	82b33c381f	We don't need even a token timeout here; just poll once ... The process is already gone, so there's not going to be any new data showing up on its stderr; we only want to make sure that we haven't missed something that was already written. So polling once is enough.	10 years ago
Abhijit Menon-Sen	6e82df451a	Clarify select() handling for ssh connections ... This change is motivated by an ssh oddity: when ControlPersist is enabled, the first (i.e. master) connection goes into the background; we see EOF on its stdout and the process exits, but we never see EOF on its stderr. So if we ran a command like this: ANSIBLE_SSH_PIPELINING=1 ansible -T 30 -vvv somehost -u someuser -m command -a whoami We would first do select([stdout,stderr], timeout) and read the command module output, then select([stdout,stderr], timeout) again and read EOF on stdout, then select([stderr], timeout) AGAIN (though the process has exited), and select() would wait for the full timeout before returning rfd=[], and then we would exit. The use of a very short timeout in the code masked the underlying problem (that we don't see EOF on stderr). It's always preferable to call select() with a long timeout so that the process doesn't use any CPU until one of the events it's interested in happens (and then select will return independent of elapsed time). (A long timeout value means "if nothing happens, sleep for up to <x>"; omitting the timeout value means "if nothing happens, sleep forever"; specifying a zero timeout means "don't sleep at all", i.e. poll for events and return immediately.) This commit uses a long timeout, but explicitly detects the condition where we've seen EOF on stdout and the process has exited, but we have not seen EOF on stderr. If and only if that happens, it reruns select() with a short timeout (in practice it could just exit at that point, but I chose to be extra cautious). As a result, we end up calling select() far less often, and use less CPU while waiting, but don't sleep for a long time waiting for something that will never happen. Note that we don't omit the timeout to select() altogether because if we're waiting for an escalation prompt, we DO want to give up with an error after some time. We also don't set exceptfds, because we're not actually acting on any notifications of exceptional conditions.	10 years ago
Toshio Kuratomi	03127dcfae	remove the stdin return value from connection plugin exec_command() methods ... The value was useless -- unused by the callers and always hardcoded to the empty string.	10 years ago
James Cammarata	9d47eabfa4	Merge pull request #12506 from hyperized/devel ... Add Weekday (0-6) as a number and add weeknumber (00-52)	10 years ago
Toshio Kuratomi	24b9e2e6d1	Update extras submodule ref	10 years ago
Gerben Geijteman	4c20964475	Add Weekday (0-6) as a number and add weeknumber (00-52)	10 years ago
Marius Gedminas	56f2a25bff	Python 3: there's no 'unicode'	10 years ago
Marius Gedminas	6d4618f46f	Python 3: there's no dict.iteritems()	10 years ago
Marius Gedminas	0624797375	Bugfix: if you define a custom __eq__, you must define a __hash__ too ... Also, on Python 3 the stock object.__hash__ raises an error ("unhashable type"), and we have code that uses Host instances as dict keys.	10 years ago
Marius Gedminas	a2bc6b4b26	Bugfix: if you define __eq__, you should define __ne__ too	10 years ago
Marius Gedminas	5d29a2eabd	Python 3: shlex.split() wants unicode ... On Python 2, shlex.split() raises if you pass it a unicode object with non-ASCII characters in it. The Ansible codebase copes by explicitly converting the string using to_bytes() before passing it to shlex.split(). On Python 3, shlex.split() raises ('bytes' object has no attribute 'read') if you pass a bytes object. Oops. This commit introduces a new wrapper function, shlex_split, that transparently performs the to_bytes/to_unicode conversions only on Python 2. Currently I've only converted one call site (the one that was causing a unit test to fail on Python 3). If this approach is deemed suitable, I'll convert them all.	10 years ago
Toshio Kuratomi	5d3d9cfe0d	Convert to byte strings to avoid UnicodeErrors ... Fixes #12488	10 years ago
Brian Coca	de18bcb95f	correct typo on error reporting ... fixes #12495	10 years ago
Abhijit Menon-Sen	40f608a377	A bit more debugging output ... We used to display input chunks earlier anyway, so this isn't making things more verbose.	10 years ago
Abhijit Menon-Sen	9700d9c04f	Fix typo in checking select results ... It's possible for more than one fd to be set, so 'elif' is obviously not the right thing to use.	10 years ago
James Cammarata	1164e83477	Remove unnecessary calls to save inventory restrictions since 81bf88b	10 years ago
Toshio Kuratomi	89a78ba16e	Update submodule refs	10 years ago
James Cammarata	9e734df0ec	Conditionally poll longer if we're still waiting for an auth prompt	10 years ago
Toshio Kuratomi	5f0f5363b6	Merge pull request #12487 from mgedmin/py3k ... Fix one more failing test on Python 3	10 years ago
James Cammarata	2898e000a0	Don't use the connection timeout for the select poll timeout	10 years ago
Abhijit Menon-Sen	587054db2a	Send initial data before calling select whenever possible ... Without this, we could execute «ssh -q ...» and call select(), which would timeout after the default 10s, and only then send initial data. (This is a relic of the earlier change where we always ran ssh with -vvv, so the situation where it would sit quietly never happened in practice; but this would have been the right thing to do even then.)	10 years ago
James Cammarata	c9a004227e	Improve error catching from malformed playbook data ... Fixes #12478	10 years ago
James Cammarata	e8e1d9f6fb	Apply --limit to inventory in adhoc commands ... Fixes #12473	10 years ago
Marius Gedminas	95e655eb67	Python 3: there's no basestring ... Fixes one failing test. The long series of module_utils/basic.py fixes were all because module_utils/basic is imported in ansible/inventory/script.py.	10 years ago
Marius Gedminas	2c4982b58d	Python 3: there's no itertools.imap ... Because the builtin map() acts like an iterator already.	10 years ago
Marius Gedminas	6708d56a21	Python 3: avoid long integer literals ... Even Python 2.4 automatically promotes int to long.	10 years ago
Marius Gedminas	f5d4935197	Python 3: treat python as a function in module_utils/basic.py ... NB: we can't use 'from __future__ import print_function', but luckily print(one_thing) works fine on both Python 2 and Python 3 without that.	10 years ago
Marius Gedminas	e71a986e16	Python 3: avoid octal constants in module_utils/basic.py	10 years ago
Marius Gedminas	d2bec7f81f	Python 3: avoid "except ..., e:" in module_utils/basic.py ... Make the code compatible with Pythons 2.4 through 3.5 by using sys.exc_info()[1] instead. This is necessary but not sufficient for Python 3 compatibility.	10 years ago
James Cammarata	65630d2ce1	Fixing one more bug related to staticmethods in LookupBase	10 years ago
James Cammarata	cbbb270761	Cleanup bug from moving base lookup methods to staticmethods	10 years ago
Abhijit Menon-Sen	ac98fe9e89	Implement ssh connection handling as a state machine ... The event loop (even after it was brought into one place in _run in the previous commit) was hard to follow. The states and transitions weren't clear or documented, and the privilege escalation code was non-blocking while the rest was blocking. Now we have a state machine with four states: awaiting_prompt, awaiting_escalation, ready_to_send (initial data), and awaiting_exit. The actions in each state and the transitions between then are clearly documented. The check_incorrect_password() method no longer checks for empty strings (since they will always match), and check_become_success() uses equality rather than a substring match to avoid thinking an echoed command is an indication of successful escalation. Also adds a check_missing_password connection method to detect the error from sudo -n/doas -n.	10 years ago
Abhijit Menon-Sen	840a32bc08	Reorganise ssh.py to cleanly separate responsibilities ... The main exec_command/put_file/fetch_file methods now _build_command and call _run to handle input from/output to the ssh process. The purpose is to bring connection handling together in one place so that the locking doesn't have to be split across functions. Note that this doesn't change the privilege escalation and connection IO code at all—just puts it all into one function. Most of the changes are just moving code from one place to another (e.g. from _connect to _build_command, from _exec_command and _communicate to _run), but there are some other notable changes: 1. We test for the existence of sshpass the first time we need to use password authentication, and remember the result. 2. We set _persistent in _build_command if we're using ControlPersist, for later use in close(). (The detection could be smarter.) 3. Some apparently inadvertent inconsistencies between put_file and fetch_file (e.g. argument quoting, sftp -b use) have been removed. Also reorders functions into a logical sequence, removes unused imports and functions, etc. Aside: the high-level EXEC/PUT/FETCH description should really be logged from ConnectionBase, while individual subclasses log transport-specific details.	10 years ago
James Cammarata	95c6fe88e4	Fix handling of conditional vars_files which contain variables ... Fixes #12484	10 years ago
Toshio Kuratomi	c83f51b7f2	Some LookupBase cleanups: ... * Make LookupBase an abc with required methods (run()) marked as an abstractmethod * Mark methods that don't use self as @staticmethod * Document how to implement the run method of a lookup plugin.	10 years ago
Toshio Kuratomi	049952fa50	Update submodule refs.	10 years ago
James Cammarata	1e7fd2196d	Fixing synchronize + delegate_to user bug ... Fixes #12464	10 years ago
James Cammarata	3ffc2783c4	Don't bomb out on handlers with undefined variables in their names	10 years ago
Toshio Kuratomi	4b0d52d2cb	Merge pull request #12420 from ansible/win_prefix_modules ... Fix for user defined modules not overriding modules from core.	10 years ago
James Cammarata	1076155d8d	When failing because of vars_files templating, try and bubble up the file/line info	10 years ago
Toshio Kuratomi	18e2ee16ef	Fix for user defined modules not overriding modules from core. ... This fix takes into account that powershell modules are somewhat different than regular modules and have to be kept separate.	10 years ago
Toshio Kuratomi	f61fb9787d	Update submodule refs	10 years ago
Rene Moser	b43939dfd6	cloudstack: make tags handling idempotence ... Credits to @jeffersongirao, who provided the patch.	10 years ago
James Cammarata	c30e464388	Additional tweaks to callback output for delegate_to	10 years ago
James Cammarata	513619867a	Show delegated-to host in callback message ... Fixes #12465	10 years ago
Rene Moser	efd122c2f0	cloudstack: add returns_to_int return handling into utils ... It is not uncommon that the API returns string for int values e.g. ports in listFirewallRules or listPortForwardings,	10 years ago
Rene Moser	c9a3801a25	cloudstack: common argument_spec and requried_together to utils	10 years ago
James Cammarata	f563b22446	Merge pull request #12461 from mgedmin/py3k ... Python 3: there's no basestring	10 years ago
James Cammarata	d2949f5449	Merge pull request #12463 from mgedmin/fix-ansible-doc ... Fix option descriptions in ansible-doc output	10 years ago
James Cammarata	0fb4a6a67b	Tweak to the way new host variables are created for delegated hosts	10 years ago
Marius Gedminas	339790adc4	Fix option descriptions in ansible-doc output ... Fixes #12462.	10 years ago
James Cammarata	18adfc6d1a	Set some default vars on hosts created for delegate_to connections	10 years ago
James Cammarata	a22f7b883d	Restrict role param vars to tasks within that role ... Fixes #12460	10 years ago
Marius Gedminas	fc0dcc3947	Python 3: there's no basestring ... Fixes one failing test. Now technically a filename can be a bytestring, even on Python 3. I hope this is unlikely for Ansible.	10 years ago
James Cammarata	ecf7d8c9ee	Fix relative path bug in copy action ... Without rebreaking #12055 Fixes #ansible-modules-core/2098	10 years ago
James Cammarata	53794b692c	Merge pull request #12457 from ansible/warn-if-core-modules-not-present ... Detect if core modules aren't installed and warn if that is the case	10 years ago
Toshio Kuratomi	627f9d73ba	Detect if core modules aren't installed and warn if that is the case ... Fixes #11206	10 years ago
Brian Coca	d27b73e7b5	fixed case in which boto3 is present but module is not using it yet	10 years ago
James Cammarata	cb7060c9fe	Allow undefined var errors to bubble up when templating vars_files in certain conditions ... Follow up to 8769f03c, which allows the undefined var error to be raised if we're getting vars with a full context (play/host/task) and the host has already gathered facts. In this way, vars_files containing variables that fail to be templated are not silently ignored.	10 years ago
Brian Coca	f96255f7fd	fixed typo	10 years ago
James Cammarata	86566e691a	Merge pull request #12447 from mgedmin/py3k ... Python 3: there is no 'basestring'	10 years ago
James Cammarata	8769f03c16	Also catch AnsibleUndefinedVariable errors when templating vars_files names ... Fixes #12449	10 years ago
Toshio Kuratomi	2a614c1c0f	Close module file once we're done reading from it	10 years ago
Marius Gedminas	9cdb6ebae3	Python 3: there is no 'basestring' ... This fixes a failing unit test. In actual use (which is still quite far), I'm not sure if bytes -> unicode conversion should be done here (in which case the code will fail with an AttributeError: 'bytes' object has no attribute 'readlines'), or inside self._connection.exec_command() (in which case my change is correct).	10 years ago
Victor Salgado	20bbd66e85	Use dict.get()	10 years ago
James Cammarata	65bf14cbb0	Merge pull request #12431 from hslee16/devel ... Stops using _groups_list to check for host when using 'add_host'	10 years ago
James Cammarata	88e1aa94fa	Add play context vars to list of variables before post validation ... Fixes #12437	10 years ago
James Cammarata	05f6e76407	Template handler names before checking to see if they need to run ... Fixes #12427	10 years ago
James Cammarata	72769d1899	Merge pull request #12432 from mgedmin/py3k ... Python 3: there's no xrange	10 years ago
James Cammarata	37f2cbc429	Merge pull request #12436 from amenonsen/ranges ... Support «hosts: foo[1:]» and add tests for split/apply_subscript	10 years ago
James Cammarata	1f5584aa5b	Refactoring delegate_to code ... Now, instead of relying on hostvars on the executor side, we compile the vars for the delegated to host in a special internal variable and have the PlayContext object look for things there when applying task/ var overrides, which is much cleaner and takes advantage of the code already dealing with all of the magic variable variations. Fixes #12127 Fixes #12079	10 years ago
James Cammarata	fa69e8ebb8	Fixing some bugs in _compute_delegate() in TaskExecutor ... * Clearing interpreter settings from variables, so those set for the original host aren't incorrectly applied to the delegated to host * Fixed incorrect string for remote user in delegated hosts hostvars * Properly looking for multiple possiblities in the delegated-to hosts hostvars (ansible_ssh_host vs. ansible_host)	10 years ago
Peter Sprygada	e45b71d6cd	added new module object to vca	10 years ago
Abhijit Menon-Sen	2fcdb37e7b	Support «hosts: groupname[1:]» notation (~= 'the rest of the group')	10 years ago
Brian Coca	aca83b15e5	Merge pull request #12425 from privateip/devel ... initial add of vca common module	10 years ago
Brian Coca	11707576a3	fix for AIX network facts ... fixes #12434	10 years ago
Brian Coca	d7b61db6dc	made boto3 non mandatory	10 years ago
Toshio Kuratomi	fdb1c14004	Update the submodule pointers	10 years ago
Petr Mifek	27f779a7cc	Small clean up and refactor of the rsync target ipv6 observing formatter for synchronize action.	10 years ago
Marius Gedminas	baf9320369	Python 3: there's no xrange ... Use six.moves.range instead (aliased to xrange on Python 2, aliased to range on Python 3). Also I couldn't resist replacing the elaborate chr/ord/randrange dance with the simpler random.choice(string.ascii_lowercase) that was already used elsewhere in the Ansible codebase.	10 years ago
Alex Lee	cf289191e5	return None if group does not exist in inventory groups	10 years ago
Petr Mifek	6f3f4dff7a	Change synchronize module plugin to be backwards compatible with RSync 2.6.9 with regard to handling IPv6 addresses.	10 years ago
James Cammarata	cc6627cdd6	Remove custom json encoder cleaner and strip proxy var stuff out before encoding ... Fixes #12349	10 years ago
James Cammarata	c95d4ca05f	Properly assign search path to environment.loader in template lookup ... Same fix as was applied in f162990c to the action plugin Fixes #12355	10 years ago
James Cammarata	bde5ed9672	Catch worker errors that may be subclassed on others that lead to incorrect exits	10 years ago
Peter Sprygada	8f43d222c0	initial add of vca common module	10 years ago
James Cammarata	053c41e79d	Fix typo in ansible module_utils import from galaxy code	10 years ago
Chrrrles Paul	7b778d8a4b	Merge pull request #12424 from amenonsen/ipv6-ranges ... Tested. Thanks for spotting and then fixing this -- Allow hexadecimal ranges in IPv6 addresses, not only 0-9	10 years ago
Abhijit Menon-Sen	2d420a9bb7	Allow hexadecimal ranges in IPv6 addresses, not only 0-9	10 years ago
James Cammarata	b386f0c64d	Merge pull request #12423 from amenonsen/split-fixup ... Remove deprecation warning; now handled in _split_patterns	10 years ago
James Cammarata	a1fffff92c	Merge branch 'addresses' of https://github.com/amenonsen/ansible into amenonsen-addresses	10 years ago
Abhijit Menon-Sen	62ca6b5e35	Remove deprecation warning; now handled in _split_patterns	10 years ago
Abhijit Menon-Sen	575a8b8c77	Merge Host.ipv[46]_address into .address ... The earlier distinction was never used; .ipv6_address was always a copy of .ipv4_address, and the latter was always used to set the remote_addr field in the PlayContext. Also uses the canonical ansible_host/ansible_port names when setting the address and port from variables.	10 years ago
James Cammarata	951128d7a6	Merge branch 'hostpatterns' of https://github.com/amenonsen/ansible into amenonsen-hostpatterns	10 years ago
Victor Salgado	14fefebaad	Modify _split_pattern to use map when working with list input	10 years ago
James Cammarata	46baed864f	Submodule update after correcting doc bug	10 years ago
James Cammarata	0beb37a121	Submodule update	10 years ago
James Cammarata	ba82e57445	Merge branch 'sudo_on_if_needed' of https://github.com/apollo13/ansible into apollo13-sudo_on_if_needed	10 years ago
Toshio Kuratomi	8532ddd5ed	typo in formatting the warning message	10 years ago
Toshio Kuratomi	4ae5512fb0	Restore python3 compat fix and fix AnsibleError undefined before use	10 years ago
James Cammarata	c881b1acae	Merge pull request #12407 from mgedmin/py3k ... Python 3: basestring in play_context.py	10 years ago
James Cammarata	8acbc00853	Fixing groups variable structure to match v1 ... Fixes #12418	10 years ago
Abhijit Menon-Sen	349eec7855	Fix missing colon (typo) in IPv6 pattern	10 years ago
Abhijit Menon-Sen	2405861a9e	Use ',' instead of ':' or ';' to separate host patterns ... The earlier-recommended "pat1:pat2:pat3[x:y]" notation doesn't work well with IPv6 addresses, so we recommend ',' as a separator instead. We know that commas can't occur within a pattern, so we can just split on it. We still have to accept the "foo:bar" notation because it's so commonly used, but we issue a deprecation warning for it. Fixes #12296 Closes #12404 Closes #12329	10 years ago
Florian Apolloner	d9f873495e	Ported over #7158 to support SELinux context switches.	10 years ago
Brian Coca	ee840f3029	fixed function signature	10 years ago
Florian Apolloner	decd9e8710	Only use become if the target user difers from the current remote user.	10 years ago
Marius Gedminas	8243954dcd	Python 3: basestring in play_context.py	10 years ago
Toshio Kuratomi	3db8070aa3	Fix urlopen usage to use open_url instead ... Add a travis test for urlopen usage	10 years ago
James Cammarata	e97d448838	Cleanup one more missed inventory bug	10 years ago
James Cammarata	5db9e38377	Merge pull request #12345 from mgedmin/py3k ... Python 3: two more instances of 'basestring'	10 years ago
Chris Church	43b15ab9a4	Merge pull request #12385 from cchurch/winrm_put_empty_file ... Enable winrm put_file to upload an empty file.	10 years ago
Chris Church	93af0b327f	Merge pull request #12384 from cchurch/powershell_strict_mode ... Add PowerShell exception handling and turn on strict mode.	10 years ago
Chris Church	0325f92b6a	Merge pull request #12054 from cchurch/winrm_options ... Support additional options for WinRM connections via inventory variables	10 years ago
Chris Church	c5409ab493	Remove ansible_winrm_ host/port/user/pass options, update exception handling around establishing a winrm connection.	10 years ago
Chris Church	056c6b77d0	Support additional options for WinRM connections via inventory variables.	10 years ago
James Cammarata	11c27078c0	Cleaning up inventory bugs from earlier group change	10 years ago
Chris Church	1d15e8f37a	Pass windows command as-is without splitting/rejoining parameters. ... * Fixes extra spaces added between parameters from https://github.com/ansible/ansible-modules-core/issues/1929 * Correctly decode PowerShell command encoded as UTF-16-LE so that it displays correctly in debug messages, fixes the other issue from https://github.com/ansible/ansible-modules-core/issues/1929 * Add test to verify that script parameters are passed as-is, so $true is interpreted as a boolean, fixes https://github.com/ansible/ansible/issues/10947	10 years ago
Victor Salgado	54f1560d3e	Fix mutable default argument	10 years ago
James Cammarata	33e79203ce	Merge branch 'quinot-topic/crash_empty_inventory' into devel	10 years ago
James Cammarata	c8f2483d6d	Cleaning up default group creation in inventory parsers	10 years ago
Toshio Kuratomi	30552cf7e9	Fix problems with undefined references to self.display and remove method that's no longer called	10 years ago
James Cammarata	3f8e12d1f7	Merge pull request #12359 from cchurch/fetch_no_fail_on_missing ... Fix fetch to not fail for missing file when fail_if_missing=False	10 years ago
James Cammarata	4429e7611b	Merge pull request #12382 from AxelDelmas/env_async ... Added env_string in async_cmd	10 years ago
James Cammarata	e899b8e70d	Merge branch 'topic/crash_empty_inventory' of https://github.com/quinot/ansible into quinot-topic/crash_empty_inventory	10 years ago
James Cammarata	b2848bd25f	Merge pull request #12389 from amenonsen/minus-t ... Set PlayContext.timeout from the value specified by -T on the command-line	10 years ago
James Cammarata	d91ff0db74	Fixing parent block serialization for blocks ... Fixes #12395	10 years ago
Thomas Quinot	c005f75469	Always create 'all' group ... Create 'all' even if host_list is empty, as this group needs to exist when creating the implicit 'localhost' host. Fixes #12391	10 years ago
Abhijit Menon-Sen	85bb508f26	Set PlayContext.timeout from the value specified by -T on the command-line ... Fixes #12372	10 years ago
James Cammarata	2a50957ad8	Fix galaxy install dep failure ... Also fixes issue where force does not force reinstall of deps Fixes #10425	10 years ago