Commit Graph

61 Commits (ba9f910ec952aef70003d94ab7f0de436ec90649)

Author SHA1 Message Date
Adam Nielsen b35086c7a3 More descriptive error message if init system is unknown 11 years ago
Michael DeHaan 073d34b40e Merge pull request #6524 from tyll/update_rc_d_disable
service module: Properly disable Debian services
11 years ago
Cristian Ciupitu 7a4270184a Micro-optimization: replace s.find(x)==0 with s.startswith(x)
timeit shows a speedup of ~1.4x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
11 years ago
Till Maas 35f9e62422 service module: Properly disable Debian services
Services on Debian need to be disabled with 'disable' instead of 'remove'
to avoid them being enabled again when 'update-rc.d $service defaults' is run,
e.g. as part of a postinst script.
11 years ago
James Cammarata 9f9c077878 Merge branch 'issues/6341' of https://github.com/threatgrid/ansible into threatgrid-issues/6341 11 years ago
Michael DeHaan cac81b1ad9 Merge pull request #6339 from threatgrid/systemd-template-svc-fix
systemd template services must not discard template part
11 years ago
Michael DeHaan bf33be20e1 Merge pull request #6005 from pgehres/chkconfig
Adding better failure output for chkconfig failures
11 years ago
Cristian Ciupitu 7f681c33a2 Micro-optimization: replace s.find(x)!=-1 with x in s
timeit shows a speedup of ~3x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
11 years ago
James Tanner fc33860e5d Force command action to not be executed by the shell unless specifically enabled 11 years ago
Charles Duffy 532cda524f #6341: use shared function for parsing systemd status; check rc code 11 years ago
Charles Duffy fd5083fe71 #6341: check systemd service status with show subcommand 11 years ago
Charles Duffy 32620cab4d systemd template services must not discard template part 11 years ago
Peter Gehres a9bf607013 Adding better failure output for chkconfig failures rather than
just saying that the service name is unknown
11 years ago
jctanner 4901af0ef6 Merge pull request #5554 from ttarabul/devel
Use /etc/rc.conf.local for sevice configuration on FreeBSD
11 years ago
Brian Coca fee79e6501 be permissive with BSD with service enabled upper/lower/mixed cases
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
11 years ago
Tyler 5ce664b499 keep /usr/local/etc/rc.conf for backwards compatibility 11 years ago
Tyler c073438d40 Use /etc/rc.conf.local for sevice configuration on FreeBSD
/etc/rc.conf.local is the preferred location for system-specific
startup configuration, and /usr/local/etc/rc.conf generally isn’t used.

see:
http://www.freebsd.org/doc/handbook/configtuning-core-configuration.html
11 years ago
Jasper N. Brouwer 9dab01c5e2 Swapped conditions of the changed if statements 11 years ago
Jasper N. Brouwer 677f95294e Fixed false positive on initctl as enable_cmd
Also on update-rc.d
In service module
11 years ago
James Tanner 36c4f05891 Add more error detail to the service module for FreeBSD 11 years ago
Michael DeHaan 0e7069d7c1 Undo an inadvertant revert from template changes so we still allow pythonic imports in module land. 11 years ago
James Tanner 8036e6ee23 Revert templating enhancements from 73dbab70 e6c28658 d409352c 9858b1f2 4587528b 9b1fe455 214b0b05 8d3db803 7f9504d1 5031104c 35cb9dc2 2bd8cb57 1e85c754 11 years ago
Michael DeHaan bc6d454b5e Enable imports to work on a snippet based system, allowing for instance a library of common EC2 functions
to be reused between modules.  See library/system/service and library/system/ping for initial examples.  Can
work the old way to just import 'basic', or can import the new way to import multiple pieces of code from
module_utils/.
11 years ago
James Tanner f27e2fd285 Fixes #4448 reloaded services should be started if not running 11 years ago
Scott Sturdivant 037dcbb4da If the output of rcvar isn't a key=value pair, ignore it. 11 years ago
Michael DeHaan ce8b0944a9 Misc pep8 fixes 11 years ago
Michael DeHaan beae21dd40 Remove examples of module antipattern of setting the choices array for boolean types. 11 years ago
Michael DeHaan c405a61505 Merge pull request #4336 from orkaa/devel
Fixes service update-rc.d functionality on debian
11 years ago
Martijn Lina 3d16b75096 replace dashes in rc.conf keys (which are based on freebsd rc.d filenames) to underscores 11 years ago
Nace Oroz 1f39663a97 Fixes service update-rc.d functionality on debian 11 years ago
cdigiovanni 6720d0cf70 Added support to disable and enable upstart jobs 11 years ago
James Cammarata 3511687dad Minor tweak to service changed logic from the previous commit 11 years ago
James Cammarata 8bdb95a014 Merge branch 'service-enable-fix' of https://github.com/gottwald/ansible into gottwald-service-enable-fix 11 years ago
Petr Svoboda f82d3f7fa9 Fix traceback in service module when svc_cmd is None (2nd fix)
When service module is used on unsupported Linux system where init
script is used directly, LinuxService.svc_cmd is None so .endswith()
fails.

This extends fix from e2f20db534 also
for state=restarted.

Fixes issue #3533
11 years ago
Ingo Gottwald 08af5f833f Bugfix service module: Only change service state when needed 11 years ago
James Cammarata 0449470f21 Allow service module to manage services not ending in .service
Fixes #3417
11 years ago
James Cammarata 5fe192e5e7 Fixes to the service module for Ubuntu 12.04 (LTS)
Fixes #3615
Fixes #3572
11 years ago
James Cammarata 5e8918cb2c Check for systemd ownership of a service even if an init.d script exists
Also slight modification to the error message in the earlier commit that
modified the update-rc.d detection portion of the code

Fixes #3474
11 years ago
James Cammarata ef02c6107a Minor fix to account for template service names in systemctl 11 years ago
James Cammarata f22ffab259 Fix for update-rc.d based systems that also have systemd installed
By default, the service module had assumed that if the system had the
update-rc.d binary, the service was either managed via upstart or standard
sysV init-style scripts. This patch adds a check for systemctl ahead
of the other methods when update-rc.d is detected, and also simplifies
the logic around the detection of systemctl-managed services
11 years ago
James Cammarata 17f683aad7 Added 'reloaded' state to list of states checked for bounced services
Fixes #3556
11 years ago
Petr Svoboda 48b064b55b Fix traceback in service module when svc_cmd is None
When service module is used on unsupported Linux system where init
script is used directly, LinuxService.svc_cmd is None so .endswith()
fails.

Fixes issue #3533
11 years ago
Michael DeHaan b22428d87e Merge pull request #3426 from trbs/services_sleep_option
sleep option for service module which adds a pauze between stopping and ...
12 years ago
Brian Coca e0e50b5936 fixed check mode
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
trbs 0d8da6eeb0 sleep option for service module which adds a pauze between stopping and starting a service using state=restarted. This helps for bad scripts that exist immediatly after signaling a process to stop. 12 years ago
Antti Rasinen c2a4645349 Fix service enable on FreeBSD
Some services have a knob (i.e. rc.conf setting) whose name
differs from that of the script. For example, lockd process
is controlled with a script called lockd, but the rc.conf
value is rpc_lockd_enable.

Fixes issue #3382.
12 years ago
martin f. krafft 3b7b061b07 Expand usage of Python 2.6 if statement
Syntax like "'foo' if bar else 'baz'" is not supported by all Python
versions targetted by Ansible. Hence we break it up.

Signed-off-by: martin f. krafft <madduck@madduck.net>
12 years ago
martin f. krafft 22b30b9281 Let update-rc.d set changed flag properly
When update-rc.d is used to enable/disable service, the changed flag was
always true (see #2189). This commit fixes that.

Signed-off-by: martin f. krafft <madduck@madduck.net>
12 years ago
Michael DeHaan 997bf64f3f Fix up some module docs formatting errors. 12 years ago
Michael DeHaan e4f3c4e286 Clarify module docs 12 years ago