Commit Graph

10983 Commits (b6c07bc9e9ade341e11c354a4bcb7d45ddc27666)

Author SHA1 Message Date
Kenny Woodson f1db594e9f Getting rid of a None type error when no resource tags are defined. (#4638) 8 years ago
Toshio Kuratomi 69ec272982 Python3 fixes to copy, file, and stat so that the connection integration tests can be run (#4632)
* Python3 fixes to copy, file, and stat so that the connection integration tests can be run

* Forgot to audit the helper functions as well.

* Fix dest to refledt b_dest (found by @mattclay)
8 years ago
GGabriele cba6804824 Adding nxos_interface_ospf 8 years ago
GGabriele 0a8a84a50d Adding nxos_hsrp 8 years ago
GGabriele c902f2da14 Fix typo 8 years ago
GGabriele aabab30a4f Fix try/except 8 years ago
GGabriele e392417232 Adding nxos_file_copy 8 years ago
GGabriele 40e600e901 Adding nxos_evpn_vni 8 years ago
GGabriele 52ed410679 Fixed DOCSTRING 8 years ago
GGabriele 0bedbb6bed Adding nxos_bgp_neighbor_af module 8 years ago
GGabriele bd758e8188 Adding nxos_bgp_neighbor module 8 years ago
GGabriele fdfec51cce Fixing DOCSTRING yaml format 8 years ago
GGabriele b5dbfd70d4 Fixing DOCSTRING 8 years ago
GGabriele e0f4565822 Adding nxos_bgp_af module 8 years ago
GGabriele a6f09215ec Adding python object for 2.1 support 8 years ago
GGabriele 77c247ba3b Adding python objects for 2.1 support 8 years ago
GGabriele d0acaf72e8 Removing delete for bollean, fixing argparse, embedding python object 8 years ago
Peter Sprygada ac1c643cc8 bugfix that adds missing itertools import to ios_facts
fixes #4647
8 years ago
Peter Sprygada 702efda508 add new functionality to junos_command module
* commands argument now accepts a dict arguments
* rpcs argument now accepts a dict argument
* waitfor has been renamed to wait_for with an alias to waitfor
* only show commands are allowd when check mode is specified
* config mode is no longer allowed in the command stack
* add argument match with valid values any, all
8 years ago
Michael Scherer 30cd0e8afe Add support for selinux_boolean_sub conversion (#4570)
SELinux since 2012 use a configuration file to
convert boolean names from a old name to a new name,
for preserving backward compatibility.

However, this has to be done explicitely when using the python
bindings, and the module was not doing it.

Openshift ansible script use this construct to detect if
a boolean exist or not:

    - name: Check for existence of virt_sandbox_use_nfs seboolean
      command: getsebool virt_sandbox_use_nfs
      register: virt_sandbox_use_nfs_output
      failed_when: false
      changed_when: false

    - name: Set seboolean to allow nfs storage plugin access from containers(sandbox)
      seboolean:
        name: virt_sandbox_use_nfs
        state: yes
        persistent: yes
      when: virt_sandbox_use_nfs_output.rc == 0

On a system where virt_sandbox_use_nfs do not exist, this work. But
on a system where virt_sandbox_use_nfs is a alias to virt_use_nfs (like
Fedora 24), this fail because the seboolean is not aware of the alias.
8 years ago
Toshio Kuratomi 45846127c5 to_text, to_bytes, and to_native now have surrogate_or_strict error handler (#4630)
On python3, we want to use the surrogateescape error handler if
available for filesystem paths and the like.  On python2, have to use
strict in these circumstances.  Use the new error strategy for to_text,
to_bytes, and to_native that allows this.
8 years ago
John R Barker aa0b93a338 Consistent naming of Arista EOS device (#4616) 8 years ago
Matt Clay 928ef28fc8 Add python3 testing for module PRs. (#4629) 8 years ago
Senthil Kumar Ganesan fed23d2f31 Cleaned up the module imports 8 years ago
Tobias Wolf cda78382b6 Fix database table quoting in privileges_unpack() (#3858)
In Ansible 2.x this module gives `changed = True` for all privileges
that are specified including a table with

    priv: "database.table:GRANT"

Mysql returns escaped names in the format

    `database`.`tables`:GRANT

However in PR #1358, which was intended to support dotted database names
(a crazy idea to begin with), the quotes for the table name were left
out, leading to `curr_priv != new_priv`.

This means that the idempotency comparison between new_priv and
curr_priv is always 'changed'.

This PR re-introduces quoting to the table part of the priv.
8 years ago
Jean Prat ed246a328f if user is empty, it is not converted to tuple when using host_all (#3038) 8 years ago
James Cammarata aa67bb43fe Adding 'end_play' docs to meta module 8 years ago
GGabriele 5277f645e5 Fixing DOC string 8 years ago
GGabriele 0b887cd193 Fixing RETURN string 8 years ago
GGabriele 6590c4677d Adding nxos_ospf_vrf module 8 years ago
GGabriele a678439059 Adding nxos_ospf module 8 years ago
GGabriele c8016946f3 Adding nxos_evpn_global module 8 years ago
GGabriele fb4da92308 Fixing typo 8 years ago
Toshio Kuratomi 5bd9cdad5a We've decided that pythn 3.5 is the minimum python3 version (#4572) 8 years ago
GGabriele a539ea47bc Adding nxos_acl_interface_module 8 years ago
Michael Scherer 25fd3928b6 Make async work on python 3 (#4583)
Since dict no longer have a iteritems method, we have to
use six to support python 2 and 3.
8 years ago
Michael Scherer f4158304ac Port mount.py to python3, need to use six.iteritems (#4581) 8 years ago
Michael Scherer b48e65219b Fix uri to run on python3 (#4580)
Since dict no longer have a method iteritems, we have to use
the six wrapper.
8 years ago
Michael Scherer f59af7d29e Port postgresql module to python3 (#4579)
Iteritems is no longer a dict method in Python3, replace it with
the six wrapper.
8 years ago
Michael Scherer 839d5b6de4 Fix mysql_user for python3 (#4576)
dict no longer have a iteritems method, it was replaced
by items. So we need to use six.

    Traceback (most recent call last):
      File \"/tmp/ansible_hjd7d65c/ansible_module_mysql_user.py\", line 587, in <module>
        main()
      File \"/tmp/ansible_hjd7d65c/ansible_module_mysql_user.py\", line 571, in main
        changed = user_add(cursor, user, host, host_all, password, encrypted, priv, module.check_mode)
      File \"/tmp/ansible_hjd7d65c/ansible_module_mysql_user.py\", line 239, in user_add
        for db_table, priv in new_priv.iteritems():
    AttributeError: 'dict' object has no attribute 'iteritems'
8 years ago
GGabriele 549ca5183d Adding RETURN string 8 years ago
Michael Scherer f2b6c7b6a2 Fix user module under python3 (#4560)
Using something like:

    - name: Create ssh keys
      user:
        name: root
        generate_ssh_key: yes
      register: key

result into this traceback on F24

    Traceback (most recent call last):
      File \"/tmp/ansible_jm5d4vlh/ansible_module_user.py\", line 2170, in <module>
        main()
      File \"/tmp/ansible_jm5d4vlh/ansible_module_user.py\", line 2108, in main
        (rc, out, err) = user.modify_user()
      File \"/tmp/ansible_jm5d4vlh/ansible_module_user.py\", line 660, in modify_user
        return self.modify_user_usermod()
      File \"/tmp/ansible_jm5d4vlh/ansible_module_user.py\", line 417, in modify_user_usermod
        has_append = self._check_usermod_append()
      File \"/tmp/ansible_jm5d4vlh/ansible_module_user.py\", line 405, in _check_usermod_append
        lines = helpout.split('\\n')
    TypeError: a bytes-like object is required, not 'str'
8 years ago
Michael Scherer 898cf5b462 Fix traceback on python3 (#4556)
Traceback (most recent call last):
  File "/tmp/ansible_csqv781s/ansible_module_systemd.py", line 374, in <module>
    main()
  File "/tmp/ansible_csqv781s/ansible_module_systemd.py", line 263, in main
    for line in out.split('\\n'): # systemd can have multiline values delimited with {}
8 years ago
GGabriele a4817cff30 Adding nxos_acl module 8 years ago
John R Barker 51aa4e803f Consistent naming of Arista EOS device 8 years ago
GGabriele bc47cf362b Fixing string case 8 years ago
Senthil Kumar Ganesan 8c5b189f8b Incorporated Ansible community feedback 8 years ago
Peter Sprygada 019de090d4 update ops_facts with enhancements
* adds support for default facts subset
* adds support for config facts subset
* maintain legacy facts from ops_facts pre-2.2

Tested on Openswitch 0.4.0
8 years ago
Peter Sprygada 018cdf33a2 update ops_template module using refactored network shared modules
This updates the ops_template module to work with the network shared
modules introduced in Ansible 2.2

Tested with OpenSwitch 0.4.0
8 years ago
Peter Sprygada 54232c3b2d update ops_config module with new enhancements
* add src argument to provide path to config file
* add new choice to match used to ignore current running config
* add update argument with choices merge or check
* add backup argument to backup current running config to control host
* add save argument to save current running config to startup config
* add state argument to control state of config file
* deprecated force argument, use match=none instead

Note: this module only supports transport=cli

Tested on OpenSwitch 0.4.0
8 years ago
Peter Sprygada ef46627f1f added new functionality to ops_command
* commands argument now accepts a dict arguments
* waitfor has been renamed to wait_for with an alias to waitfor
* only show commands are allowed when check mode is specified
* config mode is no longer allowed in the command stack
* add argument match with valid values any, all

Tested on OpenSwitch 0.4.0
8 years ago
GGabriele 882f201aa0 Fixing DOC 8 years ago
GGabriele 2b2636510d Adding nxos_bgp.py 8 years ago
Senthil Kumar Ganesan c66432bbae Moved the modules to Dell folder 8 years ago
Senthil Kumar Ganesan 90cb4710d7 Added Command and Config modules to support Dell Networking OS10 device 8 years ago
Peter Sprygada 0f4446166b update eos_eapi module with new enhancements
* add support for vrf configurations
* add support for configing the qos value for eapi
* add config argument to specify the device running-config

Tested on EOS 4.15.4F
8 years ago
Peter Sprygada 5e5698dc9e removes output keyword from command in ios_command
IOS devices only support a single command output which is structured
text.  This removes the ability to specify the command output format
when providing complex arguments to the commands
8 years ago
Peter Sprygada 7280b2642a update nxos_nxapi module with minor enhancements (#4573)
* added new config argument
* added states present and absent
* update to use network shared modules

Tested on NXOS 7.3(0)D1(1)
8 years ago
Timothy Appnel 5b00b40c22 Fixes get_url examples in docs and applies native YAML syntax. (#4474) 8 years ago
John R Barker 89529366bf digital_ocean_tag name is a required field
Spotted during final review of https://github.com/ansible/ansible-modules-core/pull/4218/files
Simple to change, so fixing post merge
8 years ago
Victor Volle 6a20e6649d Digitalocean tags (replaces #4209) (#4218)
* Fixes #4117: Add DigitalOcean Tag support

* Add GPLv3 license header and RETURN documentation

* ansible.module_utils.urls instead of "requests"
8 years ago
Arun prasath 7a7ac2ee83 Fixes bug #4546 - Made password optional (#4574) 8 years ago
David J Peacock bcc738bd0d Fix #4412: os_security_group_rule support numbered protocols (#4444) 8 years ago
Ryan Brown c85d854c84 Remove spurious `changed` state on iam_policy module (#4381)
Due to a mixup of the group/role/user and policy names, policies with
the same name as the group/role/user they are attached to would never be
updated after creation. To fix that, we needed two changes to the logic
of policy comparison:

- Compare the new policy name to *all* matching policies, not just the
  first in lexicographical order
- Compare the new policy name to the matching ones, not to the IAM
  object the policy is attached to
8 years ago
James S. Martin 4d75f9b4bc Shows messages for uncaught exceptions from called modules in async_wrapper output. (#4591) 8 years ago
Rick Mendes 503c2b6158 Fixes #3144 (#4305) 8 years ago
Vytis Banaitis 3149fdf158 Fix change status on django_manage collectstatic. (#4239)
Ignore blank lines in collectstatic output.
8 years ago
Guillaume Delpierre 90bf5434d0 gem: add support for --env-shebang (#4377)
* gem: add support for --env-shebang

* fix version added
8 years ago
Levi Morales 0c9d895438 Fixes #2322 fix for missing append check on Darwin systems (#4256) 8 years ago
Evan Kaufman 254df9bcca Implemented file content diff for replace module (#4479) 8 years ago
Matías Pizarro c1dae481e8 Use named parameters in new_droplet method call (#4483)
This mirrors the original method signature and guards against any
change in order parameter
8 years ago
Anton Onufriev f5f1062d72 Remove colors from git-branch output for correct local search (#4545)
We got an error while switching on existent local branch
because git module can not find branch in function get_branches
if we have color.branch=always in git config.
8 years ago
Michael Scherer ee5a48b84d Port the module to run on python 3 (#4496)
One of the usual issue is that run_command return bytes,
so we have to adapt the string to either be bytes too,
or convert to string.

This result into that kind of traceback:

    Traceback (most recent call last):
      File \"/tmp/ansible_ej32yu2w/ansible_module_git.py\", line 1009, in <module>
        main()
      File \"/tmp/ansible_ej32yu2w/ansible_module_git.py\", line 873, in main
        git_version_used = git_version(git_path, module)
      File \"/tmp/ansible_ej32yu2w/ansible_module_git.py\", line 788, in git_version
        rematch = re.search('git version (.*)$', out)
      File \"/usr/lib64/python3.5/re.py\", line 173, in search
        return _compile(pattern, flags).search(string)
    TypeError: cannot use a string pattern on a bytes-like object

Another issue is filter being a object instead of a list.
8 years ago
James Pharaoh 06f5f2e26d fix error in documentation for stat checksum (#4582) 8 years ago
Ilja Bauer 729486809e Replaced use of bare variables with full variable syntax (#4149) 8 years ago
Gennady Trafimenkov 7ea7564bf4 Clarify what checksum algorithm is used by copy modules (#4198) 8 years ago
Ali Ok 1e411f9551 Fix minor syntax error in authorized_key module doc (#4491) 8 years ago
Robin Roth ccddeb8cdc Clarify that refspec is needed to checkout a git hash (#4564)
fixes #1531
8 years ago
Michael Scherer 338a8c8632 Convert command output to native string (#4559)
Without it, the module always return changed on python3,
which is harmless but add noise and can have some side effects.
8 years ago
Peter Sprygada 66b0a1ef2d convert nxos_facts map from dict to frozenset
* key maps are now frozenset instead of dict objects
* FactsBase now includes utility functions for transforming json data structures

Tested on NXOS 7.3(0)D1(1)
8 years ago
chouseknecht 964b7ecffa Fix container labels expected vs actual comparison. 8 years ago
Brian Coca e37f57fc90 added docs for vars_from/defaults_from 8 years ago
Brian Coca 79d970d5b8 updated include_role docs to latest info 8 years ago
Peter Sprygada 4fd4ff8d5c update eos_template for network shared module
This updates the eos_template module to work with the changes introduced
in the network shared module in Ansible 2.2

Tested on EOS 4.15.4F
8 years ago
Peter Sprygada d0a98bc433 update nxos_template module with network shared module changes
This updates the nxos_template module to work with the network shared
modules introduced in Ansible 2.2

Tested on NXOS 7.3(0)D1(1)
8 years ago
Peter Sprygada 8f303981d4 update ios_template module using refactored network shared modules
This updates the ios_template module to work with the network shared
modules introduced in Ansible 2.2

Tested in IOS 15.6(1)T
8 years ago
Peter Sprygada 7eb550aa53 update iosxr_template to use network shared modules
This updates the iosxr_template module to make it work with the new
shared network modules introduced in Ansible 2.2

Tested on IOSXR 6.0.0
8 years ago
Peter Sprygada 0da190abbd add new iosxr_facts module for fact collection from XR devices
* adds support for std network facts
* adds support for default facts subset
* adds support for config facts subset
* adds support for interface facts subset
* adds support for hardware facts subset

Tested on IOS-XR 6.0.0
8 years ago
Jason Edelman 3b83e676e6 removed feature check for nxos_interface 8 years ago
Brian Coca b7d2c62f2b 1st draft of include role docs 8 years ago
Peter Sprygada 751eab187f updates nxos_facts with more fact collections
* adds support for std network facts
* adds support for default facts subset
* adds support for config facts subset
* adds support for interface facts subset
* adds support for hardware facts subset
* maintains backwards capabilitity with 2.1 facts module

Tested on NXOS 7.3(0)D1(1)
8 years ago
Peter Sprygada 733ee349b0 add new eos_facts module for fact collect of EOS nodes
* adds support for std network facts
* adds support for default facts subset
* adds support for config facts subset
* adds support for interface facts subset
* adds support for hardware facts subset

Tested on EOS 4.15.4F
8 years ago
Peter Sprygada d138b94c70 update iosxr_config with new arguments
* add src argument to provide path to config file
* add new choice to match used to ignore current running config
* add update argument with choices merge, replace or check
* add backup argument to backup current running config to control host
* add comment argument to provide comment to commit
* deprecated force argument, use match=none instead
8 years ago
Toshio Kuratomi c4988262b5 Fixes for lineinfile (#4553)
Lineinfile deals heavily with Unic text files.  Makes some sense to deal
with it all as byte strings.  So there is a lot of work done here to
show that we're dealing with byte strings throughout.
8 years ago
Peter Sprygada 28ab66cef2 update RETURNS doc string in ios_facts
updates the doc string for consistency and completeness
8 years ago
Patrick Marques 697a328124 ssh_public_keys on Azure virtual machine is a list (#4350)
The ssh_public_keys must be a list otherwise will give the error:
"argument ssh_public_keys is of type <type 'dict'> and we were unable to convert to list"
8 years ago
Peter Sprygada 5ebe26e782 initial add of network/sros modules
* adds support for sros_command module for sending arbitrary commands
* adds support for sros_config module for working with sros configurations
8 years ago
Dag Wieers 32e3cc7778 Fix multiple issues with unzip and gtar support (#4131)
* Improve the correct handling of gtar and unzip options

Add the option --show-transformed-names when extra_opts is being used
Ignore bogus warnings related to empty filenames
Properly quote _and_ escape filenames for unzip command
Rewrite gtar options and provide run_command with array, not string

This fixes #2480 and #4109.

* Make check-mode work for zip-files

Check-mode was disabled for zip-files since gtar did not support it.
This change enables check-mode support for zip-files, but does skip the task when used with gtar.
(Best of both worlds)

Also remove unused compress_mode variable.

This replaces PR #4401, the changes overlap somewhat so I merged them
8 years ago
Dag Wieers 02b906d70f Remove redundant code AFAICT (#3908) 8 years ago
Toshio Kuratomi b7522c5a1c Fix hg for python3 (#4528)
* Remove import of unused ConfigParser (ConfigParser has been renamed in py3)
* When retrieving version, normalize to a native string
8 years ago
Peter Sprygada bbcde06e75 added new functionality to vyos_command
* commands argument now accepts a dict arguments
* waitfor has been renamed to wait_for with an alias to waitfor
* only show commands are allowd when check mode is specified
* config mode is no longer allowed in the command stack
* add argument match with valid values any, all
8 years ago
Peter Sprygada 003b6da05a add new functionality to iosxr_command module
* commands argument now accepts a dict arguments[1]
* waitfor has been renamed to wait_for with an alias to waitfor
* only show commands are allowd when check mode is specified
* config mode is no longer allowed in the command stack
* add argument match with valid values any, all

[1] The commands argument will now accept a dict argument that can
specifiy the output format of the command.  To specify a dict argument
use the form of { command: <str>, output: <str>, prompt: <str>,
response: <str> }.
8 years ago
Peter Sprygada df972feb23 updates to vyos_config module arguments
* arguments for vyos_config for 2.2 are now complete
* adds loading config file from disk (src argument)
* removes unsupported rollback argument
* changes update_config to update with options merge or check
* changes backup_config to backup
* add state argument for state of configuration file
* adds backup argument to backup current configuration
* adds save argument to control if active config is saved to disk
* adds comment argument for setting commit comment
* adds match argument to control configuraiton match

Tested with VyOS 1.7
8 years ago
Gary Rybak e2d55d86e4 Move call to filter_exit out of command execution block to prevent setting 'changed' on a command list that is completely filtered (empty). 8 years ago
Richard Adams b0135fadea Add parameter to `ec2` module to control instance shutdown behavior (stop|terminate) 8 years ago
Toshio Kuratomi 9b7e866964 Cleanups of command.py (#4526)
* Import module_utils at the top
* Fix python3 by marking literals combined with stdout/stderr as byte
  literals
* Mark parameters as type=path where appropriate
8 years ago
Karthik Suresh 4d7d3cdbb1 Removing duplicate name: parameter possible typo (#4525)
Removed name:parameter in documentation. Possible typo.
8 years ago
Matt Clay f804bdad48 Enable CI on Shippable for OS X. (#4515) 8 years ago
chouseknecht 1b4a3dbc86 Fix doc strings. Use of > was breaking HTML generation on docs site module page. 8 years ago
Michael Scherer 1f8b2f3e6e Add support for setting fstab location on Linux too for mount (#3271)
Fix #3153
8 years ago
Michael Scherer 441205feed Add acl freebsd (#3656)
* FreeBSD do not support --omit-header and --absolute-names

* The option for following symlink wth getfacl is different on FreeBSD

* ZFS on Freebsd use nfsv4 acls, who use a slightly different syntax

* FreeBSD do not have a --test flag, so always return 'True'

* FreeBSD do not have the --omit-headers options, so we have to filter by ourself

* Mark Freebsd as working for the acl module
8 years ago
Peter Sprygada c98a906cf0 add new functionality to eos_command module
* commands argument now accepts a dict arguments[1]
* waitfor has been renamed to wait_for with an alias to waitfor
* only show commands are allowd when check mode is specified
* config mode is no longer allowed in the command stack
* add argument match with valid values any, all

[1] The commands argument will now accept a dict argument that can
specifiy the output format of the command.  To specify a dict argument
use the form of { command: <str>, output: <str>, prompt: <str>,
response: <str> }.  Command and output are required arguments. Output
accepts valid values text and json.
8 years ago
Peter Sprygada 717af59c96 update eos_config with new arguments
* add src argument to provide path to config file
* add new choice to match used to ignore current running config
* add update argument with choices merge, replace or check
* add backup argument to backup current running config to control host
* add defaults argument to control collection of config with or without defaults
* add save argument to save current running config to startup config
* add state argument to control state of config file
* deprecated force argument, use match=none instead
8 years ago
Peter Sprygada 12fc073f91 fix example in nxos_command module 8 years ago
codyrat c4d5b13c8f re.match for numeric only for kwargs[key] = int(value) (#4495) 8 years ago
Peter Sprygada 619e3bba7e fixes issue with duplicated commands in CommandRunner
The CommandRunner will not allow duplicate commands to be added to the
command stack.  This fix will now catch the exception and continue if
a duplicate command is attempting to be added to the runner instance.
8 years ago
Peter Sprygada e09cfec2e9 added new functionality to nxos_command
* commands argument now accepts a dict arguments[1]
* waitfor has been renamed to wait_for with an alias to waitfor
* only show commands are allowd when check mode is specified
* config mode is no longer allowed in the command stack
* add argument match with valid values any, all

[1] The commands argument will now accept a dict argument that can
specifiy the output format of the command.  To specify a dict argument
use the form of { command: <str>, output: <str>, prompt: <str>,
response: <str> }.  Command and output are required arguments. Output
accepts valid values text and json.
8 years ago
Peter Sprygada 543ec0f14e update nxos_config with new arguments
* add src argument to provide path to config file
* add new choice to match used to ignore current running config
* add update argument with choices merge or check
* add backup argument to backup current running config to control host
* add defaults argument to control collection of config with or without defaults
* add save argument to save current running config to startup config
* add state argument to control state of config file
* deprecated force argument, use match=none instead
8 years ago
Peter Sprygada 525cd8b947 merge functions from ios into ios_config
* merge changes from ios shared module functions into ios_config.
* add src argument to provide path to config file
* add new choice to match used to ignore current running config
* add update argument with choices merge or check
* add backup argument to backup current running config to control host
* add defaults argument to control collection of config with or withoutdefaults
* add save argument to save current running config to startup config
* add state argument to control state of config file
* deprecated force argument, use match=none instead
8 years ago
Peter Sprygada aa79cdb7d9 added new functionality to ios_command
* commands argument now accepts a dict arguments[1]
* waitfor has been renamed to wait_for with an alias to waitfor
* only show commands are allowd when check mode is specified
* config mode is no longer allowed in the command stack
* add argument match with valid values any, all

[1] The commands argument will now accept a dict argument that can
specifiy the output format of the command.  To specify a dict argument
use the form of { command: <str>, output: <str>, prompt: <str>,
response: <str> }.  Command and output are required arguments. Output
accepts valid values text and json.
8 years ago
jctanner c73f9d0492 git: add a umask parameter (#4473)
Sources #10504
Fixes #10279
8 years ago
nishiokay fc79615e38 Add ipv6 paramater to digital_ocean module (#4447) 8 years ago
Toshio Kuratomi 07e79ac683 Refactor stat.py so that it would be more friendly for unittests. (#4462)
* Refactor stat.py so that it would be more friendly for unittests.

* PEP8ify since we're moving most of the lines in the file and there's no open PRs
8 years ago
Jason Edelman 4f09d6065f added a period 8 years ago
Jason Edelman 56d8146495 make aliases a list in the docstring 8 years ago
Jason Edelman 47164d70d3 remove commented out code, add alias, and doc 8 years ago
Jason Edelman b8ff21fb07 updated version_added for new param 8 years ago
Jason Edelman 5d033241af fixed error handling 8 years ago
Jason Edelman 5640711166 fixed docs 8 years ago
Jason Edelman 995083c0d9 improve functionality for vlan trunks based on #4082 8 years ago
Linus Arver 8da17b750d docker_service: fix files/project_files typo
The original decision to rename from `project_files' to `files' was in
3a5dd00076.
8 years ago
chouseknecht fb99277066 Exposing tcp and udp for same port fails. Fixes issue #4354. 8 years ago
Chris Short 8ffe5c3c54 find.py: Editing contains description to say regex (#4452)
find module contains argument appears to accept regex; correcting description accordingly
8 years ago
Alexey Sheplyakov 8d4fe2a767 apt_key: fix spurious failure to import a subkey (#4366)
Importing a (sign only) subkey with apt_key module always fails,
however the actual keyring gets created and contains the correct keys.
Apparently the all_keys function skips the subkeys, hence the problem.

Fixes #4365
8 years ago
PikachuEXE fc87dd9650 Allow specifying human readable value for option `memory_limit` again (#4049) 8 years ago
jctanner 53a0a64bda git: set the file:// protocol if needed and refactor HEAD parser (#4434)
* make HEAD parsing more robust
* Fail the module for any splitter errors
* fix combining depth and version on filepath urls by prepending file://

Addresses #907
8 years ago
Timmo Verlaan 159918a8ef Determine branch name more reliable (#907)
* Made some changes to determine branch name more reliable (it may contain slashes now).

* Determination of branch name more reliable, as per comment on PR #907
8 years ago
jctanner 7e65315d92 git: Use a local copy of unfrackpath to avoid using ansible.lib (#4426)
Fixes #4425
8 years ago
jctanner c60954605b git: If force=yes, apply --force to submodule updates to overwrite local changes (#4415)
Fixes #238
8 years ago
chouseknecht 76260d3aa8 Fix network alias and network link comparison. - Using set based comparison was not working consistently - With != operator worked locally but consistently failed on Travis - With 'not in' operator failed locally and on Travis 8 years ago
Brian Coca 1160c79671 added meta as 'documentation' 8 years ago
chouseknecht 433b5e187f If debug true, include actions and differences in output. 8 years ago
Chris Houseknecht a8111adcd6 Some post merge clean up: (#4406)
- Removed required_if.
  - Fixed doc strings.
  - Removed debug output being appended to actions.
  - Put import of basics at bottom to be consistent with other docker modules
  - Added 'containers' alias to 'connected' param
  - Put facts in ansible_facts.ansible_docker_network
8 years ago
Brian Coca 94486c5c77 doc fix 8 years ago
Rob Cutmore 09b06a601c Git: Determine if remote URL is being changed (#4243)
* Git: Determine if remote URL is being changed

Ansible reported there were no changes when only the remote URL for a
repo was changed. This properly tracks and reports when the remote URL
for a repo changes.

Fixes #4006

* Fix handling of local repo paths

* Git: Use newer method for fetching remote URL

* Git: use ls-remote to fetch remote URL

Using ls-remote to fetch remote URL is supported in earlier versions
of Git compared to using remote command.

* Maintain previous behavior for older Git versions

Previously whether or not the remote URL changed was not factored
into command's changed status. Git versions prior to 1.7.5 lack the
functionality used for fetching a repo's remote URL so these versions
will update the remote URL without affecting the changed status.
8 years ago
Chris Houseknecht af3884f558 Adding docker_network module. (#4404) 8 years ago
jctanner 6c439a4882 user: Cast all arguments to string before passing to run_command (#4398)
Fixes #4397
8 years ago
Matt Clay 0b01e53b16 Only run integration script if it exists. 8 years ago
Matt Clay 033850b14a Update call to generate-tests. 8 years ago
Lucas Costa Beyeler 6aeea1fe7e Fix #4202: Can't unarchive remote files (#4244)
When you try to remote unarchive files with the option copy=no the code always fail, as evidenced in issue #4202. That happens because the conditional to check "if remote_src=no or copy=yes" will always be true since the default value of them is remote_src=no and copy=yes.
My modification is only to change the condition from or to and, that way only if both the vars stay with the default value will be true, otherwise you can unarchive remote files.
8 years ago
Brian Coca 16ccde49ad remove X bit 8 years ago
jctanner 634b1024d6 git: save changed submodules in check and non-check mode (#4392) 8 years ago
Dag Wieers 4ee9cc4b3f Add diff mode support to git module (#3364)
* Add diffmode support to git module

This patch adds missing diffmode support to the git module.

* Remodel get_diff() and calls to it

As proposed by @abadger

* Ensure we fetch the required object before performing a diff

Also we handle the return code ourselves, so don't leave this up to run_command().
8 years ago
Indrajit Raychaudhuri fb255b3607 Improve hostname module to support systemd in more generic way (#4382)
Now that there is general purpose `Fact` helper to detect if systemd
is active, we would be able to rely on that to apply SystemdStrategy.

Detecting presence of systemd at runtime would be more reliable than
distribution version based heuristics. (e.g., Debian, Ubuntu allows
user to change the default init system, Gentoo allows switching as
well, and so on).
8 years ago
Brian Coca ab3a87cc1a improved logic when dealing with init scripts 8 years ago
Brian Coca 3c89a21e0c fixes corner case for systemd services
when both unit file and sysv init script exist
Thanks to @olfway for fix.

fixes #3764
8 years ago
Dag Wieers fe273a4e09 Improve the documentation (#4385)
Improvements to make it more clear that pure compressed files (.gz, .bz2 and .xz) files are not supported.

This improves on #3241.
8 years ago
Sam Doran 4c6cfb9eec Improve regexp for matching file permissions (#4306)
A capital "S" appears when the the setuid or setgid bit are set but have no effect. Likewise, a capital "T" appears when the sticky bit is set but it has no effect.
8 years ago
Roman 7b547e3e0b get_url headers param values parsing (#4245) 8 years ago
Evan 7b66bdc1c4 pip: Fix uninitialized variable during check_mode (#4379)
During check_mode (`--check`), the variable change could be
used uninitialized, yielding this error:

`UnboundLocalError: local variable 'changed' referenced before assignment`

This changeset simply initializes it to False.
8 years ago
Evan Kaufman 3a44d60fbc Fixes #3791 cron always returning changed state for multiline jobs (#4285)
Strip only newlines and carriage returns. Instead of stripping ALL whitespace, which may have unintended side effects
8 years ago
BradLook 766413e79d Allow cron to target remote user (#4270) 8 years ago
René Moser 03022875c4 mysql_db: use new exception handling, fixes build (#4373) 8 years ago
Jan Malte Gerth 9549883e78 reuse already split output for filtering (#4310)
there is no need to call out.split('\n') multiple times (line 275 and 277)
8 years ago
Brian Coca 81e87cefd7 unsafe writes! (#4314)
* unsafe writes!

* moved unsafe_write docs and args to file common

* added unsafe_writes option handling
8 years ago
Saurabh Sharma a5695c8b24 error handling for importing non-existent db. Fixes ##2068 (#3617)
* error handling for importing non-existent db

* creating db on import state and suitable message on deleting db

* handling all possible cases when db exists/not-exists
8 years ago
Toshio Kuratomi c5052f9b01 Be explicit about specifying the ssh port if it was user specified (#4302)
Previously, if the port specified by the user or inventory was 22, then
the ssh client port would be used instead.

Fixes #3895
8 years ago
Zoltán Müllner ac561772ea Revert "Reset all locale environment variables before running svn commands" (#4358)
* Revert "Reset all locale environment variables before running svn commands"

This reverts commit 99456fbc98.

* Reset locale environment variables before running svn commands
8 years ago
Michael Scherer cd3c454917 Add a example with a non service unit (#4355)
Since the documentation focus mostly on service
units, a explicit example may help people realizing
it can be used for socket and timer too.
8 years ago
Alvaro Aleman d9c28454ae Make ios_command example working 8 years ago
muxator 16db1d54d1 typo in the documentation of the "state" parameter (#4353) 8 years ago
John R Barker 1357e7e83a ios & iosxr Documentation improvements (#4321) 8 years ago
Chris Houseknecht 2514ec5056 Add buildargs parameter to support Dockerfile ARG directive. (#4349)
* Add buildargs parameter to support Dockerfile ARG directive.

* Fix doc_strings. Doc string for load_path was completely missing.
8 years ago
chouseknecht f6b126d412 Default repository tag value to tag parameter value or 'latest'. 8 years ago
chouseknecht 3dab1785ba Always returns changed when state present and name includes :tag. 8 years ago
Chris Houseknecht 1cf9d3e68e Add *build* to state parameter choices. Updated deprecation message. Will be deprecated in release 2.3. Removed (#4342)
mention of *tagged* state in the force parameter doc strings. There is no *tagged* state.
8 years ago
John Barker ecc7e445b5 vyos: Docs fixes 8 years ago
John Barker d76a4e71c2 openswitch: Docs fixes 8 years ago
John Barker 3f8f67e359 NXOS Docs update 8 years ago
chouseknecht 2ea29fee3f Fix image tag operation. Allows repository in form of repo:tag. If no tag value, defaults to 'latest'. 8 years ago
John Barker d4200b0389 junos: Docs update 8 years ago
Nathaniel Case 36ba105b91 Fix ios_config broken logic 8 years ago
John Barker 6ad7d6b3cd Cumulus - consistent docs formatting 8 years ago
Nathaniel Case 6857cea9e6 Quick fix to nxos_command and minify imports 8 years ago
chouseknecht 0c4da5d3a0 Added implementation of ignore_image, which prevents recreation of containers on image change. 8 years ago
chouseknecht 5992c21c9c Fix #3670 host IP defaults to 0.0.0.0 ignoriing bridge Host IP option. 8 years ago
chouseknecht a6bfeea1c4 Improved documentation for returned actions. 8 years ago
chouseknecht cd7b34547d When build true call docker-compose build, and add nocache option. 8 years ago
chouseknecht df09b4f668 Set version_added 8 years ago
chouseknecht 1670d9b030 Add pull option to pull images prior to evaluating service state. 8 years ago
Kevin Kirsche db03ebdfb9 Fix typo in "ssantaize" typo
ssantaize to santaize
8 years ago
John Barker 2b82389705 General EOS documentation improvements
Typos, formatting, choices.
8 years ago
Shawn Siefkas e9bf046c26 Check mode fixes for ec2_vpc_net module (#2179)
* Check mode fixes for ec2_vpc_net module

Returns VPC object information

Detects state change for VPC, DHCP options, and tags in check mode

* Early exit on VPC creation in check mode
8 years ago
Shawn Siefkas 0b95051039 Fix #2526 (#2527)
Fail on unhandled exception in ec2_asg rather than raise
8 years ago
Shawn Siefkas 66f1f6d537 Check mode fix for ec2_group module (#2184)
The default VPC egress rules was being left in the egress rules for
purging in check mode.  This ensures that the module returns the correct
change state during check mode.
8 years ago
Michael Scherer 3c2110215c Do not hardcode default ssh key size for RSA (#4074)
By default, ssh-keygen will pick a suitable default for ssh keys
for all type of keys. By hardocing the number of bits to the
RSA default, we make life harder for people picking Elliptic
Curve keys, so this commit make ssh-keygen use its own default
unless specificed otherwise by the playbook
8 years ago
peter.jang b06f3bbb22 fix for rsync protocol (#4211) 8 years ago
John R Barker aa6a7d5789 State runnng v running
Fix typo
8 years ago
Matt Clay c2270a37ff Enable FreeBSD tests on Shippable. (#4296) 8 years ago
Rick Mendes be33879152 Fixes #4227: just changing messaging 8 years ago
Rick Mendes eae75cf727 Fix #3549, failure to reference `module` in `ec2_eip` module 8 years ago
David Chwalisz f979928ecc file module: add clarification on state=absent re files that do not exist. 8 years ago
Christian Schwarz e526b2ad3d system/service.py: fix false-positive service enablement on FreeBSD. (#4283)
sysrc(8) does not exit with non-zero status when encountering a
permission error.

By using service(8) `service <name> enabled`, we now check the actual
semantics expressed through calling sysrc(8), i.e. we check if the
service enablement worked from the rc(8) system's perspective.

Note that in case service(8) detects the wrong value is still set,
we still output the sysrc(8) output in the fail_json() call:
the user can derive the exact reason of failure from sysrc(8) output.
8 years ago
Lyle Mantooth f57ece661f Remove file extension from policy names (#3805)
Fixes #3804.

Prevents `__file__` from contributing ".", which is an illegal character in ELB policy names.
8 years ago
Julien Vey 7ba3ba2da9 Fix Typo in docker_image_facts module 8 years ago
Monty Taylor f441e2c1a9 Rename a confusing variable
I had to read the two lines in question twice. That might just make me
dumb, but if I'm dumb, someone else might be too.
8 years ago
Rick Mendes 4fad93561a please remove me as maintainer 8 years ago
Rick Mendes d6cc007380 Fixes #4227 8 years ago
Jasmine Hegman f5c3f4dd6b Update docs to indicate ec2_asg state defaults to present (#4046)
* Update docs to indicate ec2_asg state defaults to present

Hopefully fixes Issue #4016

* Forgot to flip required to false
8 years ago
Matt Clay df5869df4a Enable Windows tests on Shippable. (#4278) 8 years ago
Shaun Brady 7b8d625546 Make ec2_elb_lb respect VPCs when resolving groups
AWS security groups are unique by name only by VPC (Restated, the VPC
and group name form a unique key).

When attaching security groups to an ELB, the ec2_elb_lb module would
erroneously find security groups of the same name in other VPCs thus
causing an error stating as such.

To eliminate the error, we check that we are attaching subnets (implying
that we are in a VPC), grab the vpc_id of the 0th subnet, and filtering
the list of security groups on this VPC.  In other cases, no such filter
is applied (filters=None).
8 years ago
Shaun Brady 3b32b60338 Remove trailing white space 8 years ago
Shaun Brady 04199140c5 Make group_name resolution VPC aware
EC2 Security Group names are unique given a VPC.  When a group_name
value is specified in a rule, if the group_name does not exist in the
provided vpc_id it should create the group as per the documentation.

The groups dictionary uses group_names as keys, so it is possible to
find a group in another VPC with the name that is desired.  This causes
an error as the security group being acted on, and the security group
referenced in the rule are in two different VPCs.

To prevent this issue, we check to see if vpc_id is defined and if so
check that VPCs match, else we treat the group as new.
8 years ago
Rob Phoenix 6339398e7c various typo corrections to ios network modules 8 years ago
John Baublitz fe09641476 Doc update 8 years ago
John Baublitz c8dc0bf5c9 Fix exception handling to be compatible with Python 3 8 years ago
John Baublitz 4b11312737 Additional error handling for corner cases like deleting networks with active subnetworks 8 years ago
John Baublitz e4697c3780 Documentation 8 years ago
John Baublitz 96599a5963 Logic to allow subnet creation 8 years ago
John Baublitz 5591e6bb0b Add error handling for specifying 'mode' with insufficiently recent libcloud 8 years ago
John Baublitz 9c9b22dc8f Changes to allow 'auto' mode which does not allow IP address specification 8 years ago
John Baublitz 839871d87b Support for newer networking modes in GCE 8 years ago
Brian Coca 7f1e6ca005 updated docs to reflect new feature 8 years ago
Ryan 8b582cceaa fix typo in azure_rm_storageaccount (#4236) 8 years ago
Brian Coca d579dab0a0 deprecated accelerate 8 years ago
chrisweaver 531954e2f6 Enforce boolean type for dup_ok
Stop "choices" from being interpreted as strings.
8 years ago
Toshio Kuratomi 879afebf77 Remove git and synchronize modules from list of commands we want users to use the module for instead. (#4233) 8 years ago
Matthew Martin 4d952d6e6e Add CAPABILITY_NAMED_IAM to cloudformation capabilities
While from the documentation[1] one would assume that replacing
CAPABILITY_IAM with CAPABILITY_NAMED_IAM; this as empirically been shown
to not be the case.

1: "If you have IAM resources, you can specify either capability. If you
have IAM resources with custom names, you must specify
CAPABILITY_NAMED_IAM."
http://docs.aws.amazon.com/AWSCloudFormation/latest/APIReference/API_CreateStack.html
8 years ago
Michael Baydoun 3818cc2b95 fixes issues where iam_policy incorrected reported changed 8 years ago
John Baublitz 906b457bf1 Collapse boilerplate code into change_instance_state function 8 years ago
John Baublitz eb97165acc Add states for stopping and starting machines 8 years ago
Tom Melendez 067bb6ec01 Added helper function and logic to sort attributes before comparing. 8 years ago
Kai Kousa 4a8a052e2e Improve documentation on security_groups-option 8 years ago
Tom Melendez 8becd9a14d Allow GCE firewall rules to be updated when attributes changes. Fixes #2111.
Previously, when the attributes of a GCE firewall change, they were ignored.  This PR changes that behavior and now updates them.

Note that the "update" also removes attributes that are not specified.

An overview of the firewall rule behavior is as follows:

1. firewall name in GCP, state=absent in PLAYBOOK: Delete from GCP
2. firewall name in PLAYBOOK, not in GCP: Add to GCP.
3. firewall name in GCP, name not in PLAYBOOK: No change.
4. firewall names exist in both GCP and PLAYBOOK, attributes differ: Update GCP to match attributes from PLAYBOOK.
8 years ago
yfried-redhat b1ee47f358 Make os_floating_ip module idempotent
Current module fails when tries to assign floating-ips to server that
already have them and either fails or reports "changed=True" when no
ip was added

Removing floating-ip doesn't require address

Server name/id is enough to remove a floating ip.
8 years ago
Andrei Lukovenko 436ff356e7 Bug: repeatable invocation with state=present leads to (#3052)
[localhost]: FAILED! => {"changed": false, "failed": true, "msg":
"'Domain' object has no attribute 'id'"}

How to reproduce:

- name: create domain
  digital_ocean_domain: state=present name=DOMAIN_NAME ip=DROPLET_IP

- name: create domain
  digital_ocean_domain: state=present name=DOMAIN_NAME ip=DROPLET_IP

Problem: DigitalOcean API changed API
(https://developers.digitalocean.com/documentation/v2/#list-all-domain-records)
8 years ago
Brian Coca 544b044129 stop trying to set permissions in check mode
fixes #4195
8 years ago
Brian Coca 498dc61154 documenting behaviour as clear as possible 8 years ago
Toshio Kuratomi 0364831c22 Remove version-added on name field.
This parameter was actually added in 2.0.  It's just that the
documentation in previous versions of the module were wrong (it said the
name was  "network" rather than "name.)  I've renamed the parameter in
the documentation of prior versions so ansible-module-validate should no
longer think that this is a new parameter.
8 years ago
Peter Sprygada 42da47813b adds update_config argument to ios_config
New argument controls whether or not configuration is applied to the
remote device.
8 years ago
Peter Sprygada 4611e2b9ad initial add of new module vyos_config
New module for sending configuration commands to remote devices running
the VyOS operating system.
8 years ago
Peter Sprygada cff91c4c3b initial add of new module vyos_facts
* adds collection of default facts
* adds collection of configuration facts
* adds collection of lldp neighbors
8 years ago
Ryan S. Brown 9336e0d070 Indent `unarchive` module documentation to fix parsing error. 8 years ago
tobixx ed1d80b7d8 added read-/write-/executeable flags for invoking user (#4130) 8 years ago
James Cammarata aa1e9e3d5f Add remote_src param for unarchive to deprecate `copy` param
From ansible/ansible#10218
8 years ago
Peter Sprygada 92ac734e13 initial commit of vyos_command module
This adds a new module, vyos_command for sending CLI commands to remote
devices running VyOS operating system.
8 years ago
Peter Sprygada 25294f40c8 bug fix in ios_config module for handling config contents
Config contents when passed via argument were returning a string but
the module expects an instance of NetworkConfig.  This fixes that
problem.
8 years ago
Jan Hutař 5eb4e0dd0d Add way to specify environment (#3453) 8 years ago
h-hirokawa 57921c0b4d Fix azure_rm_virtualmachine (#4174). 8 years ago
Chris Houseknecht c91de38322 Entrypoint fails with 'command not found' error. 8 years ago
Chris Houseknecht 7ffa6a43c5 Add push parameter. Let API handle registry authentication check. 8 years ago
Chris Houseknecht 4002caf60e Fix module failing when no ports are exposed 8 years ago
jjshoe d8b752b3cf Fixed a typo (#4168) 8 years ago
Richard Levenberg 4943d329a4 handle multiple winrm listeners (#4142)
* handle multiple winrm listeners

* use the sorterd array
8 years ago
Marcos Diez f10413b919 better authorized_keys documentation (#3739) 8 years ago
Peter Sprygada 43ba7f3b3b removes unneeded check_args function from ios_command
The module would raise a KeyError trying to find the save_config key
which is not present in the argument_spec.  This was caused by the
check_args() function.  Since the ios shared argument spec isn't used
the check_args function is not needed and has been removed.
8 years ago
Chris Houseknecht 030dcccad4 Fix multi-interface port binding. 8 years ago
Chris Houseknecht bd3e1c77fe Add cleanup parameter. (#4144) 8 years ago
Peter Sprygada 438b9328ea fixup ios_template module to use NetworkModule
This removes the get_module() factory function and directly creates
an instance of NetworkModule.  This commit includes some minor clean
up to transition to the ios shared module for 2.2
8 years ago
Chris Houseknecht 7515b2d563 Fix 'all' option for published_ports parameter. 8 years ago
David Shrewsbury 37edf33955 Fix bug in os_router.py when router is not actually updated. (#4107)
The shade update_router() call will return None if the router is
not actually updated. This will cause the module to fail if we
do not protect against that.
8 years ago
Brian Coca 72eaf0281a updated checkmode for update-rc.d
fixes #4146
8 years ago
Chris Houseknecht dc496ffeb4 Fix purge_networks 8 years ago
Peter Sprygada 66268dd3ec fix up ios_command to use NetworkModule
* using check mode will now block all commands except show commands
* module will no longer allow config mode commands
* check args for unused values and issue warning
8 years ago
Qi Luo b86a229b61 Fix getting actual_stdin_open 8 years ago
Peter Sprygada 5fe848fca2 refactor ios_config for network module
This refactors the ios_config module to use the network module added
in 2.2 to simplify common network functions

new features

* add src, dest arguments for working with config
* results now return flag if the config was saved or not
* adds append argument for updating the dest file (when dest is used)
8 years ago
Rene Moser 5e3249b244 os_server, doc: add version added for delete_fip
Also see #3509
8 years ago
David Shrewsbury 530fd1365a Allow os_server to delete FIP (#3509)
The os_server module could automatically generate a floating IP for
the user with auto_ip=true, but we didn't allow for this FIP to be
automatically deleted when deleting the instance, which is a bug.
Add a new option called delete_fip that enables this.
8 years ago
Andrei Lukovenko 85bd975238 Bug: invocation with state=absent always leads to (#3051)
[localhost]: FAILED! => {"changed": false, "failed": true, "msg":
"'Domain' object has no attribute 'id'"}

How to reproduce:

- name: create domain
  digital_ocean_domain: state=present name=DOMAIN_NAME ip=DROPLET_IP

- name: destroy domain
  digital_ocean_domain: state=absent name=DOMAIN_NAME

Problem: DigitalOcean API accepts domain name, not record ID
(https://developers.digitalocean.com/documentation/v2/#delete-a-domain)
8 years ago
Adrian Moisey 28716f565c Add default port for aurora (#4102)
If a port isn't specified, it's looked up. The lookup breaks without
this.

Related: https://github.com/ansible/ansible-modules-core/pull/3414
8 years ago
Peter Sprygada 28a701128d update ios_facts module to use NetworkModule
minor update to ios_facts to remove get_module() in favor of NetworkModule
8 years ago
jctanner d5b35eb8db add gather_timeout parameter (#4093) 8 years ago
James Cammarata 2aad8bd882 Removing erroneous import from async_status 8 years ago
James Cammarata 204e83aeed Ensure async wrapper and status return consistent fields 8 years ago
Matt Clay 72cd76e023 Enable IRC and Slack notifications on Shippable. 8 years ago
Matt Clay a7bef31ab3 Run each integration test separately. 8 years ago
Matt Clay 1b69cff1a4 Initial support for module integration tests. 8 years ago
Dag Wieers 017eeaea29 Fix a problem where the newly provided mode is a string (#3769)
* Fix a problem where the newly provided mode is a string

This fixes #3597

* Implement python3-compatible get_exception() handling
8 years ago
Dag Wieers 855ca9b204 Revert PR #3575 since it causes problems related to exclude patterns (#3767)
* Revert PR #3575 since it causes problems related to exclude patterns

By using a different method for getting archive filelists, and extracting we introduced new problems related to excluding based on gtar patterns.

As a result files that would be excluded by gtar, would still be in the filelist. Implementing our own gtar compatible pattern exclusion mechanism is near to impossible (believe me, we looked at it...). The best way is to look at the original problem and deal with that, and ensure that extraction and filelists are done with the exact same tool and exact same options.

The solution is to decode the octal unicode representation in gtar's output back to unicode. Since gtar has no problem extracting these files in LANG=C, we simply has to compensate for it.

This reverts #3575 and fixes #11348.

* Implement codecs.escape_decode() instead of decode("string_escape") for python3
8 years ago
Chris Houseknecht a8059c68d0 Remove object name validation. 8 years ago
Brian Coca b55fd5f67a updated set_fact docs with note about typing 8 years ago
nitzmahone b51a1e175e minor win_template doc corrections 8 years ago
Brian Coca ad996f162b name was the issue, not pkg 8 years ago
Brian Coca d8e91f01b0 protect another portion against None name 8 years ago
Brian Coca 506e6ff2e2 another fix for None in name 8 years ago
Brian Coca c871f488eb avoid traceback when name is None 8 years ago
Robin Roth 5d928ca13c Fix git shallow update (#3912)
* remove unused variables

* fetch branch name instead of HEAD

fix #3782, which was introduced by f1bacc1d3f

* disable git depth option for old git versions

fixes #3782
git support for `--depth` did not fully work in old git versions (before 1.8.2)
fall back to full clones/fetches on those versions

* raise required git version to 1.9.1 for depth option

* use correct depth argument in switch_version
8 years ago
Christian Schwarz e25cb4df77 service module: use sysrc on FreeBSD (#4042)
* service module: use sysrc on FreeBSD

sysrc(8) is the designated userland program to edit rc files on FreeBSD.

It first appeared in FreeBSD 9.2, hence is available on all supported
versions of FreeBSD.

Side effect: fixes #2664

* Incorporate changes suggested by bcoca.

- Use `get_bin_path` to find sysrc binary.
- Only use sysrc when available (support for legacy versions of FreeBSD)
8 years ago
Brian Coca 186db40864 make daemon reload first thing always run
otherwise service detection can fail before we run it which might
be required to actually detect the service.
8 years ago
Brian Coca f874c29dff allow pip to take a list of names (#4056)
also simplified argspec by removing defaults
8 years ago
Patrick Uiterwijk 6b4359080e nova_compute: indicate argument type (#4070)
Without this, ansible 2.1 will convert some arguments that are
meant to be dict or list type to their str representation.

Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com>
8 years ago
Adrian Likins e2bd4a87d8 Update docs and internal naming s/RHN/RHSM (#3977) 8 years ago
Adrian Likins 09b34c764a Add 'force_register' to redhat_subscriptions (#3976)
Fixes #2448
8 years ago
Adrian Likins 127b854d2c Fix default perm for apt_repo files. (#4072)
Change the file mode arg to 'raw' ala file args

Following the file_common_args model, change the
type of the 'mode' arg here to type='raw' with no
default arg value.

The default mode for file creation is the module
constant DEFAULT_SOURCES_PER, and is used if no
mode os specified.

A default mode of 0644 (and not specified as int or str)
would get converted to an octal 420, resulting in the
sources file being created with mode '0420' instead of '0644'

Fixes #16370
8 years ago
Michael LoSapio 20d8103b53 Showing some of the sysctl settings in proper yaml format per Ansible documentation (#4073) 8 years ago
Lukas Grossar 4a532fb60c also match on tabs in ini_file (fixes #106) (#4067)
also match on tabs in ini_file
8 years ago
Ryan Brown d4cec5ccc1 Remove double-assignment of EC2 parameters (#4081)
The `source_dest_check` and `termination_protection` variables are being
assigned twice in ec2.py, likely due to an incorrect merge somewhere
along the line.
8 years ago
Hrishikesh Barua cf9bfc3459 Fix for #16518 - added missing regions 8 years ago
nitzmahone 1a4804cc60 fixes to windows setup
coerce multi-socket win32_processor to a single value
WindowsIdentity.Label doesn't exist on .NET 4.0
8 years ago
chouseknecht 9c6da9194a Update and pin to azure-2.0.0rc5 8 years ago
Brian Coca 992b999bde made password no_log in htpasswd 8 years ago
Toshio Kuratomi 30399d94f6 A few more sanity checks for detecting unzip output that's not a file entry (#3982)
* A few more sanity checks for detecting unzip output that's not a file entry

Also note that there's a rounding error somewhere in the mtime
comparison code.

* Fix reference to sub-array
8 years ago
Brian Coca c59510aaf4 updated docs in pause to reflect 0 value behaviour 8 years ago
Dag Wieers df2ef26bc7 Comment out $win32_cs.SystemFamily, cfr. @nitzmahone
Since it fails on everything pre-10/2016
8 years ago
Stian Vikan 714ced8e1c Fixed delete statement for juniper_config.py #4007 #3984 8 years ago
Shubham 162b75068f Fix broken link for issue template (#3680) 8 years ago
David Shrewsbury 88122e0f72 Use os.rename() in async_wrapper
Because the async_status module will read from the same file that
the async_wrapper module is writing, it's possible that the file
may not be fully synced during a read, causing spurious failures.
Use a temp file to do an atomic operation on the file. We can't
use atomic_move() here as that doesn't work properly under async.

Also, let's not read concurrently from the same file the subprocess
is writing to. Instead, capture stdout/stderr via PIPE and write to
the file to avoid nasty races.
8 years ago
Brian Coca f9cb5ecc3c removed extra space
as pointed out by @lloydbenson
8 years ago
jctanner 4480b8d37f Cleanup unused variable in yum.py (#4009) 8 years ago
Peter Sprygada b0bdf09a00 refactor ios_command to use CommandRunner class
* fixes running commands in check mode.  now only show commands are allowd
* renamed waitfor to wait_for with alias to waitfor for consistency
8 years ago
Dag Wieers 35b9810e39 Fix ansible_distribution and weekday locale (as hinted by @nitzmahone) 8 years ago
Dag Wieers 36d0bac0a3 Retain an important note regarding Win32_PhysicalMemory on virtual platforms 8 years ago
Dag Wieers efaaa79157 Ensure we are using an English locale for date formatting. (as hinted by @nitzmahone) 8 years ago
Dag Wieers 790adc126f Added CPU information comparable to Linux 8 years ago
Rodríguez, Jorge 82c26ad2d7 Do not forcibly push when building, either. 8 years ago
Rodríguez, Jorge 89e8787d65 Don't forcibly push loaded images to registry. Fixes #3763 8 years ago
Peter Sprygada 622592c413 refactor the eos_command module to use the CommandRunner
* This adds support the CommandRunner to handle executing commands on
the remote device.
* It also changes the waitfor argument to wait_for to remain compatable
with other modules and adds an alias for waitfor.
* Restricts commands to show commands only when check mode is specified.
* add version_added to wait_for doc string
8 years ago
Ryan S. Brown a2e6ac6ca8 IAM group modules need `module` passed
The IAM group modules were not receiving the `module` object, but they
use `module.fail_json()` in their exception handlers. This patch passes
through the module object so the real errors from boto are exposed,
rather than errors about "NoneType has no method `fail_json`".
8 years ago
jhawkesworth@users.noreply.github.com 2090304511 double backslashed all single backslashes to keep travis happy 8 years ago
Dag Wieers dc432c5697 Added more properties 8 years ago
Dag Wieers f8b0cf50b4 Format BIOS date string like on Linux 8 years ago
Dag Wieers 457ccc2e73 win_setup: Add missing properties
We add some basic properties for Windows that are available on other platforms.
8 years ago
jhawkesworth@users.noreply.github.com d3d108e13e document how force=no works for win_get_url and add RETURN 8 years ago
Daniel Petty 6441556b98 fixed $source null check, reference to $Params
$source check causes:
FAILED! => {"changed": false, "failed": true, "msg": "A parameter cannot be found that matches parameter name 'Source'."}

$Params.Remove causes:
FAILED! => {"changed": false, "failed": true, "msg": "Method invocation failed because [System.Management.Automation.PSCustomObject] does not contain a method named 'Remove'."}
8 years ago
Peter Sprygada a522c2d99f initial add of ios_facts module
This adds the new module ios_facts for collect fact information from
ios devices
8 years ago
Erik Nadel 4619513d9e apt remove now recognizes the force parameter (#3756) 8 years ago
Graham Goldstein 9632b47a85 Change documented options for os_networks_facts (#3970)
* Change documented options for os_networks_facts

os_network_facts currently lists 'network' as an available option, taking the Name or ID. In Ansible 2.0.2 to 2.2.0, this is not valid. Options 'name' and 'id' should be used instead.

* Update os_networks_facts.py

* Update os_networks_facts.py

Set version_added to the only accepted value

* Update os_networks_facts.py

Removed inappropriate 'ID' parameter
8 years ago
mattymo 5692d28f93 Add retries to apt_key with keyserver, fixes #3986 (#3987)
Public SKS gpg servers frequently are unavailable, but a retry
can mitigate frequent failures.
8 years ago
jctanner 17ebf51bd4 Add local and url support to yum state=latest (#4003)
Fixes #3807
8 years ago
jctanner 3a0056e571 Add a note about using the script module with pseudo-tty's lack of stderr channel (#4000)
Addresses #3610
8 years ago
Toshio Kuratomi eadef56a06 Add comment 8 years ago
Marius Gedminas 3a8a11d85f git: fix change testing when version is HEAD (#3025)
When `version` is not specified, it defaults to "HEAD".  "HEAD" is not a
remote tag, and it's not listed in the output of get_branches(), so we'd
keep repo_updated at the default value (None) and then return early with
changed=True in --check mode, even when before == after.

Fixes #3024.
8 years ago
chouseknecht 3d5f84c528 Fix compose_version error. Check has compose before checking version. 8 years ago
chouseknecht 1e9590ab65 Fix index 8 years ago
chouseknecht cc053c45ce Fix ulimit comparison 8 years ago
Allen Sanabria 6d6b8a1823 Fixes #1715 Allow authorized_module accept multi. (#3573)
This will allow the authorized_module to accept options that can be
passed multiple times into ssh options. For instance permitopen.
8 years ago
Mario David 88e4e1af18 add project to os_router (#3869)
* add project to os_router

* version_added fix

* correct place of version_added

* remove extraneous else

* * add shade version dependency check
* option project only on router creation

* * fix shade minimal version
* remove pop of option project

* * fix square brackets
* delete router by router_id
8 years ago
Javier M. Mellid 49f9404cd2 Add s3_url requirement in doc when rgw support is enabled in s3.py
Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
8 years ago
Javier M. Mellid 6346cad9d0 Add proper version_added for rgw option in s3.py
Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
8 years ago
Javier M. Mellid 0b156aae16 Add Ceph RGW S3 compatibility
Ceph Object Gateway (Ceph RGW) is an object storage interface built on top of
librados to provide applications with a RESTful gateway to Ceph Storage
Clusters:

http://docs.ceph.com/docs/master/radosgw/

This patch adds the required bits to use the RGW S3 RESTful API properly.

Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
8 years ago
Stanislav Antic 4c92652e7b Fix wait_for on python < 2.6 (#3790) (#3973) 8 years ago
Brian Coca f595b27e47 reverted need for module utils imports 8 years ago
Brian Coca 0c82db9cda added missing import
readded raise
8 years ago
Brian Coca 51c3eda259 exception ans sys.exit fixes 8 years ago
Toshio Kuratomi 1b88df0bda Fix exception handling in async_wrapper 8 years ago
Keisuke Kamada 259c4b31fb Do not copy file if running on check mode 8 years ago
Adam Butler 0c7ec1e860 Fixes incorrect key name protocols -> protocol (#3963) 8 years ago
nitzmahone 363ff55445 StrictMode fixes for win_get_url 8 years ago
Brian Coca 1f6c3766b0 restored incorrectly removed docs, jinja2 override 8 years ago
Hagen Kuehn 320aea77c6 fixed unknown type <type 'list'> error (#3959) 8 years ago