Commit Graph

10983 Commits (b6c07bc9e9ade341e11c354a4bcb7d45ddc27666)

Author SHA1 Message Date
Josh Lothian 319b2b28cb Fix YAML syntax in NXOS documentation (#4922)
* Fix YAML syntax in NXOS documentation

Use ':' and not '=' to ensure valid YAML
in the EXAMPLES

* Correcting introduced syntax error
8 years ago
Will Thames 10af591da2 Check whether yum file or URL install is an upgrade (#4547)
Rather than just checking whether a package with the right
name is installed, use `local_nvra` to check whether the
version/release/arch differs too.

Remove `local_name` as it is a shortcut too far.

Fixes #3807
Fixes #4529
8 years ago
Matt Clay b2460746d8 Test module docs on Shippable. (#4921) 8 years ago
Matt Clay 6cdcf09984 Remove duplicate keys from module docs. (#4920) 8 years ago
GGabriele c47fd4b3e9 Add feature mappings 8 years ago
Peter Sprygada 25375f1057 adds exception handling to nxos_command for FailedConditionalError
This adds exception handling as per ansible/ansible#17638 to the
nxos_command module.
8 years ago
Peter Sprygada a8ca526450 bug fix that now catches FailedConditionalError when specifying conditionals
This is related to ansible/ansible#17638 and updates the eos_command module
to catch the exception and return a santatized error.
8 years ago
Michael Scherer 90378e9168 Fix duplicate required key error
ansible-doc -vvvv -l show this warning:

   [WARNING]: While constructing a mapping from /home/misc/checkout/git/ansible/lib/ansible/modules/core/network/junos/junos_config.py,
   line 88, column 5, found a duplicate dict key (required). Using last defined value only.
8 years ago
Peter Sprygada 0c94d84910 eos_eapi module allows independent configuration of protocol and port
The eos_eapi module would not configure the port if the protocol wasn't
configured as reported in #4905.  This changes the behavior to now allow
the port to be configured independently

fixes #4905
8 years ago
GGabriele 6701f038ba Fixed docstring 8 years ago
GGabriele 0eb63cdeaa Fixing nxos_portchannel 8 years ago
Harnek Sidhu 422edfcbd4 Created digital_ocean_block_storage module (#4469) 8 years ago
Senthil Kumar Ganesan 1ee897e988 Addressed review comments, given as part of other reviews (#4904) 8 years ago
nichivo c4f43eb965 Insert missing option line before blank lines (#4747) 8 years ago
Senthil Kumar Ganesan a7242039ad Updated the config module to use the new Parse method for OS6 8 years ago
Senthil Kumar Ganesan 8adc05051c Added support for template module for Dell OS6 devices 8 years ago
Senthil Kumar Ganesan 1a8e0487ff fixing the CI issue, the python interperter line 8 years ago
Senthil Kumar Ganesan 4fd0ad09b3 Updated the copyright 8 years ago
Senthil Kumar Ganesan 89cd8c03c0 Added support for dellos6_facts module 8 years ago
Senthil Kumar Ganesan 1c4efc8b2c dnos* -> dellos* (Rename module & updated copyright) (#4888)
* Renamed the Modules from dnos* -> dellos*, updated copyright, corrected doc issues

* Removed the unwanted module import
8 years ago
Matt Clay f6386a113b Update CI badge. 8 years ago
Matt Clay 62073612d4 Cosmetic fix to test PR and merge hooks. (#4893) 8 years ago
Matt Clay f1be653737 Run same tests on Shippable as on Travis. (#4889)
Run the same tests as used on Travis.
8 years ago
Peter Sprygada 989793483f fix up eos_eapi module
* fixes TypeError: load_config() got an unexpected keyword argument 'session'\n"
* removes qos argument

ref #4869
8 years ago
Matt Clay d75c2ea475 Fix documentation fragment references. (#4890) 8 years ago
Brian Maddy 7ca911d345 typo in stat.executable (was stat.excutable) (#4886)
I didn't actually run this because it's so simple, but it seems correct.
8 years ago
Tom Melendez ea76dedadf Support for GCE Managed Instance Groups. (#4541)
Create, Delete, Resize and Recreate (of instances) supported.  Autoscalers are also supported.
8 years ago
Ryan S. Brown 10e0ec84fb Fix version_added for ec2_asg feature 8 years ago
GGabriele 13e87e3a6c Adding nxos_igmp_snooping 8 years ago
GGabriele 15c07334c7 Adding nxos_aaa_server_host 8 years ago
GGabriele 4b6a59bd13 Adding nxos_udld_interface 8 years ago
GGabriele f1a96986c4 Adding 2.1 and 2.2 support to nxos_switchport 8 years ago
GGabriele e669d3e889 Adding nxos_snmp_user 8 years ago
GGabriele 693f8e623a Improving argument_spec 8 years ago
GGabriele 2f58306564 Adding nxos_pim_interface 8 years ago
GGabriele 48942d6e32 Fixing docstring 8 years ago
GGabriele b42f6da0ce Adding nxos_mtu 8 years ago
GGabriele d8b2b0387b Adding nxos_vtp_version 8 years ago
GGabriele da8aa0dd29 Removing unused function 8 years ago
GGabriele d53b52d528 Fixing module name 8 years ago
GGabriele d435aca86e Adding missing version_added 8 years ago
GGabriele bf2e0ec953 Adding nxos_vtp_domain 8 years ago
GGabriele b1f33ca5a0 Improved function 8 years ago
GGabriele d3de4c160f Adding nxos_vtp_password 8 years ago
GGabriele 29ea186bd7 Adding nxos_udld 8 years ago
GGabriele c45e596159 Adding nxos_ntp_options 8 years ago
GGabriele 77b043dcf3 Fixing conditional format 8 years ago
GGabriele 52dfa697c2 Adding nxos_ntp_auth 8 years ago
GGabriele 6efb79bbeb Adding nxos_aaa_server 8 years ago
GGabriele 821b1606b3 Fixing nxos_interface 8 years ago
GGabriele 095d30ea63 Adding nxos_ntp 8 years ago
GGabriele 5f0060ec41 Fixing argument_spec 8 years ago
GGabriele 57f86c0efc Fixing docstring format 8 years ago
GGabriele 76d7379d73 Adding nxos_snmp_traps 8 years ago
GGabriele 988d6bbb2b Fixing return string 8 years ago
GGabriele 37170dd353 Adding nxos_snmp_location 8 years ago
GGabriele 2c8bc37003 Adding RETURN 8 years ago
GGabriele de8b759df2 Adding nxos_install_os 8 years ago
GGabriele c5ab15443f Adding nxos_gir_profile_management 8 years ago
GGabriele c7ca3654df Adding nxos_gir 8 years ago
GGabriele 58501d3650 Removing indentations 8 years ago
GGabriele 852f5176a1 Removing indentation 8 years ago
GGabriele 4775c257ea Fixing file writing format 8 years ago
GGabriele 2016e5d44a Adding nxos_snapshot 8 years ago
GGabriele 1752082c00 Adding nxos_snmp_host 8 years ago
GGabriele 4a182888b8 Adding nxos_snmp_community 8 years ago
GGabriele 0c4c5467f7 Fixing docstring and more fix 8 years ago
GGabriele 346f83029b Fixing error handling 8 years ago
GGabriele e1fab98061 Fixed module structure 8 years ago
GGabriele 4cbcc1f91d Adding nxos_vxlan_vtep_vni 8 years ago
Shawn Siefkas cff256b057 Adding SNS notification support to ec2_asg module
Addresses #1844
8 years ago
Senthil Kumar Ganesan a757321872 Added support for facts module for Dell Networking OS10 device. (#4879)
* Added support for dnos10_facts module

* Added the missing quotes

* Addressed @privateip comments
8 years ago
Ryan Brown 6dff21bd42 Stop sorting of termination_policies in `ec2_asg` (#4883)
The AWS API requires that any termination policy list that includes
`Default` must end with Default. The attribute sorting caused any list
of attributes to be lexically sorted, so a list like
`["OldestLaunchConfiguration", "Default"]` would be changed to
`["Default", "OldestLaunchConfiguration"]` because default is earlier
alphabetically. This caused calls to fail with BotoServerError per #4069

This commit also adds proper tracebacks to all botoservererror fail_json
calls.

Closes #4069
8 years ago
amitsi 6a1290230b pn_bgp (New Module) (#4738)
* added Py2.4 and YAML Documentation fixes

* added no_log for password

* incorporated additional review comments

* remove type for options block

* fix type for pn_multiprotocol
8 years ago
amitsi 31b3fbf3ba pn_cluster (New Module) (#4727)
*  made changes to make it 2.4 compatible

* added no_log for password

* incorporated additional review comments

* remove type for options block
8 years ago
amitsi 92877a39b1 pn_ospfarea (New Module) (#4737)
* added Py2.4 and YAML Documentation fixes

* added no_log for password

* incorporated additional review comments

* remove type for options block
8 years ago
amitsi 5ad8cebef9 pn_trunk (New Module) (#4728)
* Cluster Module

* added Py2.4 and YAML Documentation fixes

* added no_log for password

* incorporated additional review comments

* remove type for options block
8 years ago
amitsi 700c220d6b pn_vlag (New Module) (#4731)
* added Py2.4 and YAML Documentation fixes

* added no_log for password

* incorporated additional review comments

* remove type for options block
8 years ago
amitsi cdbf08e10c pn_vlan (New Module) (#4732)
* added Py2.4 and YAML Documentation fixes

* added no_log for password

* incorporated additional review comments

* remove type for options block
8 years ago
amitsi 127a99de30 pn_vrouter (New Module) (#4733)
* added Py2.4 and YAML Documentation fixes

* added no_log for password

* incorporated additional review comments

* remove type for options block
8 years ago
amitsi e1b07d47be pn_vrouterif (New Module) (#4734)
* added Py2.4 and YAML Documentation fixes

* added no_log for password

* incorporated additional review comments

* remove type for options block
8 years ago
amitsi 23c171c21b pn_vrouterlbif (New Module) (#4735)
* added Py2.4 and YAML Documentation fixes

* added no_log for password

* incorporated additional review comments

* remove type for options block
8 years ago
amitsi f9082b2d8e pn_show (New Module) (#4739)
* added Py2.4 and YAML Documentation fixes

* added no_log for password

* incorporated additional review comments

* remove type for options block and fix typo
8 years ago
amitsi d5d0949958 pn_ospf (New Module) (#4736)
* Add pn_ospf module

* remove type from the options block
8 years ago
Senthil Kumar Ganesan 4ecab1e094 Added support dnos9_facts module (#4873)
* Added support dnos9_facts module

* Addressed @gundalow review comments

* Removing the addtional command, which is already in the default
8 years ago
amitsi 8eaae151fc Empty Init Module as required (#4740)
Add network/netvisor/__init__.py
8 years ago
Tom Melendez 35acdec063 Document ability to disable external IP with 'none' setting. Closes #2562. (#4878) 8 years ago
Monty Taylor 7fe300bb29 Expose the reuse_fips flag on os_server (#4849)
* Expose the reuse_fips flag on os_server

* Remove useless line
8 years ago
mzizzi eaef333215 cloudformation stack events itertools.imap bugfix (#4868) 8 years ago
Senthil Kumar Ganesan 91cc160b43 dnos9_config (New Module) (#4816)
* Added support for dnos9_config module

* Addressed @gundalow comments
8 years ago
Senthil Kumar Ganesan 616af3506c dnos9_template (New Module) (#4819)
* Added support for dnos9_template module

* Addressed @gundalow comments
8 years ago
Senthil Kumar Ganesan 8f14b50b11 dnos6_config (New Module) (#4824)
* Added support for dnos6_config module

* Corrected the documention failure

* Addressed @gundalow comments
8 years ago
Matt Davis 6daa34e1c5 add win_shell/win_command modules + docs (#4827) 8 years ago
Riccardo Murri 6733d1c72c hostname: Support "Scientific Linux CERN" (#4855)
CERN maintains its own fork of "Scientific Linux",
which identifies as "Scientific Linux CERN SLC".
This commit lets Ansible know that this is again
another variant of RHEL.
8 years ago
Matt Clay 49692e98eb Fix python 3 issues with apt* modules. (#4848)
- Use range instead of xrange.
- Use python3-apt package for python 3.
- Eliminate unsupported for/else/raise usage.
- Use list on dict.items when modifying dict.
- Update requirements documentation.

Also made non-intrustive style fixes (adding blank lines).
8 years ago
Brian Coca 21ed52bfe4 fixed incorrect example 8 years ago
John Barker 264bb374b9 RETURNS doesn't support markup, so remove it 8 years ago
Peter Sprygada b1243feac8 rename arugment from default to defaults
This argument_spec incorrectly named an argument default and it should have
been defaults.  This corrects that issue
8 years ago
Peter Sprygada 4327e67a7e rename the argument default to defaults
The argument_spec incorrectly had the argument default and it should have
been defaults.  This corrects the problem.
8 years ago
John Barker 42d5d7b21b Docs improvements to _config 8 years ago
GGabriele e375b4c61c Fixing nxos_feature 8 years ago
Christopher Kotfila f916dae700 Unpack AWS reservations while waiting to terminate (#4012)
Previously calculation of the number of instances that have been
terminated assumed all instances were in the first reservation returned
by AWS.  If this is not the case the calculated number of instances
terminated never reaches the number of instances and the module always
times out. By unpacking the instances we get an accurate number and the
module correctly exits.
8 years ago
Ryan Brown 1a02005b8d Handle EC2 instances with multiple network interfaces (#4766)
Currently instances with multiple ENI's can't be started or stopped
because sourceDestCheck is a per-interface attribute, but we use the
boto global access to it (which only works when there's a single ENI).

This patch handles multiple ENI's and applies the sourcedestcheck across
all interfaces the same way.

Fixes #3234
8 years ago
Peter Sprygada 3a7301bb3b fixes error when calling load_config() with session keyword
The session keyword is no longer needed or supported in the load_config()
method for eos.  This fixes an issue in eos_template where the session
keyword was still being sent.
8 years ago
Toshio Kuratomi ae310d5034 Fix syntax 8 years ago
Senthil Kumar Ganesan fffd7ff44b Addressed review comments from @privateip 8 years ago
Robin Roth 2df69fb5d8 Speedup git module on clone and pull (#4562)
* remove redundant if submodules_updated

* speed up git by reducing remote commands

* run fetch only once
* run ls-remote less
  * don't run ls-remote if one would run fetch anyhow
* remove unnecessary remote_branch check in clone
  * kept if depth and version given

* fix fetch on old git versions
8 years ago
Brian Coca 627da622fe removed chdir / as it breaks tasks
fixes #17466
8 years ago
John Barker c01328b597 Document `backup` options
To make future diffing easier, use consistent ordering
8 years ago
Senthil Kumar Ganesan 9d32e313b7 Added Command module to support Dell Networking OS6 8 years ago
Senthil Kumar Ganesan 253cbc10a6 Added Command module to support Dell Networking OS9 8 years ago
Brian Coca 6030bcdb47 switched to use built in function for validation 8 years ago
Monty Taylor e27b7af1e6 Don't change to root dir in async_wrapper (#4779)
The daemonizing code here is taken from an ActiveState recipe, which
includes changing to / as a general best practice. While that is
normally true to allow for deleting the directory that the daemon
process started in, in this case it is not relevant as this is not
intended to be an actual long-running daemon.

Issue ansible/ansible#17466
8 years ago
Antonio Murdaca b9962d2389 system/systemd: enable systemctl --user (#4208)
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
8 years ago
glovenglaven 289e5f1884 Added Solaris support to core mount module (#4771)
* Added Solaris support to the mount module.

* Added checking so that if a non-standard fstab file is specified it will
still work in Solaris without breaking existing functionality.

* Added a check to avoid writing duplicate vfstab entries on Solaris

* Added "version_added" to new boot option
8 years ago
Dag Wieers 433dfd0c5b Don't add included files as arguments on the command line (#4626)
This means we will have to unarchive the complete archive if a single change is found.
Unfortunately we cannot fix this for `unzip`, the only hope is a pure-python reimplementation.

This fixes problems reported in the comments of #3810
8 years ago
Martin Matuška 3366a95765 Force download if checksums do not match (#4262) 8 years ago
Gregor Giesen b87ef7772f cron: replacement for os.getlogin() (#4777)
os.getlogin() returns the user logged in on the controlling terminal. However
'crontab' only looks for the login name of the process' real user id which
pwd.getpwuid(os.getuid())[0] does provide.

While in most cases there is no difference, the former might fail under certain
circumstances (e.g. a lxc container connected by attachment without login),
throwing the error 'OSError: [Errno 25] Inappropriate ioctl for device'.
8 years ago
nitzmahone 915b59a6d5 Fix win_user issue with disabled accounts/expired passwords
Disabled and password-expired accounts cannot call ValidatePassword successfully

fixed #4369
8 years ago
Peter Sprygada ad707c2724 roll up updates to nxos_config module
* remote 'updates' argument
* clean up functions
* update doc strings
* add required_if dependencies
8 years ago
Peter Sprygada b6748443c7 roll up updates to junos_config module
* remove 'update' argument
* update doc strings
* reorder functions
8 years ago
Peter Sprygada 47bd484b70 roll up updates to ops_config module
* 'before' and 'after' now only apply to 'lines' argument
* add required_if dependencies
* update doc strings
* remove 'update' argument
* clean up functions
8 years ago
Peter Sprygada 18957c4039 roll up updates to sros_config module
* update doc strings
* update message if rollback isn't configured
8 years ago
Peter Sprygada a9557bc12b roll up of updates to vyos_config module
* remove 'udpates' argument
* add required_if dependencies
* clean up functions
* update doc strings
8 years ago
Peter Sprygada 8444b1ed8f roll up of updates to iosxr_config module
* 'before' and 'after' arguments now only apply to 'lines'
* update doc strings
* remove update argument
* clean up warnings
8 years ago
Peter Sprygada 6a0b04d6a7 roll up of updates to ios_config module
* 'before' and 'after' are now only applied to 'lines'
* remove update argument
* update doc strings
* add path argument when performing config difference
8 years ago
Peter Sprygada e5c26150fb roll up of updates to eos_config module
* removes update argument
* adds `config` option to replace argument
* moves session management into shared module
* cleans up doc strings
* `before` and `after` args now only apply to lines
8 years ago
Andrew Gaffney bac0c4595c Fix missing colons in network module examples (#4778) 8 years ago
Peter Sprygada d73fbaaf05 add new module sros_rollback
Provides a configuration resource for managing the rollback feature on
remote devices running Nokia SROS
8 years ago
Chris Houseknecht e95f773d96 Set default log_driver to None to prevent config comparison when a log_driver is not specified. Fixes #4600. 8 years ago
Chris Houseknecht 05303a974d Purge networks using network name rather than ID. Fixes 4596. 8 years ago
Chris Houseknecht 890c2d04e2 Default restart_retries to None rather than 0. Fixes #4534. 8 years ago
Ryan Brown 6ae4e50e47 Fix failure when powering on/off EC2 instances by tag only. (#4767)
If you apply `wait=yes` and use `instance_tags` as your filter for
stopping/starting EC2 instances, this stack trace happens:

```
An exception occurred during task execution. The full traceback is:                                                                          │~
Traceback (most recent call last):                                                                                                           │~
  File "/tmp/ryansb/ansible_FwE8VR/ansible_module_ec2.py", line 1540, in <module>                                                            │~
    main()                                                                                                                                   │~
  File "/tmp/ryansb/ansible_FwE8VR/ansible_module_ec2.py", line 1514, in main                                                                │~
    (changed, instance_dict_array, new_instance_ids) = startstop_instances(module, ec2, instance_ids, state, instance_tags)                  │~
  File "/tmp/ryansb/ansible_FwE8VR/ansible_module_ec2.py", line 1343, in startstop_instances                                                 │~
    if len(matched_instances) < len(instance_ids):                                                                                           │~
TypeError: object of type 'NoneType' has no len()                                                                                            │~
                                                                                                                                             │~
fatal: [localhost -> localhost]: FAILED! => {"changed": false, "failed": true, "invocation": {"module_name": "ec2"}, "module_stderr": "Traceb│~
ack (most recent call last):\n  File \"/tmp/ryansb/ansible_FwE8VR/ansible_module_ec2.py\", line 1540, in <module>\n    main()\n  File \"/tmp/│~
ryansb/ansible_FwE8VR/ansible_module_ec2.py\", line 1514, in main\n    (changed, instance_dict_array, new_instance_ids) = startstop_instances│~
(module, ec2, instance_ids, state, instance_tags)\n  File \"/tmp/ryansb/ansible_FwE8VR/ansible_module_ec2.py\", line 1343, in startstop_insta│~
nces\n    if len(matched_instances) < len(instance_ids):\nTypeError: object of type 'NoneType' has no len()\n", "module_stdout": "", "msg": "│~
MODULE FAILURE", "parsed": false}
```

That's because the `instance_ids` variable is None if not supplied
in the task. That means the instances that result from the instance_tags
query aren't going to be included in the wait loop. To fix this, a list
needs to be kept of instances with matching tags and that list needs to
be added to `instance_ids` before the wait loop.
8 years ago
Dag Wieers 976d876e55 Ensure unicode characters in zip-compressed filenames work correctly (#4702)
* Ensure unicode characters in zip-compressed filenames work correctly

Another corner-case we are fixing hoping it doesn't break anything else.

This fixes:
- The correct encoding of unicode paths internally (so the filenames we scrape from the output and is returned by zipfile match)
- Disable LANG=C for the unzip command (because it breaks the unicode output, unlike on gtar)

* Fix for python3 and other suggestions from @abadger
8 years ago
Peter Sprygada 53bcf18eab minor updates to junos_package module for 2.2 (#4761)
* replaces get_module() with NetworkModule()
* removes old call to package_version()
8 years ago
Peter Sprygada 09b8e220ca update junos_facts module to remove get_module() factory function (#4760)
Replaces get_module() with NetworkModule instance
8 years ago
Peter Sprygada 290a4b5fac adds path kwarg when difference() is called from iosxr_config
Adds the path kwarg to handle use cases with exact and strict matching
8 years ago
Matt Clay e8f70f25df Python 3 fixes for apt_* modules. (#4754) 8 years ago
Peter Sprygada d339004437 minor bug fix to pass path to difference() in ios_config
The ios_config module needs to pass the path kwarg to difference when
specifying match=exact or strict.
8 years ago
afunix f2c324facc Updated get_url module to process FTP results correctly [#3661] (#4601) 8 years ago
Peter Sprygada 6cca2b06fe fixes bug where nxos_config wasn't handling checkpoints correctly 8 years ago
Abhijit Menon-Sen 841ceb808d Fix spot instance creation by ignoring instance_initiated_shutdown_behavior (#4741)
Before this, all spot instance requests would fail because the code
_always_ called module.fail_json when the parameter was set (which it
always was, because the module parameter's default was set to 'stop').

As the comment said, this parameter doesn't make sense for spot
instances at all, so the error message was also misleading.
8 years ago
Florian Dambrine 2adc325ef6 Fix ec2 module source_dest_check when running on non VPC instances (EC2 Classic) (#3243) 8 years ago
Peter Sprygada d6e16ded3f fix bug in ios_template when include_defaults is set to true
Module was ignoring  include_defaults argument.  This fixes the issue
such that the correct configuration is returned
8 years ago
Peter Sprygada 8a87d7ff11 adds path kwarg when performing config diff checks in ios_config 8 years ago
mlewe afa9d30717 Fixes ansible/ansible#15922 (#3793) 8 years ago
Matt Ferrante d88f5f6808 Properly support tag updates on CloudFormation stack-update actions (#3638) 8 years ago
@skg_net eae69a154f dnos10_template module 8 years ago
David J Peacock 14fb0e4136 description expanded for 112, AKA VRRP protocol) (#4645)
* description expanded for 112, AKA VRRP protocol)

* corrected syntax for description for IP protocols
8 years ago
Brian Coca a42cb96b75 added backup_file to module returns (#4723)
fixes #14502
also cleaned up some unused stuff and fixed imports
8 years ago