Commit Graph

28950 Commits (b437a19f6d8f26b07a64b5002bbea8f0eb992a51)

Author SHA1 Message Date
Nathaniel Case 50e09be14f
Allow the use of _paramiko_conn even if the connection hasn't been started. (#61570)
* Allow the use of _paramiko_conn even if the connection hasn't been started.

I'm not sure what the benefit is of Noneing paramiko_conn on close, but will keep for now

* Fix test

* Try to fix up net_put & net_get

* Add changelog
5 years ago
Jordan Borean 6e8d430872
win_become - don't dispose logon token until end (#61905) 5 years ago
Mario Lenz 900a51b283 VMware: Fix issue with order of changes in vmware_vcenter_statistics 5 years ago
Jill R 528f9a6672 Fix ec2_vpc_vgw broken tests (#60981)
* Fix ec2_vpc_vgw broken tests

Add waiter function to wait for API to report detached vgw is available.
Also catch extra error code in attach retry as EC2 sometimes reports that
the vgw is available several seconds before permitting the attachment.

Fixes: #53185

* Re-enable ec2_vgc_vgw test target
5 years ago
Tom De Keyser 6f74fca238 New module for AWS Step Functions state machines (#59116)
* add new module: aws_stepfunctions_state_machine

* add integration tests for new module: aws_stepfunctions_state_machine

* fix sanity checks

* use files/ folder instead for integration test

* rename role name in integration test

* attempt further permissions

* iam states prefix

* iam integration test prefix

* add iam policy for running step functions state machine actions

* slightly increase iam permission scope

* rename integration test folder to proper name

* move main() method to end of file

* move contents of integration-policy.json for state machines to compute-policy.json

* make check_mode return proper changed value + add check_mode integration tests

* rename module to aws_step_functions_state_machine

* fix missed rename in integration test variable

* add purge_tags option

* bump to version 2.10
5 years ago
Gonéri Le Bouder 3ea8e0a144 VMware: not ssl.SSLContext if validate_certs false (#57185)
Python < 2.7.9 does not have the ssl.SSLContext attribute.
ssl.SSLContext is only required when we want to validate the SSL
connection. If `validate_certs` is false, we don't initialize the
`ssl_context` variable.

Add unit-test coverage and a little refactoring:

- avoid the use of `mocker`, when we can push `monkeypatch` which is
  `pytest`'s default.
- use `mock.Mocker()` when possible

closes: #57072
5 years ago
Mark Chappell 1f38a12057 Fix behaviour of module_utils/ec2 compare_policies when dealing with bare bools and ints. (#61115)
* module_utils/ec2: (unit tests) Move unit tests for module_utils/ec2.py into test/units/module_utils

- compare_policies was refactored from s3_bucket
- "ec2_utils" doesn't seem to have ever existed

* module_utils/ec2: (unit tests) Add unit test for comparing quoted and unquoted bools and numbers within policies

As per https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies_grammar.html

"Values are enclosed in quotation marks. Quotation marks are optional for numeric
and Boolean values."

* module_utils/ec2: Explicitly convert bools and ints to strings when comparing policies

See also: https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies_grammar.html
5 years ago
Nathaniel Case 9d93076a99
Debug location of ansible-connection when found (#61998) 5 years ago
Xu Yuandong 28227c95a4 for capability/exchange/1.0 (#60630)
* for capability/exchange/1.0

* for capability/exchange/1.0

* update for shippable

* Update ce.py

* Update ce.py
5 years ago
Alex White-Robinson 6fa8abf162 fix: adds prefix length error to eos cli plugin (#61747) 5 years ago
Satoru SATOH 483e76ee58 Allow junos_config changes the candidate configuration only (#61969)
This allows junos_config to changes the candidate configuration only and
does not commit it as the active configuration at once w/ the
'check_commit' option.
5 years ago
Erwan Quélin 7b28960ebe VMware: Add new module VMware vSAN health infos (#58636) 5 years ago
Abhijeet Kasurde 3703c3bb1a
atomic_image: Fix absent state (#61827)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
5 years ago
Simon Dodsley df49a9e58c purefa_info: Fix failure due to API version check (#61925) 5 years ago
Abhijeet Kasurde 92099d7f2f
Remove unnecessary pass statement (#61749)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
5 years ago
Paul Belanger a680ff2ade
Clean up unused imports for nxos related code (#61856)
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
5 years ago
Felix Fontein d40ba28fb4
docker_container: improve port range parsing error behavior (#61740)
* Improve port range parsing.

* Add changelog.
5 years ago
Chris Trufan 943888b955 Fixes to ecs_certificate cert chain for #61738 (#61858)
* Fixes to ecs_certificate cert chain for #61738

* Added changelog fragment

* Fixes to ecs_certificate for cleaner join, and better integration test

* Fix integration test formatting

* End cert chain with a \n

* Update changelogs/fragments/61738-ecs-certificate-invalid-chain.yaml

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update main.yml
5 years ago
Andreas Calminder cac93cbd1f os_port allowed_address_pairs and extra_dhcp_opts list of dicts comparison fix (#56577)
* compare list of dicts

* update example for dhcp_server_opts to include ip_version which is automatically added by openstack

* add note about dhcp_server_opts

* add changelog fragment

* fix forgotten exception+pass

* no need to excplicitly check for None

* fix oops

* fix import error

* missed missing_required_lib

* changelog fragment formatting and grammar fixes

* update requirements in documentation and fix spelling
5 years ago
Mark Chappell b8650c0a50 aws_asg: Fix idempotency when using tags and metrics (#61284)
* Update AWS hacking policy to enable ASG Tagging management

* aws_asg: Add tests for ASG Tagging (including idempotency)

* aws_asg: ignore sort order when comparing tags on the ASG (fix idempotency)

* ec2_asg: (integration tests) test for idempotency when managing metrics collection

* ec2_asg: sort list of enabled metrics to ensure clean comparisons.
5 years ago
Matt Martz 8331c8fdc3
Properly hide limit and list-hosts args from ansible-inventory (#61618)
* Properly hide limit and list-hosts args from ansible-inventory. Fixes #61604

* Add changelog fragment

* Consolidate limit

* Fix positional argument with --graph

* Properly error for hidden arguments

* linting issue

* host pattern changelog
5 years ago
Sam Doran 61efffcbe1
User - correct group removal description in docs (#61936) 5 years ago
Andrey Klychkov e4d4e49388 Fix mysql.py logic related to 53326 (#61832) 5 years ago
Ganesh Nalawade 4f29b5a76b
Fix ansible-connection persist after playbook run complete issue (#61591)
* Fix ansible-connection persist after playbook run issue

*  PR https://github.com/ansible/ansible/pull/59153 to add support
   for delaying the ansible-connection added an old issue of
   ansible-connection persisting even after playbook run is finished
   till either command timeout or connect timeout is triggered.
   ansible-connection persist after playbook execution is done
   and also delays the connection initilization untill a method
   in invoked from module side on the connection object.

* Add chanegelog
5 years ago
felyl-github e6fe52bc56 Update os_security_group_rule.py (#61262)
Currently, this module does not support to add 132 SCTP rule in security group rule of openstack. Could we add this support in this module? Thanks~
5 years ago
Matt Davis 7f4328ad12
allow external collections under the ansible NS (#61908)
* fixes #59988
5 years ago
Toshio Kuratomi f58899eef7 Update release name for 2.10
Add a list of previously used release names to make it easy to tell what
release names are no longer usable.

Add a test that new release names have been added to the used list.

Fixes #61616
5 years ago
Mark Chappell 832e03d932 Fixup iam_group integration tests and return value documentation (#61243)
* iam_group: (integration tests) migrate tests to module_defaults

* iam_group: (integration tests) migrate to using temporary user and group with {{ resource_prefix }}

* iam_group: (integration tests) fix test, checking the return values

* iam_group: (integration tests) Add some more tests around the behaviour of 'changed'

* iam_group: (docs) Update documentation of iam_group return value

* Update AWS testing policies to enable group/user management
5 years ago
Kevin Breit 7d303e54f6 meraki_organization - Add warning about organization deletion (#61886)
* meraki_organization - Add warning about organization deletion
The documentation is now more explicit about the ramifications of using `state: absent` in a task.
5 years ago
Sumit Jaiswal 1425d23513 To fix IOSXR L3 Interfaces idempotency failures (#61860)
* fix zuul idemptency failures

* adding eol

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
5 years ago
Yannis Ansermoz ce8af1c8c5 Typo 'state:' net_lldp (#61543)
'state:' should be "absent" not "lldp"
5 years ago
Nathaniel Case a365e77cc3
Connect before reading the prompt? (#61797) 5 years ago
Travis Burton 394a05108d Update mso_schema_template_deploy.py (#61849)
module names are incorrect in EXAMPLES:  changed module names from 'mso_schema_template' to 'mso_schema_template_deploy'
5 years ago
gen2kes 513bddb44a VMware: Add disk_mode parameter in vmware_guest_disk (#60406)
* Solve issue 58592

Added support to select disk_mode.
5 years ago
Evgeni Golov 1aca1f86b6 don't set default:None in documentation when there is no default (#61111)
otherwise "None" will be rendered as a string on docsite
5 years ago
js-max 70f501d5c8 Update hashi_vault.py documentation with kv V2 example (#61221) 5 years ago
Nathaniel Case cc9adf7f1a
Unify ios_logging documentation with accepted options (#61777)
* Unify ios_logging documentation with accepted options

* Apply suggestions from code review

Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>

* Copy suggestion over to eos_logging
5 years ago
Fabian von Feilitzsch f406b8b4c4 Fix bug preventing wait_condition from being respected when using apply (#61493) 5 years ago
Abhijeet Kasurde 223dab99ea
gitlab_hook: Update documentation (#61837)
* Update docs for note_events

Fixes: #61833

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
5 years ago
Felix Fontein e06dbe6e4f
Azure _info modules: fix returned ansible_facts when called as _info (#61805)
* Fix Azure _info modules which still returned ansible_facts.

* Adjust PR #.

* Fix wrong assignment.

* Reorganize code for clarity.
5 years ago
Bill Dodd 2a932ad7cf Fix power command ResetType mapping logic (#59927)
* fix power command ResetType mapping logic

* add changelog fragment
5 years ago
Abhijeet Kasurde 823c108fac
ovirt: Fix API calls in ovirt_storage_domain (#61825)
* Fixed argument in _attached_sds_service API
* Fixed argument in _maintenance API

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
5 years ago
Paul Belanger c723eb2f04
Remove unused import from iosxr facts (#61785)
This is no longer needed and can be removed.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
5 years ago
Jordan Borean 3a7b77a94c
ansible-galaxy fix --server option for roles (#61820) 5 years ago
Paul Belanger f81b7dd10a
Remove unsed import for eos facts module (#61795)
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
5 years ago
Matt Martz 8214d188cf Don't truncate the last character from galaxy urls. Fixes #61624 (#61775) 5 years ago
Paul Belanger 7be672e1c2
Remove unsed import for junos facts (#61787)
This is no longer needed.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
5 years ago
Sloane Hertel ff05991265
s3 - improve waiting for the bucket (#61802) 5 years ago
Nathan Swartz 4c8407fb83 Fix documentation and facts_from_proxy value in the netapp_e_facts module. (#61072) 5 years ago
Paul Belanger 44eaea9f80
Remove unused import for cisco ios facts (#61790)
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
5 years ago