Commit Graph

416 Commits (b2350d8aaf18b518ba062a6f37ea0e7a8fb7dd49)

Author SHA1 Message Date
David Minor ed7d3f92a0 Add ssh key options parameter to authorized_key module 11 years ago
James Tanner e3849f1be7 Fixes #4312 for older versions of usermod which do not have --append 11 years ago
Michael DeHaan 119b6d73dd Remove examples of module antipattern of setting the choices array for boolean types. 11 years ago
Boris Kaul 5a34e572f5 Add support for Rich Rules in firewalld module 11 years ago
Boris Kaul 194a7dab9f Fix timeout bug in firewalld module 11 years ago
James Tanner b7f229d390 Second attempt at preventing ipv6 route enumeration on EL4 machines 11 years ago
James Tanner 4b1600aae5 Revert "Do not enumerate ipv6 routes in CentOS 4"
This reverts commit 5186c408f7.
11 years ago
James Tanner 5186c408f7 Do not enumerate ipv6 routes in CentOS 4 11 years ago
Michael DeHaan 135f79f337 Add documentation about how passwords are generated. 11 years ago
James Cammarata a2ac5d6df2 Better detection/categorization of ipv4 secondaries/virtual IPs
Fixes #3916
Fixes #3478
11 years ago
Michael DeHaan c5672cf16e Merge pull request #4389 from MattTheRat/devel
addresses #4371 - adds -m to usermod commands
11 years ago
Matt Warren 74c412e249 addresses https://github.com/ansible/ansible/issues/4371 - adding -m to home directory modification 11 years ago
Michael DeHaan f6c3dce497 Merge pull request #4336 from orkaa/devel
Fixes service update-rc.d functionality on debian
11 years ago
Martijn Lina 4cd3b9d637 replace dashes in rc.conf keys (which are based on freebsd rc.d filenames) to underscores 11 years ago
Skylar Saveland b47add0f32 fixes 4365 - Mac with cisco vpn client, GenericBsdIfconfigNetwork get_default_interfaces fails with index out of range 11 years ago
Adam Miller 323e8d4a8c fixed firewalld get_service_enabled 11 years ago
Nace Oroz 672a0c04e4 Fixes service update-rc.d functionality on debian 11 years ago
cdigiovanni 7ff2b3befd Added support to disable and enable upstart jobs 11 years ago
Brian Harring f88fed2060 Enforce umask for cron module, so cron_file generated files are 0644.
Certain cron implementations get cranky if files in cron.* are group
writable.
11 years ago
Nils Pascal Illenseer 4ee6c6d5df Add option 'lz4' for compression 11 years ago
Cristobal Rosa 617f7bb0a0 Added an space between code and comments in order to follow the coding standars 11 years ago
Cristobal Rosa be279295b6 Added a new check to check whether an network interface is in promiscuous mode 11 years ago
James Cammarata 9dd2d1eb13 Merge pull request #4222 from lessmian/devel
Module lvol fails when decimal point is a colon
11 years ago
James Cammarata 301a00ccf5 Merge branch 'obsd-fix-release' of https://github.com/johanwiren/ansible into johanwiren-obsd-fix-release 11 years ago
James Cammarata 23417368df Fixing up some open_iscsi docs and CHANGELOG update 11 years ago
James Cammarata c98ed252fe Merge branch 'open_iscsi_bis' of https://github.com/sergevanginderachter/ansible into sergevanginderachter-open_iscsi_bis 11 years ago
Tomasz Lesniewski 385ffcdfb1 Module lvol fails when decimal point is a colon 11 years ago
Rene Moser ff84812047 host: minor doc style improvements 11 years ago
Tomasz Lesniewski e2815a56dc Module lvol fails when decimal point is a colon 11 years ago
Michael DeHaan 314e1aafc1 Merge pull request #4220 from dagwieers/setup-dmidecode-fix
Fix for commented dmidecode output
11 years ago
Dag Wieers 5bd7664fac Fix for commented dmidecode output
This patch fixes the problem that on some system dmidecode prints out warning information as commented text. For example:

    [user@system ~]# dmidecode -s system-manufacturer
    # SMBIOS implementations newer than version 2.6 are not
    # fully supported by this version of dmidecode.
    HP

So we remove all commented lines from the output.
11 years ago
Rene Moser 803b2b91a6 host: added another example 11 years ago
James Cammarata a6d62ef59b Minor pep8 cleanup 11 years ago
James Cammarata 4420379f59 Fixing some bugs found during testing in the host module 11 years ago
James Cammarata da0d50c383 Merge branch 'feature/host' of https://github.com/resmo/ansible into resmo-feature/host 11 years ago
James Cammarata a8fac7906d Merge branch 'devel' of https://github.com/drybjed/ansible into drybjed-devel 11 years ago
James Cammarata c31ece58fa Added version_added string to new modprobe module and CHANGELOG update 11 years ago
James Cammarata 4d7b5da25d Merge branch 'modprobe-module' of https://github.com/stygstra/ansible into stygstra-modprobe-module 11 years ago
James Cammarata d1f713938e Modified env fact gathering to use the native python method
Also updated CHANGELOG for this feature
11 years ago
James Cammarata 19343288df Merge branch 'env_facts' of https://github.com/bcoca/ansible into bcoca-env_facts 11 years ago
Maciej Delmanowski 551b93c547 Made re.search string shorter 11 years ago
Maciej Delmanowski 40b0471e95 Add Linux Container identification 11 years ago
Johan Wirén e9554e5da2 Fixed setup module to no longer break on OpenBSD release versions. 11 years ago
James Cammarata 4efdf0d49f More housekeeping
* Modified version_added strings in recent modules
* Added firewalld inclusion to the CHANGELOG
11 years ago
James Cammarata 8721ad2909 Moving firewalld module from net_infra to system 11 years ago
René Moser 0ba7acd205 host: code cleanup 11 years ago
James Cammarata c2e02fbd6b Minor tweak to service changed logic from the previous commit 11 years ago
James Cammarata f62093da56 Merge branch 'service-enable-fix' of https://github.com/gottwald/ansible into gottwald-service-enable-fix 11 years ago
Petr Svoboda 8d290e3394 Fix traceback in service module when svc_cmd is None (2nd fix)
When service module is used on unsupported Linux system where init
script is used directly, LinuxService.svc_cmd is None so .endswith()
fails.

This extends fix from e2f20db534 also
for state=restarted.

Fixes issue #3533
11 years ago
René Moser bcaab4236b host: updated version_added 11 years ago
Rene Moser 7f96dd832f added module host
Add or remove entries in /etc/hosts using tasks:
- host: ip=127.0.0.1 hostname=localhost aliases=foobar.com,localhost.foobar.com
- host: ip=127.0.0.1 hostname=localhost state=present
- host: ip=192.168.1.1 state=absent
- host: hostname=localhost state=absent
- host: ip=::1 hostname=localhost aliases=ip6-localhost,ip6-loopback
11 years ago
David Stygstra 58620ca477 Add Python 2.4 support to modprobe module 11 years ago
David Stygstra 27a08dc647 Module to manage kernel modules 11 years ago
James Cammarata f4c5f37ca6 Merge branch 'issue_3417_systemd_stuff' into devel 11 years ago
James Cammarata 02033f9ec8 Merge branch 'archlinux-fact' of https://github.com/Schnouki/ansible into Schnouki-archlinux-fact 11 years ago
r-p-e 2f887c6dca Add some more OpenBSD facts
added:
 * ansible_distribution
 * ansible_distribution_release
 * ansible_distribution_version
11 years ago
Ingo Gottwald f7adbf2f29 Bugfix service module: Only change service state when needed 11 years ago
Thomas Jost dfb10e646e Add Archlinux "distribution" fact 11 years ago
James Cammarata 72eaa0570e Allow service module to manage services not ending in .service
Fixes #3417
11 years ago
James Cammarata 5110b2d440 Slight refactorization of the sysctl module
* Added in support for freebsd-style sysctl commands
* Replaced some functionality that was provided by module_common
* Simplified some logic in a couple of places (ie, not checking
  a split with len() but instead limiting the split to 1)

Fixes #3380
11 years ago
James Cammarata 3e9b63febd Compare exploded values in the sysctl module to avoid whitespace errors
Fixes #3931
11 years ago
James Cammarata b2741f451e Fixes to the service module for Ubuntu 12.04 (LTS)
Fixes #3615
Fixes #3572
11 years ago
James Cammarata 9a3a3e648b Check for systemd ownership of a service even if an init.d script exists
Also slight modification to the error message in the earlier commit that
modified the update-rc.d detection portion of the code

Fixes #3474
11 years ago
James Cammarata 7c8aa669cf Minor fix to account for template service names in systemctl 11 years ago
James Cammarata 6c3af4df81 Fix for update-rc.d based systems that also have systemd installed
By default, the service module had assumed that if the system had the
update-rc.d binary, the service was either managed via upstart or standard
sysV init-style scripts. This patch adds a check for systemctl ahead
of the other methods when update-rc.d is detected, and also simplifies
the logic around the detection of systemctl-managed services
11 years ago
James Laska 546788a1b6 The required package for selinux is libselinux-python 11 years ago
Brian Coca c2d1607490 Added collection of user's env
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
James Cammarata 82e1722fff Merge branch 'aix_wpar_facts' of https://github.com/mplonka/ansible into mplonka-aix_wpar_facts 11 years ago
James Cammarata 26a8d4ce9f Added 'reloaded' state to list of states checked for bounced services
Fixes #3556
11 years ago
Serge van Ginderachter a351c25c59 Introduce open-iscsi module to manage targets on the initiator. 11 years ago
Raul Melo 461858e476 Fix issue 3908. There was some ilegal operations over the sets 11 years ago
James Cammarata ceddc37f07 Fix for the cron module on FreeBSD
Apparently crontab on freebsd does not like the file path coming before
the "-u username" portion of the command to install the crontab
11 years ago
Hiroaki Nakamura a0da0afe00 Fix a bug in DebianStrategy.get_permanent_hostname(). Use strip, not split! 11 years ago
Hiroaki Nakamura 4f91238e34 Rewrite with "try ... finally" instead of "with" statement to support Python 2.4. 11 years ago
Hiroaki Nakamura 3b1d7d88b5 Remove extra sysloggings. 11 years ago
Hiroaki Nakamura f4ba0e78a4 Raise an error on unsupported platform/distributions. 11 years ago
Hiroaki Nakamura ce2b37e2ff Add a hostname module, which sets system's hostname. 11 years ago
Marcin Płonka 61298e4703 Skipping facts not available on AIX WPARs 11 years ago
shirou e18ede85a0 supports nested values of ohai. 11 years ago
Michael DeHaan 5e049a5df7 Merge branch 'fix_service_with_initscript' of git://github.com/psvo/ansible into devel 11 years ago
Andy Wilson bc30203abe docfix: grammar in docstring for sysctl module 11 years ago
Petr Svoboda e2f20db534 Fix traceback in service module when svc_cmd is None
When service module is used on unsupported Linux system where init
script is used directly, LinuxService.svc_cmd is None so .endswith()
fails.

Fixes issue #3533
11 years ago
Michael Scherer cfa5a0f94d Add urpmi as a package manager for mandriva-based distribution 11 years ago
James Cammarata e32a6110af Removing skipped=True so the task is just marked as not-changed 11 years ago
James Cammarata d98ad7b374 Set result to skipped when vol group is missing and lv state=absent
Fixes issue #3714 - lvol module state=absent fails (with error) if
the volume group doesn't exist
11 years ago
rishid 07ef8c4d84 Verify groups string is not empty before trying add user to groups 11 years ago
Brian Coca 0ae7bcf3e2 fixed bug from prev update
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Brian Coca 1e1f117886 whitespace updates on new lines
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Brian Coca d8e8aa714e now uses get_bin_path for lvg executables
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Michael DeHaan 8cc13590b4 Make exceptions handling python 2.4 compatible. 12 years ago
Michael DeHaan fc9aa5f014 Continue on mount errors, don't fail the setup module. 12 years ago
Brian Coca 3f85a82ae9 use global to fail as its not in self
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Michael DeHaan 1acd9b6325 Update CHANGELOG 12 years ago
Michael DeHaan e589365279 Merge branch 'iss_cron' of git://github.com/dirtyharrycallahan/ansible into dh_cron 12 years ago
Michael DeHaan 588b20c012 Merge pull request #3602 from bcoca/fine_tune_stat_exception
narrowed down exception
12 years ago
Michael DeHaan 3b3b600a98 Merge pull request #3470 from langemeijer/devel
Only append non_unique parameter if a uid is provided as well to user module
12 years ago
Brian Coca b7b1c714f9 narrowed down exception we ignore and fail if any other unexpected one
crops up.
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Florian Tham ceff31241b fix fatal error when removing logical volumes 12 years ago
Antti Rasinen 7b8f24adda Make zfs set_property accept values with embedded spaces
Converting the argument list to a string with ' '.join causes
the shell interpreter to misparse spaces in property values.
Since the zfs command does not need shell anywhere, using
a list instead of a string works just as well with run_command. 

Fixes #3545.
12 years ago
Antti Rasinen 7670572578 Fix zfs property parsing
Current property parser breaks when values contain spaces. Since
zfs get -H returns tab separated lines,  it is better to explicitly
split on tabs than on whitespace.
12 years ago
trbs 38b6087495 fix missing json module for issue #3363 print JSON error as string instead 12 years ago
Brian Coca 80b9b01e97 now won't throw exception if we don't have permission to stat a mtab
entry on linux (weird chromebook issue)
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Michael DeHaan 8fe15f0a30 Merge pull request #3426 from trbs/services_sleep_option
sleep option for service module which adds a pauze between stopping and ...
12 years ago
Michael DeHaan 3a84254f6d Merge pull request #3496 from johanwiren/bsd-ipv6-facts
Fix for populating default_ipv6 on BSD systems
12 years ago
Michael DeHaan d1398594ce Merge pull request #3497 from johanwiren/bsd-gateway
Updated setup module to collect gateway fact for BSD systems
12 years ago
Michael DeHaan 952760c605 Merge pull request #3388 from bcoca/fixed_user_create_doc
updated module docs to reflect 'correct' on_create vs on_creation
12 years ago
Johan Wirén 1c247c9eb4 Updated GenericBsdIfconfigNetwork to collect gateway 12 years ago
Johan Wirén 10e9194744 Fix for populating default_ipv6 on BSD systems 12 years ago
Joshua Lund cc275ca2be Added a new with_file example to the authorized_key documentation 12 years ago
Patrick Callahan 8f14ffe56b Bug fixes and enhancements.
Bugs:
(1) no longer allow empty jobs
(2) strip the header added by crontab package used in openSuSE and SuSE
(3) try not to leak temp files when things go wrong
(4) issue returning job names under certain conditions

Enhancements:
(1) Allow all special times not just reboot.
(2) Fail earlier by performing more input validation
(3) Add feature to allow removing cron file under /etc/cron.d

ToDo:
(1) Validate times (minute, hour, ...)
(2) Strip white space from fields such as name and job such that name=foo equals name=' foo'.
(3) More testing
12 years ago
Brian Coca 0664e36aa2 fixed check mode
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Casper Langemeijer 922a71fced Only append non_unique parameter if a uid is provided as well 12 years ago
Aaron Brady efc4bc10d4 Make the CPU facts Hyperthreading aware 12 years ago
trbs 3b2173b6df sleep option for service module which adds a pauze between stopping and starting a service using state=restarted. This helps for bad scripts that exist immediatly after signaling a process to stop. 12 years ago
Antti Rasinen 93fc3391fe Fix service enable on FreeBSD
Some services have a knob (i.e. rc.conf setting) whose name
differs from that of the script. For example, lockd process
is controlled with a script called lockd, but the rc.conf
value is rpc_lockd_enable.

Fixes issue #3382.
12 years ago
Brian Coca 9f75397310 updated module docs to reflect 'correct' on_create vs on_creation
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Michael DeHaan 15bf8a8398 Merge pull request #3315 from madduck/fix-service-updatercd-changed
Let update-rc.d set changed flag properly
12 years ago
Michael DeHaan 681696846a Styling: semicolon 12 years ago
Michael DeHaan fc8ffc1864 Styling: blank lines 12 years ago
Serge van Ginderachter f000dcd526 add more support for different size formats 12 years ago
martin f. krafft 85b8538e0e Expand usage of Python 2.6 if statement
Syntax like "'foo' if bar else 'baz'" is not supported by all Python
versions targetted by Ansible. Hence we break it up.

Signed-off-by: martin f. krafft <madduck@madduck.net>
12 years ago
martin f. krafft 3df2e15277 Let update-rc.d set changed flag properly
When update-rc.d is used to enable/disable service, the changed flag was
always true (see #2189). This commit fixes that.

Signed-off-by: martin f. krafft <madduck@madduck.net>
12 years ago
Michael DeHaan 3f8aa8aec5 Fix up some module docs formatting errors. 12 years ago
Patrick Callahan b5b862fe6f bug fix: modify get_device_facts to handle servers with multiple pci domains
On machines with multiple pci domains get_device_facts would fail to
find a matching pci device causing setup to fail. Also on some platforms
there is additional information between the pci information and 'host'.
Modified get_device_facts to call lspci with the -D option and modified
the regex to account for the pci domain and to be more selective.
12 years ago
Michael DeHaan 575e052c6c Merge pull request #3147 from toshywoshy/setup_mtab_without_bind
changed get_mount_facts to ignore mount types 'none'
12 years ago
Michael DeHaan 61ac8d03af Clarify module docs 12 years ago
Michael DeHaan 51ba3d8c3d Merge pull request #3230 from sayap/openrc
Add OpenRC support to the service module.
12 years ago
Brian Coca c9c7b01620 now mount/unmount are searched for instead of hardcoded
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Yap Sok Ann bcca609bc6 Add OpenRC support to the service module. 12 years ago
Michael DeHaan fe9849530c Merge pull request #3120 from chrisgardner/solaris-os-facts
Add Solaris O/S distribution facts
12 years ago
Michael DeHaan 2eb3a9a3c9 Resolve docs conflict. 12 years ago
Michael DeHaan 572f49b11f Fix merge conflict. 12 years ago
Michael DeHaan c3544de1df Merge pull request #3228 from skvidal/facts.d
first cut and docs for facts.d mechanism for setup module
12 years ago
Michael DeHaan 936e61fc28 Merge pull request #3181 from melodous/devel
HP-UX virtualization facts
12 years ago
trbs a4223e119d fixed x-bits in git 12 years ago
Michael DeHaan 78fdedd490 Merge remote branch 'origin' into devel
Conflicts:
	library/web_infrastructure/django_manage
12 years ago
Michael DeHaan f0d66f0cda Merge pull request #3176 from jpmens/sol-epoch
setup epoch time doesn't have tics on Python 2.6.4 (Solaris).
12 years ago
Seth Vidal 36df7e8c95 cut and docs for facts.d mechanism for setup module 12 years ago
Jan-Piet Mens 5c69918d53 DOCS: standardize on EXAMPLES (a.k.a. Docs-JumboPatch JetLag Edition)
Migrated all examples: in DOCUMENTATION=''' string to standalone EXAMPLES=''' string
  Added deprecation warning to moduledev.rst and remove deprecated example from it
  Fixed up a few typos and uppercased some acronyms.
  add consistency to how EXAMPLES are formatted
12 years ago
Raul Melo f9f0f5ce2c HP-UX virtualization facts 12 years ago
Jan-Piet Mens f6521d88f5 setup epoch time doesn't have tics on Python 2.6.4 (Solaris). 12 years ago
Jan-Piet Mens 3f301fd439 Protect None value in setup module 12 years ago
Michael DeHaan 790a145f6c Use get_bin_path for blkid and add some aliases to the filesystem module. 12 years ago
Joshua Lund 51c7441244 Updates to the authorized_key documentation
* Clarified the meaning of 'user'
* Changed 'sshdir' to 'path' in the example
  * 'sshdir' is used internally in the module, but the argument is 'path'
* Made the capitalization consistent in the descriptions
12 years ago
Toshaan Bharvani f76043f404 changed get_mount_facts to ignore mount types 'none' 12 years ago
Raul Melo 2475bc416c Facts for HP-UX 12 years ago
Chris Gardner 2ba47318dc Use first line from /etc/release in "distribution_release" for consistency across Solaris and derivatives. 12 years ago
Michael DeHaan 788680a15d Merge branch 'devel' of git://github.com/trbs/ansible into more_users 12 years ago
Michael DeHaan c3ff4ccb35 These options to bypass the check code seem to need to occur before said checks. 12 years ago
Chris Gardner f0a4a17ff6 Add Solaris O/S facts "distribution" and "distribution_*" 12 years ago
Michael DeHaan caa07e7fab pep8 fixes 12 years ago
Michael DeHaan 15560c9801 Fix module labelled incorrectly. 12 years ago
Michael DeHaan d434252ba4 Docs standardization 12 years ago
Michael DeHaan 417be6f81e Docs standardization 12 years ago
Michael DeHaan b9e72cdd98 Warn when there is a space in the mount module opts parameter. 12 years ago
trbs 3b3afe2283 Add support for Open and NetBSD platforms for user and group modules, including a new login_class parameter for FreeBSD, OpenBSD and NetBSD. 12 years ago
Michael DeHaan 9122efb24a Merge pull request #3083 from mvo5/feature/facts-add-statvfs
add "size_{total,free}" to the "mount" facts
12 years ago
Michael DeHaan 049b77be6d Merge pull request #3076 from mmoya/userspace-arch-facts
Provide userspace_{architecture,bits} facts
12 years ago
Michael DeHaan 514f18acac Merge branch 'solaris-network-facts' of git://github.com/chrisgardner/ansible into devel 12 years ago
Michael DeHaan 47b9db0d98 Remove debug statement in previous patch. 12 years ago
Michael DeHaan eec53347b5 Merge branch 'devel' of git://github.com/trbs/ansible into groups 12 years ago
Stephen Fromm 43d96ba335 cleanup to dmi fact discovery
When invoking dmidecode, first use module.get_bin_path() and secondly
use module.run_command.
Remove sub function execute() from get_dmi_facts().
Simplify get_dmi_facts() by only using two mechanisms to determine dmi
facts:  first try /sys/devices/virtual/dmi and if not available, use
dmidecode executable.
12 years ago
Michael DeHaan d078ad5a13 Merge pull request #3068 from lorin/authkey-default
authorized_key: Set manage_dir default value
12 years ago
Michael DeHaan 4afc0a5c03 Merge pull request #3044 from chrisgardner/solaris_facts
Solaris facts
12 years ago
Michael DeHaan 69d514100c Refine error message. 12 years ago
Michael DeHaan 0b30c74e86 Merge branch 'rc.d-systemd' of git://github.com/glensc/ansible into sysd 12 years ago
Michael Vogt 6acf9a9b3b use statvfs.f_bavail to match the output of "df -B1" 12 years ago
Michael Vogt 73a12b04a4 add "size_{total,free}" to the "mount" facts 12 years ago
Maykel Moya d0843a7f55 Provide userspace_{architecture,bits} facts
When running inside a chroot userspace architecture might not
match that of the actual host.

This patch provides userspace_bits as reported by python's
platform.architecture(). Also provides userspace_architecture fact
if host is an x86 machine.
12 years ago
Chris Gardner 1b8adab2cc Add Solaris network facts. IPv4 and IPv6 both working. 12 years ago
trbs b537aff586 Fix for #3062 additional groups should only be added once.
Also consolidated duplicate groups code into one get_groups_set() method.
Removed unused call to user_group_membership.
Removed sorting operations on set functions cause sets are inherently unordered.
Minor style improvements to match the rest of the code.

The new function will make the order of group names passed to the system command less determistic.
Which was already the case for modify_user_usermod() but not for other methods.
It will also strip out duplicate group names automatically which was not always the case previously.
12 years ago
Lorin Hochstein 8c9cceacbf authorized_key: Set manage_dir default value
This commit fixes a bug where the authorized_key module causes
the ~user/.ssh directory to be owned by root instead of the user,
when the manage_dir argument is not specified.

If the manage_dir argument was not specified, the module behaved as if
manage_dir was set to false, even though it's supposed to default to
true.

This module assumed that an optional argument, with no default
specified, will not be present in the module.params dictionary.

What actually seems to happen is that the argument does appear in
the module.params dictionary with a value of None.

The upside is that this line was evaluating to None instead of
true:

    manage_dir = params.get("manage_dir", True)

I fixed the problem in this particular module by explicitly specifying
the default value for the manage_dir arugment. But if this bug
occurred because of a change in behavior in AnsibleModule, then other
modules may be broken as well.
12 years ago
Michael DeHaan ad1a02aa55 Merge pull request #3064 from sfromm/issue2990
Verify /proc/modules is readable (issue #2990)
12 years ago
Stephen Fromm 00b3a450c7 Verify /proc/modules is readable (issue #2990) 12 years ago
Stephen Fromm 3127bab6d6 Use get_bin_path to find mkfs command (issue #2983) 12 years ago
Chris Gardner 2b71ab6765 Fix typo. Solaris 9 should now correctly ignore 'brand' and use 'implementation'. 12 years ago
Chris Gardner 88115f4ab2 TODO: Separate IPv4 and IPv6 12 years ago
Jiří Kubíček 5cb0525430 Add some FreeBSD facts
added:
 * ansible_distribution
 * ansible_distribution_release 
 * ansible_distribution_version
 * ansible_os_family
 * ansible_pkg_mgr
 * ansible_ssh_host_key_ecdsa_public

Also adds ECDSA public key for all plaforms.
12 years ago
Chris Gardner 6809b56233 Add Solaris network facts. IPv6 details overwrite IPv4 per interface, needs further work. 12 years ago
Chris Gardner f482649cbb Add clock speed to processor description for SPARC CPU. 12 years ago
Chris Gardner 68959e7f92 Use 'implementation' if 'brand' not available (Solaris 9). Add CPU socket/core counting. 12 years ago
Michael DeHaan a581077b4d Merge branch 'facter-fix' of git://github.com/flyapen/ansible into devel 12 years ago
Guillaume Lasmayous 1c0e01a72b Implement NetBSD-specific subclass of Hardware in the setup module.
Defines memory and CPU facts:
- memfree_mb
- memtotal_mb
- swapfree_mb
- swaptotal_mb
- processor (a list)
- processor_cores
- processor_count
- devices

As a matter of fact, on NetBSD, it is possible to get memory, swap and
processor facts exactly as on Linux. Tested on NetBSD-5, NetBSD-6 and
NetBSD-6.1 (without Linux emulation).
12 years ago
Chris Gardner 9ca7165f88 Use kstat for Solaris CPU info 12 years ago
Chris Gardner 66c10410ec Use kstat for Solaris CPU info 12 years ago
Kristof Keppens c5b40ca2ff change fix to lookup path with get_bin_path 12 years ago
Michael DeHaan 698b2fe9c5 Merge pull request #2992 from SirScott/service_pattern
Fixes #2991: Service module pattern argument ignored.
12 years ago
Scott Sturdivant 922a1efbc0 Fixes #2924: User creation always reports 'changed' 12 years ago
Scott Sturdivant b274fb9774 Fixes #2991: Service module pattern argument ignored. 12 years ago
Kristof Keppens e2e10c1977 fix for facter being installed in a different location 12 years ago
Elan Ruusamäe d3a2b1dbbb no need to init None to None 12 years ago
Michael DeHaan 328065506e Merge pull request #2941 from bcoca/setup_bin
no uses get_bin_path for 2nd use of ip tool
12 years ago
Michael DeHaan 39673fe8c0 Merge pull request #2940 from madema/patch-3
-o and -r option don't exist on AIX
12 years ago
Ton Kersten 8926684942 Fix issue 2906 12 years ago
Brian Coca 8d6e18fc90 no uses get_bin_path for 2nd use of ip tool (fixes reported issue with openwrt)
module needs this added to many tool invokations, but his is a start
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
madema 58d59c180d -o and -r option don't exist on AIX 12 years ago
Michael DeHaan 6b4f09d7dc Style fix. 12 years ago
Michael DeHaan 584508dda6 Merge pull request #2866 from madema/patch-2
Fixed an error in the get_cpu_facts of the AIX class
12 years ago
Michael DeHaan dab846a631 Merge pull request #2865 from madema/patch-1
Added AIX class in the service module to control AIX SRC processes.
12 years ago
Michael DeHaan 53db51a0a2 Merge pull request #2863 from lonerr/freebsd-group
FreeBSD group operations is now supported properly.
12 years ago
Michael DeHaan cb54922bcd Merge pull request #2862 from lonerr/freebsd-user
Fixed errors in FreeBSD user manipulations.
12 years ago
Michael DeHaan 67e67bca1f Change filesystem module message. 12 years ago
Michael DeHaan 63e510a632 Merge pull request #2853 from abulimov/module_mkfs
Module filesystem
12 years ago
Elan Ruusamäe 6949a9fbe4 LinuxService: avoid enforcing systemd even if init.d script was found 12 years ago
madema 02e41f3e56 Update service 12 years ago
madema cf4dbf1f40 Fixed an error in the get_cpu_facts of the AIX class
assumed proc0 as the first processor but can be different in a LPAR environment
12 years ago
madema f7c3b73336 Added AIX class in the service module to control AIX SRC processes. 12 years ago
lonerr dcb22d1760 FreeBSD group operations is now supported properly. 12 years ago
lonerr b2db6483ac Fixed errors in FreeBSD user manipulations. 12 years ago
Oleg 3531fbdb29 fix for authorized_key: skip chown and chmod if authorized_key_file is link 12 years ago
Alexander Bulimov f4de40fc43 renamed mkfs and moved to system/filesystem 12 years ago
Luciano Cavalheiro da Silva d18d2de18e Fix #2836. Ensure proper handling of option "system=yes" in module "group". 12 years ago
rektide 4f21dc4cd1 Duplicate pull #2803 in ipv6, fixing setup module's handling of venet & unknown interface types. 12 years ago
Michael DeHaan 2cf30148ba Test for the existance of a file that might not be present on older RHEL. 12 years ago
James Mills efc5a83f66 Fixed setup module to accomodate venet interfaces (OpenVZ) 12 years ago
Michael DeHaan 391fb98ee2 Allow modules to be categorized, and also sort them when generating the documentation. 12 years ago