Commit Graph

233 Commits (b1f8f0d48d86f1f1d12e558764dd7d3d37ac2026)

Author SHA1 Message Date
Matt Martz 5a254e6303 Replace tabbed indentation with spaces for mysql_db module 9 years ago
ToBeReplaced 5e82f7e11e Make ALL_IN_SCHEMA for tables affect views
ALL TABLES is considered to include views, so we must check for reltypes
'r' and 'v', not just 'r'. This bug was introduced due to using a
custom, backwards-compatible version of "ALL TABLES IN SCHEMA".
9 years ago
Bryan Fleming 3b4b065315 fixes #1120 - privileges using columns 9 years ago
Sergei Antipov 5465fb8d4f mysql_user | Hide password 9 years ago
Greg DeKoenigsberg 2a5f0bde87 Proper author info for all remaining modules 9 years ago
Louis-Michel Couture d60d493916 Update example to remove outdated information 9 years ago
Toshio Kuratomi c700993dd5 Fix a problem introduced with #1101 and optimize privilege handling
* If a db user belonged to a role which had a privilege, the user would
  not have the privilege added as the role gave the appearance that the
  user already had it.  Fixed to always check the privileges specific to
  the user.
* Make fewer db queries to determine if privileges need to be changed
  and change them (was four for each privilege.  Now two for each object
  that has a set of privileges changed).
9 years ago
Toshio Kuratomi 8c10cc20ec Expand tildes and vars in the config file path 9 years ago
Will Thames 167e7c2b81 Perform privilege grants/revokes only when required
Use `has_table_privileges` and `has_database_privileges`
to test whether a user already has a privilege before
granting it, or whether a user doesn't have  a privilege
before revoking it.
9 years ago
Toshio Kuratomi 30fc6f03d6 Allow playbook specified login_user and login_password to override config file settings 9 years ago
Toshio Kuratomi f8d8af17cd Use a list comprehension instead of map and lambda 9 years ago
Toshio Kuratomi 474b731bcc Merge pull request #1036 from shr3kst3r/strip_spaces
Strip spaces around MySQL privileges before comparing to valid privileges
9 years ago
Toshio Kuratomi 2b5e932cfb Fix for the new import code when password is empty 9 years ago
Brian Coca 7a6f532020 Merge pull request #1423 from ercpe/mysql_db-debugging
Improved output of mysql_db plugin
9 years ago
Jonathan Mainguy db9ab9b262 escapeds changes
fixed merge conflict

remove uneeded regexs

arrays
9 years ago
Robin Miller cda7a9be15 Replaced lambda functions with list comprehensions. 9 years ago
Robin Miller 74b7ce9dcf Only revoke actually granted permissions, not 'ALL'.
This prevents errors when the login_user does not have 'ALL'
permissions, and the 'priv' value contains fewer permissions than are
held by an existing user. This is particularly an issue when using an
Amazon Web Services RDS instance, as there is no (accessible) user with
'ALL' permissions on *.*.
9 years ago
Johann Schmitz 8892aa2bf4 Improved output of mysql_db plugin
Show error number and error description on connect error to ease debugging.
9 years ago
Toshio Kuratomi d74187438f Merge pull request #1417 from fdupoux/mysql-db-use-python-pipelines
Decompress mysql dumps on the fly using python subprocess …
9 years ago
fdupoux 380b122d5a Refactoring to avoid duplication of code which manages the decompression of database dumps in various formats 9 years ago
fdupoux f634c10636 Simplify code which prepares the decompression command 9 years ago
Toshio Kuratomi 32e609720a Refactor dump compression and use get_bin_path for finding the compressors 9 years ago
fdupoux 1e2ce363f7 Decompress mysql dumps on the fly using python subprocess during an import to simplify operation 9 years ago
Jonathan Mainguy 5a22f052b4 changes hostname to lowercase 9 years ago
Toshio Kuratomi 0c04a54f67 Merge pull request #1368 from ansible/postgresql-user-account-vs-role-fix
Fix a problem introduced with #1101 and optimize privilege handling
9 years ago
Toshio Kuratomi c9b17136e4 Fix a problem introduced with #1101 and optimize privilege handling
* If a db user belonged to a role which had a privilege, the user would
  not have the privilege added as the role gave the appearance that the
  user already had it.  Fixed to always check the privileges specific to
  the user.
* Make fewer db queries to determine if privileges need to be changed
  and change them (was four for each privilege.  Now two for each object
  that has a set of privileges changed).
9 years ago
Brian Coca b9dba50372 minor doc fix and made sure check_implicit_admin is true boolean 9 years ago
Toshio Kuratomi 7dd9f57e16 Fix splitting of role_attrs 9 years ago
fdupoux 51ffbda9a1 Add support for xz compression (for dump and import) in mysql_db module 10 years ago
Toshio Kuratomi ed6b95a0bb Merge pull request #45 from Jmainguy/mysql_db_alldatabases
Adds name=all which allows a user to dump or import all data...
10 years ago
Jonathan Mainguy f0af9b9ed5 Adds all_databases option which allows a user to dump or import all databases at once, identical to mysqldump --all-databases
fix line 132

Update to name=all

cleaned up all_database per abadger's suggestions
10 years ago
Toshio Kuratomi 8b4e201772 Expand tildes and vars in the config file path 10 years ago
Brian Coca 35703caf6f Merge pull request #1101 from willthames/postgresql_reduce_alter_role
Update postgresql users only when necessary
10 years ago
Pascal Borreli f29a6ec54d Fixed typos 10 years ago
Toshio Kuratomi 58c8696fc5 Allow playbook specified login_user and login_password to override config file settings 10 years ago
Julia Kreger 35bcd6a965 Set default for mysql_user config_file
The default value set by the module was a value of None for the
config_file parameter, which propogates into the connect method
call overriding the stated default in the method.

Instead, the default should be set with-in the parameter
specification so the file check is not requested to check None.
10 years ago
Brian Coca 8023c60863 minor doc fixes 10 years ago
Sven Schliesing c53ca2f776 use default value for parameter config_file in connect() 10 years ago
muffl0n 616ac905ff Use MySQLdbs read_default_file 10 years ago
Will Thames c956c65731 Usage is not a valid database or table privilege
Remove `USAGE` from the `VALID_PRIVS` dict for both database and
table because it is not a valid privilege for either (and
breaks the implementation of `has_table_privilege` and
`has_database_privilege`

See http://www.postgresql.org/docs/9.0/static/sql-grant.html
10 years ago
Will Thames 7d66da35a7 Perform privilege grants/revokes only when required
Use `has_table_privileges` and `has_database_privileges`
to test whether a user already has a privilege before
granting it, or whether a user doesn't have  a privilege
before revoking it.
10 years ago
Will Thames b4515c8909 Update postgresql users only when necessary
For read-only databases, users should not change when no changes
are required.

Don't issue ALTER ROLE when role attribute flags, users password
or expiry time is not changing.

In certain cases (hashed passwords in the DB, but the password
argument is not hashed) passlib.hash is required to avoid
running ALTER ROLE.
10 years ago
Brian Coca 6e373ace86 corrected version added 10 years ago
Brian Coca c4a22478c4 Merge pull request #830 from BlackMesh/devel
mysql_user #829: add update_password to mysql_user
10 years ago
Dennis Rowe 539b7744d0 Strip spaces around perms 10 years ago
tedder bffd137edd code review fixes per #957 10 years ago
tedder 472331a53b skip password changes so pg_authid isn't needed
Some places ([AWS RDS](https://forums.aws.amazon.com/thread.jspa?threadID=151248)) don't have, or don't allow, access to the `pg_authid` table. The only reason that is necessary is to check for a password change.

This flag is a workaround so passwords can only be set at creation time. It isn't as elegant as changing the password down the line, but it fixes the longstanding issue #297 that prevented this from being useful on AWS RDS.
10 years ago
Toshio Kuratomi b0bc6f1379 Merge pull request #888 from ansible/mysql-port
Fix for int port assignment in a playbook failing
10 years ago
Toshio Kuratomi ec6304d5a0 Merge pull request #824 from Jmainguy/mysql_db_616
Now correctly gzip/bzips file back up in case of import failure
10 years ago
Jonathan Mainguy ee8039ef09 Now correctly gzip/bzips file back up in case of import failure
Removed gunzip and bunzip2 dependency
10 years ago