Commit Graph

45762 Commits (b0f38931b0e0b55db30a012e81683d380ea7a670)
 

Author SHA1 Message Date
Michael Scherer 06651d1055 Fix traceback when using the module (#58588)
Since bricks_in_volume is a list, it can't be compared to a int.

    Traceback (most recent call last):
      File \"/root/.ansible/tmp/ansible-tmp-1561989216.06-31322871319024/AnsiballZ_gluster_volume.py\", line 114, in <module>
        _ansiballz_main()
      File \"/root/.ansible/tmp/ansible-tmp-1561989216.06-31322871319024/AnsiballZ_gluster_volume.py\", line 106, in _ansiballz_main
        invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)
      File \"/root/.ansible/tmp/ansible-tmp-1561989216.06-31322871319024/AnsiballZ_gluster_volume.py\", line 49, in invoke_module
        imp.load_module('__main__', mod, module, MOD_DESC)
      File \"/usr/lib64/python3.7/imp.py\", line 234, in load_module
        return load_source(name, filename, file)
      File \"/usr/lib64/python3.7/imp.py\", line 169, in load_source
        module = _exec(spec, sys.modules[name])
      File \"<frozen importlib._bootstrap>\", line 630, in _exec
      File \"<frozen importlib._bootstrap_external>\", line 728, in exec_module
      File \"<frozen importlib._bootstrap>\", line 219, in _call_with_frames_removed
      File \"/tmp/ansible_gluster_volume_payload_d5mfag24/__main__.py\", line 610, in <module>
      File \"/tmp/ansible_gluster_volume_payload_d5mfag24/__main__.py\", line 551, in main
    TypeError: '<' not supported between instances of 'int' and 'list'
5 years ago
Pilou 5f8080aaa0 consul_session: improve documentation and add integration tests (#56392)
* consul_session: Python 2.6 is always required on managed node
* consul_session: document all types
* consul_session: add doc for 'id' parameter
* consul_session: improve parameter descriptions
    - use formatting functions in descriptions
    - 'name' parameter is required when state=node
* consul_session: use required_if
* consul_session: add integration tests
* consul_session: use 'retry' with network dependent tasks
* Use ansible-ci-files bucket for consul binaries

Co-Authored-By: Matt Clay <matt@mystile.com>
5 years ago
Tim Rupp 580b013837 rpm_key - add fingerprint parameter (#58373)
This parameter can be used to verify keys before they are imported by providing the long form fingerprint of the key.
5 years ago
mj84 d2ccf90610 Added missing SSL parameters to rabbitmq_binding (#58064)
In rabbitmq_binding.py the SSL parameters ca_cert, client_cert, client_key were only passed to requests for post requests.
This change updates the DELETE and GET requests to include these parameters as well.
5 years ago
Aaron Longchamps 045caaa400 VMware: Adding IP-Specific properties to ESXi host firewall config (#56733)
* Adds IP-Specific properties to firewall config

Fixes: #51240
5 years ago
Diane Wang 39fbdc22ff VMware: Add new module vmware_guest_screenshot (#57449)
Signed-off-by: Tomorrow9 <tommorrow7@gmail.com>
Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>
5 years ago
Sumit Jaiswal 539f37ede3
PR to implement ansible_net_model for iosxr facts module (#58488)
* resolves 57767

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* added test

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
5 years ago
Mikhail Naletov d582efcc51 Use atexit to logout after zabbix module run (#58525) 5 years ago
Felix Fontein f0801879c7 Rename xenserver_guest_facts -> xenserver_guest_info (#57032)
* Rename xenserver_guest_facts -> xenserver_guest_info.

* Add changelog.

* Forgot one test.
5 years ago
Gonéri Le Bouder 2401154fc4 VMware: rename VMWare to VMware (#58535)
Follow the nomenclature convention decided in https://github.com/ansible/ansible/pull/56814
5 years ago
Simon Dodsley 35dcd231be purefa_user: Fix Incorrect parameter used causing crashes. (#57588) 5 years ago
Ganesh Nalawade 80d6a2f344
Add network resource modules utils function (#58273)
* Add network resource modules utils function

*  `FactsBase` parent class to handle
    facts gathering
*  `ConfigBase` parent class for resource
   module config handling
*  utils funtions for resource modules

* Fix review comments

* Fix CI issues and review comments

* Fix review comments

* Fix CI issues and minor updates
5 years ago
YuandongXu 78c8ee9261 ce_snmp_target_host: update to fix bug: None has no 'lower()' function. (#57904)
* update to fix bug: None has not 'lower()' function.

* add a changelog fragment.

* update changlog fragment.

* Update 57904-ce_snmp_target_host.yml
5 years ago
Sam Doran 8cfd0ba039 Allow for test groups with double digits (#58532) 5 years ago
Sam Doran ab6a9ef130
Get minor version number for CentOS and Debian (#57814)
* Get the most detailed version number from distro.version() for CentOS and Debian
* Update tests and fixtures
* Update fixture generation script to gather distro info and work with Python 3
* Update LinuxMint fixtures
* Cleanup fixture formatting
* Improvements based on feedback from abadger:
    - use unicode since that is what distro returns
    - use frozenset with a tuple
    - include link Debian to bug
5 years ago
YuandongXu 2f91266aa9 ce_vxlan_gateway: update the regular expression to match the more accurate. (#58226)
* Update the regular expression to match the more accurate

* Update the regular expression to match the more accurate

* Update the regular expression to match the more accurate
5 years ago
YuandongXu 23139cdbb9 update to fix a bug (#58228) 5 years ago
YuandongXu b7630ccb36 update to fix a bug (#58230) 5 years ago
YuandongXu 715de33467 ce_netstream_aging: update to fix a bug. (#58231)
* update to fix a bug

* update to for shippable.
5 years ago
YuandongXu 36cfa9e931 ce_bgp: update bgp to fix bugs (#57317)
* update bgp to fix bgus

* add a changelog fragment for bgp
5 years ago
YuandongXu bb33c922f7 ce_static_route: fix some bugs. (#58251)
* add a util function to ce.

* add a util function to ce.

* update to fix bugs for ce_static_route

* update to fix bugs for ce_static_route

* update to fix bugs for ce_static_route

* update

* update for shippable.
5 years ago
YuandongXu 442d275ae3 update vrrp (#57916) 5 years ago
Sam Doran 6cf6f5a34b
Use atexit to cleanup tmp dirs (#56532)
* Wrap everything in try/except to avoid leaving files behind
* Add unit tests, integration tests, and changelog
* Do text the correct way
5 years ago
YuandongXu 875e7c3e50 update to fix a bug. (#58200) 5 years ago
YuandongXu 4a6c86715a update to fix a bug (#58207) 5 years ago
YuandongXu e0f3e404c9 update to fix a bug (#58227) 5 years ago
Toshio Kuratomi 8acf71f78f
Skip tests with unsatisfied deps (#55853)
* Skip gitlab tests if dependencies aren't met

* Skip certain unittests if passlib is not installed

* Fix tests with deps on paramiko to skip if paramiko is not installed

* Use pytest to skip for cloudstack

If either on Python-2.6 or the cs library is not installed we cannot run
this test so skip it
5 years ago
Sandra McCann 35b6345bdc Add a banner message to warn when not on latest documentation (#58526)
* add banner to versions that are not latest

* move div into script

* fix div

* move comment

* fix shippable errors
5 years ago
YuandongXu da72644317 update acl interface. (#57905)
* update acl interface.

* update ce_interface

* update

* add a changelog fragment.

* update
5 years ago
YuandongXu b93411a5b2 update to fix a bug (#58229)
Signed-off-by: xuxiaowei0512 <786018072@qq.com>
5 years ago
YuandongXu e02353026d update ce_interface to fix bugs (#57907)
* update ce_interface

* update ce_interface

* add a changelog fragment.
5 years ago
Matt Davis fdfab01a2e
clean up setup author metadata/bot ignore (#58529) 5 years ago
Sloane Hertel 826f224f02
Handle vaulted non-ascii characters for Python2 (#58503)
* Handle vaulted non-ascii characters for Python2

* Add a test to ensure str() no longer raises UnicodeEncodeError
5 years ago
Gonéri Le Bouder e28bc46353 vcenter provider: set default values
Set default value for the following optional parameters:

- vcenter_port
- vmware_proxy_host
- vmware_proxy_port

This way we won't get an error if they are not define in the
configuration file.
5 years ago
kfattig 756cdebd37 New & fixed examples for aws_ssm lookup (#58293)
* New & fixed examples for aws_ssm lookup

* Apply suggestions from code review

Co-Authored-By: Sloane Hertel <shertel@redhat.com>

* Clarify example name
5 years ago
Sloane Hertel 23f0ca0acd fix unarchive integration tests when LC_ALL is not set to en_US.UTF-8 (#58431) 5 years ago
Olivier Scherler 7ed7d374e4 Fix onepassword lookup plugin and onepassword_facts module when a field has no name. (#58308)
* Fix onepassword lookup plugin crashing on fields with no 'name' or 't' property.

* Fix onepassword_facts module crashing on fields with no 'name' or 't' property.

* Add unit test for onepassword lookup plugin failing on entries without a name.

* Add changelog fragment for onepassword lookup plugin and onepassword_facts module fixes on fields without a name.
5 years ago
Sam Doran 1a5ae366f4
hostname - fix Oracle Linux (#58510) 5 years ago
Mark McKinstry 393ea1cd55 document problem when removing something from a dictionary (#58349)
the problem is described at https://github.com/ansible/ansible/pull/49053#issuecomment-480427406
5 years ago
Strahinja Kustudic 16610fa399 Fix version_added for gcp_compute 5 years ago
hwDCN 2d595da6ba want to be a maintainer for cloudengine (#56527)
Hi ansible_team, I am work for cloudengine and also a member of HuaweiSwitch/cost.
To quickly fix bugs,I create this PR.
Thanks a lot.
5 years ago
Nabeel Al-Saber 7afdf11456 Add Oracle scenario guide (#58443)
* Create and update docs/docsite/rst/scenario_guides/guide_oracle.rst
5 years ago
pratikgadiya12 184143e498 Fixed file_module hardlink example (#58485)
Fixes: #58451
5 years ago
Andrey Klychkov 5937080977 postgresql modules: remove extra lines from doc that are presented in ext doc fragment (#58501) 5 years ago
Joseph Andreatta 0a27ad6ea0 VMware: Add new module vmware_dvswitch_nioc (#44147)
Signed-off-by: Joseph Andreatta <joseph@vmware.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
5 years ago
Chris Van Heuveln 0868fec8bd nxos_vpc: pkl_vrf fixes for #57069 (#57370)
* nxos_vpc: pkl_vrf fixes for #57069

Fixes #57069

- Symptom: When playbooks specify `pkl_vrf: default`, the result is that the cli does not set the `vrf` state.

- Analysis:
 - First issue: 'default' is a reserved word when used with the `peer-keepalive` `vrf` keyword. It refers to the default rib.
   - This is confusing in several ways because `peer-keepalive`'s *default* vrf is the `management` vrf.

 - Second issue: When changing only one optional value (`pkl_vrf`) while other optional values are idempotent (`pkl_src`), the result is that the idempotent values are ignored; unfortunately the device cli *replaces* the entire command, in which case the idempotent values are removed.
   - e.g. playbook specifies this:
     ```
     { pkl_dest: 10.1.1.1, pkl_src: 10.2.2.2, pkl_vrf: my_vrf }
     ```

     ```
     peer-keepalive dest 10.1.1.1 src 10.2.2.2             # original

     peer-keepalive dest 10.1.1.1 src 10.2.2.2 vrf my_vrf  # intended result

     peer-keepalive dest 10.1.1.1 vrf my_vrf               # actual result
     ```

 - Third issue: the `pkl` getter was relying on positional data. This broke when the `udp` keyword nvgen'd where `vrf` used to appear (shifting all keywords to the right).

- Tested on regression platforms: `N3K,N6k,N7K,N9K,N3K-F,N9K-F`

* PEP fixes

* PEP fix 2

* pkl should merge by default, not override

* rmv debugs

* add mike's tests

* fix comments
5 years ago
Abhijeet Kasurde 760dc19284
VMware: Set vapp settings while creating VM (#58156)
vApp Settings can be set while creating VM.

Fixes: #50617

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
5 years ago
Chris Francy 3ec4739cc7 the env argument for docker_container wants a dict, not a list (#58475) 5 years ago
Abhijeet Kasurde e2d159c40c
VMware: Handle user unauthorization in tagging scenarios (#58405)
Handle unauthorization scenarios in VMware tagging APIs.

Fixes: #58326

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
5 years ago
YuandongXu 242f160747 update ce_vxlan_global to fix bugs. (#57947)
* update to fix bugs.

* add a changelog fragment.

* update a changelog fragment.
5 years ago