Commit Graph

2724 Commits (afff84321dc64cb07e1e7bf72f4b27d980e7f07f)

Author SHA1 Message Date
Ryan Brown cb2a47753a Merge pull request #4292 from julienvey/patch-1
Fix typo in docker_image_facts module
8 years ago
Ryan Brown 81c663ff71 Merge pull request #4288 from rickmendes/rm-me
please remove me as maintainer
8 years ago
Lyle Mantooth 50abfd5e27 Remove file extension from policy names (#3805)
Fixes #3804.

Prevents `__file__` from contributing ".", which is an illegal character in ELB policy names.
8 years ago
Julien Vey 0bf24f2ae1 Fix Typo in docker_image_facts module 8 years ago
Monty Taylor d38c24d0ed
Merge pull request #3407 from yfried-redhat/idempotent_os_floating_ip 8 years ago
Monty Taylor 0e8ce4ad52
Rename a confusing variable
I had to read the two lines in question twice. That might just make me
dumb, but if I'm dumb, someone else might be too.
8 years ago
Rick Mendes 203b332cdb please remove me as maintainer 8 years ago
Jasmine Hegman a3bae3e6ce Update docs to indicate ec2_asg state defaults to present (#4046)
* Update docs to indicate ec2_asg state defaults to present

Hopefully fixes Issue #4016

* Forgot to flip required to false
8 years ago
Shaun Brady 890bba6a0e Make group_name resolution VPC aware
EC2 Security Group names are unique given a VPC.  When a group_name
value is specified in a rule, if the group_name does not exist in the
provided vpc_id it should create the group as per the documentation.

The groups dictionary uses group_names as keys, so it is possible to
find a group in another VPC with the name that is desired.  This causes
an error as the security group being acted on, and the security group
referenced in the rule are in two different VPCs.

To prevent this issue, we check to see if vpc_id is defined and if so
check that VPCs match, else we treat the group as new.
8 years ago
Ryan Brown 24db4de245 Merge pull request #4156 from supertom/ansible-2111-fix
Support updating GCE firewall rules when attributes change

Fixes #2111
8 years ago
Ryan Brown d288ef2abc Merge pull request #4163 from kaikousa/improve-ec2_lc-documentation
Improve `ec2_lc` documentation on security_groups option
8 years ago
Ryan Brown a960f01bf3 Merge pull request #4234 from chrisweaver/patch-1
Enforce `bool` type for dup_ok option on AWS `iam_cert` module
8 years ago
Ryan Brown 95c67dc72a Merge pull request #4231 from phy1729/cfn-iam-capabilities
Support CAPABILITY_NAMED_IAM in AWS CloudFormation module
8 years ago
Ryan Brown 92a17c61f4 Merge pull request #4190 from jbaublitz/gce_suspend_node
Add states for stopping and starting GCE ☁️ instances
8 years ago
Ryan Brown 1e6d93cc52 Merge pull request #4203 from MichaelBaydoun/iam_policy_fix
Stop iam_policy from always reporting `changed` status
8 years ago
yfried-redhat 6b20645b40 Make os_floating_ip module idempotent
Current module fails when tries to assign floating-ips to server that
already have them and either fails or reports "changed=True" when no
ip was added

Removing floating-ip doesn't require address

Server name/id is enough to remove a floating ip.
8 years ago
Ryan 810b40aee9 fix typo in azure_rm_storageaccount (#4236) 8 years ago
chrisweaver 8879931f0c Enforce boolean type for dup_ok
Stop "choices" from being interpreted as strings.
8 years ago
Matthew Martin 34d48eb89b Add CAPABILITY_NAMED_IAM to cloudformation capabilities
While from the documentation[1] one would assume that replacing
CAPABILITY_IAM with CAPABILITY_NAMED_IAM; this as empirically been shown
to not be the case.

1: "If you have IAM resources, you can specify either capability. If you
have IAM resources with custom names, you must specify
CAPABILITY_NAMED_IAM."
http://docs.aws.amazon.com/AWSCloudFormation/latest/APIReference/API_CreateStack.html
8 years ago
Michael Baydoun 07383c40d7
fixes issues where iam_policy incorrected reported changed 8 years ago
Andrei Lukovenko 3945794704 Bug: repeatable invocation with state=present leads to (#3052)
[localhost]: FAILED! => {"changed": false, "failed": true, "msg":
"'Domain' object has no attribute 'id'"}

How to reproduce:

- name: create domain
  digital_ocean_domain: state=present name=DOMAIN_NAME ip=DROPLET_IP

- name: create domain
  digital_ocean_domain: state=present name=DOMAIN_NAME ip=DROPLET_IP

Problem: DigitalOcean API changed API
(https://developers.digitalocean.com/documentation/v2/#list-all-domain-records)
8 years ago
John Baublitz e85c2f8253 Collapse boilerplate code into change_instance_state function 8 years ago
Toshio Kuratomi 55e6703209 Remove version-added on name field.
This parameter was actually added in 2.0.  It's just that the
documentation in previous versions of the module were wrong (it said the
name was  "network" rather than "name.)  I've renamed the parameter in
the documentation of prior versions so ansible-module-validate should no
longer think that this is a new parameter.
8 years ago
John Baublitz b5da9d190d Add states for stopping and starting machines 8 years ago
Ryan Brown f61ddbc8a9 Merge pull request #3863 from ryansb/iam-pass-module
Bugfix: IAM group modules need `module` passed
8 years ago
Tom Melendez 7c8d972d8f Added helper function and logic to sort attributes before comparing. 8 years ago
Tom Melendez 0f1c083d25 Allow GCE firewall rules to be updated when attributes changes. Fixes #2111.
Previously, when the attributes of a GCE firewall change, they were ignored.  This PR changes that behavior and now updates them.

Note that the "update" also removes attributes that are not specified.

An overview of the firewall rule behavior is as follows:

1. firewall name in GCP, state=absent in PLAYBOOK: Delete from GCP
2. firewall name in PLAYBOOK, not in GCP: Add to GCP.
3. firewall name in GCP, name not in PLAYBOOK: No change.
4. firewall names exist in both GCP and PLAYBOOK, attributes differ: Update GCP to match attributes from PLAYBOOK.
8 years ago
Chris Houseknecht eab6bb8794 Merge pull request #4176 from h-hirokawa/fix4174
Fix azure_rm_virtualmachine to create a storage account with name contains lower-case only  (#4174).
8 years ago
Chris Houseknecht 77db7011f0 Merge pull request #4173 from chouseknecht/fix_entrypoint
Fix entrypoint. Should behave the same as command.
8 years ago
h-hirokawa 977a6a8b28 Fix azure_rm_virtualmachine (#4174). 8 years ago
Chris Houseknecht a75ee76aa3 Entrypoint fails with 'command not found' error. 8 years ago
Chris Houseknecht 58b551774c Add push parameter. Let API handle registry authentication check. 8 years ago
Chris Houseknecht 1058094b64 Fix module failing when no ports are exposed 8 years ago
jjshoe 90b8281a51 Fixed a typo (#4168) 8 years ago
Chris Houseknecht 73dbb744b5 Merge pull request #3887 from Jorge-Rodriguez/docker-image-no-push-on-load
Don't forcibly push loaded images to registry.
8 years ago
Kai Kousa 7632bc1ecb Improve documentation on security_groups-option 8 years ago
Chris Houseknecht 328f047fda Merge pull request #4040 from qiluo-msft/qiluo/actual_stdin_open
Fix getting actual_stdin_open
8 years ago
Chris Houseknecht 4aee56553f
Fix multi-interface port binding. 8 years ago
Chris Houseknecht 9c88c45dd2 Merge pull request #4155 from chouseknecht/fix_4091
Support publishing all ports.
8 years ago
Chris Houseknecht e51024c84d Fix 'all' option for published_ports parameter. 8 years ago
Chris Houseknecht 36ed0ad766 Add cleanup parameter. (#4144) 8 years ago
David Shrewsbury a606e9cd37 Fix bug in os_router.py when router is not actually updated. (#4107)
The shade update_router() call will return None if the router is
not actually updated. This will cause the module to fail if we
do not protect against that.
8 years ago
Chris Houseknecht 391561fa5d Merge pull request #4151 from chouseknecht/fix_4139
Fix purge_networks
8 years ago
Rene Moser 45845e0bdc os_server, doc: add version added for delete_fip
Also see #3509
8 years ago
David Shrewsbury 3979faf3e5 Allow os_server to delete FIP (#3509)
The os_server module could automatically generate a floating IP for
the user with auto_ip=true, but we didn't allow for this FIP to be
automatically deleted when deleting the instance, which is a bug.
Add a new option called delete_fip that enables this.
8 years ago
Chris Houseknecht 78f6c7e51e
Fix purge_networks 8 years ago
Andrei Lukovenko ff223ee14c Bug: invocation with state=absent always leads to (#3051)
[localhost]: FAILED! => {"changed": false, "failed": true, "msg":
"'Domain' object has no attribute 'id'"}

How to reproduce:

- name: create domain
  digital_ocean_domain: state=present name=DOMAIN_NAME ip=DROPLET_IP

- name: destroy domain
  digital_ocean_domain: state=absent name=DOMAIN_NAME

Problem: DigitalOcean API accepts domain name, not record ID
(https://developers.digitalocean.com/documentation/v2/#delete-a-domain)
8 years ago
Adrian Moisey 74285d6a53 Add default port for aurora (#4102)
If a port isn't specified, it's looked up. The lookup breaks without
this.

Related: https://github.com/ansible/ansible-modules-core/pull/3414
8 years ago
Chris Houseknecht bb582ae574
Remove object name validation. 8 years ago
Chris Houseknecht 90b3860f5b Merge pull request #4097 from chouseknecht/azure-rc5
Update and pin to azure-2.0.0rc5
8 years ago