Commit Graph

43316 Commits (ae24bbff4abf7dce43026f18bf113c2f76ba8301)
 

Author SHA1 Message Date
Chris Adams 14d4a4fc3b docs: SAN prefixes are required for openssl_csr (#53144)
The openssl_csr docs use “should” where (at least following IETF nomenclature) “must” would be more accurate.

See #53141 

+label: docsite_pr
5 years ago
Matt Clay eeaff731de
Overhaul ansible-test cloud test plugins. (#53044) 5 years ago
Matt Davis 9c644d9bcc
interpreter discovery message tweaks (#53155)
* fixes #53120 (doclink generator now understands devel)
* added hosts to some warnings
5 years ago
Matt Martz 35f5ca8295 Don't allow an empty version_added 5 years ago
Sloane Hertel 8a02f894a6 replace uses of sort_json_policy_dict with compare_policies (#52943)
* replace uses of sort_json_policy_dict with compare_policies which is compatible with Python 3 and remove sort_json_policy_dict from the AWS guidelines since it only works on Python 2

* Sort any lists containing only strings

* Sort the original policy too
5 years ago
Sam Doran 2a98faee2b
Move _handle_aliases() out of basic.py (#48578)
Refinements:
- return legal_inputs and update class properties
- remove redundant arguments from method and handle in caller
- add better exception types to method

* Add unit tests for handle_aliases
5 years ago
Sam Doran 1c87ea6fa6 Reboot - add parameter for paths to search for shutdown command (#51194)
* Look in /lib/molly-guard for shutdown command

Signed-off-by: Sam Doran <sdoran@redhat.com>

* Add parameter for extra_search_paths

Signed-off-by: Sam Doran <sdoran@redhat.com>

* Change option to search_paths

- Update docs
- Make the parameter replace the default values
- Add some sanity checking on the data type

Signed-off-by: Sam Doran <sdoran@redhat.com>

* Correct parameter in tests, change conditional for molly-guard tasks

Signed-off-by: Sam Doran <sdoran@redhat.com>

* Address feedback

* Simplify field validation

Needed the try except in case a non-iterable type is put in the search_paths field
5 years ago
Dag Wieers 4e6c113bf0 uri/win_uri: Make method a free text field (#49719)
* uri/win_uri: Make method a free text field

Since various interfaces introduce their own HTTP method (e.g. like
PROPFIND, LIST or TRACE) it's better to leave this up to the user.

* Fix HTTP method check in module_utils urls

* Add integration test for method UNKNOWN

* Clarify the change as requested during review
5 years ago
Ted Timmons 81ec48c7b4 botmeta: ignore tedder, fix some grammar (#53133)
* ignore tedder, fix some grammar

I'm less helpful than in the past on reviewing these, adding myself to the 'ignore' keys.

Also fixed some grammar in the instruction block.

* oh, so that's how the default key works. yaml fail
5 years ago
Jiri Tyr 7739b5e96c Last two fields in fstab are optional (fixes #43855) (#43941)
* Last two fields in fstab are optional
* Add changelog
5 years ago
Piotr Wojciechowski ec4cf26d60 Documentation update for labels operations on swarm/node (#53083)
* Update lib/ansible/modules/cloud/docker/docker_node.py
* Update lib/ansible/modules/cloud/docker/docker_swarm.py

Co-Authored-By: WojciechowskiPiotr <23406016+WojciechowskiPiotr@users.noreply.github.com>
5 years ago
Sloane Hertel 9b4110a50c
Enable ec2_vpc_vgw tests (#53118) 5 years ago
Will Thames 91eee48f1b aws_kms tags fix (#53088)
* Fix TagName and TagValue in aws_kms

Fixes #53061

* Improve test suite to check for tags

Also fixed some obvious failures, need to run the test suite from time
to time!
5 years ago
Nilashish Chakraborty 5d8f307116 Revert back to using section (#53069)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
5 years ago
Brian Coca 55dc63be3a
properly convert inputs to handle bytes/unicode (#53072)
* properly convert inputs to handle bytes/unicode

  fixes #52186

* Update changelogs/fragments/nmap_bytes_fix.yml

Co-Authored-By: bcoca <bcoca@users.noreply.github.com>
5 years ago
rwagnergit d2bdbadb03 adding quiet option to assert (ansible#27124) (#52032)
* adding quiet option to assert (ansible#27124)

* adding doc for quiet to assert.py

* fixing PEP8 failure

* improving example

* improving docs

* adding changelog fragment

* adding . at end of descriptions

* removing trailing blank line

* adding integration test for assert

* fixing CI complaints

* disabling gather_facts in quiet.yml test

* rerunning to capture skip

* cleaning up python 2 vs 3

* following rebase

* fixing CI complaints

* fixing CI complaints

* fixing CI complaints

* fixing CI complaints

* fixing CI complaints
5 years ago
Chuck Douglas 0e9a79a589 Change the retry_files_enabled to False and modify the comments to reflect that this has been disabled (#52581)
* Change the retry_files_enabled to False and modify the comments to reflect that
this has been disabled.

* Change the default action of retry_files_enabled to False

* Update porting guide to reflect change in default state of retry_files_enabled variable

* Change log documenting a change in default behaviour of retry_files_enabled

* Revert config change to comment out the retry_files_enabled line to let the user decided what is best.
Comment above still states how to change.
5 years ago
Abhijeet Kasurde 0f353ed99d AWS: handle boto3 credential file parsing error (#53098)
Fixes: #53051

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
5 years ago
Trishna Guha 5f577c7e79
Add type in eos_config module docs (#53117)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
5 years ago
Andrey Klychkov cf05429b3c postgresql_privs change fail to warn if role(s) does not exist (#52574)
* postgresql_privs change fail to warn if role does not exists

* postgresql_privs change fail to warn if role does not exists: fix sanity

* postgresql_privs change fail to warn if role does not exists: add changelog fragment

* postgresql_privs change fail to warn if role does not exists: fixes

* postgresql_privs change fail to warn if role does not exists: added fail_on_role param
5 years ago
Sam Doran 23a6b88dd2
Modify the correct variable when setting available hashing algorithms (#52994)
* Revert "use list instead of tuple and remove md5 on ValueError (#51357)" c459f040da.
* Modify the correct variable when determining available hashing algorithms
5 years ago
David Passante 644362d0be cloudstack: streamline modules doc (part 2) (#52730)
* cloudstack: streamline modules doc (part 2)

* Parameter types added
* Copyright format fixes
* Doc style fixes
* Examples format fixes

* minor fixes

* fix missing quoting of "version_added"
5 years ago
Bojan Vitnik 88e8330e3e New module: xenserver_guest_powerstate - manages powerstate of XenServer VMs (#49425)
* Initial commit for xenserver_guest_powerstate module
* Added unit tests for the module, removed unused imports
5 years ago
Matt Davis 4d3a6123d5
Python interpreter discovery (#50163)
* Python interpreter discovery

* No longer blindly default to only `/usr/bin/python`
* `ansible_python_interpreter` defaults to `auto_legacy`, which will discover the platform Python interpreter on some platforms (but still favor `/usr/bin/python` if present for backward compatibility). Use `auto` to always use the discovered interpreter, append `_silent` to either value to suppress warnings.
* includes new doc utility method `get_versioned_doclink` to generate a major.minor versioned doclink against docs.ansible.com (or some other config-overridden URL)

* docs revisions for python interpreter discovery

(cherry picked from commit 5b53c0012ab7212304c28fdd24cb33fd8ff755c2)

* verify output on some distros, cleanup
5 years ago
Zim Kalinowski b8a82f5930 some fixes in vm facts doc (#53089) 5 years ago
Chris Van Heuveln d69239c440 network.py:ActionModule:run: does not honor _handle_src_option failures (#52745)
* network.py:ActionModule:run: does not honor _handle_src_option failures

PR #50301 moved template error handling out of run() and into its
own method in `_handle_src_option`; however, after the change run()
ignores the return value so any errors are ignored.

Reproduceable with `nxos_config/tests/common/src_invalid.yaml`

Verified fix with `nxos_config/tests/common/src_*` tests.

Ref:
71113ee291 (diff-7477bf046013758366cc85b06f90709aR43)

* nxos_config/tests/common/src_basic: Updated to test with src

This test was not actually testing with `src:` as it should have.

* Revert 412d7e change to plugins/action/network.py

PR #52912 fixed this already.

* nxos_config: fix src_invalid test
5 years ago
Matt Clay e4d0be39c3 Remove `skip/rhel8.0` from osx_defaults test.
The test already has `skip/rhel` which is enough.
5 years ago
Dag Wieers aaec8e6b47 Fix types 5 years ago
sgerhart@gmail.com 7cb808ff37 create aci_fabric_scheduler module 5 years ago
Dag Wieers ccc94c0660 Fix types 5 years ago
sgerhart@gmail.com d99cba6dc5 create aci_firmware_group module 5 years ago
Kevin Breit 9e6e53d1f6 Migrate existing Digital Ocean integration tests to new framework (#51785)
- SSH key and floating IP tests were legacy
- PR moves, but does not enhance tests
- Uses consistent API key variable
5 years ago
Wojciech Sciesinski c99f3f558a Don't run integration tests for OS'es older than Windows 2016 (#53057) 5 years ago
Dag Wieers 80bdd21317 Fix types 5 years ago
sgerhart@gmail.com a289fcb803 create aci_firmware_policy module 5 years ago
Dag Wieers d5ef4d1e33 Fix types 5 years ago
sgerhart@gmail.com 07ff8f0bd5 create aci_firmware_group_node module 5 years ago
Dag Wieers 9abee0385d Fix type 5 years ago
sgerhart@gmail.com 323a0aa7eb create aci_maintenance_group module 5 years ago
Brian Coca cfba6dfe91
Ensure play order is obeyed (#49897)
* Ensure play order is obeyed

 it was being ignored depending on other options
 also added tests for each order (except shuffle) both serial and not
 fixes #49846
5 years ago
Zim Kalinowski 6583ed0df9 Adding postgresql configuration module (#45072)
* adding postgresqlconfiguration

* removed unnecessary option

* small fixes

* moved tests to main server test

* update comments

* updated module
5 years ago
Zim Kalinowski 6d3789125b adding mysql configuration module (#45076)
* adding mysql configuration module

* fixes in configuration

* move tests

* fixes

* updating test

* updated module

* fixed merge issues

* one more test fix

* adding for debugging purposes

* removed file checked in by mistake

* one more merge problem

* fixed test

* try to get more info

* fix error
5 years ago
Sloane Hertel c4d0c58c5a
Only run ec2_vpc_vgw on changes to the module to avoid hitting the limit (#53082)
* Only run ec2_vpc_vgw on changes to the module to avoid hitting the resource limit

* actually mark as disabled
5 years ago
Marcos Paulo de Souza fa83a711b6 hostname.py: Fix openSUSE distribution name (#47020)
All openSUSE distributions changed to the way they are returned from distro.id().

This patches fix the openSUSE Leap and SLES distro names, and adds one entry for Tumbleweed.

These descriptions are capitilized, as expected by Ansible's hostname module.

Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
5 years ago
Felix Fontein 04bfec9dfe docker_swarm: more integration tests (#53035)
* Add more tests.

* Added tests for CA options.

* Don't run in docker-in-docker situations where docker daemon becoming instable is really dangerous. Also, restart docker daemon after tests.

* Only run CA tests when openssl_certificate can be run (which is not the case for RHEL7, see #34054).

* Add comment on why docker-based CI runs are skipped.
5 years ago
Anil Kumar Muraleedharan a78c40322c Lenovo cnos logging (#52978)
* Adding the module cnos_logging.py to the module suite from Lenovo
5 years ago
John R Barker 9936e81541
BOTMETA correct team names (#53077) 5 years ago
Sloane Hertel 8fbb2f8b2a
fix no_log indentation so AWS temporary credentials aren't displayed in tests (#53073) 5 years ago
Kevin Breit 4af5842409 Developer documentation - Change path to connection_plugins (#52577)
* Change path to connection_plugins

* Update docs/docsite/rst/dev_guide/developing_plugins.rst

Co-Authored-By: kbreit <kevin.breit@kevinbreit.net>
5 years ago
Dag Wieers fe2b159106 Reorganize Cisco technologies (#52876) 5 years ago