jhawkesworth
ad94d03ba1
Tolerate win line endings on windows module_util load ( #37291 )
...
* tolerate windows line endings when loading windows module utils. Helpful for old custom windows modules.
* add test modules to demonstrate win line ending module load behaviour.
* attempt to fix sanity check failures
* pep8 fix
* explict skip of test modules from shebang check (core modules must still have expected unix style line endings)
* switch to rstrip() following core team meeting feedback
7 years ago
Jordan Borean
f37a44430f
win_service: fix when dealing with paths with special chars and change WMI to CIM cmdlets ( #37897 )
...
* win_service: fix when dealing with paths with special chars and change WMI to CIM cmdlets
* compare username in lowercase for test
7 years ago
René Moser
b06dfbec54
cs_user: fix E325 ( #38158 )
7 years ago
Matt Martz
ffbbb5a25b
Use arg_spec type for comparisons on default and choices ( #37741 )
...
* Use arg_spec type for comparisons on default and choices
* Further improve type casting
* Make sure to capture output in more places
* Individually report invalid choices
* Update ignore.txt after resolving merge conflicts
7 years ago
saichint
0df5cfd41f
fix nxos_static_route issues ( #37614 )
...
* fix nxos_static_route issues
* remove nxos_static_route from ignore
7 years ago
Matt Clay
0dade18f43
Fix yamllinter handling of tuple assignment.
7 years ago
Dag Wieers
2c2f335893
win_psexec: Fix pslint issues ( #37718 )
7 years ago
Dag Wieers
de5fb66026
win_product_facts: Fix pslint issues ( #37722 )
7 years ago
Dag Wieers
fdc0e5c5fb
win_defrag: Fix pslint issues ( #37719 )
7 years ago
Dag Wieers
f78b415db0
win_wakeonlan: Fix pslint issues ( #37717 )
7 years ago
Matt Clay
307d8b5330
Disable PowerShell null comparison test.
...
Too many false positives due to unknown types.
7 years ago
Matt Clay
05220d693d
Complete updates of remaining code-smell tests. ( #37743 )
...
* Add text/binary file support to code smell tests.
* Enhance line-endings code smell test.
* Enhance no-smart-quotes code-smell test.
* Enhance shebang code-smell test.
7 years ago
Matt Clay
8daa80e5bb
Move var precedence check to integration tests.
7 years ago
Matt Clay
775539a8b8
Fix api_profile choices in Azure docs fragment.
7 years ago
Dag Wieers
51662acc6c
Clean up Grafana docs a bit ( #37516 )
...
* Clean up Grafana docs a bit
But more is needed, default values, missing choices, proper
descriptions, actual sentences :-)
* Remove validate-modules entries
7 years ago
Dag Wieers
cdd21e2170
Clean up module documentation ( #36909 )
...
* Clean up module documentation
This PR includes:
- Removal of `default: None` (and variations)
- Removal of `required: false`
- Fixing booleans and `type: bool` where required
* Fix remaining (new) validation issues
7 years ago
Matt Martz
8980d275a0
Support recursive suboptions schema ( #37206 )
...
* Support recursive suboptions schema
* Remove todo line, add voluptuous version constraint
7 years ago
Pilou
bc6b96d42e
webfaction modules: fix broken import ( #35024 )
...
* webfaction_app: fix broken import
* doc: use formatting functions
* webaction_db: fix broken import
* webfaction_domain: fix broken import
* webfaction_mailbox: fix broken import
* webaction_site: fix broken import
* webfaction modules: fix doc
7 years ago
René Moser
e1297af18a
cs_router: fix missing doc ( #37107 )
...
* cs_router: fix missing doc
* update ignore.txt
7 years ago
René Moser
67d8c8f5c6
cs_ip_address.py: fix missing doc ( #37109 )
...
* cs_ip_address.py: fix missing doc
* update ignore.txt
7 years ago
René Moser
2559e832df
cloudstack: fix common E324 in docs ( #37082 )
...
Notes about precedence of common args.
Partly fixes E324.
7 years ago
René Moser
4705edd1a7
letsencrypt: add new param force ( #37077 )
...
* letsencrypt: add new param force to ignore remaining days
* letsencrypt: fix E325
7 years ago
Mikhail Naletov
7d0e1f92f4
[terraform] Support initializing modules and providers at runtime ( #36996 )
...
* Fixes #36994
Added function for force initializing modules and providers
Added type for force_init parameter
7 years ago
Matt Martz
ca092b5c26
Skip top level args that are the same as args in provider in doc<->arg_spec comparisons ( #36911 )
7 years ago
Gaurav Rastogi
60e39b9718
Updated the documentation of modules to match argspec including the type setting for bool parameters ( #36821 )
7 years ago
Matt Clay
dc71c2197f
More code-smell sanity test updates. ( #36830 )
...
* Add test for missing Azure requirements.
* Improve readability.
* Enhance no-unicode-literals code-smell test.
7 years ago
Matt Clay
ac1698099d
Overhaul additional sanity tests. ( #36803 )
...
* Remove unnecessary sys.exit calls.
* Add files filtering for code-smell tests.
* Enhance test-constraints code-smell test.
* Simplify compile sanity test.
* Pass paths to importer on stdin.
* Pass paths to yamllinter on stdin.
* Add work-around for unicode path filtering.
* Enhance configure-remoting-ps1 code-smell test.
* Enhance integration-aliases code-smell test.
* Enhance azure-requirements code-smell test.
* Enhance no-illegal-filenames code-smell test.
7 years ago
Matt Clay
60a24bbdaa
Pass code-smell paths on stdin.
7 years ago
Mário Santos
8b52006d5c
Fix sanity checks in OpenStack docs fragment ( #36722 )
...
* Fix sanity checks in OpenStack docs fragment
Signed-off-by: Mário Santos <mario.rf.santos@gmail.com>
7 years ago
Ed Costello
2a0c7c4331
Fix documentation of validate_certificates option in aws doc_fragment.
...
Unignore sanity test failures for AWS modules caused by this common
fragment.
7 years ago
Pilou
07927f52ae
filesystem: fix documentation ( #36556 )
7 years ago
Matt Clay
5b5cba5e50
Update more code-smell tests. ( #36570 )
...
* Enhance use-compat-six code-smell test.
* Enhance use-argspec-type-path code-smell test.
* Enhance replace-urlopen code-smell test.
* Enhance boilerplate code-smell test.
* Enhance no-underscore-variable code-smell test.
7 years ago
Matt Clay
891f4f3b2d
Upgrade more code-smell tests. ( #36560 )
...
* Enhance no-dict-* code-smell tests.
* Enhance no-basestring code-smell test.
* Enhance no-get-exception code-smell test.
* Enhance empty-init code-smell test.
* Enhance required-and-default-attribute test.
* Remove unused code-smell test.
7 years ago
Jordan Borean
ef4f8851dc
win_feature: better error handling to make it easier to debug issues ( #36491 )
...
* win_feature: better error handling to make it easier to debug issues
* removed ignroed pslint rules that are no longer needed
7 years ago
John R Barker
5d0ed38e3a
Fixup VMware module docs issues ( #36409 )
...
Fix various argspec vs documentation issue
7 years ago
Matt Clay
2b6ac4561b
Add support for enhanced code-smell tests. ( #36332 )
...
* Add support for enhanced code-smell tests:
- Path selection handled by ansible-test.
- Optional path filtering based on extension.
- Optional path filtering based on prefixes.
- Optional lint friendly output.
* Enhance no-assert code-smell test.
* Enhance no-tests-as-filters code-smell test.
7 years ago
Matt Clay
a9b58b84d8
Fix path handling in validate-modules sanity test.
7 years ago
ABond
591695932e
Fix bug in DigitalOcean module_util ( #36352 )
7 years ago
Abhijeet Kasurde
5242914ae5
Fix digital ocean issues ( #36347 )
...
Remove module from ignore lists and some documentation fix in
digital_ocean_block_storage and digital_ocean module.
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
7 years ago
Matt Clay
ff922ac2ad
Import sanity test for main() in Ansible modules.
7 years ago
John R Barker
365630df65
Update ignore to deal with renamed files ( #36323 )
7 years ago
Matt Clay
80b55e3742
Add missing validate-modules ignore entries.
7 years ago
Matt Martz
831a9d67d7
Arg spec doc comparison fixes ( #36265 )
...
* Ensure we merge doc fragments early, for comparisons
* Perform boolean conversion from arg_spec data too
* Update valdiate-modules ignore.txt due to recent changes
7 years ago
Matt Martz
50adc5409b
Add several new doc<->arg_spec checks ( #36247 )
...
* Add several new doc<->arg_spec checks. See #18183
* Update ignore.txt for validate-modules
7 years ago
John R Barker
7dfa11cd8a
Notice in 2.6 remove in Ansible 2.10 ( #36191 )
...
Update the list of allowed removed_in for modules
7 years ago
John R Barker
3e22efa0ba
Ensure docs are valid before checking deprecation ( #36160 )
7 years ago
John R Barker
17c0d3eae0
Fix more docs vs argspec ( #36048 )
7 years ago
Jordan Borean
a0178b79f1
win_uri: fixes ( #35487 )
...
* win_uri: moved away from Invoke-WebRequest and fixed multiple issues
* fixes from review
7 years ago
Pilou
54882d4715
dimensiondata: fix broken import ( #35634 )
...
* Fix broken import
* Remove never reached statements
exit_json and fail_json methods call sys.exit, subsequent statements
can not be executed.
7 years ago
Toshio Kuratomi
86242e6871
Enable wildcard import pylint ( #35786 )
...
* Wildcard imports should be taken care of. Enable the pylint check for them
* Remove wildcard import code-smell test as we're now checking via pylint
* Add unused-wildcard-import as ignored in our compat code.
These three files use wildcard imports so that they can export
symbols in a compatible location. The real code lives elsewhere.
So disable the pylint tests for the relevant sections of code.
7 years ago