Commit Graph

2516 Commits (a9017af2bb648930e27bab52de12f9983411778c)

Author SHA1 Message Date
jctanner a6bc63512e Merge pull request #5308 from zecrazytux/fix/hash_merge_dynamic_inventory
Let merge hash_bahaviour work with dynamic inventory
11 years ago
jctanner 671b0454c6 Merge pull request #4987 from jpmens/lookup-csvfile
New lookup plugin csvreader
11 years ago
willthames 31f5ecea60 Allow float as an argument type in AnsibleModule 11 years ago
Rob Smith c15cffabdd This fixes bugs added as a part of 8665b0638a
1. if accept_hostkey is false, no matter if the host key is known or not, it will fail.

2. We don't check for the host key in /etc/ssh/ssh_known_hosts

This fixes both of those issues.
11 years ago
James Tanner 3719f3f496 Do not fetch or add keys for http based git urls 11 years ago
James Tanner eeee1e1c5a Set accept_hostkey to False by default in the git module and fail
early if the key is unknown
11 years ago
James Tanner 8665b0638a Add an "accept_hostkey" parameter to the git module to help automatically
accept hostkeys for git repos and prevent task hangs when the key is unknown
11 years ago
James Tanner 09e0d052ca Ensure sys.stdout has an istty method 11 years ago
James Tanner d7c8cf6ca7 Fixes #4958 Truncate printed stdout if it contains non-printable characters 11 years ago
jay e1f5b801cf fixed bug causing symlinks to fail in the host_vars, group_vars etc directories 11 years ago
James Tanner 78ec7c736f Fixes #3973 Second Revision of live ansible-pull output 11 years ago
Luca Berruti ae543eecab Simplified p.poll handling 11 years ago
James Tanner c408bcea31 Update sshpass hostkey error message 11 years ago
James Tanner 0b64408f5a Fixes #5531 Give the user a better error message when sshpass does not know the remote hostkey 11 years ago
jeromew 69febcefde remove useless create/delete remote tmp dir roundtrip in copy module 11 years ago
Serge van Ginderachter 836fb4143c path_dwim: fix when basedir not set 11 years ago
jeromew c9b01febb3 Make sure 'tmp' is in the remote tmp dirname to ensure correct cleanup 11 years ago
jctanner 21b4212ff5 Merge pull request #5517 from lichesser/fix_set_depreciation_warning
Fixes #5513. set is built-in since 2.4 and deprecated since 2.6
11 years ago
jctanner 83dec044ab Merge pull request #5504 from smoothify/synchronize-sudo
Synchronize Module: Improved sudo override behaviour.
11 years ago
jctanner 9a69b1b0ec Merge pull request #5311 from willthames/ec2_refactor
ec2 modules: Move more responsibility to common EC2 module
11 years ago
James Tanner d6b78e9dd6 Fixes #5238 Improve error messaging about unquoted variable references in playbooks 11 years ago
James Tanner ab51bd23a2 Fixes #5196 return a unique list of hostnames for a single host pattern 11 years ago
smoothify 93a55e8dff Don't override sudo if transport is set to local.
https://github.com/ansible/ansible/pull/5251
11 years ago
Michael DeHaan c039e276a2 Fact gathering on a second play against the same hosts should not be implicitly off since this is an undocumented beheavior and potentially
rather unwanted when a play could change a fact.

gather_facts: True/False can still be explicitly used per play.

Reverts 564a212b3c
11 years ago
Michael DeHaan 87258f6d42 Resolve merge commit 11 years ago
Michael DeHaan 1c632af2c9 Merge pull request #5468 from jeromew/ansible_ssh_alt
fix issue #5372 on ssh_alt: accept -K option for a user with NOPASSWD
11 years ago
Michael DeHaan a3d90e8a87 Merge pull request #5498 from j2sol/exit_setup_early
Return early from setup step when possible
11 years ago
Michael DeHaan 227e8e31c9 Merge branch 'use_comps' of git://github.com/j2sol/ansible into devel 11 years ago
Michael DeHaan 10350d1639 Update various copyrights. Not complete, but sufficient. 11 years ago
Jesse Keating 23720ff19d Use list comprehensions for efficiency
For loops can be inefficient, particularly when doing a dot command with
them. https://wiki.python.org/moin/PythonSpeed/PerformanceTips#Loops and
https://wiki.python.org/moin/PythonSpeed/PerformanceTips#Avoiding_dots...

This patch makes use of list comprehensions to be as efficient as
possible while still retaining order. Efficiency was lost a bit when
switching away from sets() but this gains some of it back.
11 years ago
Jesse Keating 35328ed503 Return early from setup step when possible
The _list_available_hosts call can be lengthy, and in the case where
gather_facts is disabled the call is pointless. So re-arrange the logic
to return early from _do_setup_step when gather_facts is false.
11 years ago
Michael DeHaan c41a23a35a Complete removal/refactoring of conditional deprecations. 11 years ago
Michael DeHaan 8e5b7d3095 Remove code underlying when_* and only_if, which are deprecated features slated for removal in the 1.5 release. 11 years ago
Michael DeHaan 28b9fd4e30 We have had only_if, when_foo, etc, deprecated for a while and said they would be removed in 1.5. Now they are, with friendly error messages still.
Users of these features should use "when:" as documented at docs.ansible.com.

Similarly, include + with_items has been removed.  The solution is to loop
inside the task files, see with_nested / with_together, etc.
11 years ago
James Tanner 21fdb2bbc7 Fixes #5200 Handle template contents with unicode strings better 11 years ago
James Tanner fc473b3246 Fixes #5146 Handle missing stdin when running under celery with rabbitmq or redis 11 years ago
Michael DeHaan de2ffc1276 Don't need to document these guys. 11 years ago
James Tanner cb2214d6f8 Fixes #4935 Synchronize module: set destination to an fqdn if connection is not local, and abide by ansible_remote_user 11 years ago
jctanner 99560e3902 Merge pull request #5047 from sergevanginderachter/synch_template_ansiblesshhost
synchronize: allow ansible_ssh_host to be templated
11 years ago
jeromew b2cd4a62de fix issue #5372 on ssh_alt: accept -K option even for a user with NOPASSWD 11 years ago
Deon Bredenhann c85aac8b17 Treat a False mandatory variable as defined. 11 years ago
Deon Bredenhann 4f1f13b100 Remove trailing space 11 years ago
Levi Gross dc6a26123b
Fixed syntax error and removed unused imports 11 years ago
Michael DeHaan 643690ffec Remove depedency of lookup plugin on setting in ansible.cfg 11 years ago
Michael DeHaan 5b3c796641 Update constants.py
Lookup plugins for optional web services do not warrant advertising in ansible.cfg.
11 years ago
Stephen Fromm 833e1f6e2a Make sure action plugin copy cleans up tmp dir
The copy action plugin creates its own tmp dir for each file that it
copies to the target machine.  However, it does not clean up the
original tmp path it was given when run() is called.  This cleans up the
tmp path before it begins looping on source files.
11 years ago
dparalen 6bf5d664dc allow per-host sudo operation 11 years ago
James Tanner 993e0f057e Allow for no role dependencies in role metadata 11 years ago
James Tanner 1ef9930b80 Addresses #5341 Expand home directories when searching for roles in ansible-playbook 11 years ago
James Tanner 5d022182fe Fixes #5341 Use constants.py to set the roles directory 11 years ago
John Barker 4bf9f714d0 Fix inventory parsing so that FQDN can be parsed without throwing ssh
port parsing errors
Fixes problesm introduced by 948d019fef
Adds testcases to defend
11 years ago
jctanner ea8cd62b19 Merge pull request #5259 from mvo5/bugfix/improve-error-on-invalid-vars-file
improve error on invalid vars file (if its a list instead of a dict)
11 years ago
jeromew e4a3f49fa2 ssh_alt - only trigger 'fatal' when returncode == 255 (interpreted as 'could no connect') 11 years ago
willthames 12005a1cd0 Move more responsibility to common EC2 module
Moved `AWS_REGIONS` into `ec2` module
Created `ec2_connect` method in `ec2` module
Updated modules able to use `ec2_connect` and `AWS_REGIONS`
11 years ago
jctanner cd3144af5d Merge pull request #5178 from cavassin/devel
Prevents UnicodeEncodeError
11 years ago
James Tanner f3a4705a9c Revert "Merge pull request #4874 from leth/editable_install"
This reverts commit 15b89b45e1, reversing
changes made to 3d836a1ab7.
11 years ago
jctanner 15b89b45e1 Merge pull request #4874 from leth/editable_install
Fix setup.py to work with 'pip install -e .'
11 years ago
Sébastien Bocahu c8d5846ab9 Let merge hash_bahaviour work with dynamic inventory 11 years ago
jctanner 3d836a1ab7 Merge pull request #5247 from jeromew/ansible_ssh_alt
ssh_alt.py / decrease # of ssh roundtrips
11 years ago
jeromew 5c965a75f0 ssh_alt.py / decrease # of ssh roundtrips 11 years ago
jctanner 1679d83637 Merge pull request #5131 from janeznemanic/devel
Fix for issue #4730 - stacktrace when deferenencing a non-existent group
11 years ago
jctanner 301a1189dd Merge pull request #5122 from willthames/openlog_str
Make first argument to syslog.openlog be a string
11 years ago
Ferenc Grecu 56642f9b04 Remove unused parameter from _get_config 11 years ago
Michael Vogt bef5ee2c3b improve error on invalid vars file (if its a list instead of a dict) 11 years ago
Jesse Keating 8cef210aea Make sure ssh pipes are empty before moving on
Resolves issue #5082

Code as it was would hit a scenario where one of the FDs was not ready for
reading the first time through -- but p.poll() would show the process as
complete. This would cause ansible to continue on, while leaving some content
left in a pipe.

The other scenario -- the one that causes the unclosed quote, is if we go
through select.select() and we do get stdout in the ready for reading -- we
read from it (9000 bytes), but that's not all that is there. Again we'd get to
the p.poll() check and it would be indeed not none, but we would have left some
of stdout on the FD and thus the json blob would be malformed.

Tested with and without full ssh debugging.
Tested with and without ControlPersist
Tested with and without ControlPersist sockets already created
11 years ago
Michael DeHaan 929f8a5c93 Had to revert commits due to async. 11 years ago
Michael DeHaan 74e4ccb59b Revert "ssh_alt.py / decrease # of ssh roundtrips"
This reverts commit 7f8863f96d.
11 years ago
jeromew 7f8863f96d ssh_alt.py / decrease # of ssh roundtrips 11 years ago
jeromew db182ba498 copy ssh.py to ssh_alt.py 11 years ago
Steve Smith 5b81f88c8f Cast the retrieved `retries` var to an int before incrementing as it may be in string form.
For example, the following method of calculating the value will result in a type error:

    appstatus_waitfor: 4  # Minutes
    appstatus_delay: 5 # seconds
    appstatus_retries: "{{ mins * 60 / delay }}"
11 years ago
Wanderlei Antonio Cavassin 6ba93817a9 Avoid UnicodeDecodeError exception when passing module args 11 years ago
James Tanner bf78d8cf73 Addresses #5090 setup module was using path.is_file instead of path.isfile 11 years ago
cavassin 10f5af82f9 Prevent UnicodeEncodeError
Prevents UnicodeEncodeError: 'ascii' codec can't encode character, while printing shell commands output
11 years ago
jctanner 7aa35d64c2 Merge pull request #5091 from EspadaV8/5089_assemble_fix
#5089 hack-fix assemble module
11 years ago
Paul Bonser 58acd8cce1 If there is no tmp_src, don't modify the args 11 years ago
Paul Bonser 4afcd50487 properly convert arg into boolean 11 years ago
Michael DeHaan 801ca96a8b Merge pull request #5152 from sivel/too-many-ps
The word skipped only has 2 p's not 3
11 years ago
Matt Martz 5f0f3566a6 Skipped only has 2 p's not 3 11 years ago
Matt Martz 8873c3675b Ensure we are looking for the right import to determine if the module_style is new. Fixes #5148 11 years ago
jctanner 2670529671 Merge pull request #5090 from dragon3/hostname_support_amazon_linux
hostname module: add support for Amazon Linux
11 years ago
James Tanner d227614529 Fixes #5109 synchronize module ssh port
Added a parameter for dest_port and also check ansible_ssh_port inventory variable.
11 years ago
Paul Bonser 5626efba7e Optionally unarchive a file already on the remote machine 11 years ago
jctanner 93159cb9cd Merge pull request #4996 from sivel/rax-module-utils
Implement ansible.module_utils.rax
11 years ago
Janez Nemanic 8752ae6909 Fix for issue #4730 - stacktrace when deferenencing a non-existent group 11 years ago
Will Thames 76aca4d547 Make first argument to syslog.openlog be a string
syslog.openlog expects its first argument to be a string.
Without this change running under ipython fails.
11 years ago
James Cammarata 9101c2af98 Fix traceback in template error detection code
Fixes #5081
11 years ago
Andrew Smith eed32ea70c dest_contents isn’t always defined, so don’t pass it around
I think this is also a bit of a hack since it should probably be set
before being used, I’m just not sure what it should be set to.
11 years ago
Andrew Smith e2d03173d2 The file module doesn’t have it’s module_args reset
I believe that this should be reset in the same way that the copy module
does
11 years ago
Andrew Smith 7b01c83159 Passing in complex_args throws ‘unsupported parameter for module’ errors
When using assemble only params (e.g. remote_src) the copy (and I’m
guessing file) modules throw an error that the param isn’t supported.
Simply removing the complex_args param fixes it for me, but I’m not sure
that’s the correct thing to do
11 years ago
Andrew Smith da44a7f0cb I think that resultant is meant to be the contents of the combined file
It is used for the transfer and as a diff param but isn’t actually
defined anywhere before it’s used. This seemed like the least bad place
to set it.
11 years ago
Andrew Smith 4503413baa ReturnData is used throughout but not actually imported 11 years ago
dragon3 d39e6fda92 hostname module: add support for Amazon Linux 11 years ago
Andrew Smith 7d007cac16 Correct the invocation of ‘_assemble_from_fragments’ 11 years ago
jctanner 920bc6e75b Merge pull request #5086 from j2sol/fix-accelerate_inventory
Avoid a traceback when using accelerate
11 years ago
James Tanner b6879ca2bd Fixes #5030 compare connection user and sudo user and disable sudo if identical 11 years ago
Jesse Keating 5522d489e3 Avoid a traceback when using accelerate
This bit of code is attempting to access accelerate_inventory_host,
which may not have been set/created. This will cause a traceback.
Instead use getattr with a fallback to False.
11 years ago
James Tanner 12ed39ef7b Fixes #5056 Append new hosts to the groups cache 11 years ago
James Cammarata 1f80aa768a Fix bug in error detection code, where a zero-length string was causing a traceback
Fixes #5064
11 years ago
Brian Coca 65885feeeb fixed typo for assemble function 11 years ago
James Tanner b8146e3bc7 Fixes #4979 Check for the correct context when inside the inventory_hostnames plugin 11 years ago
James Tanner 903c4cae7b Fixes #5031 Template the delay value and cast to float for loops 11 years ago
Serge van Ginderachter 2f9470ec1d synchronize: allow ansible_ssh_host to be templated
This is already enabled in the runner also.
11 years ago
Antonio Zanardo 8dbd91b5ad fix typo in deprecation warning 11 years ago
James Tanner bca2634d54 Fix missing eval for string search in ssh controlpersist 11 years ago
James Tanner a16fe923ed Addresses #5011 check for proper string in smartos ssh error output 11 years ago
jctanner 5c84d7e445 Merge pull request #5002 from ovcharenko/devel
Allow to specify ansible_ssh_private_key_file location related to user home directory
11 years ago
James Tanner 512ebdb971 Revert "Merge pull request #5001 from ovcharenko/devel"
This reverts commit d6c3103a00, reversing
changes made to b11f96eaa4.
11 years ago
Aleksey Ovcharenko 9af44b1b42 Update to 4 space indent 11 years ago
Aleksey Ovcharenko 30678e04ac Make tests happy 11 years ago
Aleksey Ovcharenko 2222f6df58 Allow to specify ansible_ssh_private_key_file location related to user home directory 11 years ago
Matt Martz 3f2cbb7583 Add ansible.module_utils.rax 11 years ago
James Tanner 9b991b9154 Version bump for 1.5 11 years ago
Jan-Piet Mens 252a51be91 New lookup plugin csvreader 11 years ago
James Tanner b815a09529 Fix pep8 error in password lookup 11 years ago
James Tanner e81c976636 Fix pep8 errors in unarchive module 11 years ago
jctanner 68afd9da9f Merge pull request #4866 from sergevanginderachter/known_hosts_sudo
Check real user's known_hosts when sudo ansible...
11 years ago
Brian Coca 34c33f7ea1 now correctly spell symmetric
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Brian Coca 460bbfaec1 added union filter
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Brian Coca afe30a6633 added difference and symetric difference filters
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Michael DeHaan fc909b453f Make the legacy template detection system not hit a false positive when
replacing a \$ with $.
11 years ago
jctanner 93223510af Merge pull request #4936 from stoned/group-get_hosts-perf2
Improve Group.get_hosts() performance.
11 years ago
Matt Haggard 389602b8dd Merge pull request #4920 from iffy/ansible
Collect all stdout over ssh transport before returning data
11 years ago
Michael DeHaan f18acee779 Merge pull request #4937 from skyl/synchronize-keyerror
KeyError: 'delegate_to' lookup in sync module needs to be checked to see if defined for ad hoc
11 years ago
James Tanner e8b54dd073 Fixes #4852 properly evaluate log_path writability 11 years ago
Skylar Saveland 7bc64581d7 KeyError: 'delegate_to' no more 11 years ago
Stoned Elipot b00bf02129 Improve Group.get_hosts() performance.
- reduce hosts group list to unique elements faster
- add a cache of already computed hosts group list
11 years ago
jctanner 009fdbf96a Merge pull request #4896 from mjschultz/aws-access-keys
Check for AWS keys using boto names
11 years ago
jctanner 04847191b4 Merge pull request #4879 from bcoca/unique_intersect
added unique and intersect filters for dealing with lists
11 years ago
jctanner 0f0a89b34e Merge pull request #4758 from alanfairless/group-host-var-dirs
Support organizing group and host variables across multiple files in a directory
11 years ago
jctanner 77affdefbc Merge pull request #4585 from mscherer/connec_func
connection plugin to reuse the func/certmaster interface instead of ssh
11 years ago
jctanner be67a6f815 Merge pull request #4625 from pileofrogs/devel
unarchive module & action plugin
11 years ago
jctanner e4494be8c6 Merge pull request #4803 from dragon3/devel
Don't fail if ec2_access_key/ec2_secret_key not specified to use IAM rol...
11 years ago
Michael J. Schultz 5f9485499c Check for AWS keys using boto names
- see https://github.com/boto/boto#getting-started-with-boto
11 years ago
James Tanner 33242cacf3 Merge pull request #4375 from pfalcon/ansible
copy: Implement recursive copying if src is a directory.
11 years ago
jctanner 9a7765daf7 Merge pull request #4351 from 2m/leading-range-fix
Allow leading ranges in the inventory host entries.
11 years ago
jctanner 6dd81f25d9 Merge pull request #4856 from akuznecov/devel
Resolves #4855 issue with synchronize module failing on multiple items
11 years ago
James Tanner f31cb7c6e8 Merge pull request #4664 from jpmens/ansible
Lookup plugin for etcd

with support for configurable etcd URL in ansible.cfg (and environment)
11 years ago
James Tanner dc41bb8085 Merge pull request #4207 from ashorin/ansible
Fail playbook when serial is set and hadlers fail on set.
11 years ago
jctanner 2cf335969f Merge pull request #4738 from bcoca/assemble_action_plugin
assemble can now use src from master/origin
11 years ago
Brian Coca efd87534eb added unique and intersect filters for dealing with lists
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
11 years ago
James Tanner 6e49ee6cfc Remove commented code block 11 years ago
James Tanner 288c33e286 Merge pull request #4078 from mkaluza/ansible
add 'chars' parameter to password plugin to allow custom character set
11 years ago
jctanner 0c29807ba3 Merge pull request #3993 from stoned/inventory-script-all-group-fix
Avoid duplicates of the 'all' group when using inventory script.
11 years ago
Marcus Cobden 8d98a55df1 Fix setup.py to work with 'pip install -e .' 11 years ago
Serge van Ginderachter 80fd22dce6 Check real user's known_hosts when sudo ansible...
closes #4834
11 years ago
James Tanner 74e7eba528 Fixes #4506 test length of context before checking invalid indexes 11 years ago
Alexander Kuznecov 9d2f9bf93c resolves #4855 11 years ago
jctanner 8e8c8efc8f Merge pull request #4769 from alanfairless/more-password-entropy-revised
Revised patch for more password entropy
11 years ago
jctanner f51b8ffde9 Merge pull request #4836 from dekked/devel
Bug fix: support running handlers parametrized by name
11 years ago
James Tanner 898de833b0 Merge pull request #4413 from jerm/ansible
Add capability to pass in a PATH prefix to run_command and allow pip module
to utilize that to make virtualenv bin/ available in pip installs
11 years ago
Alan Descoins bb6f02d0e8 Support running handler parametrized by name. 11 years ago
jctanner 8d9b53b445 Merge pull request #4733 from sivel/4323-sudo-pass
Add ansible_sudo_pass hostvar support. Fixes #4323
11 years ago
James Tanner d93780bc8a Addresses #4635 add list instead of join 11 years ago
James Tanner 2b5005687a Fixes #4635 pass role conditionals to dependent roles 11 years ago
James Tanner 91aa7b51df Remove invalid ipv6 parameter from setup execution 11 years ago
James Tanner c1ed47933b Fixes #4485 add an ipv6 parameter to accelerate so that the daemon will bind to an ipv6 port instead of ipv4 11 years ago
dragon3 ff5bd7fe06 Don't fail if ec2_access_key/ec2_secret_key not specified to use IAM role. 11 years ago
willthames 76c810afe3 AWS_ACCESS_KEY misspelt in shared EC2 connection library 11 years ago
Michael DeHaan eab6737209 Clarify a warning message. 11 years ago
Michael DeHaan 70c9028e1e include_vars plugin should look in vars/ path for a role. 11 years ago
Michael DeHaan 99687749a3 Merge pull request #4775 from steverweber/fix-4640
dont sudo if sudo_user is the same as the connection user
11 years ago
Steve Weber 5bd52796ec dont sudo if sudo_user is the same as the active user 11 years ago
James Tanner afa5988391 Fixes #4540 Use shared module snippet to evaluate ec2 credentials 11 years ago
Alan Fairless 0824f004d9 Revised patch for more password entropy 11 years ago
James Tanner dc4d589ce0 Fixes #4767 detect hard links and set state in add_file_info 11 years ago
Michael DeHaan b1b5280075 Reapply pep8 changes from previous revert. 11 years ago
Michael DeHaan 51fbc6d20a Further simplify the debug: var=foo action plugin code. 11 years ago
Michael DeHaan bbf212a268 Simplify the way the debug: var=varname plugin works. 11 years ago
Michael DeHaan 7f125567cb Some simplification of include_vars and renamed include_files to include_vars. 11 years ago
Michael DeHaan b69ab89eb1 Merge branch 'include_files' of git://github.com/bennojoy/ansible into devel 11 years ago
Michael DeHaan 465f3b1c91 This allows type=dict in a module to allow passing in a real dict or JSON. 11 years ago
Michael DeHaan 8b2cd6413b When inside an apt or yum task account for multiple conditionals. Fixes 4745. 11 years ago
Michael DeHaan d34a26e307 Undo an inadvertant revert from template changes so we still allow pythonic imports in module land. 11 years ago
Alan Fairless 65e5331079 Allow organizing host/group vars in a directory
So instead of having:
 group_vars/production.yml

A user could chose to reorganize to:
 group_vars/production/staff.yml
 group_vars/production/networks.yml
 group_vars/production/dns.yml

(Backwards compatible.)
11 years ago
Alan Fairless babde9a84c refactor to catch edge cases, remove repeated code
- Move all the supported YAML file extensions into a constant
- Use helper functions to avoid duplicate code for group/host vars
- Catch and disallow some confusing situations, such as the presence of
  multiple group/host vars files for the same group/host, but with
  different extensions.  For example having both group_vars/all.yml and
  group_vars/all.yaml.
- Catch and report file system permission issues, symlink errors,
  unexpected file system objects
- Trivial performance improvement from making fewer stat system calls
- Restructuring that makes it easy for a following patch to support
  directory recursion
11 years ago
Brian Coca ac40d15120 now assemble module is also action plugin and can use local source for
files
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Michael DeHaan 7b331ef6ed Fix code typo. I'll blame jet lag for now :) 11 years ago
Michael DeHaan 90cce35919 This allows variable references in playbooks in a different way. 11 years ago
Michael DeHaan b5c9d5a59b Inventory directory should always be absolute. Fixes #4535. 11 years ago
Michael DeHaan 7201a6ffad Evaluate the conditional for each item for modules that normally try to group with_items results
like yum and apt.
11 years ago
James Tanner 078aaa95a2 Revert 1f6edf7d76 and re-enable passing lists to yum and apt 11 years ago
Matt Martz ea2ec6237a Add ansible_sudo_pass hostvar support 11 years ago
James Tanner d154bf8781 Revert templating enhancements from 73dbab70 e6c28658 d409352c 9858b1f2 4587528b 9b1fe455 214b0b05 8d3db803 7f9504d1 5031104c 35cb9dc2 2bd8cb57 1e85c754 11 years ago
James Tanner 0faecdf7d1 Fixes #4653 Set dest on results for copy module even if using file module 11 years ago
James Tanner 9249cf578d Fixes #4572 Run until loop if until is set, ignoring result failures 11 years ago
Michael DeHaan 73dbab702f Don't run lookup plugins while trying to simplify the input datastructure. 11 years ago
Michael DeHaan 6d0da41a55 No need to template modules with Jinja2 as this can confuse some docstring comments. 11 years ago
bennojoy b53e7353f9 include files 11 years ago
Michael DeHaan 603db60828 Merge pull request #4288 from sivel/3725-regex
Add regex (search, match, regex) jinja2 filters. Fixes #3725
11 years ago
Michael DeHaan 4587528b99 Fix typo in comment. 11 years ago
Michael DeHaan d409352c85 Remove some interior imports in the code. Not really needed but nice to have them gone. 11 years ago
Michael DeHaan e6c28658b4 Add in some code to pre-template datastructures prior to template usage. This prevents a certain class of error
where filter evaluations can happen too early due to the template engine recursion being a bit limited.

Addresses #4662
11 years ago
Michael DeHaan f05a3a81f9 Add missing file. 11 years ago
Michael DeHaan 54c902f102 Identation + misc PEP8 fixes. 11 years ago
Michael DeHaan bbb359870e Add package file. 11 years ago
Michael DeHaan 9858b1f2f3 Enable imports to work on a snippet based system, allowing for instance a library of common EC2 functions
to be reused between modules.  See library/system/service and library/system/ping for initial examples.  Can
work the old way to just import 'basic', or can import the new way to import multiple pieces of code from
module_utils/.
11 years ago
jctanner 43f48a2e02 Merge pull request #4167 from tima/rsync3
synchronization module take 3
11 years ago
James Tanner 40886c42b5 Fixes #4561 Compare task name without role prefix for start-at-task 11 years ago
James Tanner 1f6edf7d76 Fixes #4665 and #4666 If task is conditional do not flatten items list for packaging modules 11 years ago
James Tanner 9b1fe455c6 Fixes #4549 Do not call lookup plugins when templating a task's name 11 years ago
Serge van Ginderachter 6277e770a1 include basedir as 'playbook_dir' variable
closes #4246
11 years ago
Jan-Piet Mens bd5cd8e652 Lookup plugin for etcd
with support for configurable etcd URL in ansible.cfg (and environment)
11 years ago
James Tanner b803aac6ec Fixes #4500 change ec2 module params to type=bool
Revert 4833c2fdf0
11 years ago
James Cammarata b9dd514713 Minor fix for putting 0-length files over accelerated connections
Fixes #4652
11 years ago
James Tanner 4833c2fdf0 Fixes #4500 python bools return uppercase True and False, so allow those for BOOLEANS in module common 11 years ago
James Tanner 214b0b052c Fixes #4608 add lookup to template globals to make plugins work again 11 years ago
Dylan Martin 2c28e1daea unarchive module & action_plugin added 11 years ago
James Tanner 4f13967386 Fixes #4536 Get the remote_user from multiple sources in a preferred order 11 years ago
Timothy Appnel cbae9c913e synchronize module src and dest handles template markers. 11 years ago
Michael DeHaan 60944b81f0 Provide warning about "with_items: '{{ loop }}'" being redundant only when {{ starts the expression value. Fixes #4582. 11 years ago
Michael DeHaan 2bd8cb5790 Make the deprecation detector in templates more accurate. Fixes #4514. 11 years ago
Michael DeHaan 4125b05bf3 Allow a defaults file to solely define a role. Some typo fixes. 11 years ago
Michael DeHaan 64bbeb9d24 Suggest fixing unbalanced quotes in a bit less cases. Fixes #4501 11 years ago
Michael DeHaan 7f9504d14d Fix a typo. 11 years ago
Michael DeHaan 8d3db80370 Some misc cleanup and removal of unused imports. 11 years ago
Michael DeHaan 21d4400c96 Misc pep8 fixes 11 years ago
Michael DeHaan c933a4c59a Fix indentation depth. 11 years ago
Michael DeHaan 5031104c3a Finishing touches on template cleanup. 11 years ago
Michael DeHaan 1e85c7544b Further WIP on template cleanup. 11 years ago
Michael DeHaan 35cb9dc22f Work in progress about cleaning up template code. 11 years ago
Michael Scherer af796d6556 connection plugin to reuse the func/certmaster interface instead of ssh
This plugin permit to use func to run playbook and ansible command instead
of ssh. It can be used for a smooth transition from func/taboot to ansible by
letting people use ansible without having to change their network architecture.
11 years ago
Brian Coca c476ed93ca now correctly changes script permission in all cases
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
11 years ago
James Tanner 8478e82647 Fixes #4583 enforce that vars_files is a list 11 years ago
Michael DeHaan b0f6e77f66 Merge pull request #4571 from tgerla/whitespace
add_group module: strip trailing/leading whitespace from comma-separated group names
11 years ago
Tim Gerla 51a1709253 add_group module: strip trailing/leading whitespace from comma-separated group names 11 years ago
James Tanner 242f20c297 Fixes #4402 wrong order for isinstance parameters in dnstxt.py 11 years ago
Martynas Mickevicius 7ecb5fbc9c Handle comment on inventory group line. 11 years ago
Martynas Mickevicius 44279ce34f Allow leading ranges in the inventory host entries. 11 years ago
jctanner 6480945184 Merge pull request #4541 from Kami/improve_template_render_error_messages
Make errors which get thrown during template rendering more user-friendly
11 years ago
Stoned Elipot 4430d0f5a6 when searching for a plugin only look for a regular file 11 years ago
Tomaz Muraus 922f61899e Throw a more user-friendly exception during template rendering process. 11 years ago
Gabe Mulley 84a57b7545 ensure non-root users can read arguments file when using sudo_user
Non-standard modules must read in the arguments file in order to access their arguments, however, when this file is transfered to the remote host it may only have the permissions 600.  This means that using sudo and sudo_user will result in permission denied errors when attempting to read the arguments file.

This patch fixes #4438 by explicitly forcing the arguments file to be world readable before executing the module.
11 years ago
Brian Coca bd9acedb57 fixed name colision between warnings dict and module
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
11 years ago
Paul Sokolovsky 2e668f14f7 copy: Handle "no copy/propagate attrs only" for recursive mode well.
For this, add internal "original_basename" param to file module,
similar to copy module. (Param name is a bit misnormer now, should
be treated as "original basepath").
11 years ago
Paul Sokolovsky ce88df3cf4 copy: Handle dest path variations for recursive mode. 11 years ago
Paul Sokolovsky 6cf3975e2e copy: Set suitable default result for check mode. 11 years ago
Paul Sokolovsky 612b446856 copy: Don't modify input module_args in a recursive file handling loop. 11 years ago
Paul Sokolovsky b3b4f9885f copy: Implement recursive copying if src is a directory.
If src param to copy is a directory, all files under it are collected
and pushed one by one to target. Source dir path handled in a way
simalar to rsync: if it ends with slash, only inside contents of
directory are copied to destination, otherwise the dir itself is
copied (with all contents of course). Original idea and implementation
by https://github.com/ansible/ansible/pull/1809 . Rewritten to address
review comments and simplify/correct logic.
11 years ago
jctanner 69fa5954fd Merge pull request #3932 from jocelynj/devel
Add option remote_user to task level, to specify the ssh login user
11 years ago
Michael DeHaan e131de4de0 Added "debug: var=variableName" capability. 11 years ago
egghead ca7e2d283c Adding os realpath filter.
This is particularly useful when wanting to get the absolute path of filepaths found by the 'fileglob' filter.
This also lets you provide absolute paths to roles, which search for files in different areas unless absolutely pathed.
11 years ago
Michael DeHaan c90a82fd52 Handle possible scenario where conditional might be an integer (whoa!) down the error path. Super rare but fixes #4483. 11 years ago
Michael DeHaan 9ea54fcaaf Fixes a dev branch glitch where a conditional could be applied to multiple tasks. Also improves the errors on parsing bad conditionals to make them less confusing to users. 11 years ago
Thomas Omans 632232259a Adding config flag role_path for common/global roles
Using ANSIBLE_ROLE_PATH environment variable or role_path in ansible.cfg
can configure paths where roles will be searched for
extra paths will only be used as a backup once regular locations are exhausted
11 years ago
Michael DeHaan 43df00550d Merge pull request #3827 from mscherer/disable_callbacks
add a way for callback to disable itself
11 years ago
Michael DeHaan 1b2d4c328c Cache patterns a bit higher up to make things a little more efficient. See #4469. 11 years ago
Michael DeHaan d168c709d5 Fix an issue where the ordering of an include statement is processed ahead of the conditional in the included statement,
which required a redundant check to see if a variable was defined rather than short circuiting.

Fixes #4469
11 years ago
Michael DeHaan add45d2ca9 Fixup legacy var detector. 11 years ago
Michael DeHaan 709ffda3d1 Tweak only_if deprecation detector. 11 years ago
Michael DeHaan a45494a896 Add warnings feature. 11 years ago
Michael DeHaan 9637f620d7 Deprecation warnings of several flavors, nice and purple and can be disabled
in ansible.cfg.
11 years ago
Michael DeHaan a017a69bb3 Have the parser explain another type of YAML gotcha to reduce the need for users to ask how to resolve it. 11 years ago
Michael DeHaan 861f076df5 Tweak the syntax-detector-warning-suggester-message (SDWSM) a little. 11 years ago
Michael DeHaan 41aaad69aa Make add_host clear the inventory pattern cache, add some more aliases. Fixes #4442. 11 years ago
jctanner 65ef6a62dc Merge pull request #4425 from jeromew/ansible_sudo_user_with_items
Template sudo_user via with_items
11 years ago
James Cammarata d73a5da9e5 Merge pull request #4453 from pschwartz/fix_cfg_load_order_to_match_docs
GH-4452 Corrected config load order to match docs
11 years ago
Philip Schwartz 65c8c691f7 GH-4452 Corrected config load order to match docs with
cwd > ~ > /etc

Signed-off-by: Philip Schwartz <philip.schwartz@rackspace.com>
11 years ago
Matt Martz 61525a97df Add regex (search, match, regex) jinja2 filters. Fixes #3725 11 years ago
Serge van Ginderachter c4d20094b4 make changed filter understand results lists 11 years ago
Serge van Ginderachter e5d45311f9 Implement a |changed filter plugin 11 years ago
Serge van Ginderachter c2e5f783da Add caching to pattern enumeration
Inventory._hosts_in_unenumerated_pattern()

Was TODO: cache this logic so if called a second time the result is not
recalculated
11 years ago
jeromew dec364ae80 Template sudo_user via with_items 11 years ago
Michael DeHaan 3f968ff46a Check one more skipped scenario in with_subelements. 11 years ago
James Cammarata 9124ebb4f1 Clear out complex_args before running async_status
When using complex args with an async task, the subsequent runs of
async_status would inherit them, causing a module error (invalid params).

Fixes #3150
11 years ago
Michael DeHaan 2078518735 Allow subelements to work right with skipped results. 11 years ago
Jeremy Price 9da5043f18 Adding path_prefix to run_command so that one can pass in a path to the run environment if you nees something in a non-default path. 11 years ago
James Cammarata 948d019fef Detect IPv6 addresses in INI inventory
Prevents parts of the IPv6 address from being interpreted as a port
(for example, :80).

Fixes #3888
11 years ago
Michael DeHaan 6febc97104 Add a warning about include + with_items so nobody uses it. 11 years ago
James Cammarata 98f6bc1f63 Apply tags to dependent roles correctly
Fixes #4339
11 years ago
Michael DeHaan c69e19c6a6 Enhance references to logging functionality. Fixes #3431. 11 years ago
Michael DeHaan f081c68a65 Prevent duplicately loaded handlers from running more than once.
Fixes #3863
11 years ago
Michael DeHaan 5ed28efe45 Script module should return changed attribute so handlers always fire, unless "changed_when" is specified.
Fixes #4053
11 years ago
Michael DeHaan a7adc8ef4d Allow doing things like "groups.groupname" in with_nested.
Fixes #3858
11 years ago
Michael DeHaan 5e30cd999c Make it possible to say:
tags: 42

And have the tag be a string, not an int, so --tags matches.

Fixes #4110
11 years ago
Michael DeHaan 8fc46a3a5a Return inventory objects in the order they are presented. Additionally, fix host slicing such that it works on Python terms with
zero indexed lists and a non-inclusive final element.
11 years ago
Michael DeHaan 19386c43a7 Merge 11 years ago
James Cammarata d10582225b Merge branch 'issue_4215_fetch_expanduser' into devel 11 years ago
Andrey Shorin 35457b67f5 Pass host to runner_on_file_diff callback 11 years ago
Stoned Elipot e7957b6d58 Fix group_by: do not group a host for which a condition is false 11 years ago
Michael DeHaan 44e391fd8b Merge pull request #4255 from mcodd/legacy_vars_fix
Fix for legacy_playbook_variables (should fix issue #4254)
11 years ago
Michael DeHaan 65178290e7 Merge branch 'devel' of git://github.com/nextus/ansible into devel
Conflicts:
	lib/ansible/constants.py
11 years ago
Michael DeHaan ea73151757 Add automatic advice when folks hit one of two common but minor YAML gotchas, so they can be more easily correct them on their own. 11 years ago
Michael DeHaan 4987c73bb6 Proper check for raw as module options versus raw being in the string. 11 years ago
James Tanner 52aea868df Allow for updating host vars in add_host 11 years ago
James Cammarata d21714a37f Fix for network byte order issues in accelerate 11 years ago
James Cammarata 912e3a7b0b Merge branch 'accelerate_improvements' into devel
Conflicts:
	library/utilities/accelerate
11 years ago
James Cammarata fa80a17aa3 Make recv_data less greedy so it doesn't eat other packets 11 years ago
James Cammarata 8923a5b0d9 Drop default config value for accelerate timeout to 30 seconds 11 years ago
James Cammarata 12f6957596 Cleaning up some vvvv log messages in accelerate 11 years ago
James Cammarata 8c17711247 Removing accelerate_timeout as a playbook option
This will remain in ansible.cfg only.
11 years ago
James Cammarata d317103371 Added in an accelerate connection timeout setting 11 years ago
James Cammarata 59a5ce23d9 Adding an accelerate_timeout parameter for plays
This setting makes the timeout for each play configurable, rather than
hard-coding it at 300 seconds (now the default if left unspecified)

Fixes #4162
11 years ago
James Cammarata f9c87868ac Added keepalive packets to accelerate mode
Commands will now be started up in a separate task from the main
handler thread, so that it can be monitored for completeness while
sending a keepalive packet back to the controller to avoid a socket
receive timeout.
11 years ago
James Cammarata 8a3f8b757b Make sure yaml data loaded for role is valid before using it
Fixes #4322
11 years ago
James Cammarata bff47df5ff Fix issue with ast evaluation of strings 11 years ago
James Cammarata 5b205ae8bd Merge branch 'fixes/subprocess' of https://github.com/ferringb/ansible into ferringb-fixes/subprocess 11 years ago
James Cammarata d89ce6ac61 Merge branch 'patch-1' of https://github.com/ustun/ansible into ustun-patch-1 11 years ago
James Cammarata 12a21d94b7 Merge branch 'allow_types_in_ini' of https://github.com/bcoca/ansible into bcoca-allow_types_in_ini 11 years ago
jctanner 32a1dd422c Merge pull request #4269 from jphalip/issue-4256
In the script action: Get around a Python bug.
11 years ago
James Cammarata 7aad576f5f Minor change to add a space around role name/task delimiter 11 years ago