Toshio Kuratomi
2e16bd3a44
Refactor the Linux service_enable() method
...
* Fix check_mode for initctl systems
Fixes #9009
10 years ago
Toshio Kuratomi
104401805b
Revert "Refactor the Linux service_enable() method" needs some debugging
...
This reverts commit e294e31fd3
.
10 years ago
Toshio Kuratomi
c362902f50
Refactor the Linux service_enable() method
...
* Fix check_mode for initctl systems
Fixes #9009
10 years ago
Toshio Kuratomi
a9928492f7
Make systemd vs rht detection more robust for centos
...
Centos 6.x and below use an old RHT style of configuring hostname.
CentOS 7.x and better use systemd. Instead of depending on the
distribution string which seems to have changed over the course of 6.x
we need to explicitly check the version.
Fixes #8997
10 years ago
James Cammarata
7edcf21bdc
Move initscript rc check to later in service status check
...
Fixes #7284
10 years ago
Michael DeHaan
5aa6ddef7f
Tracebacks are now catchable with ignore_errors and have streamlined output. Also removes 'baby-JSON' for bash modules.
10 years ago
Patrik Lundin
0abf14ff19
service: use self.changed in service_enable_rcconf().
...
This sets the "changed" result of the module when a rc file is modified.
Previously only --check mode would show that it was going to change.
10 years ago
James Cammarata
30d6713bf0
Add additional checks to detect upstart services
...
Also adds checks for the upstart version, in order to test check
support for manual vs. start on manual
10 years ago
Eri Bastos
6f8a29dc3d
Proposed fix for issue #7757
10 years ago
James Cammarata
c8376e296f
Tweaking change to documentation language for cron name param
10 years ago
James Cammarata
509761249c
Merge branch 'devel' of https://github.com/mattparker/ansible into mattparker-devel
10 years ago
James Cammarata
07e77c5bed
Merge pull request #8740 from mattparker/patch-1
...
Name appears to be a required parameter for cron module
10 years ago
James Cammarata
1f2727c607
Merge pull request #8729 from ercpe/openrc-hostname
...
Hostname strategy implementation for OpenRC based systems (e.g. Gentoo)
10 years ago
Matt Parker
6086c505fe
Update cron documenation
...
The "name" parameter seems to be rather important as the identifying feature of a cron job. This is an update to the documentation to further emphasize this.
10 years ago
Matt Parker
5accd15ba6
Name appears to be a required parameter
...
As far as I can tell, `name` is a required parameter. The guard test at (now) line 458 says you need name if `state == present` and at 464 if `state != present`, although that's not quite as clear. Each of the code paths at 485 - 495 pass the name param through to `add_job`, `update_job` and `remove_job`, and the actual _update_job method earlier seems to require it too. However I don't really know python so I may be wrong, but I can't see the circumstances when `name` is not required.
10 years ago
Johann Schmitz
7ef67e3f8b
Hostname strategy implementation for OpenRC based systems (e.g. Gentoo)
10 years ago
Ding Deng
85c6434262
debconf module: add the missing 'error' vtype and reorder vtypes as they appeared in debconf-devel(7).
10 years ago
Michael DeHaan
60ce2d3853
Fix documentation builds.
10 years ago
Michael DeHaan
f21d6c7980
Merge pull request #8002 from prune998/patch-2
...
added missing force flag on mkfs commandline
10 years ago
Michael DeHaan
185d5a6221
Merge branch 'spelling' of git://github.com/cgar/ansible into devel
...
Conflicts:
docsite/rst/guide_rax.rst
plugins/callbacks/mail.py
10 years ago
Michael DeHaan
66ec9089bd
Update docs.
10 years ago
Michael DeHaan
f6f184b36d
Updating docs.
10 years ago
Brian Coca
aeeefd046f
bumped to 1.7
10 years ago
Brian Coca
5aa2ca762a
added control to fail or not on missing key
...
made split 'smarter' but still overridable
10 years ago
Brian Coca
391f8ec600
added getent module to get system data as facts
10 years ago
Serge van Ginderachter
961d4b0d6c
execute the mount after path validation
...
This avoids a stale situation where name/path contains some impossible path,
but gets configured (faultly) in fstab, and the module only fails after that,
when creating that path.
10 years ago
Jonathan Mainguy
650003dd5c
Fixes issue #8339 where Scientific Linux incorrectly tries to use FedoraStrategy of hostnamectl
10 years ago
Michael DeHaan
e978dcf7eb
Merge pull request #8283 from ps-jay/sys_mount_fstype_doc
...
Add fstype arg to the mount examples
10 years ago
Michael DeHaan
bc01f2571e
Merge pull request #8311 from neersighted/wrap_distroversion
...
Wrap get_distribution_version() in the hostname module
10 years ago
Michael DeHaan
2212b64fd9
Cleaning up explanation of mount module states.
10 years ago
Bjorn Neergaard
cbc417ca1b
Wrap get_distribution_version() in the hostname module
...
We wrap get_distribution_version() with a new function,
_get_distribution_version(), that returns `0` when the result is a string or
`None`.
This accounts for the case when get_distribution_version() returns a string,
and we try to compare it to a float. We do this in the hostname module instead
of the module snippets because other modules may want the real string
version.module snippets because other modules may want the real string version.
10 years ago
Michael DeHaan
99ad691950
Merge branch 'ufw' of git://github.com/Trozz/ansible into devel
10 years ago
Michael DeHaan
caba7ac6a6
Merge pull request #7954 from alimony/patch-3
...
cron module: Use correct parameter name in error message.
10 years ago
James Cammarata
03f0d6bec8
Merge pull request #8308 from robinro/extend-hostname-distrolist
...
Extended distributions list for hostname module
10 years ago
Robin Roth
7920f4eaf5
Fix extra newline at end of hostname for Fedora
...
This fixes a bug introduced by 138b45e3
.
The hostname has an additional newline at the end which leads to the
state always being 'changed: true' even if the hostname is unchanged.
10 years ago
Robin Roth
a26bc9c926
Extended distributions list for hostname module
...
Implementations already present
10 years ago
Tom Lazar
d89adce760
FreeBSD 10 compatibility fix
...
On FreeBSD the whitespace around the ``=`` triggers a (cryptic) ``no such file or directory`` error. removing the whitespace like above fixes this.
10 years ago
Philip Jay
bb7b290ed8
Add fstype arg to the mount examples
...
Needed fstype in the examples, since fstype is a required argument for
mount.
10 years ago
Berend de Boer
f46c4ee093
Default for fstab missing, causing KeyError: 'fstab'
10 years ago
James Cammarata
6879e4ff0a
Merge pull request #8223 from renard/create-fstab-if-not-exists
...
Create fstab if not exists
10 years ago
Sébastien Gross
e0f7b3f39c
[mount] make sure fstab exists
...
This is mainly to prevent from failing with no such file or directory
during module execution.
10 years ago
Sébastien Gross
806052a9e5
[mount] Add documentation for fstab option
10 years ago
Hector Acosta
60edb6b04b
Add check_mode support to authorized_key. Fixes #7300
...
Signed-off-by: Hector Acosta <hector.acosta@gmail.com>
10 years ago
Yasser Nabi
8cc894bef2
Enable puppet facts
...
Currently facter facts omit facts that a distributed via Puppet. This
commit adds the `--puppet` option.
In cases where puppet is not installed, the command sends a warning to
STDERR *but* completes successfully. So should not cause any issues.
The benefit is, filtering can be done based on facts set by Puppet.
10 years ago
Michael DeHaan
96fe275946
Merge pull request #8139 from peterkh/devel
...
Fix "TypeError: group id must be integer" if groupid passed in for group key
10 years ago
Ruggero Marchei
ae95ebd075
fix LooseVersion exception with empty distribution_version
10 years ago
Peter Hall
ae67002c15
Fix "TypeError: group id must be integer" if groupid passed in for group
...
key
10 years ago
Ruggero Marchei
8d01986617
fix issue #8102
10 years ago
Cristian Ciupitu
72d6e6d805
Remove useless code
10 years ago
Michael Leer
39b34b008c
add interfact documentation #7704
11 years ago
Prune
afb358af77
added missing force flag on mkfs commandline
...
even if the option ```force=yes``` is used in the playbook, it is not reflected in the mkfs command line.
As force option is dependent of the fs type, a "if-then-else" case have been added. Also, some FS types does not have a force option.
11 years ago
Markus Amalthea Magnuson
a58709ac1d
Use correct parameter name in error message.
...
The parameter is called `cron_file` but the error message uses `file` which is confusing.
11 years ago
James Cammarata
936daf6f63
Updating the other classes in the group module to match #7249
11 years ago
James Cammarata
4ca9ebf084
Merge pull request #7249 from jfchevrette/implement-group-checking-if-state-present
...
Allow group module to handle check_mode properly when group.state=present and group already exists
11 years ago
James Cammarata
236a2989cc
Merge branch 'lvg_dm_names' of https://github.com/ajsalminen/ansible into ajsalminen-lvg_dm_names
11 years ago
James Cammarata
ad4926e090
Update authors for modprobe module
11 years ago
James Cammarata
974693882e
Merge branch 'add_name' of https://github.com/stygstra/ansible into stygstra-add_name
11 years ago
James Cammarata
6ad83bb5ce
Merge branch 'devel' of https://github.com/tgolly/ansible into tgolly-devel
11 years ago
Michael DeHaan
4fbc2a83e0
Merge pull request #7861 from cchurch/devel
...
Windows Remote Support
11 years ago
David Stygstra
cae41d0931
Added author and copyright lines to modules I contributed
11 years ago
Michael DeHaan
8b262d775b
Slight tweak to windows wording.
11 years ago
Matt Martz
cab68bc579
Mention that with windows target hosts, fact_path and filter are not currently supported
11 years ago
James Cammarata
2c22cf46cf
Merge branch '7763' of https://github.com/rmarchei/ansible into rmarchei-7763
11 years ago
James Cammarata
34405ea905
Merge branch 'lvg_fix' of https://github.com/sergevanginderachter/ansible into sergevanginderachter-lvg_fix
11 years ago
Ilya Rusalowski
b1a31ebb84
Set default vg_options to empty string
11 years ago
Ruggero Marchei
f522425415
move get_distribution_version() to basic.py
11 years ago
Ruggero Marchei
bd69e9f265
use different strategy for RHEL >= 7. Fixes 7763
11 years ago
James Cammarata
d35d5ac9d1
Merge pull request #7741 from mgcrea/devel
...
Add support for Linaro distribution in hostname module
11 years ago
James Cammarata
3e04d8c70c
Merge pull request #7737 from toddmowen/zfs-fix-7696
...
zfs: fix incompatibility - share.nfs vs sharenfs (issue #7696 )
11 years ago
Olivier Louvignes
158d6276eb
Add support for Linaro distribution in hostname module
11 years ago
Todd Owen
34517b0836
zfs: work around incompatibility by renaming share.nfs to sharenfs
...
Fixes #7696
11 years ago
rgbkrk
5591e8838d
Error checking and reporting on interface ufw rule
11 years ago
Ron Gomes
73246a49dc
Fix incorrect argument ordering in error message, which provokes a
...
printf-related TypeError.
11 years ago
Yann Coleu
f378ed643c
Add primary group in the first user module doc example
11 years ago
Nicolas Brisac
ecda1455bf
open_iscsi module: support RC 21 when listing logged-in target
11 years ago
Brian Coca
5c87e97a45
now module searches for update-alternatives vs hardcoding it
11 years ago
James Cammarata
3a8ebd4325
Pull the link out of the alternatives output when not specified
...
Fixes #7414
11 years ago
Adam Chainz
6b10cf756a
Fix grammar and value errors in cron documentation
11 years ago
Luca Berruti
eca36953c8
Make alternatives module python 5 compatible
11 years ago
Jean-Francois Chevrette
8756612599
this should return 0 to indicate a non-failure when check_mode is True
11 years ago
Antti Salminen
a6b482c500
Switch to mapper device name if pvs returns the wrong one.
11 years ago
Carlos E. Garcia
4dcaa9d9fb
multiple spelling error changes
11 years ago
Michael Scherer
4ed4bfff90
Do not fail if we try to generate a ssh key for a user without being root
...
If we try to use the user module without being root, it fail on RHEL/Fedora
because usermod --help cannot be run. The root cause is lack of permission
due to EAL4+ certification, as seen in shadow-utils changelo.
So if we cannot run it, assume there is no append. It doesn't matter
much since we will not be able to run usermod at all with or without the
option.
11 years ago
Chris Lamb
b123b648a0
Correct/update debconf examples - need to specify vtype.
...
Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
11 years ago
Michael Scherer
cf3365b99e
Add a better error message for service
...
While migrating my playbook to a newer ansible version, I faced
the error message "unknown init system, cannot enable service". It turned
out to be caused by a wrong service name that was not expanded anymore.
So by giving the name of the service that cannot be enabled and a more precise
reason, i think people will be able to diagnose their issue more easily.
11 years ago
Hernandes B. de Sousa
780b5e0bbf
Add missing info for the append option
...
Both 'default' and 'choices' options were missing at the documentation.
11 years ago
James Cammarata
0c96e2f33b
Check to make sure the firewalld client is connected before proceeding
...
Fixes #6911
11 years ago
Jonathan Davila
a90aa46ed2
Added example demonstrating other functionality
11 years ago
James Tanner
0025273fca
Fixes syntax error in cron module caused by #6870
11 years ago
Eric Lake
58dccfbc29
Adding bold to service doc to call up state and enabled.
11 years ago
MorrisA
ac72d44219
Modified Cron to add AIX Crontab support, changed according to suggestions
...
from mpdehaan and redone entirely.
11 years ago
Serge van Ginderachter
867702b26a
lvg module bugfix on vg_options patch
...
When no vg_options are passed to the module, 'vg_options' still exists
in the module.params dict with a value of None, so the default empty string in
the get method is never used. None cannot be "splitted", which backtraced.
11 years ago
Michael DeHaan
3d8997d219
Name is not required, update docs.
11 years ago
Michael DeHaan
7258c15ce1
Merge pull request #6831 from aresch/patch-1
...
Fix _parse_value always returning 0 when not true, false or None.
11 years ago
Andrew Resch
32e5383bef
Fix _parse_value always returning 0 when not true, false or None.
11 years ago
Joshua Lund
74962a0e35
Update cron module documentation. The 'name' parameter is required.
11 years ago
Michael DeHaan
5826e1354a
Slightly revise wording.
11 years ago
Michael DeHaan
ff2177442b
Merge branch 'authorized_key-manage_dir' of git://github.com/tyll/ansible into devel
11 years ago
Michael DeHaan
4917f4a48f
Merge pull request #6810 from bob-smith/debconf-text
...
debconf detail requirements and fix typos
11 years ago
James Cammarata
57adad7097
Fix issue with sysctl parameter parsing introduced by 0e8c7b1
...
Fixes #6806
11 years ago
Michael DeHaan
05551cfe51
Merge pull request #6826 from bob-smith/debconf-parsing
...
debconf correctly quote strings
11 years ago
James Cammarata
09c998f104
Fixing some parsing issues in authorized_key module
...
Also adds an integration test for authorized_key for future validation.
Fixes #6700
11 years ago
John Barker
ed4717a978
debconf correctly quote strings
11 years ago
John Barker
e4a779d4dd
debconf detail requirements and fix typos
11 years ago
Tim G
32d48d75e9
Bugfix, fix crontab commands on HP-UX
11 years ago
Michael Scherer
ba9f910ec9
fix typo in the capabilities module description
11 years ago
Adam Nielsen
b35086c7a3
More descriptive error message if init system is unknown
11 years ago
Ahti Kitsik
74fa705e20
Bugfix for ufw to support "logging" properly:
...
It's a separate parameter so updated docs and set it as mutually exclusive param.
Also due to an array construction typo it was not working in any situation (ufw LOGLEVEL was passed to cmd instead of ufw logging LOGLEVEL).
Also fixed doc and parameters parsing typo ("choises" should be "choices")
11 years ago
Michael DeHaan
85320532d4
Rename vgoptions to vg_options.
11 years ago
Michael DeHaan
07423c1714
Merge branch 'devel' of git://github.com/chamill/ansible into devel
...
Conflicts:
library/system/lvg
11 years ago
Michael DeHaan
9fa0ec57fb
Scrub choices=BOOLEANS from remaining core module references. Correct form in argument_spec is type='dict'.
11 years ago
Michael DeHaan
073d34b40e
Merge pull request #6524 from tyll/update_rc_d_disable
...
service module: Properly disable Debian services
11 years ago
Michael DeHaan
d3d1c8ce9a
Merge pull request #6630 from bigl0af/devel
...
Modified library/system/user so that password change date is set on Sola...
11 years ago
Michael DeHaan
1e747e00e5
Merge pull request #6296 from jdauphant/devel
...
Add linux module parameters for the modprobe module
11 years ago
Cristian Ciupitu
7a4270184a
Micro-optimization: replace s.find(x)==0 with s.startswith(x)
...
timeit shows a speedup of ~1.4x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
11 years ago
Ahti Kitsik
c757b6624f
Fixed ufw module doc tags, it's reset everywhere, not reseted.
11 years ago
Seth Woodworth
21b7c358ee
adds missing `'` to debconf examples
11 years ago
Pierre-Louis Bonicoli
9a140881be
Fix ValueError when selection contains a colon
11 years ago
David Fox
01acd73e30
Modified library/system/user so that password change date is set on Solaris when updating password
11 years ago
Till Maas
35f9e62422
service module: Properly disable Debian services
...
Services on Debian need to be disabled with 'disable' instead of 'remove'
to avoid them being enabled again when 'update-rc.d $service defaults' is run,
e.g. as part of a postinst script.
11 years ago
Till Maas
a063987d0e
authorized_key: Be more specific about manage_dir
...
- Explain which properties are managed when manage_dir is True.
11 years ago
Michael DeHaan
7f36630dd5
Add capabilities module.
11 years ago
nate@bx.psu.edu
2daee9ed20
Bugfix for xattrless files and the capabilities module.
11 years ago
nate@bx.psu.edu
c19e4a7d0b
Create a capabilities module for managing Linux kernel capabilities(7) with setcap(8).
11 years ago
James Cammarata
9f9c077878
Merge branch 'issues/6341' of https://github.com/threatgrid/ansible into threatgrid-issues/6341
11 years ago
James Tanner
4028f55c04
Fixes #6519 Properly handle state=absent in sysctl module
11 years ago
Michael DeHaan
ba99056948
Version bump for alternatives module, changelog.
11 years ago
Gabe Mulley
4c132c11f7
add a module for update-alternatives
11 years ago
Michael DeHaan
29a3a1d516
Move facts to 'module_utils' so they can be referenced by other modules. Note unlike other module_utils/ dirs this keeps the original
...
license -- so usage of facts code in modules will be limited to GPLv3 modules.
11 years ago
Michael DeHaan
c914e9e462
Update setup module signature from merge commit.
11 years ago
Michael DeHaan
cac81b1ad9
Merge pull request #6339 from threatgrid/systemd-template-svc-fix
...
systemd template services must not discard template part
11 years ago
Michael DeHaan
790a38e25d
Merge conflict.
11 years ago
Michael DeHaan
201297cbfe
Merge pull request #6175 from AdmiralNemo/fix-filesystem
...
filesystem: Ignore blkid cache
11 years ago
Michael DeHaan
d4de77fd45
Merge pull request #6097 from mattjeffery/bug/modprobe_normalise_name
...
Normalise the module name when comparing against the module names in /proc/modules
11 years ago
Michael DeHaan
bf33be20e1
Merge pull request #6005 from pgehres/chkconfig
...
Adding better failure output for chkconfig failures
11 years ago
Cristian Ciupitu
a416dba3d1
hostname module: don't filter hostnamectl with awk
...
There's no need to filter hostnamectl's output with awk because its man
page says:
hostnamectl [OPTIONS...] {COMMAND}
--static, --transient, --pretty
If status is used (or no explicit command is given) and one
of those fields is given, hostnamectl will print out just
this selected hostname.
E.g. hostnamectl --static status => ansible.example.org
11 years ago
Cristian Ciupitu
7f681c33a2
Micro-optimization: replace s.find(x)!=-1 with x in s
...
timeit shows a speedup of ~3x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
11 years ago
James Tanner
59fb47ae9a
Fixes #6482 Check sysctl file path and catch read exceptions
11 years ago
Michael DeHaan
29138b1872
More shell updates
11 years ago
Richard C Isaacson
9e9f43272a
setup module: Mark unsafe commands as use_unsafe_shell=True.
11 years ago
Ryan
3494d67f30
add module param to Network & sub-classes
...
add module param to Network and sub-classes of Network, so that ansible 1.5.1 changes to LinuxNetwork apply to all Network classes.
11 years ago
Michael DeHaan
65c4e388eb
Revert "Fix issue#6430 by instantiating Network() with expected arguments"
...
This reverts commit 2a723e908e
.
11 years ago
James Laska
cb63352aff
Fix issue#6430 by instantiating Network() with expected arguments
11 years ago
Richard C Isaacson
7d83f64bae
Fix docstring issue.
11 years ago
Richard Isaacson
19d77ada25
Merge pull request #6406 from risaacson/at_module2
...
This fixes what was merged in 1.5.0.
11 years ago
James Tanner
e63e909d6f
Fix name in locale_gen docstring
11 years ago
James Tanner
4fae7da5e8
Fix snippet imports and version_added in ufw module
11 years ago
James Cammarata
6a81debb0a
Merge pull request #5518 from pyykkis/ufw
...
UFW module (another take)
11 years ago
James Tanner
820c328ca8
Set version_added for locale_gen
11 years ago
James Tanner
3763008d15
Rename locale module to locale_gen
11 years ago