Commit Graph

227 Commits (a4cddac368976f7fd7f97f5af0cf59d7fd032dfd)

Author SHA1 Message Date
jctanner 80b69c4821 Correct the handling of state=latest for yum groups. (#4141)
* Correct the handling up state=latest for yum groups.
* Use yum-deprecated when available

Fixes #4119
9 years ago
René Moser be0e6faa7b apt: fix changed when cache updated but not pkg (#5487) 9 years ago
Matt Martz 931a713350 If fetch_url failed to download the URL fail early with a proper error message. Fixes #5474 (#5476) 9 years ago
scottb 4263ef259e Merge pull request #5461 from Cbeck527/devel
Add more specific language to apt_key description
9 years ago
Matt Robinson 69e3aa12de apt_repository: Relax PPA checks and add basename (#5432)
Allow installation of PPA repositories on non-Ubuntu Debian derived
distribution targets (e.g. neon, Mint, Debian itself) by removing the
specific check for UbuntuDistribution before allowing PPA: format
sources. This fixes the addition of PPA repositories under KDE neon (as
the codenames match the base Ubuntu distribution).

To make the functionality also useful under Mint and Debian which have
different codenames to their Ubuntu upstream / downstream releases, add
a 'codename' option to override the default used in the PPA source
entry.
9 years ago
Chris Becker 258dd810e9 Add more specific language to module description and examples
* Add 'on the remote server' to `file` parameter description
* Add example showing how to use the `file` parameter, with specific
  language about the file's location being on the 'remote server'
9 years ago
jctanner 5890fba5dc apt: update cache until corrupt package lists are fixed (#5448)
* apt: If the cache object fails to lost due to a corrupt file, try to update the cache until it is fixed.
* Append -q to the update parameters
* Remove unused variable
* Use a string that doesn't rely on internationalization
* Use py24 exception style
* Use get_exception

Fixes #2951
9 years ago
Evgenii Terechkov b16e2597a4 Replace dangerous shell calls with module.run_command 9 years ago
Evgenii Terechkov bfee04d503 Ensure that we use shell
to run apt-get -y install ... >/dev/null

this commit must fix #2839
9 years ago
Toshio Kuratomi 1182d1f0b7 Order of return values was reversed 9 years ago
Toshio Kuratomi ac314a5e3d Fix builddep when a source package exists without a binary package
builddep only requires a source package to be in the repos but our code
was checking for a binary package before running buiddep.  Reversing the
order makes it work correctly.

Fixes #4519
9 years ago
Toshio Kuratomi 66d47c8149 Only change to short IDs for delete (#5353)
* Only change to short IDs for delete

If the user specifies long IDs, use them for all commands except for
deleting a key.  Need to use short IDs there because of an upstream
apt_key bug.  Fixed in apt_key 1.10 (fix is present in Ubuntu 16.04 but
not Ubuntu 14.0 or some Debians).

Fixes #5237

* Check that apt-key really erased the key

When erasing a key, apt-key does not understand how to process subkeys.
This update explicitly checks that the key_id is no longer present and
throws an error if it is.  It also hints at subkeys being a possible
problem in the error message and the documentation.

Fixes #5119

* Fix apt_key check mode with long ids

apt-key can be given a key id longer than 16 chars to more accurately
define what key to download.  However, we can use a maximum of 16
chars to verify whether a key is installed or not.  So we need to use
different lengths for the id depending on what we're doing with it.

Fixes #2622

Also:

* Some style cleanups
* Use get_bin_path to find the path to apt-key and then use that when
  invoking apt-key
* Return a nice user error message if the key was not found on the
  keyserver
* Make file and keyring parameters type='path' so envars and tilde are
  expanded
9 years ago
Filip Hubík 2d459b797f Fix incorrect line wrapping in output from yum check-updates
https://github.com/ansible/ansible-modules-core/issues/4318#issuecomment-251416661
9 years ago
Dag Wieers 20726b94be Ensure yum failures in with-loop result into a failed task
The implementation is fairly simple, we force the rc= parameter to not be zero so that the check in _executor/task_result.py_ correctly determines that it failed. Without this change Ansible would report the task to be ok (despite failed=True and msg=Some_error_message) although Ansible stops and the summary output reports a failed task.

This fixes #4214, #4384 and also relates to ansible/ansible#12070, ansible/ansible#16006, ansible/ansible##16597, ansible/ansible#17208 and ansible/ansible#17252
9 years ago
Alfredo Solano 845cc1a531 apt: doc: use yaml syntax in examples (#5070) 9 years ago
John R Barker 312f578f93 Bulk spelling improvement to modules-core (#5225)
* Correct spelling mistakes

* Correct more spelling issues

* merge conflict

* Revert typo in parms
9 years ago
John Barker 275fa3f055 Correct functional typos 9 years ago
Kevin Carter 9b2ee881d9 apt: fix cache time handling (#1517)
This change is in response to issue #1497 where the apt module would not properly updating the apt cache in some situations and never returned a state change on cache update when the module was used without or without an item to be installed or upgraded.

The change simply allows the apt module to update the cache when update_cache option is used without or without a set cache_valid_time. 
If cache_valid_time is set and the on disk mtime for apt cache is ">" the provided amount of seconds, which now has a default of 0, the apt cache will be updated. Additionally if no upgrade, package, or deb is installed or changed but the apt cache is updated the module will return a changed state which will help users to know that the state of the environment has changed due to a task operation, even if it was only an apt cache update.

fixes #1497

Signed-off-by: Kevin Carter <kevin.carter@rackspace.com>
9 years ago
Will Thames a076309a0f Check whether yum file or URL install is an upgrade (#4547)
Rather than just checking whether a package with the right
name is installed, use `local_nvra` to check whether the
version/release/arch differs too.

Remove `local_name` as it is a shortcut too far.

Fixes #3807
Fixes #4529
9 years ago
Matt Clay 683e5e4d1a Fix python 3 issues with apt* modules. (#4848)
- Use range instead of xrange.
- Use python3-apt package for python 3.
- Eliminate unsupported for/else/raise usage.
- Use list on dict.items when modifying dict.
- Update requirements documentation.

Also made non-intrustive style fixes (adding blank lines).
9 years ago
Matt Clay bf5b3de83e Python 3 fixes for apt_* modules. (#4754) 10 years ago
Alexey Sheplyakov 5f1ac88414 apt_key: fix spurious failure to import a subkey (#4366)
Importing a (sign only) subkey with apt_key module always fails,
however the actual keyring gets created and contains the correct keys.
Apparently the all_keys function skips the subkeys, hence the problem.

Fixes #4365
10 years ago
Jan Hutař 8e241a87cc Add way to specify environment (#3453) 10 years ago
Adrian Likins 5c55c6c90a Update docs and internal naming s/RHN/RHSM (#3977) 10 years ago
Adrian Likins f6ee484f33 Add 'force_register' to redhat_subscriptions (#3976)
Fixes #2448
10 years ago
Adrian Likins 8fdb068d7a Fix default perm for apt_repo files. (#4072)
Change the file mode arg to 'raw' ala file args

Following the file_common_args model, change the
type of the 'mode' arg here to type='raw' with no
default arg value.

The default mode for file creation is the module
constant DEFAULT_SOURCES_PER, and is used if no
mode os specified.

A default mode of 0644 (and not specified as int or str)
would get converted to an octal 420, resulting in the
sources file being created with mode '0420' instead of '0644'

Fixes #16370
10 years ago
Brian Coca 5380812b36 removed extra space
as pointed out by @lloydbenson
10 years ago
jctanner d6a834efa0 Cleanup unused variable in yum.py (#4009) 10 years ago
Erik Nadel abaaf3e797 apt remove now recognizes the force parameter (#3756) 10 years ago
mattymo 1f73bef856 Add retries to apt_key with keyserver, fixes #3986 (#3987)
Public SKS gpg servers frequently are unavailable, but a retry
can mitigate frequent failures.
10 years ago
jctanner 71d320ff18 Add local and url support to yum state=latest (#4003)
Fixes #3807
10 years ago
René Moser 218b44d604 apt: fix deb=file with --diff does not show diff on upgrades (#3826) 10 years ago
René Moser 4a727bc44a apt: fix KeyError for deb=file (#3816)
Fix KeyError: 'prepared' while installing dependencies using deb=<file>.deb
This error shows up when --diff was not passed by and the deb files has dependencies not yet installed.
Closes #3752.
10 years ago
Michael Scherer 75715a1b73 Convert packaging/* to py3/py2.4 syntax (#3702) 10 years ago
Matt Martz 1d87213de1 2 Module fixes (#3611)
* Fix syntax error in azure_rm_virtualmachine.py

* Allow rhn_register to fail gracefully when rhn-client-tools is not installed
10 years ago
René Moser 1f5cf669dd apt: fix always changed when using deb file on Debian 8 (#3541)
Extends d74e82a3f1e3293ffb70c172e5bb2b6e1ff6dbcc with also support
downgrade.
10 years ago
Pomin Wu f78509d0cf Fixed #3577 (#3578)
Initialize `upgradable` before use.
10 years ago
Toshio Kuratomi f3fef24e49 Some beginning python3 porting for modules which have unittests 10 years ago
Adrian Likins d83c269b82 improve redhat_subscription documentation (#3348)
* add subscription-manager's --type, --consumerid, --name option support

* redhat_subscription: More docs on consumerid
10 years ago
Michael Scherer a144663953 Fix error reporting for fetch_key (#2662)
Since fetch_url already take care of the exception, the try/except
clause is no longer working, so replace it with proper status
checking, thus permitting to remove urlib2 from the import list.
10 years ago
Jan Hutař 9ab4780b25 Add support for Satellite/Spacewalk which have slightly different API to Hosted (#3289) 10 years ago
Toshio Kuratomi f39e2343c4 Fix apt module needing another format character 10 years ago
NielsH ab699a0953 Resolve idempotency issue with virtual apt package (#3449)
Virtual packages were always marked as upgradable which caused the changed-state even though nothing changed.
10 years ago
Tobias Wolf dba53b5543 Add diff to apt.py (#2944)
for install, remove, deb_install, and upgrade.

Since apt has very commonly familiar output, just use the normal output
from apt-get or aptitude -- trimmed to the interesting parts -- to show
to the user if she specified --diff on the CLI.

Uses the recent support for the `diff['prepared]` key.

Fixes ansible/ansible#10239
10 years ago
Oleg Senin 377e94f77f Correct misspell (#3454) 10 years ago
Matt Davis 1c01e826d6 Merge pull request #3352 from gundalow/docsrh_subs
ansible-validate-modules part 3: Add copyright notice for Barnaby Court (@barnabycourt)
10 years ago
Adrian Likins 72f6238d04 Update redhat_subscriptions 'server_insecure' docs (#3373)
'server_insecure' maps to the subscription-manager config
(/etc/rhsm/rhsm.conf) value for 'insecure' key in the
'server' stanza. The 'insecure' configures if the https connection
to 'server_hostname' is verified as having been issued by
a CA in 'ca_cert_dir' trust store.

Previous documentation indicating it disables https and
enables http was inaccurate. Connection to server_hostname
always uses https.
10 years ago
John Barker 6b03f4afe6 Add copyright notice for James Laska 10 years ago
René Moser db564c9b0f Merge pull request #3283 from mscherer/fix_argument_rhn_register
Fix argument rhn register
10 years ago
René Moser 7080dd057b Merge pull request #3288 from jhutar/fix-sslcacert-for-rhn_register
Add missing parameters so these options are usable
10 years ago