Commit Graph

546 Commits (a230a3fad969fc21b55d69164b1470e86170ff39)

Author SHA1 Message Date
trbs b537aff586 Fix for #3062 additional groups should only be added once.
Also consolidated duplicate groups code into one get_groups_set() method.
Removed unused call to user_group_membership.
Removed sorting operations on set functions cause sets are inherently unordered.
Minor style improvements to match the rest of the code.

The new function will make the order of group names passed to the system command less determistic.
Which was already the case for modify_user_usermod() but not for other methods.
It will also strip out duplicate group names automatically which was not always the case previously.
12 years ago
Lorin Hochstein 8c9cceacbf authorized_key: Set manage_dir default value
This commit fixes a bug where the authorized_key module causes
the ~user/.ssh directory to be owned by root instead of the user,
when the manage_dir argument is not specified.

If the manage_dir argument was not specified, the module behaved as if
manage_dir was set to false, even though it's supposed to default to
true.

This module assumed that an optional argument, with no default
specified, will not be present in the module.params dictionary.

What actually seems to happen is that the argument does appear in
the module.params dictionary with a value of None.

The upside is that this line was evaluating to None instead of
true:

    manage_dir = params.get("manage_dir", True)

I fixed the problem in this particular module by explicitly specifying
the default value for the manage_dir arugment. But if this bug
occurred because of a change in behavior in AnsibleModule, then other
modules may be broken as well.
12 years ago
Michael DeHaan ad1a02aa55 Merge pull request #3064 from sfromm/issue2990
Verify /proc/modules is readable (issue #2990)
12 years ago
Stephen Fromm 00b3a450c7 Verify /proc/modules is readable (issue #2990) 12 years ago
Stephen Fromm 3127bab6d6 Use get_bin_path to find mkfs command (issue #2983) 12 years ago
Chris Gardner 2b71ab6765 Fix typo. Solaris 9 should now correctly ignore 'brand' and use 'implementation'. 12 years ago
Chris Gardner 88115f4ab2 TODO: Separate IPv4 and IPv6 12 years ago
Jiří Kubíček 5cb0525430 Add some FreeBSD facts
added:
 * ansible_distribution
 * ansible_distribution_release 
 * ansible_distribution_version
 * ansible_os_family
 * ansible_pkg_mgr
 * ansible_ssh_host_key_ecdsa_public

Also adds ECDSA public key for all plaforms.
12 years ago
Chris Gardner 6809b56233 Add Solaris network facts. IPv6 details overwrite IPv4 per interface, needs further work. 12 years ago
Chris Gardner f482649cbb Add clock speed to processor description for SPARC CPU. 12 years ago
Chris Gardner 68959e7f92 Use 'implementation' if 'brand' not available (Solaris 9). Add CPU socket/core counting. 12 years ago
Michael DeHaan a581077b4d Merge branch 'facter-fix' of git://github.com/flyapen/ansible into devel 12 years ago
Guillaume Lasmayous 1c0e01a72b Implement NetBSD-specific subclass of Hardware in the setup module.
Defines memory and CPU facts:
- memfree_mb
- memtotal_mb
- swapfree_mb
- swaptotal_mb
- processor (a list)
- processor_cores
- processor_count
- devices

As a matter of fact, on NetBSD, it is possible to get memory, swap and
processor facts exactly as on Linux. Tested on NetBSD-5, NetBSD-6 and
NetBSD-6.1 (without Linux emulation).
12 years ago
Chris Gardner 9ca7165f88 Use kstat for Solaris CPU info 12 years ago
Chris Gardner 66c10410ec Use kstat for Solaris CPU info 12 years ago
Kristof Keppens c5b40ca2ff change fix to lookup path with get_bin_path 12 years ago
Michael DeHaan 698b2fe9c5 Merge pull request #2992 from SirScott/service_pattern
Fixes #2991: Service module pattern argument ignored.
12 years ago
Scott Sturdivant 922a1efbc0 Fixes #2924: User creation always reports 'changed' 12 years ago
Scott Sturdivant b274fb9774 Fixes #2991: Service module pattern argument ignored. 12 years ago
Kristof Keppens e2e10c1977 fix for facter being installed in a different location 12 years ago
Elan Ruusamäe d3a2b1dbbb no need to init None to None 12 years ago
Michael DeHaan 328065506e Merge pull request #2941 from bcoca/setup_bin
no uses get_bin_path for 2nd use of ip tool
12 years ago
Michael DeHaan 39673fe8c0 Merge pull request #2940 from madema/patch-3
-o and -r option don't exist on AIX
12 years ago
Ton Kersten 8926684942 Fix issue 2906 12 years ago
Brian Coca 8d6e18fc90 no uses get_bin_path for 2nd use of ip tool (fixes reported issue with openwrt)
module needs this added to many tool invokations, but his is a start
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
madema 58d59c180d -o and -r option don't exist on AIX 12 years ago
Michael DeHaan 6b4f09d7dc Style fix. 12 years ago
Michael DeHaan 584508dda6 Merge pull request #2866 from madema/patch-2
Fixed an error in the get_cpu_facts of the AIX class
12 years ago
Michael DeHaan dab846a631 Merge pull request #2865 from madema/patch-1
Added AIX class in the service module to control AIX SRC processes.
12 years ago
Michael DeHaan 53db51a0a2 Merge pull request #2863 from lonerr/freebsd-group
FreeBSD group operations is now supported properly.
12 years ago
Michael DeHaan cb54922bcd Merge pull request #2862 from lonerr/freebsd-user
Fixed errors in FreeBSD user manipulations.
12 years ago
Michael DeHaan 67e67bca1f Change filesystem module message. 12 years ago
Michael DeHaan 63e510a632 Merge pull request #2853 from abulimov/module_mkfs
Module filesystem
12 years ago
Elan Ruusamäe 6949a9fbe4 LinuxService: avoid enforcing systemd even if init.d script was found 12 years ago
madema 02e41f3e56 Update service 12 years ago
madema cf4dbf1f40 Fixed an error in the get_cpu_facts of the AIX class
assumed proc0 as the first processor but can be different in a LPAR environment
12 years ago
madema f7c3b73336 Added AIX class in the service module to control AIX SRC processes. 12 years ago
lonerr dcb22d1760 FreeBSD group operations is now supported properly. 12 years ago
lonerr b2db6483ac Fixed errors in FreeBSD user manipulations. 12 years ago
Oleg 3531fbdb29 fix for authorized_key: skip chown and chmod if authorized_key_file is link 12 years ago
Alexander Bulimov f4de40fc43 renamed mkfs and moved to system/filesystem 12 years ago
Luciano Cavalheiro da Silva d18d2de18e Fix #2836. Ensure proper handling of option "system=yes" in module "group". 12 years ago
rektide 4f21dc4cd1 Duplicate pull #2803 in ipv6, fixing setup module's handling of venet & unknown interface types. 12 years ago
Michael DeHaan 2cf30148ba Test for the existance of a file that might not be present on older RHEL. 12 years ago
James Mills efc5a83f66 Fixed setup module to accomodate venet interfaces (OpenVZ) 12 years ago
Michael DeHaan 391fb98ee2 Allow modules to be categorized, and also sort them when generating the documentation. 12 years ago