Ganesh Nalawade
e14e37ee1e
Fix junos unit test failures ( #26676 )
...
* Use lxml api's in unit test to parse xml
* Remove unwanted import in unit test
* Add ncclient dependency in unit test requirement
7 years ago
Peter Sprygada
0b6f0e6c0d
adds more intelligent save logic and diff to network config modules ( #26565 )
...
* adds more intelligent save logic and diff to network config modules
* adds sha1 property to NetworkConfig
* adds new argument save_when to argument_spec
* adds new argument diff_against to argument_spec
* adds new argument intended_config to argument_spec
* renames config argument to running_config with alias to config
* deprecates the use of the save argument
* before and after now work with src argument
* misc module clean
Modules updated
* nxos_config
* ios_config
* eos_config
Most notably this makes the save mechanism more intelligent for config
modules for devices that need to copy the ephemeral config to
non-volatile storage.
The diff_against argument allows the playbook task to control what the
device's running-config is diff'ed against. By default it will return
the diff of the startup-config.
* removes ios_config from pep8/legacy_files.txt
* extends the ignore lines argument to the module
* clean up CI errors
* add missing list brackets
* fixes typo
* fixes unit test cases
* remove last line break when returning config contents
* encode config string to bytes before hashing
* fix typo
* addresses feedback in PR
* update unit test cases
7 years ago
Ricardo Carrillo Cruz
b81209c187
Fix multiple EOS EAPI code and test issues ( #26651 )
7 years ago
Ganesh Nalawade
be89ef3eb6
junos_linkagg implementation and junos modules refactor ( #26587 )
...
* junos_linkagg implementation and junos modules refactor
* junos_linkagg implementation
* junos_linkagg integration test
* net_linkagg integration test for junos
* decouple `load_config` and `commit` operations,
to allow single commit (in case on confirm commit) and
to perform batch commit (multiple `load_config` followed by single
`commit`)
* Other related refactor
* Fix CI issues
* Fix unit test failure
7 years ago
James Mighion
58ade65ea6
Adding admin option for iosxr_config ( #26509 )
...
* Adding admin option for iosxr_config. Adding unit test for new admin option for iosxr_config. Fixes #24308
* Removing space on empty line.
7 years ago
Trishna Guha
07498ebed3
fix nxos_overlay_global ( #26422 )
...
* fix nxos_overlay_global
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* swap check_mode with candidate
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
7 years ago
Trishna Guha
b81882e2a8
vyos_static_route implementation module ( #26426 )
...
* vyos_static_route implementation module
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add vyos_static_route implementation module
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* unit test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* modify vyos_static_route
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* integration test vyos_static and net_static_route
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix typo integration test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* modify vyos_static_route
* modify integration test
* vyos_static_route doc build fix
* fix integration test data
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* update net_static_route cli test set
* minor fix
7 years ago
Tim Rupp
37ca55bf71
Adds missing fields for iapp service ( #26507 )
...
The iApp service module worked fine previously, but this patch
adds enhancements to it to include more fields that can be
specified when creating iapp services.
7 years ago
Trishna Guha
c5fb4bbcc0
Fix nxos_switchport and unit test ( #26131 )
...
* fix nxos_switchport
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* nxos_switchport unit test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* legacy file
* update unit test
* handle exception
7 years ago
saichint
5229370364
fix for nxos_acl_interface idempotency ( #26156 )
...
* fix for nxos_acl_interface idempotency
* shippable error fix
* fix issues with python3.x
7 years ago
Trishna Guha
ad3fe08aae
fix vyos_banner multiline string issue ( #26383 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
7 years ago
Trishna Guha
1b427aa419
Fix vyos banner idempotent ( #26338 )
...
* fix vyos_banner idempotent
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix vyos_banner unit test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
7 years ago
Trishna Guha
93bbcd8a32
vyos_user fix idempotent ( #26289 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
7 years ago
Nathaniel Case
3102746ebe
nxos_pim_rp_address fixes ( #26119 )
...
* nxos_pim_rp_address tests
* nxos_pim_rp_address changes
* Address issues with idempotence
7 years ago
Nathaniel Case
ad6c4a544e
nxos_pim updates ( #26145 )
...
* nxos_pim tests
* Cleanup nxos_pim
8 years ago
Nathaniel Case
eea18e9875
nxos_vxlan_vtep_vni fixes ( #25913 )
...
* nxos_vxlan_vtep_vni first pass
* nxos_vxlan_vtep_vni tests
8 years ago
Tim Rupp
e7402e3d5b
Support full path templates ( #26121 )
...
This patch allows the iapp service module to support full path
templates instead of only relative templates
8 years ago
Tim Rupp
04ac15f241
Adds bigip_qkview module ( #25980 )
...
This module can be used to generate qkviews on a bigip and
save them to a location on the ansible controller.
This module is primarily used for diagnostics.
Unit tests are provided. Integration tests can be found here
https://github.com/F5Networks/f5-ansible/blob/devel/test/integration/bigip_qkview.yaml#L23
https://github.com/F5Networks/f5-ansible/tree/devel/test/integration/targets/bigip_qkview/tasks
8 years ago
Tim Rupp
16bd93a14e
Refactors bigip ssl cert module ( #25882 )
...
Includes unit tests and a refactor of the module to make code
more easily supported. Also fixes an issue where the extension of
the cert name was not appended if not provided. This problem was
causing certs to not be editable in the UI. Also deprecates params.
Unit tests are provided. Integration tests can be found here
https://github.com/F5Networks/f5-ansible/blob/devel/test/integration/bigip_ssl_certificate.yaml#L23
https://github.com/F5Networks/f5-ansible/tree/devel/test/integration/targets/bigip_ssl_certificate/tasks
8 years ago
George Nikolopoulos
11836a0296
Add module netscaler_cs_action ( #26147 )
8 years ago
Trishna Guha
34eca3816d
fix vyos_user configuration ( #26166 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
8 years ago
George Nikolopoulos
6bed831f8c
Add netscaler_server module ( #25537 )
8 years ago
Nathaniel Case
3d6d428bbc
Test multiple nxos versions at once ( #25595 )
...
* Extend tests to have multiple device representations
* Move filepath munging to nxos_module
* Device needs to be kwarg so we can leave it off
* Update other nxos tests
* Update tests that fell through
8 years ago
George Nikolopoulos
0bf64aa241
Add netscaler_save_config module ( #25614 )
8 years ago
Nathaniel Case
21c7fcf9c0
nxos_vxlan_vtep ( #25971 )
...
* nxos_vxlan_vtep tests
* Fix issues with nxos_vxlan_vtep
8 years ago
Trishna Guha
3482a6326b
Fixes nxos_vpc_interface ( #25907 )
...
* nxos_vpc_interface fix
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* nxos_vpc_interface unit test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix state_present
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* add state_present unit test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* make ansibot happy
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* teardown get_config
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
8 years ago
Nathaniel Case
0296c2285b
nxos_vrf fix ( #25812 )
...
* Fixes #25031
* Slight cleanup and add tests
8 years ago
Trishna Guha
947e9aba45
Add vyos_banner implementation module ( #25862 )
...
* Add vyos_banner implementation module
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* vyos_banne integration test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* vyos_banner unit test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* minor fix on banner text
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
8 years ago
Tim Rupp
0854c0ed88
Adds refactored bigip_hostname ( #25841 )
...
This adds a refactored bigip_hostname with unit tests and code
conventions that are common across other modules.
Unit tests are provided. Integration tests can be found here
https://github.com/F5Networks/f5-ansible/blob/devel/test/integration/bigip_hostname.yaml#L23
https://github.com/F5Networks/f5-ansible/tree/devel/test/integration/targets/bigip_hostname/tasks
8 years ago
Tim Rupp
59d470ae84
Adds bigip_iapp_service module ( #25808 )
...
This module allows a user to manage the iApp services on a bigip
that they created using the bigip_iapp_template module.
Unit tests are provided. Integration tests can be found here
https://github.com/F5Networks/f5-ansible/blob/devel/test/integration/bigip_iapp_service.yaml#L23
https://github.com/F5Networks/f5-ansible/tree/devel/test/integration/targets/bigip_iapp_service/tasks
8 years ago
Nathaniel Case
a38e727380
nxos_nxapi fix ( #25306 )
...
* Add nxos_nxapi tests
* Simple changes to nxos_nxapi
* Move validation to check_args
* Don't mark protocol change unless change is requested
* Add different regex to handle HTTP{,S} ports on a different version of nxos
8 years ago
Tim Rupp
c51b73d800
Makes all unit tests look the same ( #25762 )
...
Just a little cleanup from an earlier patch that makes f5 unit
tests only run if the f5 sdk is installed
8 years ago
Trishna Guha
98269888a9
iosxr_banner Implementation module ( #25744 )
...
* Add iosxr_banner implementation module
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Integration test for iosxr_banner
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Unit test for iosxr_banner
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* remove blank line pep8
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
8 years ago
Trishna Guha
44687bb917
Add iosxr_user implementation module ( #25615 )
...
* Add iosxr_user implementation module
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* iosxr_user Integration test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* iosxr_user Unit test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Modify integration test with idempotent case
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
8 years ago
Trishna Guha
b3c22a96bd
Add vyos_user implementation module ( #25677 )
...
* Add vyos_user implementation module
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Integration test for vyos_user
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Make state absent work
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Unit test for vyos_user
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Standardize user names
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Modify integration test with idempotent case
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add role as alias to level
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
8 years ago
Trishna Guha
9c6ee8d0bb
Add nxos_banner implementation module ( #25695 )
...
* Add nxos_banner implementation module
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* nxos_banner integration test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* nxos_banner unit test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* doc update
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
8 years ago
Brian Coca
342a85d33f
fixed again
8 years ago
Brian Coca
83703e3137
skip f5 tests when f5 lib not installed
8 years ago
Tim Rupp
8e3ef4b052
Adds virtual_address module ( #25728 )
...
This module lets users manage a number of different config options
for Virtual Addresses on a BIG-IP.
Unit tests are provided. Integration tests can be found here
https://github.com/F5Networks/f5-ansible/blob/devel/test/integration/bigip_virtual_address.yaml#L23
https://github.com/F5Networks/f5-ansible/tree/devel/test/integration/targets/bigip_virtual_address/tasks
8 years ago
Tim Rupp
b85785bf07
Refactors irule module to conform to recent standards ( #25709 )
...
Also includes unit tests for the code
8 years ago
Tim Rupp
ba12ce64b0
Adds the bigip_snmp module ( #25668 )
...
This patch adds a module for managing several snmp related settings
on a BIG-IP that are required when configuring the range of SNMP
settings on a device.
Unit tests are provided. Integration tests can be found here
https://github.com/F5Networks/f5-ansible/blob/devel/test/integration/bigip_snmp.yaml#L23
https://github.com/F5Networks/f5-ansible/tree/devel/test/integration/targets/bigip_snmp/tasks
8 years ago
Tim Rupp
478d364f4d
Adds bigip_iapp_template module ( #25630 )
...
This module can be used to upload and manage TCL iApps on a BIG-IP.
iApps can be added, removed and updated in place as needed. iApp
files should be provided to the module via Ansible lookups.
Unit tests are provided. Integration tests can be found here
https://github.com/F5Networks/f5-ansible/blob/devel/test/integration/bigip_iapp_template.yaml#L23
https://github.com/F5Networks/f5-ansible/tree/devel/test/integration/targets/bigip_iapp_template/tasks
8 years ago
Tim Rupp
0c68e200d5
Adds the bigip_provision module to Ansible ( #25558 )
...
This module allows an administrator to provision new module functionality
on a BIG-IP. BIG-IP modules provide enhanced ADC and security features that
are commonly used by customers such as GTM, ASM, and AFM.
Unit tests are provided. Integration tests can be found here
https://github.com/F5Networks/f5-ansible/blob/devel/test/integration/bigip_provision.yaml#L23
https://github.com/F5Networks/f5-ansible/tree/devel/test/integration/targets/bigip_provision/tasks
8 years ago
Nathaniel Case
4344132a7d
nxos_vpc updates ( #25452 )
...
* Add nxos_vpc tests
* Split execute-show between get_config and run_commands
8 years ago
Tim Rupp
61684f7313
Updates gtm wide ip module to be feature complete ( #25502 )
...
This module is used to manage GTM wide ips on a bigip.
Previously, this module only included a small subset of functionality
primarily related to editing a wide ip that already existed. Additionally
it used the SOAP api for its communication. this patch completes the
feature set of wide ips and refactors the code to use the F5 python SDK
and the REST API.
Unit tests are provided. Integration tests can be found here
https://github.com/F5Networks/f5-ansible/blob/devel/test/integration/bigip_gtm_wide_ip.yaml#L23
https://github.com/F5Networks/f5-ansible/tree/devel/test/integration/targets/bigip_gtm_wide_ip/tasks
8 years ago
Trishna Guha
91e5fce90f
Add ios_user implementation module ( #25413 )
...
* Add ios_user module
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Integration test for ios_user
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add unit test for ios_user
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
8 years ago
George Nikolopoulos
a00089c341
New module: manage Citrix Netscaler service configuration (network/netscaler/netscaler_service) ( #25129 )
...
* netscaler_service initial implementation
* Changes as requested by reviewers
* Skip some tests if under python2.6 and importing requests library
* Change option "operation" to "state"
* Remove print statements from netscaler module utils
* Catch all exceptions during login
* Fix fail message
* Add common option save_config
8 years ago
Brian Coca
745f72916f
bigip tests now skipped if missing lib
8 years ago
Tim Rupp
6f2c543a33
Updates and refactors the bigip pool module to use REST ( #25234 )
...
This patch updates the bigip_pool module to use F5's REST API
as well as includes unit tests.
Unit tests are provided. Integration tests can be found here
https://github.com/F5Networks/f5-ansible/blob/devel/test/integration/bigip_pool.yaml#L23
https://github.com/F5Networks/f5-ansible/tree/devel/test/integration/targets/bigip_pool/tasks
8 years ago
Tim Rupp
855fd98be6
Adds the bigip_config module to Ansible ( #25191 )
...
This patch adds the bigip_config module to Ansible to support
merging SCF files, saving running configs, resetting config
and validating SCF configs
8 years ago
Nathaniel Case
f52dcef7ba
Actually check for equality on empty commands array ( #25308 )
8 years ago
Tim Rupp
0133a5a763
Adds the bigip_gtm_pool module ( #25275 )
...
This module is used to manage GTM(DNS) pools in a BIG-IP.
Unit tests are provided. Integration tests can be found here
https://github.com/F5Networks/f5-ansible/blob/devel/test/integration/bigip_gtm_pool.yaml#L23
https://github.com/F5Networks/f5-ansible/tree/devel/test/integration/targets/bigip_gtm_pool/tasks
8 years ago
Trishna Guha
343b83041e
nxos_feature fix and unit test ( #25200 )
...
* nxos_feature fix
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* nxos_feature unit test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* remove from pep8/legacy-file
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
8 years ago
Trishna Guha
fb87680046
fix state present nxos_evpn_vni ( #25212 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
8 years ago
Nathaniel Case
53837c2ab0
Assorted nxos_bgp_* fixes ( #25080 )
...
* Simplify apply_key_map
* Fix nxapi
* Clean up get_value
* Fix missing non-values
* Add test for existing bgp_af case
* Fix small issues with bgp_neighbor_af
8 years ago
Dag Wieers
4efec414e7
test/: PEP8 compliancy ( #24803 )
...
* test/: PEP8 compliancy
- Make PEP8 compliant
* Python3 chokes on casting int to bytes (#24952 )
But if we tell the formatter that the var is a number, it works
8 years ago
Trishna Guha
31c59ad5f9
nxos_portchannel fix and unit test ( #25019 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
8 years ago
Nathaniel Case
8985f7c930
nxos_static_route updates ( #24992 )
...
* Add static_route tests
* Add VRF tests
8 years ago
Trishna Guha
6a3ce18e4b
add more testcases for nxos_evpn_vni ( #24996 )
8 years ago
Tim Rupp
6ef022b034
Adds the bigip_snmp_trap module to Ansible ( #24848 )
...
This patch adds the bigip_snmp_trap module to Ansible to support managing
SNMP trap destinations on an F5 BIG-IP.
8 years ago
Nathaniel Case
dd4a79d7d3
Clean up nxos_bgp_neighbor_af ( #24890 )
...
* Fix pep8 in bgp_neighbor_af
* Remove WARNINGS
* Rewrite command detection
* Add bgp_neighbor_af test
* Finally kill invoke
8 years ago
Tim Rupp
4fc40304d5
Adds the bigip_command module to Ansible ( #24850 )
...
This patch adds the bigip_command module to Ansible to support arbitrary
tmsh command to a F5 BIG-IP.
8 years ago
Ricardo Carrillo Cruz
b12beca3ed
Refactos nxos_ip_interface module ( #24885 )
8 years ago
Trishna Guha
1e5a0982b9
Fix nxos_hsrp and add unit test ( #24770 )
...
* nxos_hsrp fix
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* unit test nxos_hsrp
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* ansibot told me to do this
* revert apply_key_map and simplify method
8 years ago
Tim Rupp
22e096f911
Changes skip test for bigip user ( #24799 )
...
All of the F5 Ansible modules will come to require the same major
dependencies over time. This mentions that.
8 years ago
Trishna Guha
998305a493
nxos_ospf_vrf fix and unittest ( #24495 )
8 years ago
Tim Rupp
c1397626fc
Adds the bigip_user module to Ansible ( #24753 )
...
The patch adds the bigip_user module to Ansible to support managing
users on an F5 BIG-IP.
Unit tests are provided. Integration tests can be found here
* https://github.com/F5Networks/f5-ansible/blob/devel/test/integration/bigip_user.yaml
* https://github.com/F5Networks/f5-ansible/tree/devel/test/integration/targets/bigip_user/tasks
8 years ago
Trishna Guha
8937246f8f
Fix nxos ospf and Unit test ( #24613 )
...
* nxos_ospf fixes refactor
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* unit test nxos_ospf
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
8 years ago
Ganesh Nalawade
f5d865a208
Fixes #24251 save config only if it is changed ( #24345 )
...
* Fixes #24251 save config only if it is changed
Save to startup configuration only when it is different
from running configuration.
* Fix unit test issue
8 years ago
Nathaniel Case
f240ba6b60
nxos_bgp_neighbor cleanup ( #24446 )
8 years ago
Trishna Guha
b2a2f69a6e
nxos_vrf_af fix and unit test ( #24399 )
...
* nxos_vrf_af fix and unit test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* ansibot told me to do this
* use sorted() as the test list elements differ in order for python2.x and 3.x
8 years ago
Trishna Guha
62eafa8837
fixes nxos_evpn_vni and unittest ( #24372 )
...
* fixes nxos_evpn_vni
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fixes pep8 issue and syntax error
* ansibot tole me to do this
* Unit test
8 years ago
Nathaniel Case
09b2964dee
nxos_bgp_af updates ( #24171 )
...
* update docs
* clean up nxos-bgp_af
* Remove useless params from bgp_af
* Add bgp_af tests
8 years ago
Nathaniel Case
830f19d444
nxos_bgp updates ( #24270 )
...
* Remove invoke from nxos_bgp
* Try to simplify get_existing
* Streamline state_present
* More testing, squash & compact get_value & get_custom_value
* Streamline main
* nxapi has problems reading CustomNetworkConfig directly
8 years ago
Trishna Guha
ad0a01ffb5
nxos_vrf refactor ( #24280 )
...
* nxos_vrf refactor
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Unit test for nxos_vrf
Remove unnecessary keys() method
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
8 years ago
Ganesh Nalawade
0e756a1cf9
Add junos unit test case ( #24249 )
...
* Add junos modules unit test case
* Fix CI issues
8 years ago
Ricardo Carrillo Cruz
7195c31753
Refactor openvswitch_port module ( #24205 )
...
Use current patterns from other network modules for better
maintainability.
8 years ago
Ricardo Carrillo Cruz
467a9bdd4e
Refactor openvswitch_bridge ( #24014 )
...
Use common patterns from other network modules for better
maintainability.
8 years ago
Trishna Guha
2741907cba
Refactor nxos_interface and add unit test ( #24008 )
...
* [WIP] Refactor nxos_interface
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Modification in refactor
Unittest for nxos_interface
8 years ago
Nathaniel Case
fc0bf87c20
Run `save` inside config mode. ( #23977 )
...
* Run `save` before exiting config mode.
* Fix unit tests for `save`
* Allow `save` to be on its own again and introspect success
* Introspecting `compare running` makes this a lot harder.
Move `save` tests to integration tests
8 years ago
Ganesh Nalawade
9c4daded94
Add junos_config unit test ( #24005 )
8 years ago
Ricardo Carrillo Cruz
2716fad38f
Return commands instead of command ( #24061 )
...
Ok, so for openvswitch_db in particular we just return one command
but in the sake of consistency and code re-use, let's return a list
of "commands", even if it's just one.
8 years ago
Ricardo Carrillo Cruz
7c1b8da1a1
Refactor openvswitch unit tests ( #24055 )
...
Rather than passing a file to load fixture, build a matrix containing
the run_command side_effect per test.
This will allow more code-reuse for other ovs modules unit tests.
8 years ago
Nathaniel Case
0d67a49d5a
nxos_bgp fixes ( #23927 )
...
* Pre-emptively fix sanity/pep8
* fix for commands
* Quick unit test
8 years ago
Nathaniel Case
c0ebdf144d
nxos_acl_interface fixes ( #23917 )
...
* Update nxos_acl_interface
* Add basic unit tests to nxos_acl_interface
8 years ago
Nathaniel Case
f0914ee3c2
nxos_acl fixes ( #23915 )
...
* Update nxos_acl
* unit tests for nxos_acl
* Remove nxos_acl from pep8-legacy
8 years ago
Ricardo Carrillo Cruz
a3a970180a
Unit tests for openvswitch_db module ( #23974 )
8 years ago
Ganesh Nalawade
1cdfcf0bb9
Add junos_command module unit test ( #23819 )
...
* Add junos_command module unit test
8 years ago
Ricardo Carrillo Cruz
60de93c31d
Add assertion on test_iosxr_facts ( #23852 )
...
We hit bug #23737 due to bad coverage on test_iosxr_facts, we
were not checking memory facts at all.
8 years ago
Nathaniel Case
0b4cebfb8b
nxos_vlan tweaks ( #23194 )
...
* Remove commented code
Remove a lot of unnecessary output
* Tests
* Sort vlan ids _after_ running set operations, so order is not lost
8 years ago
Peter Sprygada
f0008248d4
fix iosxr commands to encode json ( #23346 )
...
the command dict in the iosxr module_utils wasn't encoding the request
to json. this patch will fix that problem
8 years ago
Ricardo Carrillo Cruz
98c98125f0
Fallback to show-run on ios_banner for devices where show banner does not work ( #22793 )
...
On switches 'show banner' command doesn't work, fallback to show run|begin banner
and extract the banner text in case that fails.
8 years ago
Ricardo Carrillo Cruz
6e56a61535
Add ios_banner module ( #22687 )
...
With unit and integration tests.
8 years ago
Ricardo Carrillo Cruz
604a38cac1
Implement eos_banner for EAPI ( #22609 )
...
On EAPI, the multi-line commands are expected to be a dict,
with key/value pairs 'cmd'/'input' .
This change implements that behaviour and fixes the idempotency
on EAPI as well.
Fixes #22494
8 years ago
Peter Sprygada
3f0f7c4f4e
updates junos shared lib and action handler ( #22541 )
...
* removes cli functions from shared lib
* adds cli functions to junos_netconf module
* statically pins junos_netconf to cli transport
* all other modules use netconf transport
* adds command rpc function to junos shared
8 years ago
Ricardo Carrillo Cruz
c57729944b
Fix the eos_banner idempotency ( #22413 )
...
The map_config_to_obj calls the run_commands helper function,
which returns a list of results.
However, the map_params_to_obj return a single string.
Therefore, the comparison between the two datasets could never be equal,
breaking idempotency.
Also, the 'no banner' command should be run on absent only if there's a banner
text set.
Fixes #22194
8 years ago
Peter Sprygada
6c8025ce5c
adds eos_system integration tests ( #22214 )
...
* adds integration test cases
* updates eos_system with minor bug fixes
8 years ago
Matt Clay
a5e3d13adc
Remove shebangs from unit tests.
8 years ago
Peter Sprygada
216877c6ca
adds system_mtu argument to nxos_system ( #21970 )
...
* updates argument_spec
* adds unit test case
8 years ago
Peter Sprygada
10b23f3a00
adds unit test cases for nxos_command ( #21959 )
8 years ago