Commit Graph

45774 Commits (9fc710f6570aebd4ed877bbaf985738f2be0bfe0)
 

Author SHA1 Message Date
plastikat 88c0907fed rabbitmq_user: Handle non-zero exit codes (#56164) (#57738)
When provided with a wrong password `rabbitmqctl
authenticate_user` returns a non-zero exit code
(65). This seems to be unexpected by the module and
it fails when `update_password` is set to 'always'.

To mitigate this behavior we augment the `_exec`
method by adding a `check_rc` flag (which defaults
to `True`, hence it's backward-compatible) and
override it when we need it (in `check_password`
method to address #56164).
5 years ago
René Moser f2cc447b4d
dnsimple: fix missing defaults and doc (#58116)
* dnsimple: fix missing defaults and doc

* fix sanity
5 years ago
Abhijeet Kasurde 7d6f417f32 Multiple minor fixes (#58374)
* Documentation update
* Typo fixes
* fail_json fixes

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
5 years ago
Pilou 77e01e6abc tower_role: ensure alias of "validate_certs" parameter is handled (#57518)
* tower_role: ensure alias of validate_certs is handled

* tower modules: remove tower_verify_ssl alias too

Error was:

    Failed to update role: The Tower server claims it was sent a bad request.
    GET https://tower/api/v2/projects/22/object_roles/
    Params: [('tower_verify_ssl', False), ('role_field', 'admin_role')]
    Data: None
    Response: {"detail": "Role has no field named 'tower_verify_ssl'"}

Full traceback:

    File "/tmp/ansible_tower_role_payload_7_2p0X/__main__.py", line 145, in main
      result = role.grant(**params)
    File "/usr/local/lib/python2.7/dist-packages/tower_cli/resources/role.py", line 365, in grant
      return self.role_write(fail_on_found=fail_on_found, **kwargs)
    File "/usr/local/lib/python2.7/dist-packages/tower_cli/resources/role.py", line 242, in role_write
      fail_on_multiple_results=True, **data)
    File "/usr/local/lib/python2.7/dist-packages/tower_cli/models/base.py", line 301, in read
      r = client.get(url, params=params)
    File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 546, in get
      return self.request('GET', url, **kwargs)
    File "/usr/local/lib/python2.7/dist-packages/tower_cli/api.py", line 299, in request
      kwargs.get('data', None), r.content.decode('utf8'))
5 years ago
Matt Clay 5e4f457a47
Fix incorrect assumptions in integration tests. (#58372)
* Fix service integration test.

Set the proper file mode when copying before asserting the mode is correct.

* Fix certificate_complete_chain test.

Do not assume that testhost is the same as localhost.
5 years ago
Tim Rupp 46214c9ef4
Replaces #16690 (#58369)
Adding integration tests for testing the 'mode' arg of the apt_repository module
5 years ago
Matt Clay d5542afd97 Properly enforce shebang on collections. 5 years ago
Matt Clay 013b0039ba
Fix incorrect assumptions in integration tests. (#58365)
* Fix nested template test.

There were two issues with the previous implementation:

1. The LOGNAME environment variable may not be set.
2. The comparison assumed that testhost is localhost.

* Fix variable display for cartesian lookup test.

* Fix vars list test.

The test assumed that the ansible_user variable is always set,
which is not guaranteed when using connections other than local.

* Fix supervisorctl integration test.

Use ansible_user_id instead of ansible_user since ansible_user
is not guaranteed to be available when the connection is not local.

* Fix file integration test.

Use ansible_user_id instead of ansible_user since ansible_user
is not guaranteed to be available when the connection is not local.

* Fix expect integration test.

Do not assume module_utils is available for utility scripts.

* Fix python_requirements_info integration test.

Check for pip instead of ansible, since ansible is not guaranteed
to be installed when using a connection other than local.

* Fix ansible-runner integration test.

Use implicit localhost to run the test since it requires access
to the ansible installation currently being tested.

* Fix tower_common integration test.

Accept errors on stdout or stderr.

* Fix tower_user integration test.

Recognize errors on stdout or stderr.
5 years ago
Sviatoslav Sydorenko c604e347b2 Skip podman_container integration tests @ RHEL8b (#58363) 5 years ago
Sagi Shnaidman f01468a9d9 Add podman container module to ansible
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
5 years ago
ShachafGoldstein 65b0e1425b win_pagefile - Fix idempotency when same settings as current (#57893)
* win_pagefile - Fix idempotency when same settings as current

* Fix tests and code

* Fix problem with system managed

* Fix again systemmanaged detection

* Change check of systemmanged in creation

* Fix readability and wrong flag for test
5 years ago
jcastilloixl 5e2451c1a8 Update net_interface.py (#58350)
typo in example command -- net_interface module accidentally listed as junos_interface
5 years ago
René Moser 360a9f1a68
exoscale: exo_dns: fix sanity checks (#58312) 5 years ago
Strahinja Kustudic 7fd10d821c Add service_account_contents parameter to allign with the modules (#57848) 5 years ago
John R. Dennis 0a5a74f192 Install hidden galaxy data files (e.g. .travis.yml) (#56005)
The package_data globs in setup.py were missing the necessary glob
to install:

galaxy/data/default/.travis.yml

A Python glob pattern will not by default match a hidden file
(i.e. a file basename beginning with a dot). If you want a glob
to pick up a hidden file in a directory you must explicitly specify
a glob pattern with "/.*".

Closes: #1777
Signed-off-by: John Dennis <jdennis@redhat.com>
5 years ago
Fred-sun 42a831d42c Update azure_rm_sqlserver related document (#58267)
* Update azure_rm_sqlserver related documentation
5 years ago
Fred-sun bb2c7cf57d Update azure_rm_sqlfirewallrule related document (#58265)
* Update azure_rm_sqlfirewallrule related documentation
5 years ago
Matt Martz e32d60bbcd
Add back _contains_vars method as maybe_template (#58290)
* Add back _contains_vars method as maybe_template. Fixes #58282

* Remove template guard in a few places

* maybe_template sounds like it might template something, rename to is_possibly_template

* Add tests for is_possibly_template
5 years ago
Matt Martz f5b9bd81fc
gather_facts is core (#58341) 5 years ago
Matt Martz bc25ac20e1
Set _ansible_verbose_override in gather_facts action plugin. Fixes #58310 (#58339) 5 years ago
Sam Doran 18d713e6d5 Use Mapping rather than dict when evaluation 'options' (#58215) 5 years ago
Martin Krizek 9069a681aa sysctl: fix 'err' referenced before assignment (#58161)
* sysctl: fix 'err' referenced before assignment

Fixes #58158

* Add changelog
5 years ago
Will Thames a09aa205e1 Fix RDS test suite and minor bugs revealed (#57940)
* Update testing policy to be correct for RDS test suite
* Create read replica in same region to avoid more permissions being
  required
* Ensure modifying DB doesn't try to downgrade engine version
* Add tags to main test suite to limit number of tests run for problem
  solving
5 years ago
Tim Rupp 48af9bdfec Adds tls_version argument to mqtt module (#58264)
Fixes: #22034

This patch adds support for a tls_version parameter that allows the
TLS version used to be configurable. By default the module will let
the underlying system libraries pick the maximum supported version.

This parameter is useful for servers that are unable to support
newer versions of TLS
5 years ago
Wojciech Wypior ac101f7f33 adds initial_hotfix parameter to vcmp guest (#58180) 5 years ago
Wojciech Wypior d591014163 fixes an issue where rule_lists were not correctly applied to the AFM policy (#58181) 5 years ago
Ondra Machacek d50ee592d0 kubevirt: Add hostname and subdomain parameters (#57223) 5 years ago
lju 60378e991b Fix ec2.py dynamic inventory script when pulling down RDS cluster information (#48075)
* Fixes #26481

* Pass lint tests
5 years ago
Ganesh Nalawade fcc32bcf0e
Fix junos netconf plugin get_configuration filter (#58271)
* junos `get_configuration` netconf api expects the
  filter as instance of ElementTree object
5 years ago
Rowin Andruscavage 896b84bfbe VMware: Python3 migrations for vmware_inventory.py (#47538)
* Sort and pretty print json output and cache file
* Enable Python3 test for vmware_inventory.py

Fixes: #46727

Signed-off-by: Rowin Andruscavage <8740187+MTN-RowinAndruscavage@users.noreply.github.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
5 years ago
Mariusz Mazur 06292566ec kubevirt: more unit tests (#57739)
* Add tests for KubeAPIVersion

* Legibility improvements for KubevirtVM tests

* Create units.utils.kubevirt with common stuff

* Add some VMIRS unit tests
5 years ago
Andrey Klychkov cf528c562a postgresql_membership: remove debug print (#58315) 5 years ago
Mike Frost 307a7c5853 This comment is no longer needed, as the calculation is done in the 'grow' method (#58109) 5 years ago
markafarrell 8555b728c3 also allow None Type for safe eval (#58269) 5 years ago
Matt Clay f749ef5c0a Remove existing invalid ignores. 5 years ago
Matt Clay 535e646a66 Add test for invalid ignore entries. 5 years ago
lolcube 547a29805e openssh_keypair: bugfix make regenerating keypairs via force possible… (#57801)
* openssh_keypair: bugfix make regenerating keypairs via force possible / add invalid file handling

* openssh_keypair: change permissions of read-only file instead of deleting it for regeneration; add changelog fragment

* address review feedbak, refactor

* add integration tests for bigfixes

* linter: fix indent

* fixup integration tests: use force when regenerating an invalid file

* linter: fix indent

* openssh_keypair: address review feedback

* openssh_keypair: fixup, remove backtick

* openssh_keypair: address review feedback

* Only pass 'y' into stdin of ssh-keygen when file exists.
5 years ago
Felix Fontein b78d23d4ad Use newer test container. 5 years ago
Matt Martz 57d8b68c03
Use to_text on value to activate _fail_with_undefined_error (#58214)
* Use to_text on value to activate _fail_with_undefined_error. Fixes #12186

* Add comment explaining in depth what to_text gives us
5 years ago
David Stark 958f740cc3 fixed reference to a non-existing hcloud_server parameter (#57659) 5 years ago
Abhijeet Kasurde 2e1392eff8 ipaddr: unit tests for empty string (#58274)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
5 years ago
Sandra McCann 5569135efd create scenario guide template file (#58212)
* create scenario guide template file

* Apply suggestions from code review

Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>
5 years ago
Mariusz Mazur 4d357ffca5 kubevirt: replace nested function with one from utils
Use dict_transformations.dict_merge() in kubevirt's merge_dicts()
5 years ago
Brian Goad 23fcae7c9e Fix issue with displaying error about unreachable hosts when using Unixy Callback (#58076) 5 years ago
ndclt 4376e88849 Coherence between example and text (use of to_native) (#58279) 5 years ago
Ganesh Nalawade 67c251d13c
Fix junos modules persistent connection check (#57986)
Fixes #57985

*  The check `USE_PERSISTENT_CONNECTION` flag is no longer
   required in action plugin as the junos modules in galaxy are renamed
   to start with `juniper_`.
5 years ago
Andrey Klychkov 278c59b17e postgresql_privs: bugfix of 27327 - incorrect views handling (#58272) 5 years ago
Martin Nečas f94da94e62 ovirt add nic linked (#58053)
* ovirt add nic linked

* add version added

* update check method
5 years ago
rajaspachipulusu17 fc1798cc14 Pluribus Networks ipv6security raguard module with UT (#57031)
* Pluribus Networks ipv6security raguard module with UT
* Doc fixes
5 years ago
Ganesh Nalawade 94fe139f04
Revert "Fix junos module transport check (#58050)" (#58270)
This reverts commit f864f621d8.
5 years ago