3 Commits (9f7956ba30abb190875ac1585f6ac9bf10a4712b)

Author	SHA1	Message	Date
Sam Doran	a11bb8b4d3	Revert "user - consistently create user home directory on Linux (#71952)" (#75704) ... This reverts commit 2f7e0b8489.	3 years ago
Ruediger Pluem	2f7e0b8489	user - consistently create user home directory on Linux (#71952) ... Always use create_homedir when we are asked to create a home directory in the User class. Don't use the -m and -k parameters from useradd / luseradd as they behave differently with respect to preexisting home directories. Instead always specify -M to ensure that useradd / luseradd do not try to create the home directory. This does not change potential different behaviours in child classes of the User class. Consider the new umask option from #73821 in create_homedir as well as we do not let luseradd / useradd create the home directory any longer.	4 years ago
Sam Doran	264e08f21a	user - properly handle password and password lock when used together (#73016) ... Do the right thing on Linux when password lock and a password hash are provided by writing out the password hash prepended by the appropriate lock string rather than using -U and -L. This is the correct way to set and lock the account in one command. On BSD, run separate commands as appropriate since locking and setting the password cannot be done in a single action. FreeBSD requires running several commands to get the account in the desired state. As a result, the rc, output, and error from all commands need to be combined and evaluated so an accurate and complete summary can be given at the end of module execution. * Improve integration tests to cover this scenario. * Break up user integration tests into smaller files * Properly lock account when creating a new account and password is supplied * Simplify rc collection in FreeBSD class Since the _handle_lock() method was added, the rc would be set to None, which could make task change reporting incorrect. My first attempt to solve this used a set and was a bit too complicated. Simplify it my comparing the rc from _handle_lock() and the current value of rc. * Improve the Linux password hash and locking behavior If password lock and hash are provided, set the hash and lock the account by using a password hash since -L cannot be used with -p. * Ensure -U and -L are not combined with -p since they are mutually exclusive to usermod. * Clarify password_lock behavior.	4 years ago