Commit Graph

26849 Commits (9b339de7b6f950450674f2ced2544d5779de9b53)

Author SHA1 Message Date
Gerrit da28089a78 Add proxy parameter to k8s module. (#55377) 6 years ago
Andrey Klychkov 0ff67d0a1c postgresql modules: missing_required_libs, removed excess param mapping (#55506) 6 years ago
Abhijeet Kasurde ffce456de9
VMware: Check return of FindByInventoryPath (#55282)
Check return value of FindByInventoryPath API which is used for
finding desired folder to deploy OVF.

Fixes: #54823

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
6 years ago
Jordan Borean f247c21d23
win_region - fix format issues when using psrp (#55487) 6 years ago
Zim Kalinowski 48cb681140
fix for removing subscripion_id from resource facts (#55203) 6 years ago
Brad House 52b582a7a4 modules/notification/irc: Fix channel joining for some IRC servers. (#55444)
* Fix channel joining for some IRC servers.

Some IRC servers may return the channel in a different case than
requested.  For instance, you might request "foo" but the server
returns "FOO".  The regular expression matching must be case-insensitive
for the join response in order to handle this.

* ansible style guidelines want spaces
6 years ago
zhongjun2 73b7ab71fe typo fix (#55424) 6 years ago
Adam Chalkley 405c7b7ab3 lxd_container: Create container via fingerprint (#52737)
In addition to using creating container using image
aliases, containers can also be created using
fingerprints, provided that the playbook author provide
alternate values for 'server', 'protocol' and swap out
'alias' for 'fingerprint'.

+label: docsite_pr
6 years ago
Andrey Klychkov c3cbc39dd9 Postgresql docs fragments 2 (#55363)
* Postgres to use docsfragments
* Postgres to use docsfragments: redefined options in postgresql_user
6 years ago
Felix Fontein 12d26eceb1 docker modules: make sure everything works with older docker-py versions (#55258)
* General test improvements.

* Adjust tests to older docker-py versions.

* docker_swarm_server_info: work around problems with older docker-py versions

* Bump minimal docker-py version for options network_filters and disk_usage.

* More general test improvements.

* Correct usage of docker_image.

* Put files into output directory.

* Speed up test.

* Remove old check.
6 years ago
Brian Coca 24b44e1772
Ensure discovery unsafe (#55295)
* Ensure safe discovery by marking it Unsafe
6 years ago
zhongjun2 252b6b5eac Add description (#55429) 6 years ago
xuxiaowei 1017f15c38 fix bugs for ce (#54750)
* Update ce.py

            while to_text(out, errors='surrogate_then_replace').strip().endswith(']'):
                display.vvvv('wrong context, sending exit to device', self._play_context.remote_addr)
                conn.exec_command('return')
                out = conn.get_prompt()

connetion has no send_command function and ce device has no 'exit' command to return user-view(a correct context),but 'return' .command.

* Add files via upload

Some bugs fix.

* Add files via upload

fix some bugs

* fix a bug for ce_command

Running a command with prompt via ce_command, It doesn't work.The reason is that the key word for network_cli recognition is answer not response.

* fix bugs

fix bugs for ce modules

* Update ce.py

* Delete ce_ftp.py

need modify

* Delete ce_lacp.py

* Add files via upload

* Delete ce_aaa_server.py

* Delete ce_aaa_server_host.py

* Compatible with Python 3

Compatible with Python 3 and fix bugs for ce

* Update ce_aaa_server.py

* Add files via upload

modify doc

* Add files via upload

Compatible with Python 3 and fix bugs

* Add files via upload

Compatible with Python 3 and fix bugs

* Add files via upload

Cancellation of change

* Update ce_netconf.py

It is a bug that response has no xml attribute:line 183

* Add files via upload

* Add files via upload

Compatible with Python 3 and fix bugs

* updatp ce_config.py

a bug for this module.
6 years ago
Abhijeet Kasurde dcbfa60413
Change to fix issue found while cloning template with opaque network (#55375)
Fixing Format issues in yml files. Check have failed

Signed-off-by: pgbidkar <pbidkar@vmware.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
6 years ago
Yunge Zhu 22f666c962 fix sample in docs (#55420) 6 years ago
Gonéri Le Bouder 339a0f4a8c vmware_datastore_facts: don't nodify dict in iter (#54869) (#54870)
With Python3, we cannot iterate on a dict and modify it at the same time.

Fixes ##54869
6 years ago
Jordan Borean fdf9df89f5
psrp - Fix raw and script tests for connection plugin (#55357)
* psrp - Fix raw and script tests for connection plugin

* Fix error propagation with raw in psrp

* uncomment test
6 years ago
Jordan Borean 49655a452d
psrp - fix test_command rc for win_reboot (#55354) 6 years ago
Jordan Borean 52946c49a4
psrp - Fix fetch for large files (#55351)
* psrp - Fix fetch for large files

* Fix typo
6 years ago
Brian Coca aa8d23b42f
ensure facts marked as unsafe (#55326)
dont rely on plugin layer to do so
6 years ago
Matt Martz ca83a5c110
Version in deprecate calls should be a string (#55395)
* Version in deprecate calls should be a string. Fixes #55312. Fixes #55313. Fixes #55314. Fixes #55315. Fixes #55316. Fixes #55317.

* Add changelog fragment
6 years ago
Matt Martz 07443a2bcd
Address 2.9 uri deprecations (#55330)
* Address 2.9 uri deprecations. Fixes #55310

* Add changelog fragment
6 years ago
Matt Martz 9f83139dcb
Don't register tests as filters (#55332)
* Don't register tests as filters. Fixes #55319

* Remove tests for deprecated functionality

* Remove no-tests-as-filters sanity tests

* Remove docs too

* Revert "Remove docs too"

This reverts commit 7daf457a74.

* Make no-tests-as-filters doc an orphan
6 years ago
williammcbroom 272dceef42 ec2_launch_template - fix spelling mistake (#55383) 6 years ago
Martin Krizek 4ec8599c38 apt: remove deprecated installed/removed aliases (#55338)
* apt: remove deprecated installed/removed aliases

Fixes #55311
6 years ago
Dag Wieers 9495ddbc21
ACI: Cleanup deprecated boolean behaviour (#55207)
* ACI: Cleanup deprecated boolean behaviour

* Remove from sanity ignore list
6 years ago
Anatoly Pugachev b28c73af62 Fixes solaris (sunos) uptime in ansible facts module (#54626)
* correct uptime on solaris by using system boot_time instead of snaptime
* add unit test
6 years ago
Jordan Borean 04cae4134f
Bump deps for ntlm-auth and PSScriptAnalyzer (#55269) 6 years ago
JP Mens 46420dd21a Clarify fact_path configurable in ansible.cfg (#54992)
Docs: Clarify that `fact_path` can be configured in `ansible.cfg`; uppercase two acronyms.
6 years ago
Hideki Saito 83f20e0ea0 Fixed wrong variable specification format in examples (#55252)
Signed-off-by: Hideki Saito <saito@fgrep.org>
6 years ago
Jiri Tyr 720f62bf85 Improving documentation of the aws_ec2 inventory plugin (#55255) 6 years ago
Kevin Breit fb3cc7f687 meraki_vlan - Remove unnecessary API calls when net_id is specified (#54939)
* Remove unnecessary API calls when net_id is specified

* Remove temp_get_nets commented out code
6 years ago
Mauricio Tavares f8834c5339 Template: Example of SELinux context type (#54861)
* Update template.py with an example using selinux with a suggestion of how to get the proper file context (cheating!)
6 years ago
Chris Collins e90df4b566 DOCS: Update "connections" data type (#55290)
The k8s plugin expects the "connections" field to be a list - current docs examples trigger:
 [WARNING]:  * Failed to parse {...}/inventory.yml with k8s plugin: Expecting connections to be a list.

Updated examples for `host` and  `namespaces` to reflect this.
6 years ago
Jose Delarosa f88b2cbe59 Use different headers for each HTTP method (#55193) 6 years ago
Andrey Klychkov 4190985995 postgresql_slot - sslrootcert fix (#55277) 6 years ago
Felix Fontein cb5c57bcd5 openssl_csr: fix idempotency problems (#55142)
* Add test for generating a CSR with everything, and testing idempotency.

* Proper SAN normalization before comparison.

* Fix check in cryptography backend.

* Convert SANs to text. Update comments.

* Add changelog.
6 years ago
MyronFanQiu 91e808eed2 azure_rm_subnet: fix CI error for deleting the azure_tags (#55276) 6 years ago
James E. King III 32345641e7 azure_rm_subnet: remove documentation that says it supports tags (#55233) 6 years ago
James Cassell 7191d45885 VMware: vmware_tools tls warning fixes (#55187)
* vmware_tools: remove silence_tls_warnings option

* attempt import of bundled urllib3
6 years ago
Jonas Kongslund 36ab96e4a9 Fix minor documentation error: base64 -> b64encode (#55257)
* Fix minor documentation error: base64 -> b64encode

* Fix minor documentation error: base64 -> b64encode
6 years ago
Felix Fontein d64b17731d docker_container: improve log_options idempotency by converting to string (#54955)
* Warn when log_options values are not strings.

* Add changelog.

* Improve message.

* Improve formatting and formulation of other messages.

* Add test for warning.

* Trying double escaping.
6 years ago
Abhijeet Kasurde 6ff4547489 VMware: get_all_host_objs accepts list of host (#55146)
vmware_portgroup accepts list of hosts, get_all_host_objs API modified
to accept list of hosts.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
6 years ago
Kevin Breit 6fff8e1d7e Fix spelling error in connection (#54957)
`connection` module utility had a spelling error. s/catergory/category
6 years ago
Toshio Kuratomi a1c8fc37e8 Remove modules which have ended their deprecation cycle
* Remove code but leave the metadata so that they can be listed as
  removed in documentation.
* Remove removed modules from validate-modules ignore
* Remove unittests for the removed nodules
* Remove links to removed modules and add list of removed moduels to the
  2.9 porting guide
6 years ago
Toshio Kuratomi bc955b9d60 Cleanup the tree for post-2.8-branch
After branch, we do the following tasks:
* Remove all old changelog fragments.  The devel tree starts fresh.
* Remove all old generated changelog info (CHANGELOG-v2.8.rst and .changes.yaml)
* Set the new codename and version in release.py
6 years ago
Evert Mulder 39445786ff Bugfixes when removing a tenant- Module reported changed when tenant was not removed.- Script error when removing a non existing tenant without parent_id (#55110) 6 years ago
Evert Mulder daaea17801 Fixed incorrect response removing a group (#55116) 6 years ago
Brian Coca 9f87552f06
add option to display per host start to default (#53819)
* add option to display per host start to default
6 years ago
Nathan Dines 5eb3117822 Added the OnFailure option to the AWS CloudFormation module (#52431)
* Added the OnFailure option to the AWS CloudFormation module

* Added unit tests for CloudFormation `on_create_failure`
6 years ago
Brian Coca e40832df84
become mixin is no more (#54002)
* become mixin is no more
  since sudo/su keywords are removed in 2.9 .. no need to keep this code around
 * also don't need test for code that is removed
 * made preprocess_data on base noop
   its not used by anything anymore, but kept for backwards compat since other methods of same name are used
6 years ago
Bob Boldin 9ddde6b27f AWS: add ec2_transit_gateway_info module (#54460)
* AWS: add ec2_transit_gateway_info module

* move info module test to main module and ensure unique description for parallel tests

* add type designators to module options in documentation

* assign results and return instead of exit.  Add elements directive available with ansible 2.8

* assign results and return instead of exit

* get() method superfluous for module.params

* correct return type in documentation for ASN and format the sample for Tag correctly

* added random uid to test description - removing unstable alias

* change random uuid to resource_prefix to improve source of object identification in testing
6 years ago
Andrey Klychkov d790285e80 postgresql_idx: improved doc, tests, remove useless lines from code (#55131)
* postgresql_idx: improve doc

* postgresql_idx: improve doc, removed unuseless rows from code

* postgresql_idx: misc doc fix

* postgresql_idx: moved common params where they were

* postgresql_idx: moved common params where they were 2
6 years ago
flowerysong 6273574eb4 Fix ec2_eip parameter logic (#55194) 6 years ago
Jordan Borean 6039ff9a24
win_domain - fix for checking for domain on new host (#55195) 6 years ago
James E. King III a5f13dd361 ec2_group: docs: fix example for deletion by group ID (#55169)
requires the region for the example task to work
6 years ago
James Cassell 05fe9ef816 vmware_tools: ignore absence of urllib3 6 years ago
Dmitriusan f40778cae3 Update documentation of filetree to mention limits of 'src' attribute (#54347)
* Filetree plugin does not return the 'src' attribute when `item.state` is set to `directory`

Error is `'dict object' has no attribute 'src'`. See https://github.com/ansible/ansible/issues/51513#issuecomment-459150769 .

* Update filetree.py
6 years ago
Keith Maxwell 04220478da Fewer examples use connection: local in docs (#55133)
* Fewer connection: local lines in module examples and scenario guides

The line 'connection: local' is not required. See
./docs/docsite/rst/inventory/implicit_localhost.rst
6 years ago
Alex Richman 698d2454c7 Fix access_logs_s3_prefix leading/trailing slash (#55148)
- Add documentation regarding restrictions on access_logs_s3_prefix (cannot have a leading or trailing slash)
6 years ago
Wojciech Wypior adc0d2cd83 fixes an edge case where order of devices parameters breaks idempotency (#55181)
code correction for aggregates in bigip_gtm_pool_member and bigip_pool to be in line with established patterns
6 years ago
Simon Dodsley 30a216bf78 Remove unneccessary line in config section of purefa_facts (#55164) 6 years ago
Brian Coca 6579dfda17
Correct plugin loader context for persistent (#54860)
* Correct plugin loader context for persistent
6 years ago
Sam Doran 27a3ec3a12 Don't use SSLEOFError in vmware_tools.py 6 years ago
James Cassell 2b8cef340e VMware: vmware_tools connection plugin (#55059)
* variable standardisation and cleanup

- connection_address -> vmware_host
- connection_username -> vmware_user
- connection_password -> vmware_password
- connection_verify_ssl -> validate_certs
- connection_ignore_ssl_warnings -> silence_tls_warnings
- ansible_vmware_tools_vm_path -> ansible_vmware_guest_path
- standardize user/pass vars
- fallback to default ansible conneciton vars
- accept VMware standard env vars:
- note lack of "become" support
- add example usage
- more reasonable default sleep interval
- auto-silence tls warnings if validate_certs=false
- get_option for executable
- remove unsafe 'makedirs_safe'

* executable: support env vars and ini
6 years ago
anasbadaha 2cc91e26e0 Adding Support For Vxlan In Onyx Switches (#55081)
* Adding Support For Vxlan In Onyx Switches

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix Pep8 Failures in onyx_vxlan.py

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix Pep8 Failures in onyx_vxlan phase 2

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix Shippable failures

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix Samer's Comments on PR

Signed-off-by: Anas Badaha <anasb@mellanox.com>
6 years ago
lumean b24c037f62 fix 'APIC Error 403: padding check failed' in python3 (#55150)
* fix 'APIC Error 403: padding check failed' in python3

With python2 the APIC-Request-Signature is filled in correctly
APIC-Request-Signature=aAvxASu...

But with python3 the string format method seems to
add the encoding to the output, causing a padding error:
APIC-Request-Signature=b'lFmHWvwW4dr...

Reproduce:
# -*- coding: utf-8 -*-
import base64
a = base64.b64encode(b'\u0001')
b = '%s' % a
print(b)
=======
python --version; python test.py
Python 2.7.16 :: Anaconda, Inc.
XHUwMDAx
Python 3.6.3 :: Anaconda, Inc.
b'XHUwMDAx'

* Ensure we use native strings
6 years ago
ashanmukhapp 51c0fda63f make waiting for init optional for non-thin volumes 6 years ago
Swartz, Nathan 5e3a7ec1f5 Improve netapp_e_volume module and add unit tests.
netapp_e_volume was refactored for maintainability and its documentation
was improved for better clarity.
6 years ago
Matthias 1a7fed9b68 na_ontap_gather_facts: Add gather subset system_node_info (#54161)
* Add gather subset system_node_info

* Fix continuation line
6 years ago
Gonéri Le Bouder d55e3ad0b8 vmware_host_vmnic_facts: ensure nm_config is define (#55156)
Fix a regression introduced by f96c569f9d.
6 years ago
rajeevarakkal acd89b3300 as per IRC Core team comment, renaming pwd to password (#55033)
ie idrac_pwd to idrac_password
share_pwd to share_password
6 years ago
Hannes Ljungberg 23d0d225f4 docker_swarm_service_info: Read information about swarm services (#55008)
* Add docker_swarm_service_info module

* Remove unused import

* Limit to retrieving info about one service

* Add exists return value

* Add yaml 3-dash

Co-Authored-By: hannseman <hannes@5monkeys.se>

* Document return value as jinja `none´

Co-Authored-By: hannseman <hannes@5monkeys.se>

* Name is required
6 years ago
Zim Kalinowski 21ec3b294f additional sample for function app (#55136)
* additional sample for function app

* format
6 years ago
Zim Kalinowski b0cc3072dc
Fix in function app (#55134) 6 years ago
Martin Krizek a40c1ed811
setup: properly detect is_chroot on Btrfs (#55089)
* setup: properly detect is_chroot on Btrfs

Fixes #55006

* Use get_bin_path for stat

* Remove comment
6 years ago
Christopher Perrin 6e5165b4fb Added license_type, vm_identety and win_rm attributes to azure_rm_virtualmachine module (#42400) 6 years ago
Zim Kalinowski 5145473451
adding facts for Azure HDINsight cluster (#55124) 6 years ago
Matt Davis 1dc8436ed9
module_utils fixes in collections (#55118)
* module_utils fixes in collections

* fixed Windows module_utils in collections
* fixed more Python module_utils cases (from X import module)
* "medium style" Ansiballz modules now work properly with collections (ie, non-replacer but also not using basic.py)
* added more tests
* split Windows/POSIX exec

* sanity
6 years ago
anasbadaha 9bd060292e Adding New Model for Configure Buffer Pool on Onyx Switches (#55082)
* Adding New Model for Configure Buffer Pool on Onyx Switches

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix Pep8 Failures in onyx_buffer_pool.py

Signed-off-by: Anas Badaha <anasb@mellanox.com>
6 years ago
Gonéri Le Bouder 754dfc54c8 VMware: vmware_host_config_manager: avoid failure if no change (#55115)
If nothing was changed, the module was raising the following error
because the `message` variable was not defined:
6 years ago
Gonéri Le Bouder f96c569f9d VMware: vmware_host_vmnic_facts: py3 fix (#55117)
With Python3, `filter()` returns an iterator. So we cannot do a `len()`
on the result.
6 years ago
Dag Wieers b6bf910bf4
A static leaf is build from the pod id and leaf id (#55120) 6 years ago
Zim Kalinowski 62f4eb7053
adding missing Azure facts modules (#54838) 6 years ago
Yunge Zhu ed1334fbe3
add wait_for_running option in azure_rm_rediscache module (#54976) 6 years ago
Chris Archibald e12846f540 Update na_ontap_export_policy_rule to allow multiple rules to be set at once. (#54801)
* update

* add unit tests
6 years ago
Madhura-CSI fe31b7eddb New module for azure virtual network gateway (#44411)
* module for azure vpn gateway

* updating vng
6 years ago
Chris Archibald db0f5a3fdc Bug fix to na_elementsw_account.py (#54798)
* bug fixes

* bug fix
6 years ago
Sam Doran c2be342ce1 Add podman_image and podman_image_info modules (#55103)
* Add podman_image and podman_image_info modules

* Add integration test for podman_image_info

* Change parameter names per feedback

* Add integration tests for podman_image
6 years ago
René Moser e28d08a3c1
cloudscale_server: implement param server_groups (#54868) 6 years ago
Chris Archibald c51f840faa Allow for multiple LIFS instead of 1 at a time (#54800)
* upload unit tests
6 years ago
Anatoly Pugachev 19f6634353 Add support of facts gathering WWNs on AIX OS (#51704)
* Extend git commit c65909d6db "Add network fact to obtain FC WWN initiator ports"
adding support of enumerating AIX device WWN ports

$ lsdev -Cc adapter -l fcs*
fcs0 Defined   00-00 8Gb PCI Express Dual Port FC Adapter (df1000f114108a03)
fcs1 Defined   00-01 8Gb PCI Express Dual Port FC Adapter (df1000f114108a03)
fcs2 Available 04-00 8Gb PCI Express Dual Port FC Adapter (df1000f114108a03)
fcs3 Available 04-01 8Gb PCI Express Dual Port FC Adapter (df1000f114108a03)

$ lscfg -vpl fcs3 | grep 'Network Address'
        Network Address.............10000090FA551509

* no self in this code

* Two fixes:

- fix run_command execution, passing 'use_unsafe_shell=True' since we have a pipe in it ( | grep )
  if we don't set unsafe shell, it will return error on execution.

- strip new line characters at the end of WWNs.

* fix pep8 , E225 missing whitespace around operator

* use module.get_bin_path() instead of hardcoded values

* move module.get_bin_path() out of for loop

* use python string parsing instead of calling external grep

* use in operator instead of find() for simplicity and readability

* add changelog fragment
6 years ago
Felix Fontein 7d2e4dd2fd ufw: fix default (again) (#55004) 6 years ago
s-hertel 44a07cfe71 Use standard _sanitize_group_name method 6 years ago
Ondra Machacek af528bed80 inventory_plugins: Add kubevirt inventory plugin
Signed-off-by: Ondra Machacek <omachace@redhat.com>
6 years ago
desimaniac b41c6fcdd4 Pushover: Adds support for optional 'title' (#53726)
** SUMMARY **
Adds support for optional 'title'.

** ISSUE TYPE **
Feature Pull Request

** COMPONENT NAME **
pushover
6 years ago
Dag Wieers 9ac57dff61
MSO: Remove parameters to specify object ids (#55107)
MSO: Remove parameters to specify object ids
6 years ago
Abhijeet Kasurde bea397b458 Add type int for various argument params (#55026)
Specify type as int for various arguments where default value is int.

Fixes: #55005

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
6 years ago
adamgoossens dd3de27cc8 New module: keycloak_group (#35637)
* Initial implementation of groups module.

Not all parameters are supported, yet.

* Clarify read-only status of realmRoles, clientRoles and access attributes

* Fix testing failures

* Fix additional style issues.

* Minor updates and fixes after review feedback

* Simplify return values after feedback

This removes the 'proposed' and 'end_state' return values, replacing them instead with just 'group'. 'group' is the representation of the group after the module completes.

Also update the dates, and the Ansible version

* Corrections after module validation

* Further documentation updates after feedback

Minor whitespace adjustments also

* Add delegate_to: localhost stanzas to examples
6 years ago
Chris Archibald 7bb19f1b4d bug fix (#55057) 6 years ago